Compare commits

...

1399 Commits

Author SHA1 Message Date
khushi8112
b9083411cc fix: remove unused print format 2026-03-24 12:17:42 +05:30
khushi8112
c99cec1071 fix: add closing div tab 2026-03-24 12:17:42 +05:30
khushi8112
4307cd5b1c feat: default print format for Quotation 2026-03-24 12:17:36 +05:30
ruthra kumar
cd5b0ea5fd Merge pull request #52802 from nabinhait/workspace-cleanup-1
fix: Removed quick access link from selling workspace
2026-03-24 11:30:53 +05:30
ruthra kumar
ae8068e833 Merge pull request #53302 from Shllokkk/xxs-xxe-fix
fix: sanitize genericode import inputs and secure XML parser
2026-03-24 11:27:15 +05:30
Nabin Hait
d7c48d645a fix: Removed quick access link from selling workspace 2026-03-24 11:11:56 +05:30
ruthra kumar
107fecd4b0 Merge pull request #53730 from khushi8112/asset-location-overwritten-by-accounting-dimension
fix: skip overwriting existing asset fields with accounting dimensions
2026-03-24 11:04:59 +05:30
khushi8112
2859a143f2 fix: skip overwriting existing asset fields with accounting dimensions 2026-03-24 02:19:44 +05:30
Khushi Rawat
bd9b0185f4 Merge pull request #53680 from khushi8112/better-opening-invoice-creation-tool
fix(UX): improve party selection UX with party name field
2026-03-24 01:35:54 +05:30
Khushi Rawat
0faa261729 Merge pull request #53646 from khushi8112/default-print-format-for-rfq
feat: default print format for Request for Quotation
2026-03-24 01:34:00 +05:30
Mihir Kandoi
91da450a31 chore: remove unused imports (#53722) 2026-03-23 16:39:55 +00:00
Pandiyan P
8ebc2e38ec fix(manufacturing): close work order status when stock reservation is… (#53714)
* fix(manufacturing): close work order status when stock reservation is enabled

* chore: better syntax

---------

Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
2026-03-23 16:05:00 +00:00
diptanilsaha
96c79dfe8b chore(test_item_group): removed unused function _print_tree (#53716) 2026-03-23 15:50:01 +00:00
diptanilsaha
958bb6c619 chore: skip semgrep check for db.commit in BootStrapTestData (#53715) 2026-03-23 15:39:14 +00:00
ruthra kumar
30380851d8 Merge pull request #52285 from Jatin3128/payment_entry_ref
fix(Payment Entry): split orders as per the schedules in the reference table
2026-03-23 19:36:36 +05:30
Rucha Mahabal
248ea16d96 feat(employee): Create User button and form. (#52726)
* feat(employee): Create User button and form.

* feat(employee): Add automatic user creation feature and related validations. Create User on Import.

* refactor(employee): create user function -removed useless function calls

* refactor(employee): reorganize joining and employee exit tabs at the end.

* feat(employee): Add birthdays and work anniversaries indicator in form ,list view enhancements and new empty state.

* fix: add missing type hints to whitelisted function arguments

* fix(employee): add 'set_only_once' property to 'Create User Automatically' field

* refactor(employee): remove anniversary indicator logic from employee form

* fix: move Joining section before Exit, relabel Employee Exit -> Exit

* fix: reset employee listview empty state, add import btn instead

* fix: employee user creation

- consider prefered email as default in employee creation

- remove unused user parameter from `create_user` API

- remove unnecessary validations on user ID, already checked by user doctype hooks

- set company email only if empty

* fix: only validate auto user creation before insert

* fix: uncollapse User Details section in new form

* fix: hide Create User Automatically checkbox if user is already selected

* fix: set create user perm to 1 by default + persist option while saving employee

* fix: avoid setting unnecessary fields

* fix: fallback to Personal Email for user creation just like client-side

* fix: reset User ID and make it read-only if 'Create User Automatically' is set

* test: Create User Automatically

* test(fix): set company in employee

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2026-03-23 17:47:02 +05:30
rohitwaghchaure
3f3ddf968e Merge pull request #53705 from rohitwaghchaure/fixed-support-63246
fix: batch validation for subcontracting receipt
2026-03-23 17:01:47 +05:30
Rucha Mahabal
a14f834589 test(fix): set company in employee 2026-03-23 16:52:11 +05:30
Rohit Waghchaure
b8d201658a fix: batch validation for subcontracting receipt 2026-03-23 16:29:47 +05:30
Rucha Mahabal
cc93b14154 Merge branch 'develop' into feat/employee-creation-and-lifecycle 2026-03-23 16:11:10 +05:30
Rucha Mahabal
d4ecede3c3 test: Create User Automatically 2026-03-23 16:09:58 +05:30
Asief Tejani
99d55ab8d8 docs(README): sync erpnext docker with frappe_docker repo (#53447)
Co-authored-by: diptanilsaha <diptanil@frappe.io>
2026-03-23 16:00:03 +05:30
diptanilsaha
8ea0cc90df fix: check for submit permissions instead of write permissions when updating status (#53697) 2026-03-23 15:43:33 +05:30
Rucha Mahabal
2be6bb694f fix: reset User ID and make it read-only if 'Create User Automatically' is set 2026-03-23 15:42:13 +05:30
Rucha Mahabal
31af13a5e6 fix: fallback to Personal Email for user creation just like client-side 2026-03-23 15:31:51 +05:30
Sudharsanan Ashok
41f986ff83 fix(manufacturing): update non-stock item dict (#53689) 2026-03-23 15:16:37 +05:30
khushi8112
469bb0ba4e fix: party name not updating correctly 2026-03-23 09:44:41 +00:00
khushi8112
8fd9b88cd9 fix(UX): improve party selection UX with party name field 2026-03-23 09:44:41 +00:00
Rucha Mahabal
97bb100010 fix: avoid setting unnecessary fields 2026-03-23 15:06:15 +05:30
khushi8112
6b9fb77772 fix: set default print format for when downlod pdf 2026-03-23 15:04:14 +05:30
khushi8112
2af0d9cf6c feat: default print format for Request for Quotation 2026-03-23 15:04:14 +05:30
Nishka Gosalia
75ce885684 Merge pull request #53695 from nishkagosalia/fix-type-hint-stock 2026-03-23 15:01:43 +05:30
nishkagosalia
2f72ae9afd fix: type hint in stock module 2026-03-23 14:37:46 +05:30
Nishka Gosalia
ca877ba223 Merge pull request #53649 from nishkagosalia/st-63180 2026-03-23 14:27:13 +05:30
diptanilsaha
a908bc7e92 fix(trends): added validation for period_based_on filter (#53690) 2026-03-23 14:23:42 +05:30
Rucha Mahabal
091899d0df fix: set create user perm to 1 by default + persist option while saving employee 2026-03-23 14:23:01 +05:30
Rucha Mahabal
ec3302d1c1 fix: hide Create User Automatically checkbox if user is already selected 2026-03-23 14:06:56 +05:30
Rucha Mahabal
1466df91bd fix: uncollapse User Details section in new form 2026-03-23 14:06:24 +05:30
Rucha Mahabal
ee1aa10328 fix: only validate auto user creation before insert 2026-03-23 13:37:07 +05:30
nishkagosalia
dcd0509089 chore: Adding new argument in status updater to skip qty validation 2026-03-23 13:18:26 +05:30
Rucha Mahabal
613d36a139 fix: employee user creation
- consider prefered email as default in employee creation

- remove unused user parameter from `create_user` API

- remove unnecessary validations on user ID, already checked by user doctype hooks

- set company email only if empty
2026-03-23 12:52:23 +05:30
Mihir Kandoi
7a61d6fcd5 fix: shipping rule applied twice on non stock items (#53655) 2026-03-23 06:49:39 +00:00
Mihir Kandoi
5154102468 fix: PO should not be required for internal transfers (#53681) 2026-03-23 06:32:26 +00:00
Rucha Mahabal
d99d16423a fix: reset employee listview empty state, add import btn instead 2026-03-23 11:59:05 +05:30
Rucha Mahabal
000b5b72d5 fix: move Joining section before Exit, relabel Employee Exit -> Exit 2026-03-23 11:27:00 +05:30
MochaMind
f483d9ff13 chore: update POT file (#53677) 2026-03-22 14:47:24 +01:00
rohitwaghchaure
c1c3757943 Merge pull request #53673 from rohitwaghchaure/fixed-stock-queue-not-updated
fix: stock queue for SABB
2026-03-22 13:00:28 +05:30
Rohit Waghchaure
3fcf308ed8 fix: stock queue for SABB 2026-03-22 12:06:43 +05:30
rohitwaghchaure
145a42eb30 Merge pull request #53638 from rohitwaghchaure/fixed-deadlock-issue-for-sle
fix: deadlock issue for SLE
2026-03-21 14:03:40 +05:30
Mihir Kandoi
fa35fbdb8e fix: do not overwrite expense account in stock entry (#53658) 2026-03-20 08:02:32 +00:00
diptanilsaha
8e17c722fb fix: validate permission before updating status (#53651) 2026-03-19 14:49:29 +00:00
Nishka Gosalia
ffd3e90806 Merge pull request #53645 from nishkagosalia/gh-53526 2026-03-19 18:29:00 +05:30
nishkagosalia
7f70e62c30 fix: Adding validation for operation time in BOM 2026-03-19 17:31:31 +05:30
ruthra kumar
44247f63d5 Merge pull request #53594 from ruthra-kumar/fix_failing_patch
fix: patch failure due to dependency
2026-03-19 17:30:35 +05:30
ruthra kumar
bb3cee8ef5 fix: patch failure due to dependency 2026-03-19 16:13:20 +05:30
Mihir Kandoi
fc25d83a9e fix: co by product patch for v14 migration (#53644) 2026-03-19 10:31:46 +00:00
Rohit Waghchaure
f48b03c6ec fix: deadlock issue for SLE 2026-03-19 14:31:17 +05:30
Sudharsanan Ashok
442fe9a833 fix(stock): fix email error message (#53606) 2026-03-19 07:11:41 +00:00
diptanilsaha
086fea7cf0 fix(payment_schedule): using show_alert instead of msgprint for non-selection of payment schedule (#53623) 2026-03-19 12:29:28 +05:30
Sakthivel Murugan S
256d267a3b fix: set customer details on customer creation at login (#53509) 2026-03-19 12:04:31 +05:30
Pandiyan P
0fdc1bc497 fix(stock): handle NoneType error (#53593) 2026-03-19 11:56:58 +05:30
Mihir Kandoi
71293bcf73 refactor: remove test file import in stock ageing report (#53619) 2026-03-19 11:52:57 +05:30
Mihir Kandoi
f1e36b09f9 fix: consider returned qty in subcontracting report (#53616) 2026-03-19 05:24:58 +00:00
Mihir Kandoi
743970a8c6 fix: python error in manufacture entry if transfer against is job card (#53615) 2026-03-19 04:57:37 +00:00
Sowmya
03d8a7a6af fix: ignore cost center (#53063) 2026-03-19 09:54:17 +05:30
Vishnu Priya Baskaran
31b44534df fix: check posting_date in args (#53303) 2026-03-19 09:52:37 +05:30
ruthra kumar
df7e6b7a79 Merge pull request #47910 from ruthra-kumar/ci_lightmode_runner
refactor(test): repo wide test suite refactor to achieve deterministic behaviour
2026-03-18 21:42:16 +05:30
ruthra kumar
eb143ba742 refactor(test): cleanup; remove redundant attribute 2026-03-18 20:59:39 +05:30
ruthra kumar
22c05d4b8f refactor(test): make pick list deterministic 2026-03-18 20:59:39 +05:30
ruthra kumar
7e8f9f10f3 refactor(test): make item wise sales register deterministic 2026-03-18 20:59:39 +05:30
ruthra kumar
5263386bb2 refactor(test): replace integration test case with ERPNextTestSuite 2026-03-18 20:59:39 +05:30
ruthra kumar
72d08902fd refactor(test): make purchase order deterministic 2026-03-18 20:59:39 +05:30
ruthra kumar
23d35c6cca refactor(test): make sales invoice deterministic 2026-03-18 20:59:39 +05:30
ruthra kumar
da8fcde4a8 refactor(test): make location determinisitic 2026-03-18 20:59:38 +05:30
ruthra kumar
6eea0a2299 refactor(test): make bank clearance deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
9e63c14cef refactor(test): make sales invoice deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
21b25ce96c refactor(test): hardcoded names over dynamic 2026-03-18 20:59:38 +05:30
ruthra kumar
7cad642a11 refactor(test): use JSON for company master 2026-03-18 20:59:38 +05:30
ruthra kumar
5237e58f29 refactor(test): remove explicit call to master data setup 2026-03-18 20:59:38 +05:30
ruthra kumar
e67165d6ce refactor(test): hardcoded names over dynamic ones
Much faster bootstrap without those get_doc calls
2026-03-18 20:59:38 +05:30
ruthra kumar
5a4a77f5d2 refactor: move test bootstrap to module 2026-03-18 20:59:38 +05:30
ruthra kumar
96b82624cd refactor(test): speed up setup 2026-03-18 20:59:38 +05:30
ruthra kumar
fc8fadf455 refactor(test): make stock entry deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
518800cd2f refactor(test): remove redundant before_tests 2026-03-18 20:59:38 +05:30
ruthra kumar
0f2f53cbd0 refactor(test): make process deferred accounting deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
19e03ccdde refactor(test): make bom deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
7fea5a5ca2 refactor(test): make customer deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
cb693e05bf refactor(test): tax rule; removed setUpClass, tearDownClass 2026-03-18 20:59:38 +05:30
ruthra kumar
aa998219b1 refactor(test): common make function 2026-03-18 20:59:38 +05:30
ruthra kumar
4d65cb907f refactor(test): make bom stock calculated deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
c2dea5245d refactor(test): make pos profile deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
07374b5dbc refactor(test): make pos opening entry deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
25279321ac refactor(test): make pos invoice merge log deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
0474d0c4e8 refactor(test): make pos closing deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
ec9b2f0567 refactor(test): make stock test_utils deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
6c27efeeea refactor(test): make currency exchange deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
ffca80daa5 refactor(test): make sales partner target variance deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
2c0466d637 refactor(test): make sales order analysis deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
a91ed14aec refactor(test): make uae vat audit deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
96f9fc3484 refactor(test): make uae vat 201 deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
e01e3c0a62 refactor(test): make job card deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
4777b060ba refactor(test): make opportunity summary by sales stage deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
ed099bcd85 refactor(test): make queries deterministic 2026-03-18 20:59:38 +05:30
ruthra kumar
d81fd25325 refactor(test): make item wise details deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
2eec0f704c refactor(test): make accounts controller deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
b4245e9353 refactor(test): make subcontracting controller deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
323a3dd573 refactor(test): make test mapper deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
56a5ddae8f refactor(test): make item wise inventory account deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
a3d8bb8d21 refactor(test): make distributed discount deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
18fe191929 refactor(test): make requested items order and receive deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
f4d355a0e4 refactor(test): make accounts/test/test_utils.py deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
0ef004ce48 refactor(test): make gross profit deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
47cae808c5 refactor(test): make sales payment summary deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
1689d6a9fc refactor(test): make consolidated trial balance report deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
12ae84401a refactor(test): remove redundant tearDown, tearDownClass and rollback 2026-03-18 20:59:37 +05:30
ruthra kumar
8090caa026 refactor(test): make inventory dimension deterministic
fixed flaky test 'test_inventory_dimension'

use '3' precision for test_opening_balnace
2026-03-18 20:59:37 +05:30
ruthra kumar
ff87eedd96 refactor(test): make item group deterministic
'Item Group C' follows 'Item Group B'. So `lft` will increase while
`rgt` stays the same.
2026-03-18 20:59:37 +05:30
ruthra kumar
57f94b3ac2 refactor(test): make packed item deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
3b65364828 chore: typo 2026-03-18 20:59:37 +05:30
ruthra kumar
b5db1e9e1f refactor(test): remove redundant create_asset_category 2026-03-18 20:59:37 +05:30
ruthra kumar
79c23fc6c6 refactor(test): make sales invoice deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
31718d2066 refactor(test): make item group deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
cd499d4955 refactor(test): make timesheet deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
4484863baa refactor(test): make task deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
ddcd8a03ee refactor(test): make project deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
ce50e23536 refactor(test): make maintenance schedule deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
3c904cbc5f refactor(test): make leads deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
06ddc80292 refactor(test): make purchase order deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
7da61621cc refactor(test): make asset repair deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
075fe3f668 refactor(test): make asset deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
b2242d3cce refactor(test): make loyalty point entry deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
c55628a55d refactor(test): make dunning deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
3a5869e525 refactor(test): make budget deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
bb51e3147c refactor(test): make auto match party deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
5415e2ca82 refactor(test): make bank clearance deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
e6885af96b refactor(test): remove explicit commit and dead code 2026-03-18 20:59:37 +05:30
ruthra kumar
6d86bfe2e3 refactor(test): rollback on tearDown 2026-03-18 20:59:37 +05:30
ruthra kumar
70059d1ec0 refactor(test): make irs supplier test deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
d2da518e02 refactor(test): make party specific item deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
d119e3a8e8 refactor(test): make subcontracting receipt deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
577be4f9ad refactor(test): make purchase receipt deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
8dd9ab6475 refactor(test): make stock reconciliation deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
ee8e96dbcf refactor(test): make subcontracting order deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
faaad3ae8e refactor(test): make purchase receipt deterministic 2026-03-18 20:59:37 +05:30
ruthra kumar
c5f2ef454f refactor(test): make material request deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
7224dcce26 refactor(test): make stock ledger entry deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
f758ee4adc refactor(test): make item deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
26d7900590 refactor(test): make work order deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
2d1db2e403 refactor(test): make purchase receipt deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
4111d4ee1d refactor: fix logical bug and make stock settings test deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
d8be59b1ba refactor(test): make stock entry deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
c38696157c refactor(test): make serial no deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
dab31bc36d refactor(test): make serial and batch bundle deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
d790a1d3a6 refactor(test): make pick list deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
298960bfc6 refactor(test): make packed item deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
b8437f7f22 refactor(test): make material request deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
db49e6d830 refactor(test): make LCV deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
7853b779bd refactor(test): make item price deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
23cdd82de1 refactor(test): make delivery trip deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
5c85074f54 refactor(test): make delivery note deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
8d20da91d1 refactor(test): make transaction deletion record deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
0b046647e7 refactor(test): make item group deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
9231dbbb2f refactor(test): make employee deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
0dbd10893e refactor(test): make department deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
f2a85fd134 refactor(test): make currency exchange deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
7a8ece76ea refactor(test): make test deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
8b720ffd4f refactor(test): make project deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
6e3ea35dda refactor(test): make sales order deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
a4f8920d97 refactor(test): make quotation deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
7b8e15c5b8 refactor(test): make production plan deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
464c09ed10 refactor(test): make job card tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
bfb8837c54 refactor(test): make bom tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
7b26a4c2eb refactor(test): make bom update tool tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
8c5276c5e1 refactor(test): make plaid settings deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
2516cdafcb refactor(test): make financial reports deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
fcee9ad778 refactor(test): make sales invoice deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
5b0c41a3f7 refactor(test): make pos invoice deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
f5e69f2602 refactor(test): better setup for loyalty point and POS Invoice 2026-03-18 20:59:36 +05:30
ruthra kumar
d69d2c374f refactor(test): pos invoice tests are almost deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
524118e108 refactor(test): make timesheet and activity type deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
b64231ce2e refactor(test): make maintenance schedule deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
1a6358ec70 refactor(test): make prospect deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
0b2dbcf30c refactor(test): make opportunity deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
3b5667c007 refactor(test): remove empty IntegrationTestCase 2026-03-18 20:59:36 +05:30
ruthra kumar
e490d5044b refactor(test): make tax withholding tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
87f0247f2b refactor(test): ensure new bankers rounding method is set 2026-03-18 20:59:36 +05:30
ruthra kumar
91875fdf8d refactor(test): set precision in class setup 2026-03-18 20:59:36 +05:30
ruthra kumar
3dc3b2b64e refactor(test): make sales invoice tests deterministic
- allow_negative_stock is required for test_taxes_merging_from_delivery_note
2026-03-18 20:59:36 +05:30
ruthra kumar
eb70060798 refactor(test): make purchase invoice tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
2edbbb6052 refactor: avoid name clash 2026-03-18 20:59:36 +05:30
ruthra kumar
c2e9a91a94 refactor(test): handle setup of Workstation Operation Component 2026-03-18 20:59:36 +05:30
ruthra kumar
81ef8655c2 refactor(tests): make asset maintenance tests deterministic 2026-03-18 20:59:36 +05:30
ruthra kumar
def64ae864 refactor(test): incorrect fieldname for abbrevation 2026-03-18 20:59:36 +05:30
ruthra kumar
379f12daee refactor(test): make asset repair tests deterministic 2026-03-18 20:59:35 +05:30
ruthra kumar
cee55a1518 refactor(test): make supplier quotation deterministic 2026-03-18 20:59:35 +05:30
ruthra kumar
1560619fe0 refactor(test): install supplier scorecard presets 2026-03-18 20:59:35 +05:30
ruthra kumar
5b20935235 chore: remove default templated test case 2026-03-18 20:59:35 +05:30
ruthra kumar
4eb23df627 refactor(test): set_user utility method 2026-03-18 20:59:35 +05:30
ruthra kumar
253fbc2a70 refactor: replace all IntegrationTestCase -> ERPNextTestSuite 2026-03-18 20:59:35 +05:30
ruthra kumar
ea2763432d refactor: utility to return default supplier scorecards 2026-03-18 20:59:35 +05:30
ruthra kumar
03a64b67d9 refactor(test): flaky test in lead 2026-03-18 20:59:35 +05:30
ruthra kumar
2309bea1a0 refactor(test): flaky tax rule testsuite
- Make Sales Stage preset
2026-03-18 20:59:35 +05:30
ruthra kumar
3c14621ae0 refactor(test): load shipping rule records 2026-03-18 20:59:35 +05:30
ruthra kumar
27474eceee refactor(test): fix flaky shareholder test 2026-03-18 20:59:35 +05:30
ruthra kumar
36a9893558 refactor(test): fix flaky process deferred accounting tests 2026-03-18 20:59:35 +05:30
ruthra kumar
d37f2ada65 refactor(test): flaky pricing rule tests 2026-03-18 20:59:35 +05:30
ruthra kumar
c0647cf93b refactor(test): flaky stock entry; load records json 2026-03-18 20:59:35 +05:30
ruthra kumar
95d6bbe7ad refactor(test): flaky pos invoice merge log test 2026-03-18 20:59:35 +05:30
ruthra kumar
aeae6d4a10 refactor(test): flaky post invoice test 2026-03-18 20:59:35 +05:30
ruthra kumar
0914fd695d refactor(test): flaky pos invoice test; load stock entry json 2026-03-18 20:59:35 +05:30
ruthra kumar
a5a6a3bc9c refactor(test): flaky PE test; load currency exchange record 2026-03-18 20:59:35 +05:30
ruthra kumar
56542c805a refactor: load journal entry test records and make holiday list 2026-03-18 20:59:35 +05:30
ruthra kumar
6041574209 refactor: utility to load JSON records 2026-03-18 20:59:35 +05:30
ruthra kumar
0b14d1fe34 refactor(test): update system settings in super() 2026-03-18 20:59:35 +05:30
ruthra kumar
6572dc286a refactor(test): flaky test setup in pos closing entry 2026-03-18 20:59:35 +05:30
ruthra kumar
223737cbe2 refactor(test): fix flaky test setup for opening invoice creation 2026-03-18 20:59:35 +05:30
ruthra kumar
b00df01817 refactor(test): flaky test setup in Exchange Rate Revaluation 2026-03-18 20:59:35 +05:30
ruthra kumar
ce8ce10ef1 refactor(test): flaky test data setup for coupon code 2026-03-18 20:59:35 +05:30
ruthra kumar
97b922f9f1 refactor(test): make price list - more test records 2026-03-18 20:59:35 +05:30
ruthra kumar
92f0175e91 refactor(test): flaky test data in bank reconciliation tool 2026-03-18 20:59:35 +05:30
ruthra kumar
66c7815369 refactor(test): call super() method first 2026-03-18 20:59:35 +05:30
ruthra kumar
f6b6c93c10 refactor(test): make customer 2026-03-18 20:59:35 +05:30
ruthra kumar
8393c1b4f6 refactor(test): make price list and update selling settings 2026-03-18 20:59:35 +05:30
ruthra kumar
20b835a53b refactor(test): make item attribute 2026-03-18 20:59:35 +05:30
ruthra kumar
1fb26b5989 refactor(test): make test accounts 2026-03-18 20:59:35 +05:30
ruthra kumar
59144e03bc refactor(test): make item tax template 2026-03-18 20:59:35 +05:30
ruthra kumar
0feedd183b refactor(test): make uom 2026-03-18 20:59:35 +05:30
ruthra kumar
402c7df643 refactor(test): make item group 2026-03-18 20:59:35 +05:30
ruthra kumar
526fc1778f refactor(test): make item 2026-03-18 20:59:35 +05:30
ruthra kumar
aa76fc5d7c refactor(test): make warehouse 2026-03-18 20:59:35 +05:30
ruthra kumar
a769c71642 chore: typo in setup method 2026-03-18 20:59:35 +05:30
ruthra kumar
3ea1283613 refactor(test): make persistent location 2026-03-18 20:59:35 +05:30
ruthra kumar
6fc0a53bae refactor(test): setup fiscal years without any gap 2026-03-18 20:59:35 +05:30
ruthra kumar
c6b661526d refactor(test): make cost center 2026-03-18 20:59:35 +05:30
ruthra kumar
0c8145e924 refactor: suppress welcome mail 2026-03-18 20:59:35 +05:30
ruthra kumar
033e826242 refactor(test): even more master data setup 2026-03-18 20:59:35 +05:30
ruthra kumar
783d51e8cc refactor(test): make all presets in setupclass 2026-03-18 20:59:35 +05:30
ruthra kumar
aff6452075 refactor: temporary standing decorator for change_settings 2026-03-18 20:59:35 +05:30
ruthra kumar
33f4791698 refactor: replace IntegrationTestCase with ERPNextTestCase repo-wide
- import ERPNextTestSuite
 - use it on test class
2026-03-18 20:59:35 +05:30
ruthra kumar
4027b82714 refactor(test): bare bones presets for company 2026-03-18 20:59:34 +05:30
ruthra kumar
5c112daa1e refactor(test): make persistent company records
'test_coa_based_on_country_template' made deterministic
2026-03-18 20:59:34 +05:30
ruthra kumar
a00814d849 refactor(test): IntegraionTestCase -> python's built-in TestCase 2026-03-18 20:59:34 +05:30
ruthra kumar
3cee89d827 chore: drop dead hook 2026-03-18 20:59:34 +05:30
ruthra kumar
2447042060 chore: remove global dependencies 2026-03-18 20:59:34 +05:30
ruthra kumar
319e220efe chore: remove IGNORE_TEST_RECORD_DEPENDENCIES 2026-03-18 20:59:34 +05:30
ruthra kumar
8eef42d075 chore: remove EXTRA_TEST_RECORD_DEPENDENCIES 2026-03-18 20:59:34 +05:30
ruthra kumar
002b4fb048 chore: delete all test_records.json 2026-03-18 20:59:34 +05:30
ruthra kumar
4167609e41 ci: run parallel test in lightmode
- modify individual test CI. let it be dormat for now.

Acked-by: ruthra kumar <ruthra@erpnext.com>
2026-03-18 20:59:34 +05:30
Mihir Kandoi
6cb6a52ded fix: incorrect sle calculation when doc has project (#53599) 2026-03-18 13:19:30 +00:00
rohitwaghchaure
0d8f6b05e3 Merge pull request #53246 from aerele/stock-entry-cost-center
feat: add cost center field to the stock entry accounting dimension tab
2026-03-18 11:49:01 +05:30
Lakshit Jain
072ec9b7ae fix: initialize all tax columns to resolve Key error in item_wise_sales_register and item_wise_purchase_register reports (#53323) 2026-03-17 23:37:06 +05:30
Mihir Kandoi
aba1f34de0 Modify CODEOWNERS to include additional owners (#53575) 2026-03-17 17:07:48 +00:00
Sudharsanan Ashok
31d14df37b fix(stock): add company filter while fetching batches (#53369) 2026-03-17 16:39:21 +00:00
Mihir Kandoi
b433852f8a chore: make supplier data expanded by default in PI (#53565) 2026-03-17 22:08:17 +05:30
Sudharsanan Ashok
fe5f16cb18 fix(stock): fix the property setter (#53422) 2026-03-17 22:02:41 +05:30
mergify[bot]
fe85dc10cc fix(italy): fix e-invoice ScontoMaggiorazione structure and included_in_print_rate support (backport #53334) (#53568)
Co-authored-by: Arturo <tamburro92@users.noreply.github.com>
2026-03-17 22:01:15 +05:30
Khushi Rawat
445aef7d17 Merge pull request #53446 from Kesavan-code/Fix-53445
fix: fetch accounting dimensions from child row in asset creation
2026-03-17 21:37:34 +05:30
Mihir Kandoi
f319857939 chore: add documentation link in valuation method field (#53564) 2026-03-17 15:32:29 +00:00
Sudharsanan Ashok
517310182e fix(manufacturing): update working hours validation (#53559) 2026-03-17 20:47:46 +05:30
diptanilsaha
3ff2871f24 fix(sales_invoice): reset payment methods on pos_profile change (#53514) 2026-03-17 19:29:30 +05:30
Soham Kulkarni
72835f9a58 Merge pull request #53322 from sokumon/add-clear-demo-data 2026-03-17 17:05:51 +05:30
ruthra kumar
dd4b83906d Merge pull request #53535 from aerele/remove-payables-receivables-workspace-v16
fix: remove payables and receivables workspace
2026-03-17 17:03:02 +05:30
ruthra kumar
41fbb916a0 fix: incorrect user perms in queries (#53548)
* chore: remove incorrect import

* fix: use qb to prevent incorrect sql due to user permissions
2026-03-17 16:32:05 +05:30
ruthra kumar
04b967bd6d fix: use qb to prevent incorrect sql due to user permissions 2026-03-17 16:06:54 +05:30
sokumon
ed3444de5a fix: use same label 2026-03-17 15:48:24 +05:30
Mihir Kandoi
ef09cffa58 chore: initiate release twice in a week (#53543) 2026-03-17 10:17:02 +00:00
Nishka Gosalia
49581e7408 fix: Creating new item price incase of changes in expired item price (#53534)
Co-authored-by: Nishka Gosalia <nishkagosalia@Nishkas-MacBook-Air.local>
2026-03-17 15:32:17 +05:30
ruthra kumar
fc2edfbded chore: remove incorrect import 2026-03-17 15:23:05 +05:30
rohitwaghchaure
13765e7557 Merge pull request #53500 from rohitwaghchaure/fixed-valuation-for-non-batchwise-valuation-batches
fix: valuation rate for no Use Batch wise Valuation batches
2026-03-17 14:12:15 +05:30
Rohit Waghchaure
4befa15198 fix: valuation rate for no Use Batch wise Valuation batches 2026-03-17 13:17:00 +05:30
ravibharathi656
26a9646407 fix: remove payables and receivables workspace 2026-03-17 12:36:57 +05:30
Jatin3128
a9e52833fe fix(Payment Entry): split orders as per the schedules in the refrence table 2026-03-17 11:28:48 +05:30
Abdus Samad
65ed936ff3 fix: add item_name to quick entry fields in Item doctype (#53530) 2026-03-17 10:56:30 +05:30
Nikhil Kothari
ef32622166 fix(banking): include paid purchase invoices in reports and bank clearance (#52675)
* fix(banking): include paid purchase invoices in reports and bank clearance

* fix: condition for amounts not reflected in system

* fix: set Sales Invoice to be the payment document in bank rec

* fix: add additional filter for `is_paid`

* fix: added is_paid

* fix: added invoice number in bank clearance tool

* chore: make requested changes

* fix: exclude opening JEs

* fix: bring back banking icon in desktop
2026-03-17 10:17:32 +05:30
Jeraldin P J
e2667ab098 fix: enable logs to track changes in doctype. (#53491)
Co-authored-by: jeraldin2003 <jeraldin2003>
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
2026-03-16 18:21:26 +00:00
Sanjesh-Raju
0a38389bc3 fix: correct overlap detection in JobCard.has_overlap (#53473)
Co-authored-by: Sanjesh <rsanjesh64@gmail.com>
Co-authored-by: Tridots Tech <info@tridotstech.com>
2026-03-16 18:18:30 +00:00
Nishka Gosalia
953f089c06 feat: Adding requested qty in packed item (#53486)
* feat: Adding requested qty in packed item

* fix: correct import path

---------

Co-authored-by: Nishka Gosalia <nishkagosalia@Nishkas-MacBook-Air.local>
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
2026-03-16 18:09:39 +00:00
rohitwaghchaure
87785a2886 Merge pull request #53513 from rohitwaghchaure/fixed-do-not-set-rate-for-si
fix: do not set valuation rate for invoice without update stock
2026-03-16 23:32:52 +05:30
Abdus Samad
4cd150ba7a fix: change "Date" label to "Posting Date" in Sales Invoice and Purchase Invoice (#53503) 2026-03-16 17:57:44 +00:00
Rohit Waghchaure
bec9e48435 fix: do not set valuation rate for invoice without update stock 2026-03-16 23:08:55 +05:30
Shllokkk
0ef7594536 Merge pull request #53223 from Shllokkk/dashboard-chart-fix
Bank balance chart fix for payments dashboard
2026-03-16 20:01:39 +05:30
diptanilsaha
09dd2f851d fix(support-settings): disable the auto-close tickets feature if close_issue_after_days is set to 0 (#53499) 2026-03-16 11:47:01 +00:00
rohitwaghchaure
b5d24f5971 Merge pull request #53495 from rohitwaghchaure/fixed-support-62674
fix: stock adjustment entry
2026-03-16 15:17:12 +05:30
Rohit Waghchaure
af3067ee23 fix: stock adjustment entry 2026-03-16 14:51:09 +05:30
diptanilsaha
5f2c24a199 fix(p&l_statement): disable accumulated value filter by default (#53488) 2026-03-16 07:18:06 +00:00
Mihir Kandoi
fd7d5bdae1 fix: use bom source warehouse in WO created from PP (#53478) 2026-03-16 10:46:28 +05:30
Mihir Kandoi
ebb4a3d053 fix: use bom source warehouse in WO created from PP 2026-03-16 10:29:31 +05:30
Jeraldin P J
c09ea94133 fix: remove supplier selection dialog when creating Purchase Order from Material Request (#53391)
Co-authored-by: jeraldin2003 <jeraldin2003>
Co-authored-by: Nikhil Kothari <nik.kothari22@live.com>
2026-03-16 09:45:30 +05:30
Raffael Meyer
9e8c70e6b4 chore: add docs to project URLs (#53467) 2026-03-15 13:36:00 +00:00
MochaMind
008b296014 chore: update POT file (#53464) 2026-03-15 14:31:26 +01:00
sokumon
413b119ec6 fix: add icon in clear demo data 2026-03-15 17:49:32 +05:30
diptanilsaha
7a8d1931ed fix(serial_and_batch_bundle_selector): handle CSV attachment properly (#53460) 2026-03-15 12:58:58 +05:30
Mihir Kandoi
5ba6446451 fix: sales order indicator should be based on available qty rather th… (#53456) 2026-03-15 09:43:11 +05:30
Mihir Kandoi
708e4fa2be fix: sales order indicator should be based on available qty rather than delivered qty 2026-03-15 09:41:32 +05:30
[Kesavan-001]
e0fb31f81e Fix:Cost center mapping issue 2026-03-14 13:26:46 +05:30
[Kesavan-001]
a084feba96 Fix:Cost center mapping issue 2026-03-14 12:50:47 +05:30
[Kesavan-001]
10fe8580d5 Fix:Cost center mapping issue 2026-03-14 12:39:48 +05:30
David
b5a21855f6 feat(stock): implement fallback logic for Delivery Trip address mapping (#53260) 2026-03-14 05:41:19 +00:00
diptanilsaha
c99598e22e Merge pull request #53309 from frappe/l10n_develop 2026-03-14 02:39:06 +05:30
Sagar Vora
be85ecba1b Merge pull request #53430 from sagarvora/auto-cancel-exempt
fix: exempt ledger entries and closing balance from auto-cancellation
2026-03-13 18:06:21 +00:00
Sagar Vora
c069a1787d fix: hide cancel button from ledger / closing balance doctypes 2026-03-13 23:20:42 +05:30
MochaMind
67a80127e3 fix: Portuguese, Brazilian translations 2026-03-13 23:07:09 +05:30
Sagar Vora
56efe5e82c fix: exempt ledger entries and account closing balance from auto-cancellation 2026-03-13 23:03:13 +05:30
ruthra kumar
b1c1bca2b8 Merge pull request #53423 from ruthra-kumar/remove_fw_added_total_rows_from_trends_reports
refactor: disable total row in trends report
2026-03-13 18:02:05 +05:30
ruthra kumar
4dbc72b301 refactor: disable total row in trends report 2026-03-13 17:37:04 +05:30
ruthra kumar
b9a47d85db Merge pull request #53415 from ruthra-kumar/broken_cost_center_filter_in_get_outstanding_documents
fix: broke cost center filter in get outstanding reference docs
2026-03-13 15:24:28 +05:30
ruthra kumar
7dfe36fdce fix: broke cost center filter in get outstanding reference docs 2026-03-13 14:55:56 +05:30
Khushi Rawat
e85eb90ec7 Merge pull request #53416 from khushi8112/subsidiary-companies-value-in-purchase-analytics
feat: show subsidiary companies value in purchase analytics
2026-03-13 14:42:06 +05:30
khushi8112
9f755ad65a feat: show subsidiary companies value in purchase analytics 2026-03-13 14:37:11 +05:30
Mihir Kandoi
bd87a7e612 Revert "fix(regional): rename duplicate Customer fields in Italy setup" (#53409) 2026-03-13 07:27:32 +00:00
Smit Vora
20fc9c7b18 Merge pull request #53396 from vorasmit/same-phantom-different-fg 2026-03-13 09:44:42 +05:30
Khushi Rawat
f08293efec Merge pull request #53390 from khushi8112/asset-purchase-amount-currency
refactor: show company currency in purchase amount label
2026-03-13 00:47:37 +05:30
khushi8112
6219a9e6f0 fix: update label on company change 2026-03-13 00:27:43 +05:30
khushi8112
b4c82c0f1a refactor: show company currency in purchase amount label 2026-03-13 00:27:43 +05:30
MochaMind
7362f2e5fb fix: Portuguese, Brazilian translations 2026-03-12 23:05:16 +05:30
MochaMind
62715787c1 fix: Swedish translations 2026-03-12 23:05:07 +05:30
Smit Vora
b1e1c65774 chore: phantom qty unused in sub_assembly_items 2026-03-12 21:16:03 +05:30
Smit Vora
1975ae4486 test: ensure phantom BOM explosion across all items 2026-03-12 20:31:56 +05:30
Solede
c6efc403cd fix(regional): rename duplicate Customer fields in Italy setup (#50921)
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-12 20:25:35 +05:30
Smit Vora
e57de4311c fix: correctly group RMs of same phantom from different FG 2026-03-12 20:21:18 +05:30
Mihir Kandoi
999a72a16a fix: get_item_tax_info type hints (#53392) 2026-03-12 14:07:49 +00:00
Sagar Vora
d8a56e9943 Merge pull request #53395 from shubhdoshi21/flag-fix
fix: update invalid syntax for flags
2026-03-12 12:39:22 +00:00
Shubh Doshi
c6e6859090 fix: update invalid syntax for flags 2026-03-12 17:52:10 +05:30
Shubh Doshi
ad8c05426e fix: make ledger entries submittable and cleanup invalid test submissions (#52921)
* fix: enable submittability for ledger entries and cleanup invalid test submissions

* fix: reverted child table submittability

* fix: added ignore_links flag for back gl entry

* fix: add ignore_links for reconcile,cancelled PLE,cancelled SLE

* fix: update test_recreate_stock_ledgers to use db.delete instead of doc.delete

* chore: temporary test against frappe PR 37009

* fix: make Advance Payment Ledger Entry submittable

* refactor: add extra line for create_shipping_rule

* chore: revert temporary test against frappe PR 37009

* fix: use parent doc save with ignore_validate_update_after_submit for child table updates

* chore: temporary test against frappe PR 37009

* chore: revert temporary test against frappe PR 37009

* fix: use skip_docstatus_validation
2026-03-12 16:27:51 +05:30
Khushi Rawat
0e888cc86b Merge pull request #53379 from khushi8112/correct-filter-for-asset-in-purchase-receipt
fix: use correct filter to get the composite assets
2026-03-12 15:10:34 +05:30
khushi8112
f5a3227349 fix: use correct filter to get the composite assets 2026-03-12 14:51:25 +05:30
Mihir Kandoi
7f644785ce fix: do not modify rate in the child item merely for comparison (#53301) 2026-03-12 14:30:00 +05:30
Mihir Kandoi
3bb18d0baf fix: precision issue in production plan (#53370) 2026-03-12 14:26:29 +05:30
Khushi Rawat
bef4c010c6 Merge pull request #53371 from khushi8112/asset-repair-show-general-ledger
fix: move show_general_ledger to Asset Repair form events
2026-03-12 14:05:20 +05:30
khushi8112
ac124bdc7e fix: move show_general_ledger to Asset Repair form events 2026-03-12 13:18:00 +05:30
Mihir Kandoi
9c0c39381f fix: add validation in bom creator function (#53364) 2026-03-12 06:48:54 +00:00
Mihir Kandoi
b1ff4daaf5 fix: NoneType error when template description is to be copied to variant (#53358) 2026-03-12 06:33:28 +00:00
Mihir Kandoi
cb05f8a67a refactor: supplier quotation comparision report button should start f… (#53361) 2026-03-12 06:15:47 +00:00
Mihir Kandoi
8d5566e783 refactor: add type hints required flag to hooks.py (#53356) 2026-03-12 11:42:46 +05:30
Mihir Kandoi
417066d188 refactor: add type hints required flag to hooks.py 2026-03-12 11:08:24 +05:30
Ejaaz Khan
e4d79c6246 fix: remove redundant pos print format (#53348) 2026-03-12 05:11:53 +00:00
David
a3a57e20f1 Feat/shipment default contact (#53029) 2026-03-12 10:40:39 +05:30
NaviN
a8dcf70459 fix(delivery note): avoid maintaining si_detail on return delivery note (#52456) 2026-03-12 10:36:18 +05:30
Pandiyan P
a30599570c fix: handle NoneType error while creating a item (#53313) 2026-03-12 10:31:41 +05:30
V Shankar
e107d3ca84 fix: re-calculate taxes and totals after resetting bundle item rate (#53342) 2026-03-12 10:29:59 +05:30
Pandiyan P
77cf0afa1a fix: update child item schedule_date and prevent past dates (#53298) 2026-03-12 09:57:38 +05:30
MochaMind
793db90a14 fix: Portuguese, Brazilian translations 2026-03-11 23:09:41 +05:30
Deepesh Garg
9a4c7766e3 Merge pull request #53327 from Nihantra-Patel/fix-journal-entry-ignore-linked-doctypes
fix: Append existing ignored doctypes in Journal Entry on_cancel instead of overwriting
2026-03-11 16:10:37 +05:30
Mihir Kandoi
f1ac0376fb feat: co product by product support (#52979) 2026-03-11 14:46:36 +05:30
ruthra kumar
65c33e6b39 Merge pull request #53326 from ruthra-kumar/allow_cost_center_on_payment_entry_deductions
refactor: make cost center editable in payment entry deduction
2026-03-11 14:45:41 +05:30
Nihantra Patel
39e10c4ab0 fix: Append existing ignored doctypes in Journal Entry on_cancel instead of overwriting 2026-03-11 14:40:41 +05:30
ruthra kumar
38bdc99172 Merge pull request #53294 from ruthra-kumar/stop_v14_weekly_release
ci: drop v14 from weekly release
2026-03-11 14:38:38 +05:30
ruthra kumar
078b22d985 refactor: make cost center editable in payment entry deduction 2026-03-11 14:26:16 +05:30
Nishka Gosalia
0205341cb5 Merge pull request #53312 from creative-paramu/production_plan_item_description_update 2026-03-11 14:18:36 +05:30
Parameshwari Palanisamy
39e68a9ce7 Update production_plan.py 2026-03-11 11:41:24 +05:30
creative-paramu
19533551f4 fix: update item description in Production Plan Assembly Items table 2026-03-11 11:14:33 +05:30
MochaMind
f3b270c927 fix: Serbian (Cyrillic) translations 2026-03-10 23:06:36 +05:30
MochaMind
330216ff0d fix: Serbian (Latin) translations 2026-03-10 23:06:26 +05:30
MochaMind
86bad84504 fix: Swedish translations 2026-03-10 23:06:18 +05:30
MochaMind
24e0c4034d fix: Spanish translations 2026-03-10 23:06:09 +05:30
Shllokkk
17eb983c40 fix: sanitize genericode import inputs and secure XML parser 2026-03-10 21:15:33 +05:30
ruthra kumar
ac8f3d7f96 fix: set default list view columns and filters for sales, purchase and accounts module (#53256) 2026-03-10 17:52:17 +05:30
Abdeali Chharchhodawala
0d42faac2e Merge pull request #52636 from Abdeali099/Abdeali/india-coa
refactor: enhance chart of accounts for India with account categories
2026-03-10 17:21:37 +05:30
ruthra kumar
7cf7a967da Merge pull request #53071 from aerele/fix-gross-profit-qty-precision
fix(gross-profit): apply precision-based rounding to grouped totals
2026-03-10 16:37:41 +05:30
ruthra kumar
ee187065c6 ci: drop v14 from weekly release 2026-03-10 16:29:02 +05:30
rohitwaghchaure
ac8a0b7b3d Merge pull request #53283 from rohitwaghchaure/fixed-patch-not-exists
fix: removed non existent patch
2026-03-10 14:25:50 +05:30
Mihir Kandoi
567d6c5102 Merge pull request #53282 from mihir-kandoi/fix-qi-submission 2026-03-10 14:15:32 +05:30
rohitwaghchaure
20cdf744fd Merge pull request #53281 from rohitwaghchaure/fixed-better-validation-message-pi-with-update-stock
fix: better validation message for Purchase Invoice with Update Stock
2026-03-10 14:03:18 +05:30
Mihir Kandoi
9f62ec5192 fix: allow user to make QI after submission not working 2026-03-10 13:55:49 +05:30
Rohit Waghchaure
c4b3080eae fix: removed non existent patch 2026-03-10 13:55:36 +05:30
Rohit Waghchaure
cfb06cf247 fix: better validation message for Purchase Invoice with Update Stock 2026-03-10 13:36:11 +05:30
Mihir Kandoi
53238ba94f Merge pull request #53203 from aerele/employee-user-status 2026-03-10 13:09:08 +05:30
Mihir Kandoi
1da71fee2b Merge pull request #53235 from aerele/fix/sales-order-delivery-date 2026-03-10 12:52:53 +05:30
Priyal Rawal
a6e78c2eea fix: add permission checks in whitelisted functions (#53103) 2026-03-10 07:04:15 +00:00
ruthra kumar
f2f47d6d88 Merge pull request #53238 from vorasmit/regional-rounding
fix: use return value of `get_round_off_applicable_accounts`
2026-03-10 12:28:16 +05:30
rohitwaghchaure
8d470b92db Merge pull request #53272 from rohitwaghchaure/fixed-patch-falling
fix: patch failing
2026-03-10 12:01:42 +05:30
Rohit Waghchaure
6024c4a077 fix: patch failing 2026-03-10 11:44:20 +05:30
MochaMind
b0ec75d539 fix: sync translations from crowdin (#53262) 2026-03-09 20:49:12 +01:00
ruthra kumar
cd7845124c fix: allow payment_request to be created in draft (#53160) 2026-03-09 20:21:33 +05:30
Shllokkk
2e844a58fb perf: optimize account balance data fetching for Chart Of Accounts 2026-03-09 20:09:03 +05:30
rohitwaghchaure
5ca8641488 Merge pull request #53254 from rohitwaghchaure/fixed-github-53253
fix: bom UX issues
2026-03-09 18:17:33 +05:30
Nabin Hait
9cf529215f fix: set default list view columns and filters for sales, purchase and accounts module 2026-03-09 17:20:52 +05:30
Rohit Waghchaure
32447b8204 fix: bom UX issues 2026-03-09 16:25:08 +05:30
Nishka Gosalia
af817b8134 Merge pull request #53249 from nishkagosalia/purchase-order-button-fix 2026-03-09 15:05:42 +05:30
Nishka Gosalia
829dbbe12b fix :buttons not visible on purchase and sales order 2026-03-09 15:02:31 +05:30
Khushi Rawat
9c27d66add Merge pull request #53242 from khushi8112/asset-report-query-builder
refactor: replace raw SQL with query builder in asset depreciation and balances report
2026-03-09 14:57:29 +05:30
sudarshan-g
47772f4e77 feat: add cost center field to the stock entry accounting dimension tab 2026-03-09 13:32:59 +05:30
rohitwaghchaure
563184920a Merge pull request #53239 from rohitwaghchaure/fixed-validation-for-docstatus
fix: validation for cancellation
2026-03-09 13:18:56 +05:30
Pandiyan37
77367b5517 fix(selling): update delivery date in line items 2026-03-09 13:10:01 +05:30
khushi8112
f496995415 refactor: more functions in same file 2026-03-09 12:56:24 +05:30
Krishna Shirsath
1f19175fef refactor(employee): remove anniversary indicator logic from employee form 2026-03-09 12:50:56 +05:30
khushi8112
314c882f3b refactor: replace raw SQL with query builder in asset depreciation and balannces report 2026-03-09 12:39:49 +05:30
Mihir Kandoi
adbe856c4e Merge pull request #53234 from aerele/fix/support-#61532 2026-03-09 12:33:46 +05:30
Rohit Waghchaure
8de272a8a1 fix: validation for cancellation 2026-03-09 12:05:46 +05:30
Krishna Pramod Shirsath
f8f61f0b81 Merge branch 'develop' into feat/employee-creation-and-lifecycle 2026-03-09 11:47:19 +05:30
Krishna Shirsath
053242d5bd fix(employee): add 'set_only_once' property to 'Create User Automatically' field 2026-03-09 11:12:12 +05:30
Smit Vora
56a073955a test: regional account correctly added to round off accounts 2026-03-09 06:19:42 +05:30
Smit Vora
5c6056e76b fix: use return value of get_round_off_applicable_accounts 2026-03-09 05:19:22 +05:30
diptanilsaha
bf38dea95f Merge pull request #53233 from frappe/pot_develop_2026-03-08 2026-03-08 22:56:51 +05:30
Sudharsanan11
ae9ff767fa feat(manufacturing): show disassembled qty in progress bar 2026-03-08 19:14:41 +05:30
Sudharsanan11
8027f5aafd fix(manufacturing): show returned qty in progress bar 2026-03-08 19:14:41 +05:30
frappe-pr-bot
cad6956935 chore: update POT file 2026-03-08 09:42:56 +00:00
ruthra kumar
d038ad2350 Merge pull request #53227 from ruthra-kumar/add_party_filter_on_comparison_report
refactor: party type and party filter for comparison report
2026-03-07 18:18:58 +05:30
ruthra kumar
b6f9c0844e refactor: party type and party filter for comparison report 2026-03-07 18:02:56 +05:30
diptanilsaha
f67cfc48e0 Merge pull request #53224 from diptanilsaha/missed_ta 2026-03-07 15:23:50 +05:30
diptanilsaha
56345f4354 refactor(book_appointment): type annotations for whitelisted methods 2026-03-07 15:00:34 +05:30
diptanilsaha
b51c59d20d refactor(templates): type annotations for whitelisted methods 2026-03-07 15:00:34 +05:30
diptanilsaha
decd9343ee refactor(call_log): type annotations for whitelisted methods 2026-03-07 15:00:34 +05:30
diptanilsaha
950bf682c3 refactor(support): type annotations for whitelisted methods 2026-03-07 15:00:34 +05:30
diptanilsaha
1f4d20413e refactor(serial_no): added missing type annotation on auto_fetch_serial_number 2026-03-07 15:00:34 +05:30
diptanilsaha
11a6db32ae refactor(leaderboard): type annotations for whitelisted methods 2026-03-07 15:00:34 +05:30
diptanilsaha
805fc807a9 refactor(work_order): added type annotations on cancel_stock_reservation_entries 2026-03-07 15:00:34 +05:30
diptanilsaha
b4fb74c84d refactor(asset): added type annotations on get_depreciation_rate 2026-03-07 15:00:28 +05:30
diptanilsaha
ac351bce4b Merge pull request #53222 from frappe/l10n_develop 2026-03-07 14:55:12 +05:30
diptanilsaha
208112e7a9 refactor(payment_request): type annotations for whitelisted methods 2026-03-07 11:44:16 +05:30
diptanilsaha
616bae1f84 refactor: type annotations for whitelisted methods 2026-03-07 11:42:16 +05:30
diptanilsaha
573eb25d5b Merge pull request #53022 from diptanilsaha/crm_ta 2026-03-07 11:41:26 +05:30
diptanilsaha
8267482ee9 refactor(crm): type annotations for whitelisted methods 2026-03-07 03:00:54 +05:30
diptanilsaha
a1c378c16f Merge pull request #53032 from diptanilsaha/setup_ta 2026-03-07 02:29:29 +05:30
diptanilsaha
e6bebbfe81 test: added the currency key and fixed company 2026-03-07 02:05:54 +05:30
MochaMind
9358a122cd fix: Russian translations 2026-03-06 23:08:42 +05:30
rohitwaghchaure
3bd023d640 Merge pull request #53218 from rohitwaghchaure/fixed-item-creation-in-test-cases
fix: HRMS test cases failing due to validation in item
2026-03-06 17:54:36 +05:30
Rohit Waghchaure
6702506f58 fix: HRMS test cases failing due to validation in item 2026-03-06 17:35:12 +05:30
diptanilsaha
913ce9454e fix(consolidated_financial_statement): convert report to presentation_currency if valid filter is set 2026-03-06 16:04:28 +05:30
diptanilsaha
24f5fb7b44 fix(sales_order): set valid target.currency in make_purchase_order 2026-03-06 16:04:28 +05:30
diptanilsaha
6aaca38ce3 refactor(setup): type annotataions for whitelisted methods 2026-03-06 16:04:28 +05:30
diptanilsaha
fbdb3a1f48 Merge pull request #53031 from diptanilsaha/regional_ta 2026-03-06 15:54:05 +05:30
Shubh Doshi
d2e039ad4e fix: add type hints to whitelisted functions (#53210) 2026-03-06 08:27:01 +00:00
rohitwaghchaure
d6abbce4ec Merge pull request #53200 from rohitwaghchaure/fixed-stock-balance-report
fix: stock balance report qty
2026-03-06 12:43:55 +05:30
Poovitha Palanivelu
194d060f13 fix: update user status depends on employee status 2026-03-06 12:27:24 +05:30
rohitwaghchaure
f316229f9e Merge pull request #52549 from rohitwaghchaure/feat-option-to-enable-disable-serial-batch
feat: option to enable serial / batch feature
2026-03-06 12:17:11 +05:30
Rohit Waghchaure
a15e5fdc4e fix: stock balance report qty 2026-03-06 12:16:07 +05:30
Rohit Waghchaure
82c3da5b1e feat: option to enable serial / batch features 2026-03-06 11:47:53 +05:30
Soham Kulkarni
76d8e8fec9 Merge pull request #53177 from sokumon/add-clear-demo-data 2026-03-05 23:43:21 +05:30
Akhil Narang
702adda000 fix(help): escape query (#53192)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-03-05 13:06:09 +00:00
rohitwaghchaure
2bc3c146a6 Merge pull request #52956 from rohitwaghchaure/organization-desktop-icon
feat: organization desktop icon
2026-03-05 14:05:32 +05:30
rohitwaghchaure
ba05608ce6 Merge pull request #52745 from rohitwaghchaure/fixed-balance-qty-inv-dimension
fix: balance qty for inv dimension
2026-03-05 13:49:36 +05:30
Rohit Waghchaure
4e9a2a327f feat: organization desktop icon 2026-03-05 13:43:35 +05:30
rohitwaghchaure
06e0effbf7 Merge pull request #53170 from jacob-salvi/new-org-icon
chore: New org icon
2026-03-05 13:39:16 +05:30
Rohit Waghchaure
a3eafe5b18 fix: balance qty for inv dimension 2026-03-05 13:22:45 +05:30
Mihir Kandoi
50d6971d20 Merge pull request #53161 from mihir-kandoi/type-hint-issues 2026-03-05 12:06:26 +05:30
Nishka Gosalia
7e368c16b7 Merge pull request #52924 from nishkagosalia/projects-form-cleanup 2026-03-05 11:57:43 +05:30
Jatin3128
edac82f6e3 Merge pull request #52138 from aerele/payment-date-mismatch
feat(selling-settings): add checkbox to fetch payment terms
2026-03-05 11:48:43 +05:30
Nishka Gosalia
3c9f520e68 refactor: project module form cleanup 2026-03-05 11:40:22 +05:30
sokumon
6603005822 fix: add clear demo data in sidebar 2026-03-05 11:32:56 +05:30
Nishka Gosalia
15eb5d9827 Merge pull request #52415 from aerele/project-template-task-subject 2026-03-05 11:31:21 +05:30
ravibharathi656
7801dd5353 fix(task): allow is_template field in quick entry 2026-03-05 10:56:48 +05:30
ravibharathi656
c1431105f4 fix(project template): clear subject when task is empty 2026-03-05 10:56:48 +05:30
jacob-salvi
6f93210b9b chore: new organisation icon 2026-03-05 10:14:45 +05:30
SowmyaArunachalam
8aae46a25e test: test payment terms with backdated entries 2026-03-04 21:47:43 +05:30
SowmyaArunachalam
99ed1c34f3 fix: fetch payment terms from quotation 2026-03-04 21:47:41 +05:30
Mihir Kandoi
f07a6eb199 Merge pull request #53166 from mihir-kandoi/wo-producted-qty 2026-03-04 20:33:57 +05:30
Mihir Kandoi
5fead1d17a fix: WO produced qty should be calculated using finished item child table transfer qty 2026-03-04 20:17:37 +05:30
SowmyaArunachalam
8b9e02fd44 fix: set default to 1 2026-03-04 19:00:16 +05:30
SowmyaArunachalam
f23dc07914 fix: handle payment terms template when disabled 2026-03-04 19:00:15 +05:30
SowmyaArunachalam
5611e9168e test: enable automatically_fetch_payment_terms_from_quotation 2026-03-04 19:00:15 +05:30
SowmyaArunachalam
b1149fe950 fix: consider payment term only when enabled 2026-03-04 19:00:15 +05:30
SowmyaArunachalam
70b401e610 feat(selling-settings): add checkbox to recalculate payment date 2026-03-04 19:00:15 +05:30
Mihir Kandoi
58c198a58b Merge pull request #53157 from mihir-kandoi/gh53101 2026-03-04 16:51:09 +05:30
Khushi Rawat
f2decc852c Merge pull request #53154 from khushi8112/inter-company-asset-transfer-issue
fix: skip asset sale processing for internal transfer invoices
2026-03-04 16:36:03 +05:30
Mihir Kandoi
ee19c32c3a fix: disallow all actions on job card if work order is closed 2026-03-04 16:34:32 +05:30
Mihir Kandoi
74b658fabf fix: some type hints 2026-03-04 16:31:28 +05:30
ervishnucs
24825a16e0 fix: allow payment_request to be created in draft 2026-03-04 16:25:30 +05:30
Mihir Kandoi
083b571641 Merge pull request #53156 from nishkagosalia/st-61597 2026-03-04 16:12:24 +05:30
Nishka Gosalia
e37d4a6f7c fix: updating costing based on employee change in timesheet 2026-03-04 15:24:54 +05:30
khushi8112
9cb3dad079 fix: skip asset sale processing for internal transfer invoices 2026-03-04 14:20:14 +05:30
Mihir Kandoi
700c14d5b3 Merge pull request #53147 from nishkagosalia/gh-52102 2026-03-04 12:19:35 +05:30
Mihir Kandoi
c0148c7266 Merge pull request #53148 from mihir-kandoi/fg_completed_qty 2026-03-04 12:09:18 +05:30
Mihir Kandoi
2d83069b82 fix: do not update fg_completed_qty when changing qty of fg line item 2026-03-04 12:06:28 +05:30
Nishka Gosalia
2ec02e477f feat: allowing rate modification in update item in quotation 2026-03-04 10:54:51 +05:30
ruthra kumar
42ae954c16 Merge pull request #53005 from frappe/l10n_develop
fix: sync translations from crowdin
2026-03-04 10:45:47 +05:30
Mihir Kandoi
e3a55d31d3 Merge pull request #52784 from aerele/fix/support-#60042 2026-03-03 21:16:15 +05:30
Mihir Kandoi
767925a481 Merge pull request #53132 from aerele/fix/selling-price-validation 2026-03-03 21:09:30 +05:30
Mihir Kandoi
e970578c47 Merge pull request #53070 from aerele/rfq-email-template 2026-03-03 21:05:53 +05:30
kavin-114
723993fdf6 test: add unit test for FG Item selling price validation 2026-03-03 20:44:08 +05:30
kavin-114
4335318482 fix(selling): handle selling price validation for FG item
System checks valuation rate in incoming_rate field, since SO has it in valuation_rate field of item row,
need to handle the field name dynamically based upon the doctype name in Selling Controller.
2026-03-03 20:44:00 +05:30
Mihir Kandoi
17c715fde0 Merge pull request #53084 from aerele/fix/support-#61033 2026-03-03 20:40:31 +05:30
Mihir Kandoi
c76be620a8 Merge pull request #53037 from aerele/fix/qi-naming-rule-issue 2026-03-03 20:38:54 +05:30
Mihir Kandoi
2ce276df5b Merge pull request #53099 from aerele/fix/procurement-report-requestor-invalid 2026-03-03 20:38:10 +05:30
rohitwaghchaure
e1bad10e6c Merge pull request #53123 from rohitwaghchaure/fixed-status-of-serial-no
fix: serial no status for Disassemble entry
2026-03-03 18:53:35 +05:30
Shariq Ansari
93f2a8ad6b Merge pull request #53119 from shariquerik/erpnext-crm-fix 2026-03-03 03:42:52 -08:00
Rohit Waghchaure
81acefa8ad fix: serial no status for Disassemble entry 2026-03-03 17:11:53 +05:30
shariquerik
800810d23d fix: ensure contacts are processed only if present in create_prospect_against_crm_deal 2026-03-03 16:56:00 +05:30
diptanilsaha
a1124449c2 Merge pull request #53110 from diptanilsaha/pr_tt 2026-03-03 15:00:09 +05:30
diptanilsaha
6342e78305 refactor: renamed args to pricing_ctx in set_transaction_type for clarity 2026-03-03 14:42:11 +05:30
Vishnu Priya Baskaran
d2e04750b5 fix: avoid circular dependency (#53109) 2026-03-03 14:32:08 +05:30
diptanilsaha
7ec0354a79 fix(pricing_rule): strict validation of transaction_type 2026-03-03 14:08:49 +05:30
Ravibharathi
9a5b476d9c Merge pull request #51940 from aerele/accounts-receivable-payment-terms-template-filter 2026-03-03 11:27:31 +05:30
diptanilsaha
7ee08c9964 Merge pull request #53104 from frappe/ch-sec 2026-03-03 10:38:15 +05:30
diptanilsaha
b666d9d5c1 chore: update SECURITY.md 2026-03-03 10:36:54 +05:30
kavin-114
bdf4e51da3 fix: populate mr owner and set po owner as fallback 2026-03-02 23:40:40 +05:30
kavin-114
397de1274f fix: pass company in test case using make_quality_inspections 2026-03-02 22:50:21 +05:30
kavin-114
4c39cf2d65 test: add unit test to handle company condition in naming rule 2026-03-02 22:50:11 +05:30
rohitwaghchaure
260fc6a7ce Merge pull request #53093 from rohitwaghchaure/fixed-opening-qty-in-stock-balance
fix: opening qty in stock balance
2026-03-02 20:48:51 +05:30
Mihir Kandoi
c031e345db Merge pull request #52838 from Shllokkk/so-mr-po 2026-03-02 20:41:20 +05:30
Rohit Waghchaure
d7fdab99cb fix: opening qty in stock balance 2026-03-02 17:44:13 +05:30
Shllokkk
35d814c7b3 Merge branch 'develop' into so-mr-po 2026-03-02 16:43:13 +05:30
Shllokkk
91c6475f1c fix: update select query field in patch and code refactor 2026-03-02 16:25:02 +05:30
rohitwaghchaure
735631899f Merge pull request #53087 from aerele/perf/index-reference-purchase-receipt-column
perf: add index on reference_purchase_receipt column
2026-03-02 14:37:08 +05:30
rohitwaghchaure
868a7eb5ca Merge pull request #53082 from rohitwaghchaure/fixed-validate-warehouse-of-sabb
fix: validate warehouse of SABB for draft entry
2026-03-02 14:21:56 +05:30
kavin-114
8c94396ad9 perf: add index on reference_purchase_receipt column 2026-03-02 14:05:40 +05:30
rohitwaghchaure
47b08eaa41 Merge pull request #53072 from aerele/fix/support-#61417
fix(accounts): set posting time to get incoming rate
2026-03-02 13:45:49 +05:30
Rohit Waghchaure
9b8f685c82 fix: validate warehouse of SABB for draft entry 2026-03-02 13:41:20 +05:30
Sudharsanan11
c5b3673a30 fix(accounts): set posting time to get incoming rate 2026-03-02 13:21:25 +05:30
Sudharsanan11
9538a9870c fix(accounts): add transaction time field 2026-03-02 13:21:21 +05:30
Sudharsanan11
6b1aac4aee fix(manufacturing): ignore sales order validation for subassembly item 2026-03-02 12:26:55 +05:30
Diptanil Saha
066442c236 Merge pull request #53079 from diptanilsaha/bvr-validate-dimension 2026-03-02 12:00:37 +05:30
Navin-S-R
52dd7665e7 fix(gross-profit): apply precision-based rounding to grouped totals 2026-03-02 11:15:49 +05:30
diptanilsaha
79d0708ea7 fix(budget-variance-report): validate 'budget_against' filter 2026-03-02 11:04:35 +05:30
Nishka Gosalia
7b3d85c74e Merge pull request #53047 from trustedcomputer/fix-timesheet-table-read-only 2026-03-02 10:54:44 +05:30
rohitwaghchaure
733528a9f5 Merge pull request #53050 from rohitwaghchaure/fixed-incorrect-voucher-detail-no
fix: voucher detail no in SABB
2026-03-02 09:52:48 +05:30
Pugazhendhi Velu
49d363b174 fix: handle html email template separately in RFQ to avoid jinja context error 2026-03-01 18:21:09 +00:00
Rohit Waghchaure
c37a56ec89 fix: voucher detail no in SABB 2026-03-01 21:54:00 +05:30
Mihir Kandoi
1592229b24 Merge pull request #53067 from mihir-kandoi/correct-precision 2026-03-01 21:21:10 +05:30
Mihir Kandoi
36726b0f7b fix: use the correct precision value in stock reco 2026-03-01 20:48:33 +05:30
Mihir Kandoi
3fad5fb9b9 Merge pull request #53062 from Sanjesh2254/fix/sle-voucher-type-comparison 2026-03-01 20:46:01 +05:30
Sanjesh
cffb59ae73 fix: correct sle voucher_type comparison in get_ref_doctype 2026-03-01 16:31:53 +05:30
Mihir Kandoi
9563af9ae1 Merge pull request #53057 from mihir-kandoi/gh53003 2026-03-01 15:47:12 +05:30
Mihir Kandoi
e68d9af498 Merge pull request #53052 from mihir-kandoi/gh53035 2026-03-01 15:20:55 +05:30
Mihir Kandoi
04127019f9 fix: allow allowed roles to bypass over billing validation 2026-03-01 15:16:38 +05:30
Mihir Kandoi
81fd3c86f4 Merge pull request #53051 from mihir-kandoi/gh53049 2026-03-01 15:09:29 +05:30
Mihir Kandoi
30c3ff2efe fix: use stock qty instead of qty when creating stock entry from MR 2026-03-01 15:04:17 +05:30
Mihir Kandoi
5f12b0db3f fix: use conversion factor when creating stock entry from pick list 2026-03-01 14:53:27 +05:30
trustedcomputer
b9d95711a2 fix: remove read-only property from Sales Invoice Timesheet Table 2026-02-28 18:10:07 -08:00
MochaMind
86ade52dc6 fix: Spanish translations 2026-02-28 22:26:03 +05:30
kavin-114
74def423ed fix(stock): pass company to avoid document naming rule issue in QI
When a Document Naming Rule is configured in QI with a condition based on the company,
the system was not passing the company value properly. As a result, the naming rule
condition was skipped and the document name was generated using the default series.

This fix ensures that the company is passed correctly so that the configured
Document Naming Rule is evaluated and applied as expected.
2026-02-28 13:10:30 +05:30
rohitwaghchaure
061d2e45a9 Merge pull request #52988 from rohitwaghchaure/fixed-same-reposting-picked-by-multiple-jobs
fix: same reposting entry picked by multiple rq jobs
2026-02-28 07:35:44 +05:30
diptanilsaha
df6780bf1a refactor(regional): type annotataions for whitelisted methods 2026-02-28 02:52:03 +05:30
Khushi Rawat
6fc0ea02a1 Merge pull request #53004 from khushi8112/tax-rule-validation-query-builder
refactor: use query builder for Tax Rule validation query
2026-02-27 23:54:03 +05:30
MochaMind
81281d88c7 fix: Serbian (Cyrillic) translations 2026-02-27 22:21:42 +05:30
MochaMind
3dcdde83c7 fix: Serbian (Latin) translations 2026-02-27 22:21:36 +05:30
MochaMind
27381ae77b fix: Swedish translations 2026-02-27 22:21:32 +05:30
MochaMind
63fe68bf28 fix: Spanish translations 2026-02-27 22:21:25 +05:30
Diptanil Saha
6fbdcc3dd1 Merge pull request #53028 from diptanilsaha/qm_ta 2026-02-27 17:06:37 +05:30
ruthra kumar
8397b1ee4b Merge pull request #53027 from ruthra-kumar/remove_frappe_flags_from_dimension_filter
refactor: remove frappe.flags from accounting dimensions filter
2026-02-27 16:54:56 +05:30
Diptanil Saha
a5e4256491 Merge pull request #53026 from diptanilsaha/project_ta 2026-02-27 16:50:36 +05:30
diptanilsaha
eb2f986b11 refactor(quality_management): type annotations for whitelisted methods 2026-02-27 16:48:58 +05:30
Diptanil Saha
5bae06ae96 Merge pull request #53024 from diptanilsaha/maintenance_ta 2026-02-27 16:41:39 +05:30
Diptanil Saha
2712bc8661 Merge pull request #53023 from diptanilsaha/ref_erp_int 2026-02-27 16:40:49 +05:30
ruthra kumar
290f979fd3 refactor: remove frappe.flags from accounting dimensions filter 2026-02-27 16:37:27 +05:30
diptanilsaha
a22ea1de86 refactor(project): type annotations for whitelisted methods 2026-02-27 16:34:04 +05:30
diptanilsaha
13859dfb3c refactor(erpnext_integrations): type annotations for whitelisted methods 2026-02-27 16:19:40 +05:30
diptanilsaha
3078c4a451 fix: get_serial_nos_from_schedule return value 2026-02-27 16:11:45 +05:30
diptanilsaha
73f72bda42 refactor(maintenance): type annotations for whitelisted methods 2026-02-27 16:00:20 +05:30
rohitwaghchaure
aec400c12d Merge pull request #53013 from rohitwaghchaure/revert-stock-reco-issue
fix: old stock reco entries causing issue in the stock balance report
2026-02-27 14:56:07 +05:30
Rohit Waghchaure
0874cbc268 fix: old stock reco entries causing issue in the stock balance report 2026-02-27 14:09:15 +05:30
Mihir Kandoi
048608556c Merge pull request #53012 from thomasantony12/patch-2 2026-02-27 13:53:07 +05:30
Krishna Pramod Shirsath
66976c13e4 Merge branch 'develop' into feat/employee-creation-and-lifecycle 2026-02-27 13:10:24 +05:30
Diptanil Saha
397d806f0f Merge pull request #53014 from diptanilsaha/tb_ctb 2026-02-27 12:55:13 +05:30
Krishna Shirsath
124ec4d3c2 fix: add missing type hints to whitelisted function arguments 2026-02-27 12:53:44 +05:30
diptanilsaha
61e01aff67 fix(consolidated-trial=balance): total calculation with show_group_accounts and show_net_values filters 2026-02-27 12:26:20 +05:30
diptanilsaha
560c2511cc feat(consolidated-trial-balance): introduced show_net_values filter 2026-02-27 12:24:47 +05:30
diptanilsaha
f582fdbf71 fix(trial-balance): totals with filter show_group_accounts enabled 2026-02-27 12:21:56 +05:30
ruthra kumar
ffa6280431 Merge pull request #53011 from ruthra-kumar/remove_frappe_flags_from_acc_dimension
refactor: use cache decorator in accounting dimensions
2026-02-27 11:48:06 +05:30
ruthra kumar
565542879e refactor: remove frappe.flags and make use of cache decorator 2026-02-27 11:30:52 +05:30
Thomas antony
b33f06701c feat: UOM query filter for opportunity items
Add UOM query filter based on item code in opportunity form.
2026-02-27 11:11:28 +05:30
MochaMind
1811bb7643 fix: Serbian (Latin) translations 2026-02-26 22:23:42 +05:30
MochaMind
94ea72948e fix: Persian translations 2026-02-26 22:23:37 +05:30
MochaMind
cfda569af1 fix: Swedish translations 2026-02-26 22:23:29 +05:30
MochaMind
4b72ac7d22 fix: Spanish translations 2026-02-26 22:23:21 +05:30
khushi8112
235e3adbcb refactor: use query builder for Tax Rule validation query 2026-02-26 17:18:40 +05:30
Diptanil Saha
c57e452efd Merge pull request #52997 from diptanilsaha/pe-correct-precisions 2026-02-26 14:53:50 +05:30
Rohit Waghchaure
4dfbacfd92 fix: same reposting entry picked by multiple rq jobs 2026-02-26 14:34:39 +05:30
diptanilsaha
d82a0a9455 fix(payment_entry): fix precision for total_allocated_amount and base_total_allocated_amount
Co-authored-by: Ahuahuachi <Ahuahuachi@users.noreply.github.com>
2026-02-26 14:33:50 +05:30
ruthra kumar
c2ed02d4e4 Merge pull request #52630 from mendozal/fix-compute-tax-net-amount-in-js
fix(account): compute tax net_amount in JS controller
2026-02-26 13:47:27 +05:30
Luis Mendoza
b10b205394 fix(accounts): round and convert net_amount to company currency in JS tax controller 2026-02-26 08:09:53 +00:00
Luis Mendoza
485166b668 style: prettier formatting 2026-02-26 08:09:53 +00:00
Luis Mendoza
153ad99f85 fix(accounts): compute tax net_amount in JS controller 2026-02-26 08:09:53 +00:00
ruthra kumar
2d07b346de Merge pull request #52970 from ljain112/fix-missing-type-hint
fix: update type hint for party parameter to allow None in get_party_details and set_taxes functions
2026-02-26 13:32:43 +05:30
ruthra kumar
56732df641 Merge pull request #52188 from aerele/payment-entry-float-precision
fix(payment entry): round unallocated amount
2026-02-26 13:07:33 +05:30
Shllokkk
8c46e06e04 fix: correct get linked payments type hint in bank reconcilliation tool (#52982)
fix: correct type hint for bank reconcilliation tool
2026-02-26 12:41:40 +05:30
ravibharathi656
b0d6751777 fix(payment entry): round unallocated amount 2026-02-26 12:25:44 +05:30
rohitwaghchaure
5d46e1a7b1 Merge pull request #52983 from rohitwaghchaure/fixed-asset-broken-link
fix: broken link of docs in asset onboarding
2026-02-26 11:05:43 +05:30
Rohit Waghchaure
1cdf439e38 fix: broekn link of docs in asset onboarding 2026-02-26 10:47:56 +05:30
Mihir Kandoi
4c374e182d Merge pull request #52952 from nishkagosalia/gh-52947 2026-02-25 20:59:15 +05:30
Diptanil Saha
4c7175fad1 Merge pull request #52973 from ljain112/fix-fiscal-year
fix: ensure cache is cleared on fiscal year update and trash
2026-02-25 20:05:23 +05:30
ljain112
39b0e3522a fix: ensure cache is cleared on fiscal year update and trash 2026-02-25 19:27:52 +05:30
ljain112
f220960d91 fix: update type hint for party parameter to allow None in get_party_details and set_taxes functions 2026-02-25 18:01:24 +05:30
rohitwaghchaure
7ef187b1eb Merge pull request #52967 from rohitwaghchaure/patch-for-existing-records
fix: patch to complete onboarding stpes for existing records
2026-02-25 17:59:17 +05:30
Rohit Waghchaure
d90ec49241 fix: patch to complete onboarding stpes for existing records 2026-02-25 17:23:57 +05:30
rohitwaghchaure
2517369270 Merge pull request #52957 from rohitwaghchaure/fixed-parallel-reposting
fix: reposting creation slow for GL entries
2026-02-25 16:03:26 +05:30
Rohit Waghchaure
d9ac198bad fix: reposting creation slow for GL entries 2026-02-25 14:23:38 +05:30
ruthra kumar
cf09f725ca Merge pull request #52910 from Shllokkk/accounts-type-hints
refactor(accounts): add type hints for whitelisted functions
2026-02-25 13:25:31 +05:30
Krishna Shirsath
4f43f655cf feat(employee): Add birthdays and work anniversaries indicator in form ,list view enhancements and new empty state. 2026-02-25 13:21:06 +05:30
Nishka Gosalia
a37ffe6e2a Merge pull request #52948 from nishkagosalia/fix-type-hints 2026-02-25 13:12:13 +05:30
Nishka Gosalia
dd0bcf4dbd fix: type hint in stock 2026-02-25 12:54:10 +05:30
Nishka Gosalia
1d4c835843 fix: customer field made mandatory for sales invoice 2026-02-25 12:43:20 +05:30
Shllokkk
61661a159d fix: correct type hints 2026-02-25 12:30:52 +05:30
Mihir Kandoi
1e297a0e5f Merge pull request #52945 from mihir-kandoi/fix-item-link-formatter 2026-02-25 10:25:38 +05:30
Mihir Kandoi
9ef7f05712 fix: item code shows undefined 2026-02-25 10:19:10 +05:30
Mihir Kandoi
10257bbb6e Merge pull request #52942 from mihir-kandoi/gh52359 2026-02-25 10:12:45 +05:30
Mihir Kandoi
bd9e5e97d7 chore: clearer description for internal transfer at arms length 2026-02-25 09:57:13 +05:30
ruthra kumar
bf8b730259 Merge pull request #52940 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-25 08:49:47 +05:30
MochaMind
cecea63627 fix: Persian translations 2026-02-24 22:28:22 +05:30
MochaMind
d6888a32ae fix: Portuguese, Brazilian translations 2026-02-24 22:28:15 +05:30
MochaMind
1a6a16be5b fix: Swedish translations 2026-02-24 22:28:02 +05:30
MochaMind
dced32088c fix: Spanish translations 2026-02-24 22:27:22 +05:30
Khushi Rawat
bb7fdd59dc Merge pull request #52889 from khushi8112/default-print-format-and-letterhead
feat: default letterhead and print format
2026-02-24 21:21:36 +05:30
Mihir Kandoi
c2a1dbeb67 Merge pull request #52724 from ljain112/fix-subcontracting-ctrl 2026-02-24 20:37:09 +05:30
khushi8112
8a2cb96c2a fix: test cases related to default letterhead change 2026-02-24 19:56:25 +05:30
ruthra kumar
7aa3dbcd86 Merge pull request #51777 from Jatin3128/payment-request-schedules-feat
feat: making payment requests based on payment schedule
2026-02-24 18:38:16 +05:30
khushi8112
570f574758 test: debugging the issue 2026-02-24 18:24:16 +05:30
khushi8112
fbf5529ddd fix: add missing property_type 2026-02-24 18:24:16 +05:30
khushi8112
0ea22f9796 feat: default letterhead and print format 2026-02-24 18:24:16 +05:30
Harsh Patadia
bdcb2c1512 refactor: separate construction of chart related data from get_columns() (#52824)
* fix: avoid hardcoded column slicing for Profit & Loss chart data

* refactor: improve parameter naming and reduce code repetion by using same function get_period_columns()

* refactor: improved parameter naming in get_data() and get_chart_data()
2026-02-24 12:36:47 +00:00
Nishka Gosalia
ddb497acb5 Merge pull request #52834 from nishkagosalia/stock-type-hints 2026-02-24 17:34:04 +05:30
rohitwaghchaure
539d1a4e42 Merge pull request #52930 from rohitwaghchaure/fixed-removed-form-tour-
fix: remove form tour for sales and purchase order
2026-02-24 17:23:33 +05:30
Nishka Gosalia
13995a64b8 refactor(stock): adding type hint for stock module 2026-02-24 17:10:57 +05:30
Rohit Waghchaure
ed7315d78e fix: remove form tour for sales and purchase order 2026-02-24 17:00:02 +05:30
Diptanil Saha
9541cb226d Merge pull request #52029 from ljain112/fix-inclusive-discount 2026-02-24 16:58:12 +05:30
Khushi Rawat
dd910bb4cc Merge pull request #52927 from khushi8112/fix-taxes-and-totals-type-hint
fix: type hint for get_round_off_applicable_accounts
2026-02-24 15:57:47 +05:30
khushi8112
2f3ac06eff fix: type hint for get_round_off_applicable_accounts 2026-02-24 15:36:41 +05:30
Jatin3128
e476dff842 feat(payment request): create payment request as per payment schedules 2026-02-24 07:04:16 +00:00
Jatin3128
60108590b0 feat(payment_request): add option to calculate request amount using payment schedule 2026-02-24 07:04:16 +00:00
Shllokkk
f7ff61be5d refactor(accounts): add type hints for whitelisted functions 2026-02-24 12:30:44 +05:30
rohitwaghchaure
a15e2ecf78 Merge pull request #52839 from rohitwaghchaure/feat-user-onboarding
feat: module onboarding
2026-02-24 12:25:06 +05:30
ruthra kumar
4ba43a538e fix: unhide book_advance_payments_in_separate_party_account check fie… (#52363)
fix: unhide book_advance_payments_in_separate_party_account check field in Payment Entry doctype
2026-02-24 11:51:39 +05:30
Sowmya
d638f3e033 fix(sales-order): update quotation status while cancelling sales order (#52822)
* fix(sales-order): update quotation status while cancelling sales order

* test: validate quotation status

* chore: remove submit
2026-02-24 11:47:48 +05:30
Rohit Waghchaure
792a1a7ab7 feat: module onboarding 2026-02-24 11:45:31 +05:30
rohitwaghchaure
ced0c94e8e fix: sales and purchase modules forms clean-up (#52875) 2026-02-23 23:35:08 +05:30
Rohit Waghchaure
0e356dc2e3 fix: sales and purchase modules forms clean-up 2026-02-23 23:05:05 +05:30
ruthra kumar
99a5886f3a Merge pull request #52896 from aerele/skip-empty-dimensions-exc-gain-loss
fix: skip empty dimension values in exchange gain loss
2026-02-23 21:06:00 +05:30
Mihir Kandoi
e5e164c536 Merge pull request #52905 from frappe/mergify/bp/develop/pr-52544 2026-02-23 20:59:03 +05:30
Mihir Kandoi
bde15cb64b Merge pull request #52417 from Shllokkk/quality-procedure-fix 2026-02-23 20:52:40 +05:30
Imesha Sudasingha
ae3453c84b Merge pull request #52544 from one-highflyer/fix/improve-reserved-serial-no-error-message
fix(stock): improve error message when serial no is reserved via SRE

(cherry picked from commit 71248ff40b)
2026-02-23 15:12:56 +00:00
Mihir Kandoi
a0c8ac524b Merge pull request #52764 from aerele/populate_doctypes_to_be_ignored_table 2026-02-23 20:20:29 +05:30
Diptanil Saha
30e0285ae7 Merge pull request #52891 from diptanilsaha/notifs 2026-02-23 19:37:52 +05:30
Mihir Kandoi
2f635a1021 Merge pull request #52892 from mihir-kandoi/gh52864 2026-02-23 19:06:17 +05:30
Mihir Kandoi
9a253c4f54 Merge pull request #52878 from mihir-kandoi/gh52832 2026-02-23 18:48:45 +05:30
ruthra kumar
68144c5be2 Merge pull request #52812 from aerele/fix-clerance-details
fix: bank account mismatch error on reverse transaction reconciliation
2026-02-23 18:05:55 +05:30
ravibharathi656
7df9d951c6 fix: skip empty dimension values in exchange gain loss 2026-02-23 18:01:10 +05:30
Mihir Kandoi
db00860662 fix: link field displays incorrect value when empty 2026-02-23 17:50:24 +05:30
Mihir Kandoi
a85a0aef52 fix: standalone sales invoice return should not fallback to item master for valuation rate 2026-02-23 17:48:46 +05:30
diptanilsaha
3e87059939 fix: fiscal year notification subject 2026-02-23 17:43:36 +05:30
diptanilsaha
96aa37eff5 fix: material request on receive notification condition 2026-02-23 17:43:08 +05:30
Diptanil Saha
a8b538cc67 Merge pull request #50301 from Abdeali099/fixing-emp-contacts 2026-02-23 17:39:46 +05:30
l0gesh29
60d2f2d304 fix: populate doctypes to be ignored table in validate 2026-02-23 17:20:54 +05:30
Sudharsanan Ashok
8b2a971019 fix(manufacturing): remove delete query of job card & batch and serial no (#52840)
* fix(manufacturing): remove delete query of batch and serial no

* fix(manufacturing): remove delete query of job card

* fix: remove delete function call for work order
2026-02-23 16:58:13 +05:30
Khushi Rawat
9478ccca27 Merge pull request #52861 from khushi8112/print-format-sales-order-purchase-invoice
feat: standard print format for Sales Order and Purchase Invoice
2026-02-23 16:26:48 +05:30
Khushi Rawat
9198bc1b8f Merge pull request #52884 from khushi8112/update-modified-timestamp-in-json
fix: update modified timestamp in json
2026-02-23 16:07:03 +05:30
khushi8112
7b3c10769b fix: update modified timestamp in json 2026-02-23 15:42:57 +05:30
Mihir Kandoi
a2afabab79 Merge pull request #52880 from aerele/fix-support/60562 2026-02-23 15:33:33 +05:30
Khushi Rawat
5e5487faae Merge pull request #52879 from mahsem/typo_recon
fix: typo
2026-02-23 15:23:52 +05:30
mahsem
2b72aab671 fix: typo 2026-02-23 10:34:30 +01:00
Pandiyan37
b7f45e6963 fix(work_order): update returned qty 2026-02-23 15:04:21 +05:30
khushi8112
cbea4493c1 refactor: add translation and fix typo 2026-02-23 14:17:08 +05:30
khushi8112
371efce88a feat: standard print format for Sales Order and Purchase Invoice 2026-02-23 14:17:08 +05:30
Khushi Rawat
f133b96cb4 Merge pull request #52823 from khushi8112/type-hints-for-controllers
refactor: add type hints to controller functions
2026-02-23 14:13:19 +05:30
Mihir Kandoi
853090729a Merge pull request #52871 from mihir-kandoi/gh52856 2026-02-23 13:22:38 +05:30
khushi8112
3677609838 refactor: correct type hint for rm_items 2026-02-23 13:08:26 +05:30
Mihir Kandoi
8e14249335 fix: use stock qty instead of qty when updating transferred qty in WO 2026-02-23 13:02:04 +05:30
khushi8112
e088a596c7 fix: remove unnecessary guest access from get_period_date_ranges 2026-02-23 12:49:46 +05:30
khushi8112
021aa63e24 fix: incorrect type hint 2026-02-23 12:49:46 +05:30
khushi8112
7100d61f3c refactor: add type hints to controller functions 2026-02-23 12:49:46 +05:30
ruthra kumar
3584d2bf23 Merge pull request #52852 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-23 11:01:57 +05:30
Mihir Kandoi
60e96633c4 Merge pull request #52803 from aerele/fix/support-#60342 2026-02-23 07:30:39 +05:30
Sudharsanan11
cfbdfcf515 test(manufacturing): add test to validate the planned qty 2026-02-23 02:32:40 +05:30
Sudharsanan11
d58171987c test(stock): add test to validate company for receipts and expense accounts 2026-02-23 02:16:21 +05:30
Sudharsanan11
d54d0c25a2 fix: set company based expense account 2026-02-23 02:16:21 +05:30
Sudharsanan11
15dfc08a31 fix(stock): validate company for receipt documents and expense accounts 2026-02-23 02:16:16 +05:30
MochaMind
e2682d2690 fix: Esperanto translations 2026-02-22 22:08:55 +05:30
MochaMind
ad511755ec fix: French translations 2026-02-22 22:08:52 +05:30
MochaMind
d790c60a93 fix: Serbian (Latin) translations 2026-02-22 22:08:49 +05:30
MochaMind
f53ea90113 fix: Norwegian Bokmal translations 2026-02-22 22:08:45 +05:30
MochaMind
a4652e0d5f fix: Bosnian translations 2026-02-22 22:08:42 +05:30
MochaMind
da16cc1727 fix: Burmese translations 2026-02-22 22:08:39 +05:30
MochaMind
a8fe1e24b3 fix: Croatian translations 2026-02-22 22:08:36 +05:30
MochaMind
a24efc6e34 fix: Thai translations 2026-02-22 22:08:33 +05:30
MochaMind
61f6daf55e fix: Persian translations 2026-02-22 22:08:30 +05:30
MochaMind
ddc3842eb7 fix: Indonesian translations 2026-02-22 22:08:26 +05:30
MochaMind
ad7a52e2cb fix: Portuguese, Brazilian translations 2026-02-22 22:08:23 +05:30
MochaMind
589f1246cb fix: Vietnamese translations 2026-02-22 22:08:20 +05:30
MochaMind
cbb3bf6f6a fix: Chinese Simplified translations 2026-02-22 22:08:17 +05:30
MochaMind
3ce05fc0dc fix: Turkish translations 2026-02-22 22:08:13 +05:30
MochaMind
7388b051ed fix: Swedish translations 2026-02-22 22:08:10 +05:30
MochaMind
e4c4f1a0c2 fix: Serbian (Cyrillic) translations 2026-02-22 22:08:06 +05:30
MochaMind
d4f2ea3358 fix: Slovenian translations 2026-02-22 22:08:03 +05:30
MochaMind
d490b2a3c6 fix: Russian translations 2026-02-22 22:08:00 +05:30
MochaMind
8915df90ae fix: Portuguese translations 2026-02-22 22:07:57 +05:30
MochaMind
0ac09df5d9 fix: Polish translations 2026-02-22 22:07:53 +05:30
MochaMind
0f0f8bd64b fix: Dutch translations 2026-02-22 22:07:50 +05:30
MochaMind
3eb0d5fd73 fix: Italian translations 2026-02-22 22:07:46 +05:30
MochaMind
6f77a11522 fix: Hungarian translations 2026-02-22 22:07:43 +05:30
MochaMind
3f2603a34d fix: German translations 2026-02-22 22:07:40 +05:30
MochaMind
48fc867b7b fix: Danish translations 2026-02-22 22:07:37 +05:30
MochaMind
4674b5a207 fix: Czech translations 2026-02-22 22:07:34 +05:30
MochaMind
c2b8b8469d fix: Arabic translations 2026-02-22 22:07:31 +05:30
MochaMind
50daec2972 fix: Spanish translations 2026-02-22 22:07:28 +05:30
MochaMind
63defa40cb chore: update POT file (#52857) 2026-02-22 13:33:52 +01:00
MochaMind
f7830fddeb fix: Vietnamese translations 2026-02-21 21:47:16 +05:30
MochaMind
f65d50b7e4 fix: Swedish translations 2026-02-21 21:47:09 +05:30
MochaMind
dcd47223fa fix: Dutch translations 2026-02-21 21:46:52 +05:30
Diptanil Saha
d6531189f9 Merge pull request #52842 from diptanilsaha/ref-fy
refactor: `Fiscal Year` cleanup
2026-02-21 12:39:14 +05:30
Mihir Kandoi
b49adbd74c Merge pull request #52845 from mihir-kandoi/remove-supplier-invoice-date-validdation 2026-02-21 12:24:48 +05:30
diptanilsaha
4c76786ce4 fix(fiscal_year): Fiscal Year auto-generation and notification 2026-02-21 12:17:09 +05:30
Mihir Kandoi
7cff0ba626 fix: remove supplier invoice date/posting date validation 2026-02-21 12:08:37 +05:30
diptanilsaha
94fb7e11b4 fix(fiscal_year_company): made company field mandatory 2026-02-21 02:02:03 +05:30
diptanilsaha
74ac28fc70 refactor: Fiscal Year DocType cleanup 2026-02-21 01:58:45 +05:30
Shllokkk
d0323dea65 fix: add missing logic to update requested qty on cancel of a material request 2026-02-20 20:29:43 +05:30
Shllokkk
519e115eb2 Merge branch 'develop' into so-mr-po 2026-02-20 20:11:44 +05:30
Shllokkk
1a4d7ad937 fix: correct ordered_qty and requested_qty for Sales Order Item through a patch 2026-02-20 20:09:18 +05:30
Shllokkk
c2f19036f3 fix: correct fields being updated on material request and purchase order creation from sales order 2026-02-20 19:58:23 +05:30
Mihir Kandoi
969f01fca3 Merge pull request #52835 from mihir-kandoi/inconsistent-label-name 2026-02-20 16:58:15 +05:30
Mihir Kandoi
d6e1ca0f10 fix: inconsistent label name between parent and child 2026-02-20 16:40:32 +05:30
Mihir Kandoi
32d09acba9 Merge pull request #52825 from mihir-kandoi/gh52746 2026-02-20 14:23:40 +05:30
Mihir Kandoi
59492cf08e Merge pull request #52821 from mihir-kandoi/gh52770 2026-02-20 14:23:16 +05:30
ruthra kumar
9902473321 Merge pull request #52783 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-20 14:22:57 +05:30
Mihir Kandoi
ba96d37c11 fix: update items fetches wrong item code 2026-02-20 14:21:26 +05:30
Mihir Kandoi
1352dc79bb fix: sensible insufficient stock message in pick list 2026-02-20 10:29:07 +05:30
Mihir Kandoi
548cdb55d7 Merge pull request #52814 from Shllokkk/selling-type-hints
refactor(selling): add type hints to whitelisted function parameters
2026-02-19 23:07:49 +05:30
Mihir Kandoi
b2afda0462 Merge pull request #52781 from Shllokkk/buying-type-hints
refactor(buying): add type hints for whitelisted function parameters
2026-02-19 23:05:49 +05:30
Mihir Kandoi
866bca70f9 Merge pull request #52811 from nishkagosalia/gh-52373
fix: permission issue for quotation item during update item
2026-02-19 22:57:49 +05:30
Shllokkk
d3911cd7d8 fix: add missing type hints due to failing test case 2026-02-19 22:08:18 +05:30
Raffael Meyer
387fb1b202 feat: add Bank Transaction as Reference Type to Journal Entry Account (#52760)
* feat: add Bank Transaction as Reference Type to Journal Entry Account

* fix: take care of existing property setters

* fix: cancelling Bank Transactions should still be possible

* fix: handle blank options in patch

* fix: hide Reference Due Date for Bank Transaction
2026-02-19 16:20:12 +00:00
MochaMind
0ef15e6364 fix: Serbian (Latin) translations 2026-02-19 21:32:58 +05:30
MochaMind
6e95eebfa4 fix: Thai translations 2026-02-19 21:32:39 +05:30
MochaMind
a4175553fc fix: Swedish translations 2026-02-19 21:32:04 +05:30
MochaMind
b8d7bb2c08 fix: Serbian (Cyrillic) translations 2026-02-19 21:31:59 +05:30
Shllokkk
2504f0fc0c refactor(selling): add type hints to whitelisted function parameters 2026-02-19 20:39:05 +05:30
Mihir Kandoi
732c98b72f fix: typo 2026-02-19 20:28:33 +05:30
Mihir Kandoi
6342e9a3e2 fix: ignore permissions instead of saving parent 2026-02-19 20:27:54 +05:30
ervishnucs
8fe0bf4ba3 fix: check gl account of an associated bank account in bank transaction 2026-02-19 18:39:54 +05:30
Nishka Gosalia
58b8af0fa8 fix: permission issue for quotation item during update item 2026-02-19 17:16:06 +05:30
Krishna Shirsath
870254b710 refactor(employee): reorganize joining and employee exit tabs at the end. 2026-02-19 17:14:50 +05:30
Krishna Shirsath
6513185cb7 refactor(employee): create user function -removed useless function calls 2026-02-19 17:00:35 +05:30
Krishna Shirsath
57f3048d27 feat(employee): Add automatic user creation feature and related validations. Create User on Import. 2026-02-19 15:51:53 +05:30
diptanilsaha
fa5eae08a0 fix(test_purchase_order): validation to create pi from po with terms
Fixed the test to check for error while creating Purchase Invoice from unsubmitted Purchase Order
2026-02-19 14:44:15 +05:30
Mihir Kandoi
4561e3a389 Merge pull request #52804 from marcramser/patch-6
fix(Purchase Receipt): copy project from first row when adding items
2026-02-19 14:01:39 +05:30
Marc Ramser
21423676c9 fix(Purchase Receipt): copy project from first row when adding items
Adds `items_add` method to copy expense_account, cost_center and project from first row to newly added items, matching Purchase Invoice behavior.
2026-02-19 09:25:38 +01:00
Shllokkk
531112e364 refactor(buying): correct broken test case test_make_purchase_invoice_with_terms 2026-02-19 13:22:33 +05:30
Sudharsanan11
4d40c84a31 fix(manufacturing): update status for work order before calculating planned qty 2026-02-19 12:59:11 +05:30
Mihir Kandoi
fc54565d95 Merge pull request #52792 from mihir-kandoi/gh52782
fix: unable to submit subcontracting order if created from material r…
2026-02-19 11:09:17 +05:30
Mihir Kandoi
37323480dd fix: unable to submit subcontracting order if created from material request 2026-02-19 10:50:26 +05:30
Mihir Kandoi
29bc300282 Merge pull request #52794 from mihir-kandoi/sre-read-only
fix: reservation based on field should be read only in SRE
2026-02-19 10:39:36 +05:30
Mihir Kandoi
21452b4c6e fix: reservation based on field should be read only in SRE 2026-02-19 10:18:26 +05:30
Mihir Kandoi
c98e1454fc Merge pull request #52490 from thomasantony12/patch-1
fix: Add handling for Sales Invoice Item quantity field
2026-02-19 09:42:12 +05:30
Mihir Kandoi
1fc2eddf6f fix: add purchase invoice as well 2026-02-19 04:45:20 +05:30
Mihir Kandoi
024c268fe0 Merge pull request #52712 from mihir-kandoi/gh52710
fix: addresses portal
2026-02-19 04:39:35 +05:30
Shllokkk
85c8296548 fix: add missing type hints 2026-02-18 22:37:25 +05:30
MochaMind
b15716f65a fix: Persian translations 2026-02-18 20:27:11 +05:30
MochaMind
a6f5130db1 fix: Portuguese, Brazilian translations 2026-02-18 20:27:07 +05:30
MochaMind
37b9402214 fix: Swedish translations 2026-02-18 20:27:00 +05:30
ruthra kumar
390294a92b Merge pull request #52780 from ruthra-kumar/journal_entry_form_cleanup
refactor: Journal Entry form cleanup
2026-02-18 18:00:46 +05:30
Shllokkk
a6bb44b421 refactor(buying): add type hints for whitelisted function parameters 2026-02-18 17:50:19 +05:30
Khushi Rawat
d3ebcd85b4 Merge pull request #52776 from khushi8112/type-hint-for-projects-module
refactor(projects): add type hints to functions
2026-02-18 17:33:31 +05:30
ruthra kumar
73d5aa35a1 refactor: Journal Entry form cleanup 2026-02-18 17:26:19 +05:30
khushi8112
39d3f4580e refactor(projects): add type hints to functions 2026-02-18 17:13:39 +05:30
mergify[bot]
40391252d5 Merge branch 'develop' into fixing-emp-contacts 2026-02-18 10:47:34 +00:00
Mihir Kandoi
1f62cecdfd Merge pull request #52628 from aerele/fix/support-#59774
fix(manufacturing): set pick list purpose while creating it from work order
2026-02-18 15:14:50 +05:30
Mihir Kandoi
e5f138d004 Merge pull request #52771 from mihir-kandoi/type-hints-manufacturing 2026-02-18 14:16:57 +05:30
Sudharsanan11
23ccc2a8c5 fix(manufacturing): set pick list purpose while creating it from work order 2026-02-18 14:05:42 +05:30
Mihir Kandoi
fad53f6fe4 refactor(manufacturing): add args type hints to functions 2026-02-18 13:58:44 +05:30
Khushi Rawat
7f9066c05a Merge pull request #52734 from khushi8112/type-hint-for-asset-module
refactor(assets): add type annotations in asset module
2026-02-18 12:59:44 +05:30
khushi8112
eb17284711 fix: args must be wrapped under a ctx 2026-02-18 12:35:29 +05:30
MochaMind
e159fc2779 fix: sync translations from crowdin (#52748)
* fix: Portuguese, Brazilian translations

* fix: Persian translations
2026-02-18 12:30:22 +05:30
ruthra kumar
747595082d Merge pull request #52763 from ruthra-kumar/fix_payment_request_bug
fix: better permissions on make payment request
2026-02-18 12:28:06 +05:30
khushi8112
beffc016da refactor: Optimize asset depreciation schedule retrieval with type hints 2026-02-18 12:22:55 +05:30
Mihir Kandoi
f9ec45eda7 Merge pull request #52762 from mihir-kandoi/type-hints-subcontracting
refactor(subcontracting): add arg type hints to functions
2026-02-18 12:17:24 +05:30
Mihir Kandoi
1bc0b40a2e refactor(subcontracting): add arg type hints to functions 2026-02-18 12:01:24 +05:30
ruthra kumar
f36962fc58 fix: better permissions on make payment request 2026-02-18 11:54:53 +05:30
khushi8112
36dcf8b2a5 fix: type hint in make depreciation entry function 2026-02-18 11:33:12 +05:30
Mihir Kandoi
e317ab1479 fix: addresses portal 2026-02-18 11:15:32 +05:30
Diptanil Saha
ea04f55d12 Merge pull request #52759 from diptanilsaha/utils_ta
refactor(utilities): type annotations for whitelisted methods
2026-02-18 01:56:33 +05:30
diptanilsaha
cac6b65dee refactor(utilities): type annotations for whitelisted methods 2026-02-18 01:39:50 +05:30
Diptanil Saha
c6a292f6a9 fix: user permission on reports (#52709) 2026-02-17 21:56:25 +05:30
Mihir Kandoi
e6825476e7 Merge pull request #52750 from mihir-kandoi/st60110
fix: setup fails to set abbr to departments
2026-02-17 21:24:32 +05:30
Mihir Kandoi
54144f72a5 Merge pull request #52743 from Mutantpenguin/patch-3
bug: fix comparison regarding `None` values
2026-02-17 21:21:25 +05:30
Mihir Kandoi
debe868950 fix: setup fails to set abbr to departments 2026-02-17 21:07:30 +05:30
khushi8112
773cc80ed4 fix: incorrect type hint 2026-02-17 17:51:27 +05:30
Markus Lobedann
3fd5a0f100 fix: bug with comparison regarding None values and empty string
In their default state, the fields can be `None`. When a user enters something and deletes it afterwards, the fields contain an empty string.

This fixes the comparison.
2026-02-17 12:46:30 +01:00
rohitwaghchaure
83f5c03494 Merge pull request #52729 from rohitwaghchaure/feat-negative-batch-report
feat: Negative Batch report
2026-02-17 16:33:28 +05:30
Mihir Kandoi
eb0fa4d26d Merge pull request #52677 from mihir-kandoi/standalone-credit-debit-note
fix: standalone credit/debit notes should not fetch any serial or bat…
2026-02-17 16:09:47 +05:30
Mihir Kandoi
4f4bd98943 Merge pull request #52733 from mihir-kandoi/allow-sequence-id-edit
fix: allow sequence ID edit in BOM if routing is not set
2026-02-17 16:05:33 +05:30
Rohit Waghchaure
34edbed00b feat: Negative Batch report 2026-02-17 16:05:13 +05:30
khushi8112
84773a3a32 refactor(assets): add type annotations in asset module 2026-02-17 15:56:24 +05:30
Mihir Kandoi
08529964b4 fix: allow sequence id edit in BOM if routing is not set 2026-02-17 15:39:52 +05:30
ruthra kumar
2c011bb9ad Merge pull request #52679 from AarDG10/fix-acc-timeline
fix: log changes made to accounts settings
2026-02-17 13:55:24 +05:30
ruthra kumar
ee9ce0dee8 Merge pull request #52648 from Abdeali099/Abdeali/fix-typo
fix: correct typos in marketing campaign custom fields function
2026-02-17 13:41:40 +05:30
Krishna Shirsath
3b521b74ea feat(employee): Create User button and form. 2026-02-17 13:32:09 +05:30
ljain112
1d3d09f48c refactor: use postprocess in mapped_doc to update items in subcontracting controller 2026-02-17 13:16:41 +05:30
ruthra kumar
e8ef6f1afb Merge pull request #52654 from Jarif-Junaeed/develop
fix: resolve POS crash and correct is_return typo in TransactionBase
2026-02-17 13:10:29 +05:30
Mihir Kandoi
a374d0b3e7 Merge pull request #52720 from Shllokkk/pricing-rule-fix
fix: wrong display_depends_on condition for item group and brand chil…
2026-02-17 12:59:22 +05:30
Shllokkk
de2843d9f1 fix: wrong display_depends_on condition for item group and brand child tables 2026-02-17 12:28:15 +05:30
Vishnu Priya Baskaran
ae0be7f6ce Merge pull request #52649 from aerele/fix-sales-funnel-layout
fix: ensure layout has Bootstrap row and column
2026-02-17 12:25:15 +05:30
Mihir Kandoi
7860673855 Merge pull request #52716 from mihir-kandoi/gh52551
fix: do not allow plant floor company and warehouse to be updated
2026-02-17 12:11:53 +05:30
Mihir Kandoi
fd72132743 fix: do not allow plant floor company and warehouse to be updated 2026-02-17 11:54:12 +05:30
Mihir Kandoi
1eb9f5b803 Merge pull request #52713 from mihir-kandoi/st60127
fix: production plan status
2026-02-17 11:23:17 +05:30
Mihir Kandoi
b3e6b304e4 fix: production plan status 2026-02-17 10:43:47 +05:30
Diptanil Saha
c8c54a42e2 Merge pull request #52706 from diptanilsaha/wsb-pp
fix(selling-workspace-sidebar): changed order of pos profile
2026-02-17 00:40:33 +05:30
diptanilsaha
72f4fd08ee fix(selling-workspace-sidebar): changed order of pos profile 2026-02-17 00:23:01 +05:30
rohitwaghchaure
4defb104db Merge pull request #52620 from Shllokkk/production-plan-fix
fix: prevent rows from being added to sub_assembly_items and mr_items
2026-02-17 00:11:31 +05:30
Mihir Kandoi
48cafc8e57 Merge pull request #52626 from aerele/fix/support-#59888
fix(manufacturing): add sales order fields in subassembly child table
2026-02-16 23:41:16 +05:30
rohitwaghchaure
8adf8aed41 Merge pull request #52699 from rohitwaghchaure/fixed-negative-stock-validation-sle
fix: consider sle for negative stock validation
2026-02-16 23:25:52 +05:30
Sudharsanan11
341dc4be7a test(manufacturing): add test to validate the sales order references for sub assembly items 2026-02-16 23:21:35 +05:30
Sudharsanan11
0f2ed28ab7 fix(manufacturing): set sales order references in subassembly child table 2026-02-16 23:21:35 +05:30
Sudharsanan11
c2282eaf08 fix(manufacturing): add sales order fields in subassembly child table 2026-02-16 23:21:35 +05:30
Rohit Waghchaure
38f35acffe fix: consider sle for negative stock validation 2026-02-16 23:02:15 +05:30
Shllokkk
25f979a825 fix: prevent rows from being added to sub_assembly_items and mr_items 2026-02-16 22:33:36 +05:30
rohitwaghchaure
afa14e6cd4 Merge pull request #52678 from mihir-kandoi/sales-purchase-invoice-update-stock-cleanup
chore: do not show stock details if update stock is disabled
2026-02-16 22:31:25 +05:30
Diptanil Saha
802507d321 Merge pull request #52692 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-16 21:16:11 +05:30
rohitwaghchaure
12ff8e6279 Merge pull request #52691 from rohitwaghchaure/fixed-cancel-sabb-for-lcv
fix: cancel SABB if SLE cancelled from LCV
2026-02-16 21:11:38 +05:30
Soham Kulkarni
219cf6bc57 fix(pos_invoice): add correct depends on condition (#52689)
* fix(pos_invoice): add correct depends on condition

* fix: show field in sales order

* refactor: eval condition
2026-02-16 15:36:30 +00:00
MochaMind
a7ec72b25c fix: Esperanto translations 2026-02-16 20:22:05 +05:30
MochaMind
4bd3d4d36c fix: Serbian (Latin) translations 2026-02-16 20:22:01 +05:30
MochaMind
d425270c88 fix: Norwegian Bokmal translations 2026-02-16 20:21:57 +05:30
MochaMind
f8c8c1cc2d fix: Bosnian translations 2026-02-16 20:21:53 +05:30
MochaMind
cc02c411b6 fix: Burmese translations 2026-02-16 20:21:49 +05:30
MochaMind
65dd7d4851 fix: Croatian translations 2026-02-16 20:21:45 +05:30
MochaMind
47b80cbc2b fix: Thai translations 2026-02-16 20:21:39 +05:30
MochaMind
20d2317f61 fix: Persian translations 2026-02-16 20:21:35 +05:30
MochaMind
d2a4b8bfd8 fix: Indonesian translations 2026-02-16 20:21:30 +05:30
MochaMind
2b26d859c3 fix: Portuguese, Brazilian translations 2026-02-16 20:21:26 +05:30
MochaMind
3516cda350 fix: Vietnamese translations 2026-02-16 20:21:22 +05:30
MochaMind
4d51d0d351 fix: Chinese Simplified translations 2026-02-16 20:21:19 +05:30
MochaMind
303b7a117c fix: Turkish translations 2026-02-16 20:21:15 +05:30
MochaMind
83006a3ed1 fix: Swedish translations 2026-02-16 20:21:11 +05:30
MochaMind
b3e9fa2142 fix: Serbian (Cyrillic) translations 2026-02-16 20:21:07 +05:30
MochaMind
45d7a398b6 fix: Slovenian translations 2026-02-16 20:21:01 +05:30
MochaMind
ffb88c30b9 fix: Russian translations 2026-02-16 20:20:58 +05:30
MochaMind
40fd9a8008 fix: Portuguese translations 2026-02-16 20:20:53 +05:30
MochaMind
eb357a2805 fix: Polish translations 2026-02-16 20:20:48 +05:30
MochaMind
fd2cadd431 fix: Dutch translations 2026-02-16 20:20:44 +05:30
MochaMind
e66bbe4eec fix: Italian translations 2026-02-16 20:20:40 +05:30
Rohit Waghchaure
f23a49a25e fix: cancel SABB if SLE cancelled from LCV 2026-02-16 20:20:39 +05:30
MochaMind
1c749c01cd fix: Hungarian translations 2026-02-16 20:20:37 +05:30
MochaMind
f95ff68c10 fix: German translations 2026-02-16 20:20:30 +05:30
MochaMind
5815a92273 fix: Danish translations 2026-02-16 20:20:26 +05:30
MochaMind
bb8d84e65e fix: Czech translations 2026-02-16 20:20:23 +05:30
MochaMind
c28020a1bd fix: Arabic translations 2026-02-16 20:20:19 +05:30
MochaMind
95b0ec70cb fix: Spanish translations 2026-02-16 20:20:15 +05:30
MochaMind
1c0f2e1fba fix: French translations 2026-02-16 20:20:11 +05:30
Khushi Rawat
83338675f9 Merge pull request #52331 from aerele/fix-validate-asset-category-accounts
fix(asset): validate depreciation when category has active depreciable assets
2026-02-16 17:45:18 +05:30
Khushi Rawat
a6f808702f Merge pull request #52688 from khushi8112/toggle-reference-doc
fix: toggle reference doc on asset_type change
2026-02-16 17:38:39 +05:30
khushi8112
8e71060931 fix: toggle reference doc on asset_type change 2026-02-16 17:28:51 +05:30
rohitwaghchaure
659112842e Merge pull request #52681 from rohitwaghchaure/fixed-better-validation-message-for-batch
fix: better validation for negative batch
2026-02-16 15:15:54 +05:30
Rohit Waghchaure
a8636e4f59 fix: better validation for negative batch 2026-02-16 13:06:11 +05:30
AarDG10
45febbabd7 fix: log changes made to accounts settings 2026-02-15 23:18:49 +05:30
Mihir Kandoi
cdc62e7327 chore: do not show serial batch selector if not needed 2026-02-15 21:09:04 +05:30
Mihir Kandoi
4499e974a0 chore: do not show stock details if update stock is disabled 2026-02-15 20:54:44 +05:30
Mihir Kandoi
2017edca88 fix: standalone credit/debit notes should not fetch any serial or batch by default 2026-02-15 20:29:57 +05:30
MochaMind
894771029c chore: update POT file (#52673) 2026-02-15 14:00:17 +01:00
Mihir Kandoi
bdf909e94e Merge pull request #52670 from mihir-kandoi/st59534
fix: total weight does not update when updating items
2026-02-15 14:14:11 +05:30
Mihir Kandoi
63323a2611 fix: total weight does not update when updating items 2026-02-15 13:58:32 +05:30
Mihir Kandoi
36393e447e Merge pull request #52658 from aerele/fix-filter-for-update-items
fix: allow non-stock items while updating items
2026-02-15 12:57:39 +05:30
Diptanil Saha
fe01206a73 Merge pull request #52666 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-15 11:29:26 +05:30
MochaMind
e766bb0cd7 fix: Burmese translations 2026-02-14 19:11:32 +05:30
MochaMind
53e3222935 fix: Persian translations 2026-02-14 19:11:29 +05:30
Jarif Junaeed
47353fbceb fix: resolve POS crash and correct is_return typo in TransactionBase 2026-02-14 14:08:57 +06:00
ruthra kumar
a23c2f2166 Merge pull request #52643 from aerele/quotation-lost-reason-detail
fix: consider table multiselect in delete transaction
2026-02-13 14:07:07 +05:30
ervishnucs
07db5941aa fix: allow non-stock items while updating items 2026-02-13 11:58:54 +05:30
ruthra kumar
dd9e1814b0 Merge pull request #52651 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-13 10:14:33 +05:30
MochaMind
0e262de96f fix: Spanish translations 2026-02-12 19:09:18 +05:30
Abdeali Chharchhoda
6b7fed7f59 fix: correct typos in marketing campaign custom fields function 2026-02-12 15:41:14 +05:30
ruthra kumar
7ba2ed6f3f Merge pull request #52644 from ruthra-kumar/use_query_builder_for_profitability_analysis
refactor: use query builder for profitability analysis
2026-02-12 14:24:04 +05:30
ruthra kumar
5e34325604 refactor: use query builder for profitability analysis 2026-02-12 14:08:27 +05:30
SowmyaArunachalam
9bb60405e7 fix: removed lost reason detail 2026-02-12 13:26:47 +05:30
SowmyaArunachalam
be3d2422a7 fix: consider table multiselect in delete transaction 2026-02-12 13:22:17 +05:30
Navin-S-R
bd9d9c3cc7 fix: validate depreciation accounts exist for all companies with depreciable assets 2026-02-12 13:08:19 +05:30
ruthra kumar
1218c0f518 Merge pull request #52640 from ruthra-kumar/use_query_builder_for_sales_person_commision
refactor: use query builder for sales person commission summary
2026-02-12 12:36:43 +05:30
ruthra kumar
7105e3fb69 refactor: use query builder for sales person commission summary 2026-02-12 12:19:51 +05:30
ruthra kumar
ae985c00e9 Merge pull request #52571 from belee-asp/fix/report-letterhead-hardcode
fix(stock): remove hardcoded letter_head from report
2026-02-12 11:48:58 +05:30
ruthra kumar
803c09a4ae Merge pull request #52619 from aerele/feat-show-formatted-currency-on-preview
feat: show formatted currency symbol on ledger preview
2026-02-12 11:28:21 +05:30
Navin-S-R
1b288682e8 chore: resolve conflicts 2026-02-12 11:13:46 +05:30
Navin-S-R
7d14833856 fix: handle duplicate acctount row for the same company 2026-02-12 11:13:46 +05:30
Navin-S-R
2c6054d51a fix(asset category): validate depreciation accounts when category has active depreciable assets 2026-02-12 11:13:46 +05:30
Navin-S-R
464e1929db fix(asset): validate depreciation accounts for depreciable asset upon creation 2026-02-12 11:13:46 +05:30
ruthra kumar
33d0e9559a Merge pull request #52507 from ruthra-kumar/toggle_for_utm_parameters
refactor: toggle for UTM parameters
2026-02-12 10:55:45 +05:30
ruthra kumar
20af546b26 refactor: better description on toggle 2026-02-12 10:38:50 +05:30
Diptanil Saha
7e99a1f4b0 Merge pull request #52625 from frappe/l10n_develop 2026-02-11 19:15:44 +05:30
MochaMind
2adde497c8 fix: Serbian (Latin) translations 2026-02-11 18:59:56 +05:30
MochaMind
97d6a35edc fix: Serbian (Cyrillic) translations 2026-02-11 18:59:32 +05:30
Navin-S-R
5c8cb1e7ec feat: show formatted currency symbol on ledger preview 2026-02-11 17:29:20 +05:30
ruthra kumar
d1217dfedd Merge pull request #52593 from ljain112/tds-report-columns
refactor: update labels for tax withholding reports columns to improve clarity
2026-02-10 18:12:09 +05:30
ruthra kumar
4ddb3c7a6c Merge pull request #52602 from frappe/l10n_develop2
fix: sync translations from crowdin
2026-02-10 18:11:22 +05:30
ruthra kumar
3ed7627ec3 Merge pull request #52017 from aerele/fix-gross-profit-return-period
fix(gross-profit): handle returns outside the given sale period
2026-02-10 18:10:30 +05:30
MochaMind
1b5d5c5be8 fix: Swedish translations 2026-02-10 17:54:26 +05:30
MochaMind
4946a13d45 fix: Italian translations 2026-02-10 17:54:05 +05:30
ruthra kumar
578783af8e refactor: utm analytics section delivery note 2026-02-10 14:36:55 +05:30
ruthra kumar
223d560b32 refactor: utm section in opportunity 2026-02-10 14:36:55 +05:30
ruthra kumar
71e8941285 refactor: utm analytics section in lead 2026-02-10 14:36:52 +05:30
ruthra kumar
7de0ca164d refactor: utm analytics section in pos profile 2026-02-10 14:24:59 +05:30
ruthra kumar
0bafa347a5 refactor: utm section pos invoice 2026-02-10 14:23:28 +05:30
ljain112
2cfdcc1af4 refactor: update labels for tax withholding reports columns to improve clarity 2026-02-10 12:54:46 +05:30
ruthra kumar
678d261f40 refactor: utm section in sales invoice 2026-02-10 11:59:17 +05:30
ruthra kumar
c00bf7df6a refactor: utm section in sales order 2026-02-10 11:56:32 +05:30
Navin-S-R
047b278791 fix(gross-profit): handle item group filters 2026-02-10 11:47:35 +05:30
ruthra kumar
aaf5f923b0 refactor: hide UTM parameters 2026-02-10 11:40:12 +05:30
Navin-S-R
fdfa7bc963 test: fix test assertions to use index-based totals 2026-02-10 11:29:58 +05:30
Navin-S-R
3ab978ab46 test: validate sales person wise gross profit 2026-02-10 11:29:58 +05:30
Navin-S-R
4da3d43013 test: validate return invoice profit and profit percentage 2026-02-10 11:29:58 +05:30
Navin-S-R
51709f032f fix: handle gross profit and percentage for return invoices 2026-02-10 11:29:58 +05:30
Navin-S-R
67d8223f73 fix(gross-profit): handle returns outside sale period 2026-02-10 11:29:57 +05:30
El-Shafei H.
da07f84e44 fix: Added a missing option to the currency field (#52528) 2026-02-10 02:14:06 +05:30
V Shankar
23a73c9cdb fix(map_current_doc): prevent mutation of query args in get_query (#52202) 2026-02-10 00:16:59 +05:30
Mihir Kandoi
7b197cbe1c Merge pull request #52527 from aerele/fix/support-59242
fix(stock): correct warehouse mapping for material issue
2026-02-09 21:05:56 +05:30
Roxxane
99cd29d88f fix(stock): remove hardcoded letter_head from report
The 'Incorrect Serial and Batch Bundle' report had a hardcoded
letter_head value of 'Test', preventing users from deleting a
Letter Head named 'Test' due to link check.

Standard reports should not reference specific Letter Head names.

Fixes #52569
2026-02-09 22:25:11 +08:00
Akhil Narang
0cf4c2ded5 Merge pull request #52559 from akhilnarang/drop-db-query-usage
refactor: drop usages of db_query
2026-02-09 18:52:04 +05:30
Diptanil Saha
271a982cb4 Merge pull request #52562 from frappe/l10n_develop2
fix: sync translations from crowdin
2026-02-09 17:49:10 +05:30
Pandiyan37
f22b9e297b fix(stock): inward stock for pick list test record 2026-02-09 17:45:50 +05:30
MochaMind
61d0863239 fix: Esperanto translations 2026-02-09 17:30:45 +05:30
MochaMind
803cc7c653 fix: Serbian (Latin) translations 2026-02-09 17:30:37 +05:30
MochaMind
b4341df44c fix: Norwegian Bokmal translations 2026-02-09 17:30:31 +05:30
MochaMind
4a77a8b840 fix: Bosnian translations 2026-02-09 17:30:27 +05:30
MochaMind
680117e97e fix: Burmese translations 2026-02-09 17:30:22 +05:30
MochaMind
4bab80faaa fix: Croatian translations 2026-02-09 17:30:11 +05:30
MochaMind
74a1707e3f fix: Thai translations 2026-02-09 17:30:01 +05:30
MochaMind
f145331ae5 fix: Persian translations 2026-02-09 17:29:57 +05:30
MochaMind
be5df6b2b7 fix: Indonesian translations 2026-02-09 17:29:53 +05:30
MochaMind
14a5ff2b54 fix: Portuguese, Brazilian translations 2026-02-09 17:29:48 +05:30
MochaMind
f585ddea71 fix: Vietnamese translations 2026-02-09 17:29:44 +05:30
MochaMind
958ba61f66 fix: Chinese Simplified translations 2026-02-09 17:29:40 +05:30
MochaMind
f7b18159a6 fix: Turkish translations 2026-02-09 17:29:37 +05:30
MochaMind
ae759481e1 fix: Swedish translations 2026-02-09 17:29:33 +05:30
MochaMind
c2bafcf83b fix: Serbian (Cyrillic) translations 2026-02-09 17:29:28 +05:30
MochaMind
04b5e1b3a0 fix: Slovenian translations 2026-02-09 17:29:24 +05:30
MochaMind
3207a9e642 fix: Russian translations 2026-02-09 17:29:19 +05:30
MochaMind
67e8286a57 fix: Portuguese translations 2026-02-09 17:29:14 +05:30
MochaMind
7c0c41f3de fix: Polish translations 2026-02-09 17:29:09 +05:30
MochaMind
c5da02dbd0 fix: Dutch translations 2026-02-09 17:29:05 +05:30
MochaMind
ee1ae88ecd fix: Italian translations 2026-02-09 17:29:01 +05:30
MochaMind
e7b8c257a3 fix: Hungarian translations 2026-02-09 17:28:57 +05:30
MochaMind
93078bcf0c fix: German translations 2026-02-09 17:28:54 +05:30
MochaMind
566072a17f fix: Danish translations 2026-02-09 17:28:50 +05:30
MochaMind
31191096ad fix: Czech translations 2026-02-09 17:28:46 +05:30
MochaMind
0975222e3a fix: Arabic translations 2026-02-09 17:28:42 +05:30
MochaMind
576279fa92 fix: Spanish translations 2026-02-09 17:28:38 +05:30
MochaMind
21eec60924 fix: French translations 2026-02-09 17:28:34 +05:30
Poojashree T R
e98b68c38f fix: validate asset movement transaction date (#52340)
* fix: validate asset transaction date

* fix: validate asset transaction date

* fix: add translation in validate_transaction_date

* test: test_movement_transaction_date

* fix: to ensure test reliability
2026-02-09 17:20:42 +05:30
Poojashree T R
155f6afb48 fix: set asset status as fully depreciated (#52309)
* fix: set asset status as fully depreciated

* test: test_is_fully_depreciated_asset_status

* fix: remove unused condition
2026-02-09 17:01:40 +05:30
Akhil Narang
1e45195ef9 refactor: drop usages of db_query
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-09 16:53:02 +05:30
rohitwaghchaure
3a2e4ff5e5 Merge pull request #52550 from rohitwaghchaure/feat-allow-negative-stock-for-batch
feat: allow negative stock for the batch item
2026-02-09 16:19:29 +05:30
Mihir Kandoi
b2a0d6559f Merge pull request #52501 from aerele/quotation-ordered-status-regression
fix(quotation): ignore zero ordered_qty
2026-02-09 16:08:22 +05:30
Pratik Badhe
22123dd955 fix: email campaign timeout issue (#51994)
* fix: email campaign timeout issue

* refactor: email campaign backend logic

* refactor: use sendmail instead of manually batching
2026-02-09 16:07:46 +05:30
Rohit Waghchaure
376ab0e346 feat: allow negative stock for the batch item 2026-02-09 15:04:19 +05:30
Pandiyan37
da0322e994 test(stock): add test to check from warehouse for issue type 2026-02-09 13:06:27 +05:30
rohitwaghchaure
479b44c610 Merge pull request #52516 from aerele/fix/support-#59057
fix(stock): ignore pos reserved batches for stock levels
2026-02-09 11:57:43 +05:30
Pandiyan37
a34e8c99cd fix(stock): set source warehouse for issue type 2026-02-09 10:58:50 +05:30
Mihir Kandoi
b8e1758dcf Merge pull request #52538 from mihir-kandoi/revert-gh52220
revert: "fix: allow sales invoice to be renamed"
2026-02-09 10:29:47 +05:30
Mihir Kandoi
2660907ac8 revert: "fix: allow sales invoice to be renamed"
This reverts commit 95fdbe55f9.
2026-02-09 10:13:23 +05:30
rohitwaghchaure
9f8c08fd18 Merge pull request #52534 from rohitwaghchaure/form-cleanup-supplier-form
refactor: supplier form cleanup
2026-02-09 09:36:32 +05:30
Sudharsanan11
47ac67f7a2 test(stock): add test to ignore pos reserved batches for stock levels 2026-02-08 23:28:06 +05:30
Jannat Patel
0cf9915698 fix: sync translations from crowdin (#52449)
* fix: French translations

* fix: Spanish translations

* fix: Arabic translations

* fix: Czech translations

* fix: Danish translations

* fix: German translations

* fix: Hungarian translations

* fix: Italian translations

* fix: Dutch translations

* fix: Polish translations

* fix: Portuguese translations

* fix: Russian translations

* fix: Slovenian translations

* fix: Serbian (Cyrillic) translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Chinese Simplified translations

* fix: Vietnamese translations

* fix: Portuguese, Brazilian translations

* fix: Indonesian translations

* fix: Persian translations

* fix: Thai translations

* fix: Croatian translations

* fix: Burmese translations

* fix: Bosnian translations

* fix: Norwegian Bokmal translations

* fix: Serbian (Latin) translations

* fix: Esperanto translations

* fix: Serbian (Cyrillic) translations

* fix: Swedish translations

* fix: Croatian translations

* fix: Bosnian translations

* fix: Serbian (Latin) translations

* fix: Persian translations

* fix: Italian translations
2026-02-08 17:50:31 +01:00
MochaMind
dd1027f165 chore: update POT file (#52531) 2026-02-08 17:49:49 +01:00
Rohit Waghchaure
bd521d9089 refactor: supplier form cleanup 2026-02-08 20:37:57 +05:30
rohitwaghchaure
ebce5d2635 Merge pull request #52508 from rohitwaghchaure/form-cleanup-stock-manufacturing
refactor: form cleanup for stock and manufacturing doctypes
2026-02-08 20:21:46 +05:30
Sudharsanan11
277ba9cb79 fix(stock): ignore pos reserved batches for stock levels 2026-02-08 10:05:07 +05:30
Mihir Kandoi
86389b46e2 Merge pull request #52497 from aerele/fix/support-#59190
fix: add is_group filter for supplier_group and warehouse fields
2026-02-07 21:40:41 +05:30
Rohit Waghchaure
bf20ecca60 refactor: form cleanup for stock and manufacturing doctypes 2026-02-06 19:27:35 +05:30
ruthra kumar
8c960620cc Merge pull request #52504 from ruthra-kumar/ux_refactor_sales_order
refactor: form cleanup for sales order
2026-02-06 17:27:07 +05:30
Khushi Rawat
7be1c885cd Merge pull request #52393 from khushi8112/form-cleanup-assets
refactor: assets module form cleanup
2026-02-06 17:23:06 +05:30
ruthra kumar
3957df6511 Merge pull request #52495 from ruthra-kumar/ux_refactor_for_quotation
refactor: form cleanup for quotation
2026-02-06 17:13:19 +05:30
Sudharsanan11
a9829f5f7b fix(stock): add is group filter for warehouse fields 2026-02-06 17:05:24 +05:30
ruthra kumar
9db3fa1b65 refactor: form cleanup for quotation
1. use standard names for dimension section
2026-02-06 16:48:11 +05:30
ruthra kumar
93d1716eb5 refactor: form cleanup for sales order 2026-02-06 16:24:53 +05:30
khushi8112
4f59d580c4 chore: linters check 2026-02-06 16:22:44 +05:30
khushi8112
d1b81b96a5 fix: implement coderabbit suggested changes 2026-02-06 16:19:40 +05:30
khushi8112
9f7bfc0e36 refactor: asset repair UI changes 2026-02-06 16:19:40 +05:30
khushi8112
eb7932ed73 refactor: asset capitalization form cleanup 2026-02-06 16:19:40 +05:30
khushi8112
e8e8d233ab fix: test cases fixes related to new select box change 2026-02-06 16:19:40 +05:30
khushi8112
f2f509234b fix: test case 2026-02-06 16:19:40 +05:30
khushi8112
e90a3b5a56 fix(UI): improve asset action buttons group 2026-02-06 16:19:40 +05:30
khushi8112
c36fa5bdb6 fix: patch to migrate checkbox data into select 2026-02-06 16:19:40 +05:30
khushi8112
f7b9221324 refactor: use selectbox instead of checkboxes for asset type 2026-02-06 16:19:40 +05:30
khushi8112
4e7794bfc3 fix(UI): reposition fields for better UX 2026-02-06 16:19:40 +05:30
Mihir Kandoi
71ad323cb6 Merge pull request #52499 from nishkagosalia/fix-test-case 2026-02-06 15:58:48 +05:30
ravibharathi656
32ea37035e fix(quotation): ignore zero ordered_qty 2026-02-06 15:50:01 +05:30
Nishka Gosalia
81dceceb4f fix: test case 2026-02-06 15:42:15 +05:30
rohitwaghchaure
d02a85df50 Merge pull request #52494 from rohitwaghchaure/fixed-remove-lable-currency
fix: remove currency label for rounding adjustment
2026-02-06 13:30:24 +05:30
Rohit Waghchaure
000af2bc96 fix: remove currency label for rounding adjustment 2026-02-06 13:29:23 +05:30
Sudharsanan11
cfdc554a19 fix(buying): add supplier group link filters in field level 2026-02-06 13:12:04 +05:30
Khushi Rawat
6e744bcaa7 Merge pull request #52491 from khushi8112/asset-field-toggle-issue
fix: apply composite asset logic only in draft
2026-02-06 13:04:31 +05:30
khushi8112
ee501e884a fix: apply composite asset logic only in draft 2026-02-06 12:58:42 +05:30
Thomas antony
edfcaee99b fix: Add handling for Sales Invoice Item quantity field
Add handling for Sales Invoice Item quantity field
2026-02-06 12:48:15 +05:30
Mihir Kandoi
31ec3af164 Merge pull request #52219 from nishkagosalia/st-56775
fix: enabling skip delivery option for order type maintenance
2026-02-06 12:09:28 +05:30
Mihir Kandoi
70053fea8e Merge pull request #52000 from nishkagosalia/gh-51010
fix: Added validation for quality inspection in job card
2026-02-06 12:07:41 +05:30
Mihir Kandoi
ac9232d888 Merge pull request #52475 from mihir-kandoi/gh52358-2
fix: do not show update stock flag unneccessarily
2026-02-06 11:57:11 +05:30
Nishka Gosalia
1a22e3cb61 fix: enabling skip delivery option for order type maintenance 2026-02-06 11:53:09 +05:30
Diptanil Saha
57d14f695f refactor: global defaults (#52481)
* fix(global_defaults): set disable rounded total on POS Profiles

* fix: removed re-setting fields on toggle functions

* fix: removed property setter for print_hide
2026-02-06 10:18:07 +05:30
rohitwaghchaure
1415472674 Merge pull request #52476 from rohitwaghchaure/fixed-stock-reservation-for-fg
fix: stock reservation created against job card
2026-02-06 04:34:59 +05:30
Rohit Waghchaure
dca2cfd009 fix: stock reservation created against job card 2026-02-05 22:06:54 +05:30
Mihir Kandoi
5fb5b7b30e fix: do not show update stock flag unneccessarily 2026-02-05 20:45:46 +05:30
rohitwaghchaure
a632d5f313 Merge pull request #52469 from rohitwaghchaure/form-cleanup-master-doctypes
refactor: form cleanup for master doctypes related to stock module
2026-02-05 19:46:18 +05:30
rohitwaghchaure
4136ac26c4 Merge pull request #52467 from rohitwaghchaure/fixed-github-52466
fix: operation status and bom validation
2026-02-05 19:45:39 +05:30
Diptanil Saha
a67b548f44 fix(pos_profile): allow_partial_payment field description (#52470)
fix(pos_profile): allow_partial_payment field description
2026-02-05 13:07:40 +00:00
Nikhil Kothari
ef44528ba5 feat(accounts): expand Journal Entry Template to support dimensions and party (#51621)
* feat(accounts): expand Journal Entry Template to support dimensions and party

* fix: do not update standard row values
2026-02-05 18:24:26 +05:30
Rohit Waghchaure
6c49d5dc7d refactor: form cleanup for master doctypes related to stock module 2026-02-05 18:17:37 +05:30
Rohit Waghchaure
95baf953a8 fix: operation status and bom validation 2026-02-05 18:14:35 +05:30
rohitwaghchaure
c86e316670 Merge pull request #52459 from rohitwaghchaure/fixed-stock-reco-balance-value
fix: stock balance report issue
2026-02-05 14:49:22 +05:30
Rohit Waghchaure
7e584dd84a fix: stock balance report issue 2026-02-05 14:32:48 +05:30
Jatin3128
cb4e6ad825 Merge pull request #52438 from Jatin3128/fix-chart-label
fix(balance sheet): removed the extra labels from the chart
2026-02-05 13:23:55 +05:30
Deepesh Garg
4584893542 Merge pull request #52453 from deepeshgarg007/erpnext_form_cleanups_v1
fix: Currency fields label (Sales Invoice)
2026-02-05 13:10:53 +05:30
Mihir Kandoi
6b0fe32180 Merge pull request #52452 from mihir-kandoi/gh52451
fix: process loss error incorrectly thrown even when semi FG BOM does…
2026-02-05 12:57:22 +05:30
Deepesh Garg
e08fe10f31 fix: Currency fields label 2026-02-05 12:54:48 +05:30
Mihir Kandoi
99ddc36c26 fix: process loss error incorrectly thrown even when semi FG BOM does not have any process loss 2026-02-05 12:42:12 +05:30
Smit Vora
26854d8d42 Merge pull request #52360 from vorasmit/fix-calc-balance
fix: correctly calculate running balances for financial report
2026-02-05 12:23:09 +05:30
Diptanil Saha
1c5e36017c feat(pos): allow warehouse change configuration (#52437) 2026-02-05 12:00:42 +05:30
Mihir Kandoi
611f7d07c2 Merge pull request #52445 from mihir-kandoi/gh52444
fix: item code is tuple with operation id
2026-02-05 11:57:55 +05:30
Mihir Kandoi
481deee4b2 fix: item code is tuple with operation id 2026-02-05 11:42:52 +05:30
Deepesh Garg
116ea657cd Merge pull request #52399 from deepeshgarg007/erpnext_form_cleanups
refactor: Better organizing of the fields in various doctypes
2026-02-05 11:27:39 +05:30
Mihir Kandoi
e9befff0cb Merge pull request #52416 from aerele/fix/inventory-dimension-attribute
fix(stock): update target field attribute
2026-02-05 10:23:31 +05:30
Deepesh Garg
1770d92ea6 Merge branch 'develop' into erpnext_form_cleanups 2026-02-05 09:50:22 +05:30
Jatin3128
a64b5f2c5d fix(balance sheet): removed the extra labels from the chart 2026-02-05 05:02:46 +05:30
Diptanil Saha
812d7de7f7 fix: pos profile form cleanup (#52436) 2026-02-05 04:21:14 +05:30
Pandiyan37
21d0ee8db1 test(stock): testcase for different inventory dimension 2026-02-04 22:33:39 +05:30
Pandiyan37
14818b8311 Merge branch 'develop' of https://github.com/frappe/erpnext into fix/inventory-dimension-attribute 2026-02-04 22:09:09 +05:30
Mihir Kandoi
c9dbd58e7f Merge pull request #52427 from archielister/develop 2026-02-04 20:02:33 +05:30
rohitwaghchaure
e63ff83f24 Merge pull request #52422 from rohitwaghchaure/fixed-not-able-to-complete-jc
fix: not able to complete job card
2026-02-04 18:42:56 +05:30
rohitwaghchaure
d3e269a3d3 Merge pull request #52392 from rohitwaghchaure/form-cleanup-buying
refactor: Cleanup buying module related doctypes
2026-02-04 18:13:00 +05:30
ruthra kumar
b33a805702 Merge pull request #51990 from ruthra-kumar/security_fixes
refactor: use https over http while saving website link
2026-02-04 18:01:55 +05:30
Deepesh Garg
efc4c900f3 chore: linting issues 2026-02-04 17:55:06 +05:30
archielister
e4df0a393a fix for obtaining bom_no 2026-02-04 12:20:43 +00:00
ruthra kumar
a3bd73b9db Merge pull request #52419 from ruthra-kumar/plug_payment_request_vulnerability
fix: enfore permission on make_payment_request
2026-02-04 17:44:27 +05:30
ruthra kumar
8db29b0a81 refactor: patch partner_website for old data 2026-02-04 17:43:31 +05:30
ruthra kumar
8cf31548f2 refactor: scrub http and use https in sales partner 2026-02-04 17:43:29 +05:30
Deepesh Garg
3a91f6793f refactor: Add advance settings 2026-02-04 17:35:27 +05:30
Shllokkk
ced2f33a63 fix: correct link filter for processes child table procedure field 2026-02-04 17:22:19 +05:30
Deepesh Garg
954173d629 refactor: Add advance settings 2026-02-04 17:16:40 +05:30
Rohit Waghchaure
f3ea1863ae refactor: Cleanup buying module forms 2026-02-04 17:07:25 +05:30
Rohit Waghchaure
175fe9279c fix: not able to complete job card 2026-02-04 17:04:13 +05:30
Mihir Kandoi
3b45485351 Merge pull request #51773 from aerele/fix/production-analytics-report 2026-02-04 16:57:23 +05:30
ruthra kumar
b755ca12ca fix: enfore permission on make_payment_request 2026-02-04 16:54:51 +05:30
Deepesh Garg
0687e683f8 refactor: Add advance settings 2026-02-04 16:50:58 +05:30
Pandiyan37
7e08154217 fix(stock): update target field attribute 2026-02-04 15:19:56 +05:30
Deepesh Garg
a734f90920 fix: Add totals and base total section 2026-02-04 12:41:19 +05:30
Sudharsanan11
27091e5168 fix(manufacturing): fix chart period keys 2026-02-04 12:18:03 +05:30
Mihir Kandoi
3f8af9b3c9 Merge pull request #52383 from mihir-kandoi/fix-rate-comparison-3 2026-02-04 12:17:53 +05:30
Mihir Kandoi
e8d1e9d946 fix: return None instead of 0 if valuation rate is falsy 2026-02-04 12:02:14 +05:30
Deepesh Garg
6d64a6a1d1 Merge branch 'develop' of https://github.com/frappe/erpnext into erpnext_form_cleanups 2026-02-04 11:57:05 +05:30
Deepesh Garg
2f2e16fc33 refactor: Better organizing of the fields in various doctypes 2026-02-04 11:18:09 +05:30
Sudharsanan11
16f09141da fix(manufacturing): handle None value for actual_end_date 2026-02-04 11:14:47 +05:30
Diptanil Saha
036f64013d fix: remove customer_pos_id reference (#52396) 2026-02-04 10:47:56 +05:30
Jatin3128
51cfd6119f Merge pull request #51745 from elshafei-developer/fix-translate-report-Gross-Profit
fix(gross profit report): translate column Sales Invoice
2026-02-04 04:43:23 +05:30
ruthra kumar
b719a6c767 fix: group item wise tax details by tax row (#51898) 2026-02-03 21:08:01 +05:30
NaviN
6fde0a6261 fix: merge taxes in purchase receipt when get items from multiple purchase invoices (#51422)
* fix: merge taxes in purchase receipt when get items from multiple purchase invoices

* fix: make merge tax configurable

* chore: follow standard merge taxes method

* chore: follow standard merge taxes method
2026-02-03 21:03:14 +05:30
Mihir Kandoi
671726a3e4 Merge pull request #52259 from aerele/fix/support-#58787 2026-02-03 20:24:43 +05:30
Mihir Kandoi
f1b4fe12a2 fix: rate comparison in stock reco 2026-02-03 20:21:51 +05:30
Mihir Kandoi
4c4d8859f6 Merge pull request #52374 from aerele/fix/fetch-batch-valuation-rate-in-stock-recon 2026-02-03 20:17:12 +05:30
rohitwaghchaure
a3ba0a18c4 Merge pull request #52278 from aerele/feat/add-company-field-bin
feat(stock): add company field to Bin with migration patch
2026-02-03 20:10:44 +05:30
ruthra kumar
2e51e7fb78 Merge pull request #51651 from aerele/ppr-skip-ref-detail
fix: correct exchange gain loss in ppr
2026-02-03 20:05:19 +05:30
ruthra kumar
6387aebed8 Merge pull request #51558 from ili-ad/fix/postgres-customer-autoname
fix(postgres): avoid UNSIGNED cast in customer autoname
2026-02-03 19:48:49 +05:30
ruthra kumar
b478f0da89 Merge pull request #52314 from aerele/fix/journal-entry-exchange-rate-type
fix(journal-entry): normalize exchange rate to float
2026-02-03 19:47:00 +05:30
rohitwaghchaure
6d41e35242 Merge pull request #52375 from frappe/mergify/bp/develop/pr-52369
fix: zero valuation rate if returning from different warehouse (backport #52369)
2026-02-03 19:29:08 +05:30
Rohit Waghchaure
eb2119e292 fix: zero valuation rate if returning from different warehouse
(cherry picked from commit 28929df0e8)
2026-02-03 13:41:15 +00:00
kavin-114
c5df570262 fix(stock): fetch batch wise valuation rate in get_items 2026-02-03 18:36:18 +05:30
Smit Vora
12f8bb2937 test: further tests for query builder 2026-02-03 18:11:34 +05:30
ruthra kumar
7fd6278c18 Merge pull request #52320 from mendozal/fix-sales-tax-template-sidebar-link
fix: correct Sales Tax Template sidebar link to proper DocType
2026-02-03 17:35:14 +05:30
ruthra kumar
c90f77af44 Merge pull request #52279 from aerele/profit-loss-chart-xaxis
fix(profit and loss statement): exclude non period columns
2026-02-03 17:29:18 +05:30
rohitwaghchaure
c29bcbfed8 Merge pull request #52160 from aerele/support-57403
fix(stock): remove is_return condition on pos batch qty calculation
2026-02-03 16:41:09 +05:30
Smit Vora
a29710dc07 test: correct error message 2026-02-03 16:32:26 +05:30
Smit Vora
f45a5a63a7 test: revert original pcv setting 2026-02-03 16:30:05 +05:30
ruthra kumar
82aa32f74e Merge pull request #51997 from aerele/feat/add-partially-billed-status
Add partially billed status indicator
2026-02-03 16:28:24 +05:30
Shllokkk
5793322c30 fix: unhide book_advance_payments_in_separate_party_account check field in Payment Entry doctype 2026-02-03 16:26:35 +05:30
Smit Vora
61d8308e81 test: add tests for query builder 2026-02-03 16:18:27 +05:30
Smit Vora
b41c1858a3 fix: Period Closing Voucher doesn't exist for GL Entry 2026-02-03 16:03:14 +05:30
rohitwaghchaure
4a7d606099 Merge pull request #52338 from rohitwaghchaure/fixed-negative-stock-error-for-purchase-return
fix: negative stock for purchase return
2026-02-03 15:54:39 +05:30
Sudharsanan11
de8f8ef9f4 fix(stock): include subcontracting order qty while calculating the bin qty 2026-02-03 15:37:15 +05:30
Shllokkk
93a4b9d49f Merge pull request #52346 from Shllokkk/ux-fixes
fix: move company field to first position in sales invoice, purchase …
2026-02-03 15:34:33 +05:30
ruthra kumar
9160aeb30e Merge pull request #52339 from sokumon/rename-icons
chore: rename icons
2026-02-03 15:30:20 +05:30
Smit Vora
ee2f8d8ebc fix: correctly calculate running balances for financial report 2026-02-03 15:21:38 +05:30
sokumon
2d312bcfe8 chore: rename icons 2026-02-03 15:21:17 +05:30
ruthra kumar
3ee11307f1 Merge pull request #52345 from ruthra-kumar/ignore_svg
ci: skip svg
2026-02-03 15:19:40 +05:30
Shllokkk
8e9365eb3b fix: move company field to first position in sales invoice, purchase invoice, sales order, purchase order and journal entry 2026-02-03 15:04:39 +05:30
Rohit Waghchaure
77893933a2 fix: negative stock for purchase return 2026-02-03 15:02:59 +05:30
ruthra kumar
e565d2283e ci: skip svg 2026-02-03 14:59:52 +05:30
ruthra kumar
ff2f015d67 Merge pull request #52280 from aerele/fix/support-#57038
fix(stock): ignore packing slip while cancelling the sales invoice
2026-02-03 13:53:51 +05:30
Dharanidharan2813
be0040ddc7 fix(journal-entry): normalize exchange rate to float 2026-02-03 12:51:53 +05:30
kavin-114
12ec997027 test: add unit test case for pos reserved with return qty 2026-02-03 12:43:09 +05:30
Dharanidharan2813
7767000ccf feat(delivery-note): add status indicator when document is partially billed 2026-02-03 12:29:55 +05:30
Praveenkumar26-S
d54259c99c feat(stock): add company field to Bin with migration patch 2026-02-03 11:41:20 +05:30
Nishka Gosalia
46b4cf3add fix: Added validation for quality inspection in job card 2026-02-03 11:38:36 +05:30
ruthra kumar
42f2abf5ae Merge pull request #51655 from aerele/project-gross-margin-credit-note
fix: include credit notes in project gross margin calculation
2026-02-03 11:37:09 +05:30
Mihir Kandoi
dbbeca6308 Merge pull request #52184 from aerele/fix/support-#58126 2026-02-03 09:09:21 +05:30
Luis Mendoza
06a7c85c93 fix: correct Sales Tax Template sidebar link to proper DocType 2026-02-02 20:53:47 +00:00
Dharanidharan S
7a1c4a5ded fix: avoid duplicate taxes and charges rows in payment entry (#52178) 2026-02-03 00:56:02 +05:30
Apriliansyah Idris
6cc802147b fix: duplicate account number (Indonesia COA) (#52080) 2026-02-03 00:22:43 +05:30
Sudharsanan11
4d9412181c test(subcontracting): add test for consumed_qty calculation with similar finished goods 2026-02-02 22:52:30 +05:30
Sudharsanan11
0d372a62a1 fix(subcontracting): include item bom in supplied items grouping key 2026-02-02 22:51:33 +05:30
rohitwaghchaure
62a98a0504 Merge pull request #52303 from rohitwaghchaure/fixed-batch-selector-v16
fix: batch selector not working if Use Legacy (Client side) Reactivity disabled
2026-02-02 22:01:25 +05:30
Mihir Kandoi
135a433018 Merge pull request #52246 from mihir-kandoi/st58765 2026-02-02 15:14:22 +00:00
Mihir Kandoi
af6a1eb189 Merge pull request #52304 from mihir-kandoi/customer-contact-quotation 2026-02-02 20:15:59 +05:30
Mihir Kandoi
a8068b89ed Merge pull request #52281 from aerele/fix/stock-bal-report-opening 2026-02-02 20:06:53 +05:30
Mihir Kandoi
75b2c2c83d fix: populate contact fields when creating quotation from customer 2026-02-02 19:59:53 +05:30
Rohit Waghchaure
d1cba1073f fix: batch selector not working if Use Legacy (Client side) Reactivity disabled 2026-02-02 19:54:27 +05:30
Mihir Kandoi
c176af4fe3 Merge pull request #52286 from mihir-kandoi/reset-incoming-rate 2026-02-02 19:47:04 +05:30
Mihir Kandoi
2d6b43fd54 fix: reset incoming rate in selling controller if there are changes in item 2026-02-02 14:08:27 +05:30
ruthra kumar
20ce96e358 Merge pull request #52200 from Tom-1508/fix-journal-print-date
fix(accounts): correct date in Journal Auditing Voucher print format
2026-02-02 12:51:02 +05:30
Tamal Majumdar
43e2495df8 fix: journal auditing voucher print date to use posting_date 2026-02-02 12:42:38 +05:30
ruthra kumar
0e4c37bb6d Merge pull request #51692 from aerele/fix/payment-reconciliation-spelling
fix: correct spelling of Payment Reconciliation in Accounting
2026-02-02 12:39:33 +05:30
kavin-114
f3eb6c7078 fix(stock): add stock recon opening stock condition 2026-02-02 12:36:09 +05:30
nivithamerlin
35e53d28df fix: correct spelling of Payment Reconciliation in Accounting 2026-02-02 12:24:36 +05:30
ravibharathi656
6180e5eb53 fix(profit and loss statement): exclude non period columns 2026-02-02 12:05:45 +05:30
Sudharsanan11
c58887b44a fix(stock): ignore packing slip while cancelling the sales invoice 2026-02-02 11:59:42 +05:30
Mihir Kandoi
c7fd855092 Merge pull request #52274 from mihir-kandoi/over-order-quotation-test 2026-02-02 10:07:20 +05:30
Mihir Kandoi
53e58f6678 test: over ordering of quotation items 2026-02-02 09:51:09 +05:30
MochaMind
5ea7a91fe1 chore: update POT file (#52265) 2026-02-01 15:07:23 +01:00
Mihir Kandoi
200cefa0a5 Merge pull request #52253 from mihir-kandoi/st58854 2026-01-31 20:03:17 +05:30
Mihir Kandoi
f5d74b4572 Merge pull request #52252 from mihir-kandoi/item-report-view-blank 2026-01-31 19:50:51 +05:30
Mihir Kandoi
d9998a977c fix: make item name editable in RFQ 2026-01-31 19:47:51 +05:30
Mihir Kandoi
b24ae5e9a2 fix: better fix for aac39b2671 2026-01-31 19:42:27 +05:30
rohitwaghchaure
54d96bb761 Merge pull request #52232 from rohitwaghchaure/fixed-validate-repack-stock-entry
fix: validation when more than one FG items in repack stock entry
2026-01-31 12:46:02 +05:30
Rohit Waghchaure
6423ce2fa7 fix: validation when more than one FG items in repack stock entry 2026-01-31 12:30:18 +05:30
Mihir Kandoi
6066fef1c9 Merge pull request #52231 from UmakanthKaspa/fix/report-view-item-code 2026-01-30 22:15:40 +05:30
UmakanthKaspa
b20f57321f fix: item code not showing in report view 2026-01-30 14:13:34 +00:00
Mihir Kandoi
33b6fd408f Merge pull request #52222 from mihir-kandoi/st56549 2026-01-30 19:30:05 +05:30
Mihir Kandoi
36f1e3572c fix: test cases 2026-01-30 19:16:39 +05:30
Mihir Kandoi
4cc306d2d8 fix: validate over ordering of quotation 2026-01-30 18:36:24 +05:30
Mihir Kandoi
3e9a3c1185 Merge pull request #52226 from mihir-kandoi/failing-tests 2026-01-30 17:47:44 +05:30
Mihir Kandoi
d3f44a425c fix: failing test cases 2026-01-30 17:30:50 +05:30
Mihir Kandoi
058be326f0 Merge pull request #51433 from mihir-kandoi/naming-rule-based-on-posting-date 2026-01-30 17:10:50 +05:30
Mihir Kandoi
46b742cd4c Merge pull request #52223 from mihir-kandoi/gh52220 2026-01-30 17:02:10 +05:30
Mihir Kandoi
95fdbe55f9 fix: allow sales invoice to be renamed 2026-01-30 16:46:41 +05:30
Mihir Kandoi
fc8647d1da Merge pull request #52209 from mihir-kandoi/fix-precision-pr 2026-01-30 12:05:16 +05:30
Mihir Kandoi
f82f1da706 Merge pull request #52213 from mihir-kandoi/st58513 2026-01-30 11:58:53 +05:30
Mihir Kandoi
6e17ccf499 fix: hide close button on WO if WO is completed 2026-01-30 11:56:38 +05:30
Mihir Kandoi
40bfd08866 Merge pull request #52210 from mihir-kandoi/gh52189 2026-01-30 11:46:49 +05:30
Mihir Kandoi
89f6f0f46f fix(barcode): failing request when item has both batch and serial 2026-01-30 11:37:21 +05:30
Mihir Kandoi
838d245215 fix: add precision to rejected batch no qty calculation 2026-01-30 10:19:35 +05:30
Dany Robert
b565dd3da8 fix: missing depr_series causing error on jv creation (#52085) 2026-01-29 23:10:04 +05:30
Mihir Kandoi
e1b6ec340c Merge pull request #52201 from mihir-kandoi/gh52199 2026-01-29 21:42:29 +05:30
Mihir Kandoi
c38f884095 fix: hide item_wise_tax_details table from print 2026-01-29 21:25:39 +05:30
rohitwaghchaure
464560a949 Merge pull request #52190 from rohitwaghchaure/fixed-lead-time-calculation-for-fg
fix: lead time calculation for FG item
2026-01-29 17:58:44 +05:30
rohitwaghchaure
f7f2e73f79 Add Landed Cost Voucher Amount in Internal Purchase Receipt (#52158)
* fix(stock): set incoming_rate with lcv rate for internal purchase

* test: add unit test to check internal purchase with lcv
2026-01-29 17:32:13 +05:30
Rohit Waghchaure
646688c291 fix: lead time calculation for FG item 2026-01-29 17:30:22 +05:30
kavin-114
dd4fd89ef8 test: add unit test to check internal purchase with lcv 2026-01-29 16:48:39 +05:30
kavin-114
f0dccc3cd7 fix(stock): set incoming_rate with lcv rate for internal purchase 2026-01-29 16:48:32 +05:30
Mihir Kandoi
91b1df49a4 Merge pull request #52181 from mihir-kandoi/st58663 2026-01-29 15:30:29 +05:30
Mihir Kandoi
7f6f39f5e7 fix: js error if user does not have write permission for date field 2026-01-29 15:28:55 +05:30
Jacob Salvi
cdcf3fa593 refactor: new accounting icons (#52173)
* chore: new icons share-management

* chore: new accounting icons

* chore: trigger CI

---------

Co-authored-by: Soham Kulkarni <77533095+sokumon@users.noreply.github.com>
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
2026-01-29 14:42:47 +05:30
jacob-salvi
728c678cf9 chore: new accounting icons 2026-01-29 11:47:57 +05:30
Diptanil Saha
e11ba21b42 fix(demo): removed toolbar eventlistener (#52171) 2026-01-29 05:57:12 +00:00
Mihir Kandoi
1a4ecba742 Merge pull request #52166 from mihir-kandoi/gh52113 2026-01-29 10:49:53 +05:30
Mihir Kandoi
4e19c7e8bd fix: production plan not considering planning datetime when creating WO 2026-01-29 10:16:06 +05:30
Aarol D'Souza
578b06e027 Merge pull request #52092 from AarDG10/fix-email-render-rfq
fix(RFQ): render email templates for preview and sending
2026-01-29 09:06:51 +05:30
kavin-114
2c19c1fd06 fix(stock): remove is_return condition on pos batch qty calculation 2026-01-29 02:17:20 +05:30
Soham Kulkarni
3d65db2ac3 feat: clear demo data from desktop screen (#52128) 2026-01-28 17:13:22 +05:30
rohitwaghchaure
fabc26bb69 Merge pull request #52007 from aerele/fix/set-zero-rate-for-expired-batch
Fix: Set Zero Rate for Standalone Credit Note with Expired Batch
2026-01-28 16:12:37 +05:30
mahsem
27226b1d82 chore: delete swedish 2024 chart of accounts template (#52032) 2026-01-28 15:09:48 +05:30
Mihir Kandoi
0dc804f9b4 Merge pull request #51961 from aerele/sales-order-project-dimensions 2026-01-27 21:53:39 +05:30
Mihir Kandoi
3192f3f011 Merge pull request #52084 from harrishragavan/fix/shipment-field-validation 2026-01-27 21:26:42 +05:30
harrishragavan
3c6eb9a531 fix(shipment): user contact validation to use full name 2026-01-27 20:52:26 +05:30
Soham Kulkarni
8dae178728 Merge pull request #52119 from sokumon/blue-icons 2026-01-27 20:43:51 +05:30
sokumon
6f9cd8c261 chore: change color of icons in accounting folders 2026-01-27 20:15:00 +05:30
ruthra kumar
d6189b8101 Merge pull request #51894 from ruthra-kumar/refactor_accounting_workspace
refactor: accounting workspace
2026-01-27 18:45:10 +05:30
Nikhil Kothari
48f4a44fb5 feat(accounts): retain filters when switching between financial statements (#51668) 2026-01-27 18:38:37 +05:30
ruthra kumar
f0332c4dc7 refactor: reuse icon for invoicing 2026-01-27 18:30:03 +05:30
NaviN
ec41f1b0f5 fix(asset capitalization): update total_asset_cost on asset capitalisation submission (#52077)
fix(asset capitalization): update total_asset_cost on asset capitalization submission
2026-01-27 18:04:04 +05:30
madelyngamble2
7e9647f3f0 fix: unable to split asset from capitalization (#52020)
* fix: Allow split asset from capitalized composite asset (fixes #52016)

* test: Add test case for splitting asset created via capitalization (fixes #52016)

* docs: Add docstring to before_submit method

* fix: Remove unused variable and fix UTF-8 encoding in asset files

* fix: Remove UTF-8 BOM from asset.py to fix linting

* fix: Fix test_split_asset_created_via_capitalization test parameters

* fix: Remove unused import create_item

* chore: remove unnecessary comments

Removed validation comments for composite asset capitalization in before_submit method.

---------

Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com>
2026-01-27 17:46:58 +05:30
ruthra kumar
fb9656b975 refactor: rename Accounts to Accounting 2026-01-27 17:23:40 +05:30
Mihir Kandoi
1b6fe8498d Merge pull request #52106 from mihir-kandoi/gh34977 2026-01-27 16:27:14 +05:30
Mihir Kandoi
5eeebbde7f test: fix tests 2026-01-27 16:10:44 +05:30
ruthra kumar
f7abf9c1da refactor: link payments dashboard to sidebar 2026-01-27 15:52:57 +05:30
ruthra kumar
99406ccc15 refactor: payments dashboard 2026-01-27 15:52:57 +05:30
ruthra kumar
1295d7aa30 refactor: shed duplicates from invoicing sidebar 2026-01-27 15:52:57 +05:30
ruthra kumar
5a680d5037 refactor: reorder accounts setup sidebar 2026-01-27 15:52:57 +05:30
ruthra kumar
7528d42187 refactor: introduce setup icon and reorder 2026-01-27 15:52:57 +05:30
ruthra kumar
cbdc945287 refactor: payments sidebar and icon 2026-01-27 15:52:57 +05:30
ruthra kumar
faf0dcb102 chore: rename accounting to invoicing 2026-01-27 15:52:57 +05:30
ruthra kumar
5e02b4009e chore: remove accounting icon 2026-01-27 15:52:57 +05:30
ruthra kumar
8125f9035c refactor: invoicing icon 2026-01-27 15:52:57 +05:30
Vishnu Priya Baskaran
efa3973b77 fix: check the payment ledger entry has the dimension (#51823)
* fix: check the payment ledger entry has the dimension

* fix: add project in payment ledger entry
2026-01-27 15:45:33 +05:30
Mihir Kandoi
71371b0ba5 fix: show everything else besides other party specific item 2026-01-27 15:43:58 +05:30
SowmyaArunachalam
543b6e51c0 fix: handle parent level project change 2026-01-27 15:37:14 +05:30
kavin-114
3460a7efb5 test(credit-note): add unit test for zero valuation rate on expired batch 2026-01-27 15:13:46 +05:30
kavin-114
e78c750b4e fix(credit-note): set incoming rate as zero for expired batch 2026-01-27 15:13:34 +05:30
Dharanidharan S
d82c92a237 fix(accounts): correct base grand total and rounded total mismatch (#51739) 2026-01-27 14:08:16 +05:30
Mihir Kandoi
826cf66af8 Merge pull request #52088 from mihir-kandoi/gh51577 2026-01-27 12:19:58 +05:30
Mihir Kandoi
b49c679a50 fix: show message if image is removed from item description 2026-01-27 12:04:49 +05:30
NaviN
5f05714e9d fix(payment entry): update currency symbol (#51956) 2026-01-27 12:01:11 +05:30
AarDG10
37cdae2f34 ci: minor text correction 2026-01-27 11:59:18 +05:30
SowmyaArunachalam
3b27f49d79 chore: use frappe.model.set_value 2026-01-27 11:36:51 +05:30
AarDG10
525b3960e1 fix(RFQ): render email templates for preview and sending 2026-01-27 11:35:50 +05:30
kavin-114
04cdf88715 feat(credit-note): add checkbox to set valuation rate as zero for expired batch 2026-01-27 11:04:36 +05:30
V Shankar
f8f626975f fix(journal-entry): prevent submit failure due to double background queuing (#52083) 2026-01-27 11:00:38 +05:30
rohitwaghchaure
31c536e33f Merge pull request #52062 from rohitwaghchaure/fixed-github-52028
fix: not able to complete the job card
2026-01-26 23:14:20 +05:30
Mihir Kandoi
c1fef8269a Merge pull request #52064 from Shankarv19bcr/customer-auto-name-fix 2026-01-26 15:16:21 +05:30
Shankarv19bcr
e5ba0e6401 fix: strip whitespace in customer_name 2026-01-26 14:37:55 +05:30
Rohit Waghchaure
696ea68f86 fix: not able to complete the job card 2026-01-26 11:35:48 +05:30
MochaMind
71d00f5290 chore: update POT file (#52057) 2026-01-25 20:37:19 +01:00
Henning Wendtland
0fb37ad792 feat(Transaction Deletion Record): Editable "DocTypes To Delete" List with CSV import/export (#50592)
* feat: add editable DocTypes To Delete list with import/export

Add user control over transaction deletion with reviewable and reusable deletion templates.

- New "DocTypes To Delete" table allows users to review and customize what will be deleted before submission
- Import/Export CSV templates for reusability across environments
- Company field rule: only filter by company if field is specifically named "company", otherwise delete all records
- Child tables (istable=1) automatically excluded from selection
- "Remove Zero Counts" helper button to clean up list
- Backward compatible with existing deletion records

* refactor: improve Transaction Deletion Record code quality

- Remove unnecessary chatty comments from AI-generated code
- Add concise docstrings to all new methods
- Remove redundant @frappe.whitelist() decorators from internal methods
- Improve CSV import validation (header check, child table filtering)
- Add better error feedback with consolidated skip messages
- Reorder form fields: To Delete list now appears before Excluded list
- Add conditional visibility for Summary table (legacy records only)
- Improve architectural clarity: single API entry point per feature

Technical improvements:
- export_to_delete_template_method and import_to_delete_template_method
  are now internal helpers without whitelist decorators
- CSV import now validates format and provides detailed skip reasons
- Summary table only shows for submitted records without To Delete list
- Maintains backward compatibility for existing deletion records

* fix: field order

* test: fix broken tests and add new ones

* fix: adapt create_transaction_deletion_request

* test: fix assertRaises trigger

* fix: conditionally execute Transaction Deletion pre-tasks based on selected DocTypes

* refactor: replace boolean task flags with status fields

* fix: remove UI comment

* fix: don't allow virtual doctype selection and improve protected Doctype List

* fix: replace outdated frappe.db.sql by frappe.qb

* feat: add support for multiple company fields

* fix: autofill comapny field, add docstrings, filter for company_field

* fix: add edge case handling for update_naming_series and add tests for prefix extraction

* fix: use redis for running deletion validation, check per doctype instead of company
2026-01-25 14:20:28 +05:30
rohitwaghchaure
88069779b2 Merge pull request #52050 from mahsem/swedish_address_template
fix: swedish_address_template
2026-01-25 10:51:39 +05:30
rohitwaghchaure
c5a4164a6b Merge pull request #52043 from rohitwaghchaure/fixed-uom-not-fetching-in-bom
fix: UOM of item not fetching in BOM
2026-01-25 10:44:28 +05:30
mahsem
334e8ada30 fix: swedish_address_template 2026-01-24 23:41:30 +01:00
Rohit Waghchaure
ba8eadda52 fix: UOM of item not fetching in BOM 2026-01-24 14:15:56 +05:30
Smit Vora
297a2ea259 Merge pull request #51691 from Abdeali099/do-not-warn-filter-missing 2026-01-24 12:37:45 +05:30
Smit Vora
e129e1438e Merge pull request #51670 from Abdeali099/fix-bank-quik-entry-erroe 2026-01-24 12:36:46 +05:30
HALFWARE
e810cd8440 fix: update country_wise_tax.json for Algerian Taxes (#51878)
* Algeria chart of accounts

Algeria chart of accounts

* Update Algeria Chart Of Account

* Algeria chart of account

* Algeria Chart of Account

Algeria Chart of Account

* Modify Algeria tax entries in country_wise_tax.json

Updated tax rates and account names for Algeria.

* Rename account for Algeria tax from VAT to TVA

Rename account for Algeria tax from VAT to TVA
2026-01-24 12:02:39 +05:30
El-Shafei H.
50b3396064 fix: Ensure paid_amount is always numeric before calling allocate_amount_to_references (#50935)
fix: ensure paid_amount is not null in allocate_party_amount_against_ref_docs
2026-01-24 11:47:38 +05:30
Abdeali Chharchhoda
9322095786 refactor: use console.error for error logging in Plaid integration 2026-01-24 11:34:34 +05:30
Abdeali Chharchhoda
8a1b8259bd fix: handle undefined bank_transaction_mapping in quick entry 2026-01-24 11:33:42 +05:30
Abdeali Chharchhoda
d905f78984 refactor: not warn when filter field is missing in FS reports 2026-01-24 11:21:17 +05:30
rohitwaghchaure
7250ee4429 Merge pull request #52024 from rohitwaghchaure/fixed-support-56966
fix: Bin reserved qty for production for extra material transfer
2026-01-23 21:13:20 +05:30
ljain112
2068299766 fix: prevent precision errors in discount distribution with inclusive tax 2026-01-23 20:30:07 +05:30
Rohit Waghchaure
f5378b6573 fix: Bin reserved qty for production for extra material transfer 2026-01-23 19:35:47 +05:30
Diptanil Saha
c4e35f1284 Merge pull request #51976 from diptanilsaha/gh_51348 2026-01-23 16:30:27 +05:30
Mihir Kandoi
6a9c0e22de Merge pull request #51999 from aerele/support/fix-58134 2026-01-23 14:03:26 +05:30
rohitwaghchaure
809b29fe90 Merge pull request #52006 from rohitwaghchaure/fixed-negative-stock-for-purchase-return
fix: negative stock for purchase return
2026-01-23 11:33:25 +05:30
Rohit Waghchaure
d68a04ad16 fix: negative stock for purchae return 2026-01-23 01:19:52 +05:30
rohitwaghchaure
6954811c55 Merge pull request #52003 from rohitwaghchaure/fixed-hide-stock-entry-button
fix: do not show stock entry button if timer is running
2026-01-22 23:56:54 +05:30
rohitwaghchaure
8cdc21c264 Merge pull request #51989 from aerele/fix/autofill-warehouse
fix: autofill warehouse for packed items
2026-01-22 22:57:16 +05:30
Rohit Waghchaure
466668c6b8 fix: do not show stock entry button if timer is running 2026-01-22 22:56:34 +05:30
MochaMind
e7e22c809e fix: sync translations from crowdin (#51913)
* fix: Arabic translations

* fix: Arabic translations

* fix: Arabic translations

* fix: Arabic translations
2026-01-22 13:52:18 +00:00
Bharathidhasan06
2606ca6fa9 fix(stock): use purchase UOM in Supplier Quotation items 2026-01-22 18:07:36 +05:30
diptanilsaha
54acaa2aec fix(payment_reconciliation): retain journal entry accounts child table order 2026-01-22 14:06:56 +05:30
Khushi Rawat
a030ea6fde Merge pull request #51756 from aerele/asset-repair
fix: disable asset repair when status is fully depreciated
2026-01-22 13:59:39 +05:30
Sudharsanan11
3f8a0a4833 fix: autofill warehouse for packed items 2026-01-22 12:54:51 +05:30
Mihir Kandoi
e5d25a7f04 Merge pull request #51908 from ljain112/fix-inward-subcontracting 2026-01-22 10:34:44 +05:30
Mihir Kandoi
40e86b6670 Merge pull request #51929 from ljain112/fix-subcontracting-inward-rm-rate 2026-01-22 10:31:53 +05:30
Mihir Kandoi
d0c9924c37 Merge pull request #51966 from aerele/customer-group-filters 2026-01-22 10:26:22 +05:30
Mihir Kandoi
ede4faa152 Merge pull request #51967 from aerele/project-update-naming-series 2026-01-22 10:22:31 +05:30
Mihir Kandoi
05cf1dcab8 Merge pull request #51968 from mihir-kandoi/gh51965 2026-01-21 22:50:22 +05:30
Mihir Kandoi
43a6dd5657 Merge pull request #51964 from mihir-kandoi/dont-show-dn-btn-if-not-reqd 2026-01-21 22:39:08 +05:30
Mihir Kandoi
343ee9695b fix: rejected qty in PR doesn't consider conversion factor 2026-01-21 22:33:24 +05:30
ravibharathi656
49e64f4e1c fix(project): add missing counter to project update naming series 2026-01-21 19:55:33 +05:30
SowmyaArunachalam
1e3db9f916 fix(customer): add customer group filters 2026-01-21 17:37:37 +05:30
Mihir Kandoi
70ec977cb2 fix: create DN btn should not be shown if it cannot be created 2026-01-21 17:13:35 +05:30
Mihir Kandoi
d6bbe43fa0 Merge pull request #51958 from mihir-kandoi/force-serial-batch-stock-reco 2026-01-21 16:23:18 +05:30
SowmyaArunachalam
9e51701e2a fix(sales order): set project at item level from parent 2026-01-21 16:11:04 +05:30
Mihir Kandoi
035b3cb61e fix: tests 2026-01-21 15:58:46 +05:30
Mihir Kandoi
97c36d1edc Merge pull request #51947 from mihir-kandoi/st57849 2026-01-21 15:46:38 +05:30
Mihir Kandoi
7170a1bd78 fix: force user to enter batch or serial for serial/batch items 2026-01-21 15:30:55 +05:30
Diptanil Saha
936f13eb20 ci: generate pot files for version-16-hotfix (#51954) 2026-01-21 14:37:21 +05:30
Mihir Kandoi
ed51db3217 Merge pull request #51948 from mihir-kandoi/st57735 2026-01-21 13:05:43 +05:30
Mihir Kandoi
5bacb67d36 fix: warehouse permissions in MR incorrectly ignored 2026-01-21 12:50:50 +05:30
Mihir Kandoi
c919b1de38 fix: job cards should not be deleted on close of WO 2026-01-21 11:46:00 +05:30
Mihir Kandoi
46ab5e8e46 Merge pull request #51934 from mihir-kandoi/st57619 2026-01-20 20:46:38 +05:30
Mihir Kandoi
3960c01798 fix: validation message in stock reco row idx 2026-01-20 20:30:10 +05:30
rohitwaghchaure
3c5071cefc Merge pull request #51930 from frappe/revert-51920-fixed-do-reposting-for-lcv
Revert "perf: prevent duplicate reposting for the same item"
2026-01-20 19:48:35 +05:30
rohitwaghchaure
6e4b90055f Revert "perf: prevent duplicate reposting for the same item" 2026-01-20 19:30:42 +05:30
ljain112
37ee560eae fix: calculate weighted average rate for customer provided items in subcontracting inward order 2026-01-20 18:48:59 +05:30
Mihir Kandoi
4b3000b071 Merge pull request #51909 from mihir-kandoi/gh51906 2026-01-20 17:44:23 +05:30
rohitwaghchaure
ad6cb177e3 Merge pull request #51920 from rohitwaghchaure/fixed-do-reposting-for-lcv
perf: prevent duplicate reposting for the same item
2026-01-20 17:38:15 +05:30
ljain112
d256365f4a fix: throw if item order field is not set in subcontracting controller 2026-01-20 17:33:01 +05:30
Diptanil Saha
05fea7f66f Merge pull request #51887 from diptanilsaha/bank_ac 2026-01-20 17:21:51 +05:30
Rohit Waghchaure
7535931571 perf: prevent duplicate reposting for the same item 2026-01-20 17:13:16 +05:30
Mihir Kandoi
27915c9ce2 Merge pull request #51914 from mihir-kandoi/st57262 2026-01-20 16:44:43 +05:30
ruthra kumar
93b131f48a Merge pull request #51671 from nikkothari22/advance-taxes-dimensions
fix(accounts): add missing accounting dimensions in advance taxes and charges
2026-01-20 16:36:16 +05:30
Nikhil Kothari
10d5463a40 Merge branch 'develop' into advance-taxes-dimensions 2026-01-20 16:19:08 +05:30
Mihir Kandoi
017cc9d9f9 fix: continuous raw material consumption with bom validation 2026-01-20 16:18:06 +05:30
Mihir Kandoi
b691de0147 fix: allow creation of DN in SI for items not having DN reference 2026-01-20 15:08:37 +05:30
rohitwaghchaure
beabbb1fa2 Merge pull request #51900 from rohitwaghchaure/fixed-github-49961
fix: validation to check at-least one raw material for manufacture entry
2026-01-20 13:54:48 +05:30
rohitwaghchaure
65c3020d1b Merge pull request #51899 from rohitwaghchaure/fixed-github-51401
feat: option to import serial / batches using csv for outward entry
2026-01-20 13:37:35 +05:30
Rohit Waghchaure
f003b3c378 fix: validation to check at-least one raw material for manufacture entry 2026-01-20 13:36:46 +05:30
Rohit Waghchaure
a268316322 feat: option to import serial / batches using csv for outward entry 2026-01-20 13:10:40 +05:30
Mihir Kandoi
090dabeea5 Merge pull request #51895 from mihir-kandoi/st57390 2026-01-20 13:03:08 +05:30
Mihir Kandoi
edba9efb5e fix: overproduction % not considered when making WO from SO 2026-01-20 12:48:03 +05:30
Diptanil Saha
ad205546c3 fix: collapsible filters on accounts receivable and accounts payables reports (#51798)
Co-authored-by: sokumon <sohamkulkarns9@gmail.com>
2026-01-20 12:44:49 +05:30
ravibharathi656
57bd1facf5 fix: group item wise tax details by tax row 2026-01-20 12:31:30 +05:30
ravibharathi656
a378fee8e0 fix: include credit notes in project gross margin calculation 2026-01-20 08:47:58 +05:30
ruthra kumar
47ee9ce0e2 Merge pull request #51886 from barredterra/translatable-return-msg
fix(accounts_controller): make return message translatable
2026-01-20 07:55:47 +05:30
Lakshit Jain
aea70c5ec1 Merge pull request #51561 from ljain112/fic-adv-ple-po
fix: delete advance ledger entries  while reconciling payment entry
2026-01-20 07:50:27 +05:30
diptanilsaha
7532ab01d6 fix(bank_account): validation for is_company_account 2026-01-20 00:46:46 +05:30
barredterra
0209f0fe29 fix(accounts_controller): make return message translatable 2026-01-19 17:55:50 +01:00
rohitwaghchaure
51fd15e2af Merge pull request #51830 from aerele/fix/work-order-produced-qty
fix(manufacturing): consider process loss qty while validating the work order
2026-01-19 21:46:06 +05:30
Mihir Kandoi
7b5f69bae8 Merge pull request #51880 from mihir-kandoi/gh51873 2026-01-19 20:04:26 +05:30
Mihir Kandoi
11d198fcd6 Merge pull request #51879 from mihir-kandoi/gh51875 2026-01-19 19:59:42 +05:30
Mihir Kandoi
ad11914fca fix: no attribute error on LCV 2026-01-19 19:49:01 +05:30
Mihir Kandoi
fbac8b032e fix: no attribute error on subcontracting receipt 2026-01-19 19:43:31 +05:30
Abdeali Chharchhoda
63d71ff90a Merge branch 'develop' into fixing-emp-contacts 2026-01-19 17:55:55 +05:30
Diptanil Saha
04a2a52639 Merge pull request #51595 from FHenry/dev_fr_chertofaccount_2025 2026-01-19 17:52:47 +05:30
Diptanil Saha
7dc8b74aa1 Merge pull request #51860 from frappe/pot_develop_2026-01-19 2026-01-19 15:42:08 +05:30
rohitwaghchaure
15047235cb Merge pull request #51769 from aerele/pos-set-warehouse-reset
fix(pos): reapply set warehouse during cart update
2026-01-19 15:35:53 +05:30
rohitwaghchaure
020bdfb5bc Merge pull request #51690 from nishkagosalia/gh-49830
feat: Adding Item name in update item dialog box
2026-01-19 15:29:08 +05:30
rohitwaghchaure
3a85c38417 Merge pull request #51856 from rohitwaghchaure/fixed-serial-no-count
fix: qty with serial no count
2026-01-19 15:24:43 +05:30
frappe-pr-bot
60ed4ada10 chore: update POT file 2026-01-19 09:52:35 +00:00
Khushi Rawat
4b27bcd432 Merge pull request #51822 from aerele/check-dimensions
fix(budget variance report): check budget dimensions
2026-01-19 15:22:23 +05:30
Diptanil Saha
a2ae2c1a1a Merge pull request #51819 from earona/patch-1 2026-01-19 15:21:08 +05:30
Rohit Waghchaure
56e58ef301 fix: qty with serial no count 2026-01-19 15:13:08 +05:30
rohitwaghchaure
7102036500 Refactor batch bundle get snos sle (#51644)
* refactor: Batch & Bundle get Stock ledger for snos

* refactor: Batch & Bundle get Stock ledger for snos v2

* refactor: Batch & Bundle get Stock ledger for snos - added posting date in select

* refactor: Batch & Bundle get sle for snos - Added docstring

* chore: fix semantic commit message

---------

Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
2026-01-19 14:52:20 +05:30
Rohit Waghchaure
dfcbee9cc0 chore: fix semantic commit message 2026-01-19 14:22:32 +05:30
krupalvora
22dee50348 refactor: Batch & Bundle get sle for snos - Added docstring 2026-01-19 14:21:19 +05:30
krupalvora
1ccc7365a7 refactor: Batch & Bundle get Stock ledger for snos - added posting date in select 2026-01-19 14:21:18 +05:30
krupalvora
a074d81754 refactor: Batch & Bundle get Stock ledger for snos v2 2026-01-19 14:21:18 +05:30
krupalvora
c0149925ad refactor: Batch & Bundle get Stock ledger for snos 2026-01-19 14:21:17 +05:30
Mihir Kandoi
d8d74236dd Merge pull request #51845 from aerele/bom-company-filter 2026-01-19 14:03:15 +05:30
22-poojashree
73bcfc4710 fix(bom): pass company warehouse filter 2026-01-19 13:30:07 +05:30
mahsem
0c0f43f7f7 fix: common_party_path (#51826)
* fix: common_pary_path

* chore: remove non-existent anchor

---------

Co-authored-by: ruthra kumar <ruthra@erpnext.com>
2026-01-19 07:49:30 +00:00
MochaMind
998f206da1 fix: sync translations from crowdin (#51704)
* fix: Persian translations

* fix: Hungarian translations

* fix: Hungarian translations

* fix: Hungarian translations
2026-01-19 13:01:37 +05:30
ruthra kumar
e7f6125df8 Merge pull request #51513 from aerele/net-profit-calculation
fix: calculate net profit amount from root node accounts
2026-01-19 12:44:14 +05:30
Lakshit Jain
f00aeec9b4 Merge pull request #51787 from ljain112/fix-taxes-disc
fix: recalculate taxes when item tax template changes after discount
2026-01-19 12:30:29 +05:30
Smit Vora
83919119f8 fix: allow disassemble stock entry without work order (#51761)
* fix: allow disassemble stock entry without work order

* fix: use existing functionality to load fg item

* chore: better dict update
2026-01-19 11:36:12 +05:30
ruthra kumar
9a79beda04 Merge pull request #51742 from aerele/item-wise-sales-register
fix: add other charges in total
2026-01-19 11:13:51 +05:30
Sudharsanan11
e6366e830c fix(manufacturing): consider process loss qty while validating the work order 2026-01-19 11:09:21 +05:30
ruthra kumar
218c255543 Merge pull request #51803 from ljain112/unused-imports
chore: remove unused imports
2026-01-19 10:24:44 +05:30
Mihir Kandoi
167e9c5341 Merge pull request #51827 from trustedcomputer/fix-email-digest 2026-01-19 09:58:41 +05:30
Mihir Kandoi
7cbd644782 Merge pull request #51824 from mihir-kandoi/fg-qty-process-loss-fix 2026-01-18 22:50:21 +05:30
trustedcomputer
d2e01e97f0 fix: remove incorrect validation throwing spurious error 2026-01-18 08:32:46 -08:00
Mihir Kandoi
56f5df6847 fix: setting process loss qty causes fg item qty to be incorrect 2026-01-18 20:11:51 +05:30
ervishnucs
cb696a8880 fix(budget variance report): check budget dimensions 2026-01-18 19:32:51 +05:30
Florian HENRY
b3efb3084f chore: re add older template 2026-01-18 10:46:13 +01:00
Florian HENRY
4fe1b214c1 chore: fix bank account type 2026-01-18 10:43:09 +01:00
Mihir Kandoi
96c3fccb05 Merge pull request #51817 from aerele/fix/barcode-uom-fx-in-item 2026-01-18 15:04:59 +05:30
Florian HENRY
6a876de838 chore: fix CASH acount type 2026-01-17 22:05:53 +01:00
Florian HENRY
765487a087 chore: fix bank acount type 2026-01-17 21:17:43 +01:00
Exequiel Arona
d472888bf0 ci: fix generate POT workflow 2026-01-17 17:06:16 -03:00
Florian HENRY
b83640fae7 Merge branch 'develop' of https://github.com/frappe/erpnext into dev_fr_chertofaccount_2025 2026-01-17 20:57:19 +01:00
Florian HENRY
c519cd0268 chore: add Expenses Included In Valuation account 2026-01-17 20:57:08 +01:00
Pandiyan5273
30263b26a5 fix: prevent UOM from updating incorrectly while scanning barcode 2026-01-17 20:28:04 +05:30
Sowmya
3fe5b5c80d fix: change docfield type to render html format (#51795) 2026-01-17 14:55:25 +05:30
ljain112
e8510287e3 chore: remove unused imports 2026-01-17 14:45:57 +05:30
ruthra kumar
310cca6939 Merge pull request #51555 from ili-ad/fix/postgres-company-month-sales
fix(postgres): compute current month sales without DATE_FORMAT
2026-01-16 16:58:22 +05:30
Mihir Kandoi
e51b7155aa Merge pull request #51790 from aerele/fix/support-57170 2026-01-16 16:17:56 +05:30
Mihir Kandoi
96ade0b821 Merge pull request #51791 from mihir-kandoi/item-fields-visibility 2026-01-16 16:00:25 +05:30
Mihir Kandoi
b3db2981de fix: dont show certain fields based on permissions 2026-01-16 15:58:02 +05:30
Mihir Kandoi
0d7b2d812c Merge pull request #51784 from aerele/warehouse-filter 2026-01-16 15:13:56 +05:30
Pandiyan5273
f959b2c59a fix(stock): resolve quantity issue when adding items via barcode scan 2026-01-16 15:12:28 +05:30
Mihir Kandoi
7549f1ba95 Merge pull request #51788 from mihir-kandoi/js-errors 2026-01-16 15:11:53 +05:30
Mihir Kandoi
047343ca11 fix: js error on customer doctype 2026-01-16 15:10:31 +05:30
Mihir Kandoi
e2c3d0fa94 test: add test case 2026-01-16 14:52:49 +05:30
Mihir Kandoi
b8d4522ea1 chore: make feature opt in 2026-01-16 14:00:42 +05:30
Mihir Kandoi
22fd1a1cfd feat: document naming rule will now use posting date of the document 2026-01-16 14:00:42 +05:30
Mihir Kandoi
876c815bd8 Merge pull request #51693 from mihir-kandoi/sample-retention-refactor 2026-01-16 13:53:50 +05:30
Mihir Kandoi
8fd1d6aec8 chore: typo 2026-01-16 13:38:38 +05:30
rohitwaghchaure
589a393b5c fix: opening stock not working for serial / batch (#51781) 2026-01-16 13:15:24 +05:30
Mihir Kandoi
19ae405742 fix: bugs 2026-01-16 13:15:22 +05:30
SowmyaArunachalam
f952b92d71 fix: add company filters for warehouse 2026-01-16 13:15:00 +05:30
Mihir Kandoi
b567184dd7 test: add test case 2026-01-16 12:31:54 +05:30
Jatin3128
c5b0787de6 Merge pull request #51673 from Jatin3128/ar/ap-future-range-fix
fix: add below-0 column in ar/ap report
2026-01-16 12:06:22 +05:30
Mihir Kandoi
3d0f649411 feat: support for serial item 2026-01-16 10:23:11 +05:30
Mihir Kandoi
b54067e04d fix: remove already transferred batch 2026-01-16 10:23:11 +05:30
Mihir Kandoi
8d188cd32b refactor: sample retention stock entry 2026-01-16 10:23:11 +05:30
Diptanil Saha
5ebaee03da Merge pull request #51764 from diptanilsaha/hook_dv 2026-01-15 18:02:06 +05:30
rohitwaghchaure
7ff31a1d91 Merge pull request #51768 from rohitwaghchaure/fixed-stock-and-account-value-comparision-report
fix: Show non-SLE vouchers with GL entries in Stock vs Account Value …
2026-01-15 17:49:24 +05:30
Rohit Waghchaure
1db9ce205f fix: Show non-SLE vouchers with GL entries in Stock vs Account Value Comparison report 2026-01-15 17:04:49 +05:30
ravibharathi656
5a53c45321 fix(pos): reapply set warehouse during cart update 2026-01-15 17:03:16 +05:30
diptanilsaha
050ea96cc6 chore(hooks): develop_version bump 2026-01-15 15:14:27 +05:30
Mihir Kandoi
fb6e0be5fe Merge pull request #51753 from mahsem/docs_path 2026-01-14 21:29:33 +05:30
SowmyaArunachalam
66fe1aa85d fix: disable asset repair when status is fully depreciated 2026-01-14 21:22:10 +05:30
mahsem
7ef8c81caf fix: docs_path 2026-01-14 16:36:22 +01:00
rohitwaghchaure
2f3d4ddc58 Merge pull request #51729 from rohitwaghchaure/fixed-valuation-for-non-batchwise-valuation
fix: valuation rate for non batchwise valuation
2026-01-14 19:35:20 +05:30
Diptanil Saha
257f0c338c Merge pull request #51730 from diptanilsaha/st_56828 2026-01-14 15:51:09 +05:30
SowmyaArunachalam
9406c07c42 fix: add other charges in total 2026-01-14 12:49:30 +05:30
Ankush Menat
1d35e2b261 build: bump required frappe version (#51738) 2026-01-14 11:07:06 +05:30
Mihir Kandoi
0643beb079 Merge pull request #51684 from aerele/test/manufacture-entry-without-wo 2026-01-14 11:03:19 +05:30
Mihir Kandoi
22e0ca2d7e Merge pull request #51295 from aerele/partial-billing-timesheet 2026-01-14 11:02:18 +05:30
Mihir Kandoi
ce7be9fad5 Merge pull request #51733 from mihir-kandoi/gh51731 2026-01-14 10:24:36 +05:30
Mihir Kandoi
6d3f6d73d0 fix: add uom js error 2026-01-14 10:22:59 +05:30
diptanilsaha
8b445e04e5 fix(transaction.js): use flt instead of cint for plc_conversion_rate 2026-01-14 01:36:15 +05:30
Rohit Waghchaure
b6312bca9c fix: valuation rate for non batchwise valuation 2026-01-14 00:02:28 +05:30
Mihir Kandoi
201a04c49a Merge pull request #51725 from mihir-kandoi/ci-patch-test-develop-2 2026-01-13 20:12:13 +05:30
Mihir Kandoi
5e2c7a08d3 revert: make CI not run on .github change 2026-01-13 19:57:11 +05:30
Mihir Kandoi
0da98e6769 ci: patch test for v16 branch 2026-01-13 19:29:39 +05:30
rohitwaghchaure
da87f358c4 Merge pull request #51719 from rohitwaghchaure/fixed-github-51715
fix: stock module not opened when no warehouses
2026-01-13 17:19:33 +05:30
Rohit Waghchaure
9de3b07223 fix: stock module not opened when no warehouses 2026-01-13 17:02:48 +05:30
Khushi Rawat
d3cd887f5e Merge pull request #51666 from aerele/fix-asset-value-adjustment-cancel
fix(asset value adjustment): skip cancelling revaluation journal entry if already cancelled
2026-01-13 12:38:44 +05:30
Navin-S-R
d65cd605a1 fix: move validation to before_cancel 2026-01-13 12:16:52 +05:30
Ankush Menat
6ec41fa47e build: Bump dev version 2026-01-13 12:15:21 +05:30
Khushi Rawat
d879a91165 Merge pull request #51509 from khushi8112/fix-test-cases
fix: use system configured float precision for depreciation rate
2026-01-13 11:58:58 +05:30
Khushi Rawat
d21cfae095 Merge pull request #51363 from aerele/asset-partial-sales
fix(asset): handle partial asset sales by splitting remaining quantity
2026-01-13 11:54:20 +05:30
Mihir Kandoi
be5f2b6cf0 Merge pull request #51650 from mihir-kandoi/v16-prep 2026-01-13 11:06:02 +05:30
ruthra kumar
37b3a22825 Merge pull request #51412 from ljain112/fix-tds-customer
fix(tds): correct tax logic for customer
2026-01-13 11:05:31 +05:30
Mihir Kandoi
bb307dec0a chore: add v14
remove when EOL reached
2026-01-13 11:04:17 +05:30
Nabin Hait
3bc58fb46f fix: Redirect to Desktop after signup (#51696) 2026-01-12 19:20:27 +05:30
Navin-S-R
73b038084b fix: prevent manual cancellation of the linked Revaluation Journal Entry 2026-01-12 18:18:22 +05:30
Nishka Gosalia
e6133ad6d4 feat: Adding Item name in update item dialog box 2026-01-12 17:06:49 +05:30
Navin-S-R
eeb6d0e9bf fix: remove the redundant purchase receipt submit 2026-01-12 16:45:04 +05:30
Navin-S-R
ca97f34092 fix: use new_asset instead of asset_doc when checking values after splitting 2026-01-12 16:36:34 +05:30
Pandiyan5273
784e338be4 test(stock-entry): manufacture entry without work order 2026-01-12 15:52:38 +05:30
jacob-salvi
a1192e34d7 chore: new icons share-management 2026-01-12 15:14:59 +05:30
elshafei-developer
3e39d13172 fix(gross profit report): translate column Sales Invoice 2026-01-12 06:56:13 +00:00
Nikhil Kothari
22e9cb4cf4 fix(accounts): add missing accounting dimensions in advance taxes and charges 2026-01-12 00:42:52 +05:30
Abdeali Chharchhoda
7c7ba0154a refactor: remove redundant onload function for bank mapping table 2026-01-12 00:23:02 +05:30
Navin-S-R
500c44e3f5 fix: ignore permissions when cancelling revaluation journal entry 2026-01-11 21:30:09 +05:30
Navin-S-R
5f00239bba refactor(journal entry): replace raw SQL with query builder to unlink asset value adjustment 2026-01-11 19:25:22 +05:30
Navin-S-R
b1704ccef1 fix(asset value adjustment): skip cancelling revaluation journal entry if already cancelled 2026-01-11 19:20:01 +05:30
l0gesh29
f7004aa8c3 chore: modify error msg 2026-01-11 14:32:15 +05:30
l0gesh29
8379b39aaf fix: add validation for direct return 2026-01-11 13:52:46 +05:30
ravibharathi656
02e96039ac fix: correct exchange gain loss in ppr 2026-01-10 17:25:42 +05:30
Mihir Kandoi
4987b2fe26 ci: ignore ci folder for tests 2026-01-10 17:01:04 +05:30
Mihir Kandoi
7e7e83440f ci: version 16 related changes 2026-01-10 16:43:39 +05:30
l0gesh29
ff9b936634 fix: add validation for return against 2026-01-09 19:08:23 +05:30
Logesh Periyasamy
43d1d685c6 fix: add validation for amount and hours
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-01-09 18:11:42 +05:30
l0gesh29
cda8a97f4a fix: add validation for duplication 2026-01-09 17:43:55 +05:30
Florian HENRY
bf430fce09 feat: remove old French chart of accounts with code as nex 2025 is provided 2026-01-08 13:49:16 +01:00
Florian HENRY
6bdaeb983d chore: Review PR #51595 2026-01-08 13:47:40 +01:00
Florian HENRY
c81dee137f feat: add new 2025 Charts of Accounts for France 2026-01-08 10:59:18 +01:00
Matt Howard
323636b396 fix(postgres): avoid UNSIGNED cast in customer autoname 2026-01-06 15:13:30 -05:00
Matt Howard
64f391adf7 fix(postgres): compute current month sales without DATE_FORMAT 2026-01-06 15:00:25 -05:00
khushi8112
c0a85faa68 test: set up float precision 2026-01-06 23:49:21 +05:30
khushi8112
825e3717ca fix: do not update float precision on setup 2026-01-06 14:41:36 +05:30
khushi8112
007258d657 refactor: modify test cases to handle float precision rounded to 2 decimals 2026-01-06 14:39:31 +05:30
Navin-S-R
c84986d00e fix: calculate net profit amount from root node accounts 2026-01-05 19:09:05 +05:30
khushi8112
8d186d6b3f fix: use correct test class 2026-01-05 16:47:32 +05:30
khushi8112
1296829b9c fix(test): Use the system-configured float precision 2026-01-05 16:44:06 +05:30
ljain112
86b0f67dbc fix(tds): correct tax logic for customer 2025-12-31 14:26:22 +05:30
Navin-S-R
4adeaedfde test: validate asset split for auto created asset from purchase voucher 2025-12-30 16:29:46 +05:30
Navin-S-R
23b094f151 fix(asset): handle same asset being sold in multiple line items in sales invoice 2025-12-30 14:47:28 +05:30
Navin-S-R
e7e6567792 fix(asset): skip purchase document validation while splitting existing asset 2025-12-30 12:09:37 +05:30
Navin-S-R
9eeccb765d test: validate asset partial sales 2025-12-29 22:14:26 +05:30
Navin-S-R
a88fe2ecab fix: refactor older testcases 2025-12-29 15:53:31 +05:30
Navin-S-R
9a2710b9d7 fix(asset): handle partial asset sales by splitting remaining quantity 2025-12-29 15:40:46 +05:30
l0gesh29
50f73a5072 fix: handle return cancellation 2025-12-24 22:09:03 +05:30
l0gesh29
ae594e81f9 test: add test for partial billing and return 2025-12-24 22:08:28 +05:30
l0gesh29
57d34ab146 fix: include total hours validation in depends on 2025-12-24 18:35:48 +05:30
l0gesh29
ff0b37055b feat: add list_view status for partial billing 2025-12-23 20:14:45 +05:30
l0gesh29
c87b5d3132 feat(timesheet): handle partial billing in sales invoice 2025-12-23 20:13:54 +05:30
l0gesh29
38a4642479 feat: modify field properties 2025-12-23 20:10:38 +05:30
Abdeali Chharchhoda
58cdb9503b refactor: method to get employee contact without permission check 2025-12-19 11:39:02 +05:30
Abdeali Chharchhoda
ec1eb6d222 refactor: use common method to get employee contacts 2025-12-18 18:48:09 +05:30
Abdeali Chharchhoda
7b89c12470 fix: get employee email with priority if preferred is not set 2025-12-18 18:41:31 +05:30
Abdeali Chharchhoda
b8e06b9636 refactor: add validation for missing employee parameter 2025-11-02 19:32:34 +05:30
Abdeali Chharchhoda
2ea6508fa5 refactor: fetch employee contact details in realtime 2025-11-01 20:18:52 +05:30
Abdeali Chharchhoda
a41297d841 feat: retrieve employee contact details 2025-11-01 19:18:23 +05:30
Abdeali Chharchhoda
4ad1474e32 feat: retrieve employee basic contact information 2025-11-01 17:55:09 +05:30
Abdeali Chharchhoda
87c59f471c chore: Removing unused import 2025-11-01 17:32:52 +05:30
1089 changed files with 225505 additions and 151784 deletions

View File

@@ -60,7 +60,7 @@ body:
description: Share exact version number of Frappe and ERPNext you are using.
placeholder: |
Frappe version -
ERPNext Verion -
ERPNext version -
validations:
required: true

View File

@@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
branch: ["develop"]
branch: ["develop", "version-16-hotfix"]
permissions:
contents: write
@@ -30,6 +30,11 @@ jobs:
with:
python-version: "3.14"
- name: Setup Node
uses: actions/setup-node@v6
with:
node-version: 24
- name: Run script to update POT file
run: |
bash ${GITHUB_WORKSPACE}/.github/helper/update_pot_file.sh

View File

@@ -8,8 +8,8 @@ permissions:
on:
schedule:
# 9:30 UTC => 3 PM IST Tuesday
- cron: "30 9 * * 2"
# 9:30 UTC => 3 PM IST
- cron: "30 9 * * 1,4"
workflow_dispatch:
jobs:
@@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ["14", "15"]
version: ["15", "16"]
steps:
- uses: octokit/request-action@v2.x

View File

@@ -113,8 +113,8 @@ jobs:
jq 'del(.install_apps)' ~/frappe-bench/sites/test_site/site_config.json > tmp.json
mv tmp.json ~/frappe-bench/sites/test_site/site_config.json
wget https://erpnext.com/files/v13-erpnext.sql.gz
bench --site test_site --force restore ~/frappe-bench/v13-erpnext.sql.gz
wget https://frappe.io/files/erpnext-v14.sql.gz
bench --site test_site --force restore ~/frappe-bench/erpnext-v14.sql.gz
git -C "apps/frappe" remote set-url upstream https://github.com/frappe/frappe.git
git -C "apps/erpnext" remote set-url upstream https://github.com/frappe/erpnext.git
@@ -142,8 +142,8 @@ jobs:
bench --site test_site migrate
}
update_to_version 14 3.11
update_to_version 15 3.13
update_to_version 16 3.14
echo "Updating to latest version"
git -C "apps/frappe" fetch --depth 1 upstream "${GITHUB_BASE_REF:-${GITHUB_REF##*/}}"

View File

@@ -4,8 +4,8 @@ on:
workflow_dispatch:
concurrency:
group: server-individual-tests-develop-${{ github.event_name }}-${{ github.event.number || github.event_name == 'workflow_dispatch' && github.run_id || '' }}
cancel-in-progress: false
group: server-individual-tests-lightmode-develop
cancel-in-progress: true
permissions:
contents: read
@@ -21,7 +21,7 @@ jobs:
- id: set-matrix
run: |
# Use grep and find to get the list of test files
matrix=$(find . -path '*/doctype/*/test_*.py' | xargs grep -l 'def test_' | awk '{
matrix=$(find . -path '*/test_*.py' | xargs grep -l 'def test_' | sort | awk '{
# Remove ./ prefix, file extension, and replace / with .
gsub(/^\.\//, "", $0)
gsub(/\.py$/, "", $0)
@@ -58,6 +58,7 @@ jobs:
strategy:
fail-fast: false
matrix: ${{fromJson(needs.discover.outputs.matrix)}}
max-parallel: 14
name: Test
@@ -130,4 +131,13 @@ jobs:
FRAPPE_BRANCH: ${{ github.event.inputs.branch }}
- name: Run Tests
run: 'cd ~/frappe-bench/ && bench --site test_site run-tests --app erpnext --module ${{ matrix.test }}'
run: |
site_name=$(echo "${{matrix.test}}" | sed -e 's/.*\.\(test_.*$\)/\1/')
echo "$site_name"
mkdir ~/frappe-bench/sites/$site_name
cp -r "${GITHUB_WORKSPACE}/.github/helper/site_config_mariadb.json" ~/frappe-bench/sites/$site_name/site_config.json
cd ~/frappe-bench/
bench --site $site_name reinstall --yes
bench --site $site_name set-config allow_tests true
bench --site $site_name run-tests --module ${{ matrix.test }} --lightmode

View File

@@ -7,6 +7,7 @@ on:
paths:
- "**.js"
- "**.css"
- "**.svg"
- "**.md"
- "**.html"
- 'crowdin.yml'

View File

@@ -129,7 +129,7 @@ jobs:
FRAPPE_BRANCH: ${{ github.event.client_payload.sha || github.event.inputs.branch }}
- name: Run Tests
run: 'cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --app erpnext --total-builds ${{ strategy.job-total }} --build-number ${{ matrix.container }} --with-coverage'
run: 'cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --lightmode --app erpnext --total-builds ${{ strategy.job-total }} --build-number ${{ matrix.container }} --with-coverage'
env:
TYPE: server

View File

@@ -50,13 +50,13 @@ pull_request_rules:
- version-15-hotfix
assignees:
- "{{ author }}"
- name: backport to version-16-beta
- name: backport to version-16-hotfix
conditions:
- label="backport version-16-beta"
- label="backport version-16-hotfix"
actions:
backport:
branches:
- version-16-beta
- version-16-hotfix
assignees:
- "{{ author }}"
- name: Automatic merge on CI success and review

View File

@@ -7,17 +7,17 @@ erpnext/accounts/ @ruthra-kumar
erpnext/assets/ @khushi8112
erpnext/regional @ruthra-kumar
erpnext/selling @ruthra-kumar
erpnext/support/ @ruthra-kumar
erpnext/buying/ @rohitwaghchaure @mihir-kandoi
erpnext/maintenance/ @rohitwaghchaure
erpnext/maintenance/ @rohitwaghchaure @mihir-kandoi
erpnext/manufacturing/ @rohitwaghchaure @mihir-kandoi
erpnext/quality_management/ @rohitwaghchaure
erpnext/quality_management/ @rohitwaghchaure @mihir-kandoi
erpnext/stock/ @rohitwaghchaure @mihir-kandoi
erpnext/subcontracting @mihir-kandoi
erpnext/subcontracting/ @mihir-kandoi
erpnext/projects/ @nishkagosalia
erpnext/controllers/ @ruthra-kumar @rohitwaghchaure @mihir-kandoi
erpnext/patches/ @ruthra-kumar
erpnext/patches/ @ruthra-kumar @rohitwaghchaure @mihir-kandoi
.github/ @ruthra-kumar
.github/ @ruthra-kumar @mihir-kandoi
pyproject.toml @ruthra-kumar

View File

@@ -1,3 +1,4 @@
<div align="center">
<a href="https://frappe.io/erpnext">
<img src="./erpnext/public/images/v16/erpnext.svg" alt="ERPNext Logo" height="80px" width="80xp"/>
@@ -74,25 +75,48 @@ It takes care of installation, setup, upgrades, monitoring, maintenance and supp
</div>
### Self-Hosted
#### Docker
Prerequisites: docker, docker-compose, git. Refer [Docker Documentation](https://docs.docker.com) for more details on Docker setup.
See [Frappe Docker Documentation](https://github.com/frappe/frappe_docker) for full documentation & FAQ on docker setup
Run following commands:
#### Prerequisites
```
- [Docker](https://docs.docker.com/get-docker/)
- [Docker Compose v2](https://docs.docker.com/compose/)
- [git](https://docs.github.com/en/get-started/getting-started-with-git/set-up-git)
> For Docker basics and best practices refer to Docker's [documentation](https://docs.docker.com)
#### Demo setup
The fastest way to try ERPNext is to play in an already set up sandbox, in your browser, click the button below:
<a href="https://labs.play-with-docker.com/?stack=https://raw.githubusercontent.com/frappe/frappe_docker/main/pwd.yml">
<img src="https://raw.githubusercontent.com/play-with-docker/stacks/master/assets/images/button.png" alt="Try in PWD"/>
</a>
### Try on your environment
> **⚠️ Disposable demo only**
>
> **This setup is intended for quick evaluation. Expect to throw the environment away.** You will not be able to install custom apps to this setup. For production deployments, custom configurations, and detailed explanations, see the full documentation.
First clone the repo:
```sh
git clone https://github.com/frappe/frappe_docker
cd frappe_docker
docker compose -f pwd.yml up -d
```
After a couple of minutes, site should be accessible on your localhost port: 8080. Use below default login credentials to access the site.
- Username: Administrator
- Password: admin
Then run:
See [Frappe Docker](https://github.com/frappe/frappe_docker?tab=readme-ov-file#to-run-on-arm64-architecture-follow-this-instructions) for ARM based docker setup.
```sh
docker compose -f pwd.yml up -d
```
Wait for a couple of minutes for ERPNext site to be created or check `create-site` container logs before opening browser on port `8080`. (username: `Administrator`, password: `admin`)
See [Frappe Docker](https://github.com/frappe/frappe_docker/blob/main/docs/01-getting-started/03-arm64.md) for ARM based docker setup
## Development Setup

View File

@@ -1,7 +1,7 @@
# Security Policy
The ERPNext team and community take security issues seriously. To report a security issue, fill out the form at [https://erpnext.com/security/report](https://erpnext.com/security/report).
The ERPNext team and community take security issues seriously. To report a security issue, please go through the information mentioned [here](https://frappe.io/security).
You can help us make ERPNext and all it's users more secure by following the [Reporting guidelines](https://erpnext.com/security).
You can help us make ERPNext and all its users more secure by following the [Reporting guidelines](https://frappe.io/security).
We appreciate your efforts to responsibly disclose your findings. We'll endeavor to respond quickly, and will keep you updated throughout the process.
We appreciate your efforts to responsibly disclose your findings. We'll endeavor to respond quickly, and will keep you updated throughout the process.

View File

@@ -6,7 +6,7 @@ import frappe
from frappe.model.document import Document
from frappe.utils.user import is_website_user
__version__ = "16.0.0-dev"
__version__ = "17.0.0-dev"
def get_default_company(user=None):

View File

@@ -0,0 +1,50 @@
{
"cards": [
{
"card": "Total Outgoing Bills"
},
{
"card": "Total Incoming Bills"
},
{
"card": "Total Incoming Payment"
},
{
"card": "Total Outgoing Payment"
}
],
"charts": [
{
"chart": "Incoming Bills (Purchase Invoice)",
"width": "Half"
},
{
"chart": "Outgoing Bills (Sales Invoice)",
"width": "Half"
},
{
"chart": "Accounts Receivable Ageing",
"width": "Half"
},
{
"chart": "Accounts Payable Ageing",
"width": "Half"
},
{
"chart": "Bank Balance",
"width": "Full"
}
],
"creation": "2026-01-26 21:25:12.793893",
"dashboard_name": "Payments",
"docstatus": 0,
"doctype": "Dashboard",
"idx": 0,
"is_default": 0,
"is_standard": 1,
"modified": "2026-01-26 21:25:12.793893",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Payments",
"owner": "Administrator"
}

View File

@@ -52,7 +52,7 @@ class ERPNextAddress(Address):
@frappe.whitelist()
def get_shipping_address(company, address=None):
def get_shipping_address(company: str, address: str | None = None):
filters = [
["Dynamic Link", "link_doctype", "=", "Company"],
["Dynamic Link", "link_name", "=", company],

View File

@@ -17,6 +17,15 @@ frappe.dashboards.chart_sources["Account Balance Timeline"] = {
fieldtype: "Link",
options: "Account",
reqd: 1,
default: locals[":Company"][frappe.defaults.get_user_default("Company")]["default_bank_account"],
get_query: () => {
return {
filters: {
account_type: "Bank",
is_group: 0,
},
};
},
},
],
};

View File

@@ -4,7 +4,7 @@
import frappe
from frappe import _
from frappe.utils import add_to_date, formatdate, get_link_to_form, getdate, nowdate
from frappe.utils import add_to_date, formatdate, getdate, nowdate
from frappe.utils.dashboard import cache_source
from frappe.utils.dateutils import get_from_date_from_timespan, get_period_ending
from frappe.utils.nestedset import get_descendants_of
@@ -13,15 +13,15 @@ from frappe.utils.nestedset import get_descendants_of
@frappe.whitelist()
@cache_source
def get(
chart_name=None,
chart=None,
no_cache=None,
filters=None,
from_date=None,
to_date=None,
timespan=None,
time_interval=None,
heatmap_year=None,
chart_name: str | None = None,
chart: str | dict | None = None,
no_cache: bool | None = None,
filters: str | dict | None = None,
from_date: str | None = None,
to_date: str | None = None,
timespan: str | None = None,
time_interval: str | None = None,
heatmap_year: str | None = None,
):
if chart_name:
chart = frappe.get_doc("Dashboard Chart", chart_name)
@@ -37,21 +37,14 @@ def get(
filters = frappe.parse_json(filters) or frappe.parse_json(chart.filters_json)
account = filters.get("account")
filters.get("company")
company = filters.get("company")
if not account and chart_name:
frappe.throw(
_("Account is not set for the dashboard chart {0}").format(
get_link_to_form("Dashboard Chart", chart_name)
)
)
if not frappe.db.exists("Account", account) and chart_name:
frappe.throw(
_("Account {0} does not exists in the dashboard chart {1}").format(
account, get_link_to_form("Dashboard Chart", chart_name)
)
)
if not company and not account:
frappe.throw(_("Company and account filters not set!"))
if not company:
frappe.throw(_("Company filter not set!"))
if not account:
frappe.throw(_("Account filter not set!"))
if not to_date:
to_date = nowdate()

View File

@@ -7,7 +7,6 @@ from frappe.utils import (
cint,
date_diff,
flt,
formatdate,
get_first_day,
get_last_day,
get_link_to_form,
@@ -524,7 +523,8 @@ def make_gl_entries(
if gl_entries:
try:
make_gl_entries(gl_entries, cancel=(doc.docstatus == 2), merge_entries=True)
frappe.db.commit()
if not frappe.in_test:
frappe.db.commit()
except Exception as e:
if frappe.in_test:
doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
@@ -606,7 +606,8 @@ def book_revenue_via_journal_entry(
if submit:
journal_entry.submit()
frappe.db.commit()
if not frappe.in_test:
frappe.db.commit()
except Exception:
frappe.db.rollback()
doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")

View File

@@ -471,7 +471,7 @@ class Account(NestedSet):
@frappe.whitelist()
@frappe.validate_and_sanitize_search_inputs
def get_parent_account(doctype, txt, searchfield, start, page_len, filters):
def get_parent_account(doctype: str, txt: str, searchfield: str, start: int, page_len: int, filters: dict):
return frappe.db.sql(
"""select name from tabAccount
where is_group = 1 and docstatus != 2 and company = {}
@@ -515,7 +515,9 @@ def get_account_autoname(account_number, account_name, company):
@frappe.whitelist()
def update_account_number(name, account_name, account_number=None, from_descendant=False):
def update_account_number(
name: str, account_name: str, account_number: str | None = None, from_descendant: bool = False
):
_ensure_idle_system()
account = frappe.get_cached_doc("Account", name)
if not account:
@@ -577,7 +579,7 @@ def update_account_number(name, account_name, account_number=None, from_descenda
@frappe.whitelist()
def merge_account(old, new):
def merge_account(old: str, new: str):
_ensure_idle_system()
# Validate properties before merging
new_account = frappe.get_cached_doc("Account", new)
@@ -614,7 +616,7 @@ def merge_account(old, new):
@frappe.whitelist()
def get_root_company(company):
def get_root_company(company: str):
# return the topmost company in the hierarchy
ancestors = get_ancestors_of("Company", company, "lft asc")
return [ancestors[0]] if ancestors else []

View File

@@ -52,60 +52,55 @@ frappe.treeview_settings["Account"] = {
],
root_label: "Accounts",
get_tree_nodes: "erpnext.accounts.utils.get_children",
on_get_node: function (nodes, deep = false) {
if (frappe.boot.user.can_read.indexOf("GL Entry") == -1) return;
on_node_render: function (node, deep) {
const render_balances = () => {
for (let account of cur_tree.account_balance_data) {
const node = cur_tree.nodes && cur_tree.nodes[account.value];
if (!node || node.is_root) continue;
let accounts = [];
if (deep) {
// in case of `get_all_nodes`
accounts = nodes.reduce((acc, node) => [...acc, ...node.data], []);
} else {
accounts = nodes;
}
// show Dr if positive since balance is calculated as debit - credit else show Cr
const balance = account.balance_in_account_currency || account.balance;
const dr_or_cr = balance > 0 ? __("Dr") : __("Cr");
const format = (value, currency) => format_currency(Math.abs(value), currency);
frappe.db.get_single_value("Accounts Settings", "show_balance_in_coa").then((value) => {
if (value) {
const get_balances = frappe.call({
method: "erpnext.accounts.utils.get_account_balances",
args: {
accounts: accounts,
company: cur_tree.args.company,
include_default_fb_balances: true,
},
});
get_balances.then((r) => {
if (!r.message || r.message.length == 0) return;
for (let account of r.message) {
const node = cur_tree.nodes && cur_tree.nodes[account.value];
if (!node || node.is_root) continue;
// show Dr if positive since balance is calculated as debit - credit else show Cr
const balance = account.balance_in_account_currency || account.balance;
const dr_or_cr = balance > 0 ? __("Dr") : __("Cr");
const format = (value, currency) => format_currency(Math.abs(value), currency);
if (account.balance !== undefined) {
node.parent && node.parent.find(".balance-area").remove();
$(
'<span class="balance-area pull-right">' +
(account.balance_in_account_currency
? format(
account.balance_in_account_currency,
account.account_currency
) + " / "
: "") +
format(account.balance, account.company_currency) +
" " +
dr_or_cr +
"</span>"
).insertBefore(node.$ul);
}
}
});
if (account.balance !== undefined) {
node.parent && node.parent.find(".balance-area").remove();
$(
'<span class="balance-area pull-right">' +
(account.account_currency != account.company_currency
? format(account.balance_in_account_currency, account.account_currency) +
" / "
: "") +
format(account.balance, account.company_currency) +
" " +
dr_or_cr +
"</span>"
).insertBefore(node.$ul);
}
}
});
};
if (frappe.boot.user.can_read.indexOf("GL Entry") == -1) return;
if (!cur_tree.account_balance_data) {
frappe.db.get_single_value("Accounts Settings", "show_balance_in_coa").then((value) => {
if (value) {
frappe.call({
method: "erpnext.accounts.utils.get_account_balances_coa",
args: {
company: cur_tree.args.company,
include_default_fb_balances: true,
},
callback: function (r) {
if (!r.message || r.message.length === 0) return;
cur_tree.account_balance_data = r.message || [];
render_balances();
},
});
}
});
} else {
render_balances();
}
},
add_tree_node: "erpnext.accounts.utils.add_ac",
menu_items: [

View File

@@ -99,7 +99,7 @@ def identify_is_group(child):
@frappe.whitelist()
def get_chart(chart_template, existing_company=None):
def get_chart(chart_template: str | None, existing_company: str | None = None):
chart = {}
if existing_company:
return get_account_tree_from_existing_company(existing_company)
@@ -132,7 +132,7 @@ def get_chart(chart_template, existing_company=None):
@frappe.whitelist()
def get_charts_for_country(country, with_standard=False):
def get_charts_for_country(country: str, with_standard: bool = False):
charts = []
def _get_chart_name(content):
@@ -225,7 +225,7 @@ def build_account_tree(tree, parent, all_accounts):
@frappe.whitelist()
def validate_bank_account(coa, bank_account):
def validate_bank_account(coa: str, bank_account: str):
accounts = []
chart = get_chart(coa)
@@ -244,7 +244,9 @@ def validate_bank_account(coa, bank_account):
@frappe.whitelist()
def build_tree_from_json(chart_template, chart_data=None, from_coa_importer=False):
def build_tree_from_json(
chart_template: str, chart_data: dict | None = None, from_coa_importer: bool = False
):
"""get chart template from its folder and parse the json to be rendered as tree"""
chart = chart_data or get_chart(chart_template)

View File

@@ -33,6 +33,17 @@
},
"account_number": "1151.000"
},
"Pajak Dibayar di Muka": {
"PPN Masukan": {
"account_number": "1152.001",
"account_type": "Tax"
},
"PPh 23 Dibayar di Muka": {
"account_number": "1152.002",
"account_type": "Tax"
},
"account_number": "1152.000"
},
"account_number": "1150.000"
},
"Kas": {
@@ -97,17 +108,6 @@
},
"account_number": "1130.000"
},
"Pajak Dibayar di Muka": {
"PPN Masukan": {
"account_number": "1151.001",
"account_type": "Tax"
},
"PPh 23 Dibayar di Muka": {
"account_number": "1152.001",
"account_type": "Tax"
},
"account_number": "1150.000"
},
"account_number": "1100.000"
},

View File

@@ -6,64 +6,83 @@
"Current Assets": {
"Accounts Receivable": {
"Debtors": {
"account_type": "Receivable"
"account_type": "Receivable",
"account_category": "Trade Receivables"
}
},
"Bank Accounts": {
"account_type": "Bank",
"is_group": 1
"is_group": 1,
"account_category": "Cash and Cash Equivalents"
},
"Cash In Hand": {
"Cash": {
"account_type": "Cash"
"account_type": "Cash",
"account_category": "Cash and Cash Equivalents"
},
"account_type": "Cash"
"account_type": "Cash",
"account_category": "Cash and Cash Equivalents"
},
"Loans and Advances (Assets)": {
"is_group": 1
"is_group": 1,
"account_category": "Other Receivables"
},
"Securities and Deposits": {
"Earnest Money": {}
"Earnest Money": {
"account_category": "Other Current Assets"
}
},
"Stock Assets": {
"Stock In Hand": {
"account_type": "Stock"
"account_type": "Stock",
"account_category": "Stock Assets"
},
"account_type": "Stock"
"account_type": "Stock",
"account_category": "Stock Assets"
},
"Tax Assets": {
"is_group": 1
"is_group": 1,
"account_category": "Other Current Assets"
}
},
"Fixed Assets": {
"Capital Equipment": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Electronic Equipment": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Furniture and Fixtures": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Office Equipment": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Plants and Machineries": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Buildings": {
"account_type": "Fixed Asset"
"account_type": "Fixed Asset",
"account_category": "Tangible Assets"
},
"Accumulated Depreciations": {
"account_type": "Accumulated Depreciation"
"account_type": "Accumulated Depreciation",
"account_category": "Tangible Assets"
}
},
"Investments": {
"is_group": 1
"is_group": 1,
"account_category": "Long-term Investments"
},
"Temporary Accounts": {
"Temporary Opening": {
"account_type": "Temporary"
"account_type": "Temporary",
"account_category": "Other Non-current Assets"
}
},
"root_type": "Asset"
@@ -72,55 +91,103 @@
"Direct Expenses": {
"Stock Expenses": {
"Cost of Goods Sold": {
"account_type": "Cost of Goods Sold"
"account_type": "Cost of Goods Sold",
"account_category": "Cost of Goods Sold"
},
"Expenses Included In Valuation": {
"account_type": "Expenses Included In Valuation"
"account_type": "Expenses Included In Valuation",
"account_category": "Other Direct Costs"
},
"Stock Adjustment": {
"account_type": "Stock Adjustment"
"account_type": "Stock Adjustment",
"account_category": "Other Direct Costs"
}
}
},
"Indirect Expenses": {
"Administrative Expenses": {},
"Commission on Sales": {},
"Administrative Expenses": {
"account_category": "Operating Expenses"
},
"Commission on Sales": {
"account_category": "Operating Expenses"
},
"Depreciation": {
"account_type": "Depreciation"
"account_type": "Depreciation",
"account_category": "Operating Expenses"
},
"Entertainment Expenses": {
"account_category": "Operating Expenses"
},
"Entertainment Expenses": {},
"Freight and Forwarding Charges": {
"account_type": "Chargeable"
"account_type": "Chargeable",
"account_category": "Operating Expenses"
},
"Legal Expenses": {
"account_category": "Operating Expenses"
},
"Marketing Expenses": {
"account_type": "Chargeable",
"account_category": "Operating Expenses"
},
"Miscellaneous Expenses": {
"account_type": "Chargeable",
"account_category": "Operating Expenses"
},
"Office Maintenance Expenses": {
"account_category": "Operating Expenses"
},
"Office Rent": {
"account_category": "Operating Expenses"
},
"Postal Expenses": {
"account_category": "Operating Expenses"
},
"Print and Stationery": {
"account_category": "Operating Expenses"
},
"Legal Expenses": {},
"Marketing Expenses": {},
"Miscellaneous Expenses": {},
"Office Maintenance Expenses": {},
"Office Rent": {},
"Postal Expenses": {},
"Print and Stationery": {},
"Rounded Off": {
"account_type": "Round Off"
"account_type": "Round Off",
"account_category": "Operating Expenses"
},
"Salary": {},
"Sales Expenses": {},
"Telephone Expenses": {},
"Travel Expenses": {},
"Utility Expenses": {},
"Write Off": {},
"Exchange Gain/Loss": {},
"Gain/Loss on Asset Disposal": {},
"Impairment": {}
"Salary": {
"account_category": "Operating Expenses"
},
"Sales Expenses": {
"account_category": "Operating Expenses"
},
"Telephone Expenses": {
"account_category": "Operating Expenses"
},
"Travel Expenses": {
"account_category": "Operating Expenses"
},
"Utility Expenses": {
"account_category": "Operating Expenses"
},
"Write Off": {
"account_category": "Operating Expenses"
},
"Exchange Gain/Loss": {
"account_category": "Operating Expenses"
},
"Gain/Loss on Asset Disposal": {
"account_category": "Other Operating Income"
},
"Impairment": {
"account_category": "Operating Expenses"
}
},
"root_type": "Expense"
},
"Income": {
"Direct Income": {
"Sales": {
"account_type": "Income Account"
"account_type": "Income Account",
"account_category": "Revenue from Operations"
},
"Service": {
"account_type": "Income Account"
"account_type": "Income Account",
"account_category": "Revenue from Operations"
},
"account_type": "Income Account"
},
@@ -132,31 +199,51 @@
},
"Source of Funds (Liabilities)": {
"Capital Account": {
"Reserves and Surplus": {},
"Shareholders Funds": {},
"Revaluation Surplus": {}
"Reserves and Surplus": {
"account_category": "Reserves and Surplus"
},
"Shareholders Funds": {
"account_category": "Share Capital"
},
"Revaluation Surplus": {
"account_category": "Reserves and Surplus"
}
},
"Current Liabilities": {
"Accounts Payable": {
"Creditors": {
"account_type": "Payable"
"account_type": "Payable",
"account_category": "Trade Payables"
},
"Payroll Payable": {}
"Payroll Payable": {
"account_category": "Other Payables"
}
},
"Stock Liabilities": {
"Stock Received But Not Billed": {
"account_type": "Stock Received But Not Billed"
"account_type": "Stock Received But Not Billed",
"account_category": "Trade Payables"
}
},
"Duties and Taxes": {
"TDS": {
"account_type": "Tax"
}
"account_type": "Tax",
"account_category": "Current Tax Liabilities"
},
"account_type": "Tax",
"is_group": 1,
"account_category": "Current Tax Liabilities"
},
"Loans (Liabilities)": {
"Secured Loans": {},
"Unsecured Loans": {},
"Bank Overdraft Account": {}
"Secured Loans": {
"account_category": "Long-term Borrowings"
},
"Unsecured Loans": {
"account_category": "Long-term Borrowings"
},
"Bank Overdraft Account": {
"account_category": "Short-term Borrowings"
}
}
},
"root_type": "Liability"

View File

@@ -1,9 +1,7 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# License: GNU General Public License v3. See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import nowdate
from erpnext.accounts.doctype.account.account import (
@@ -12,11 +10,10 @@ from erpnext.accounts.doctype.account.account import (
update_account_number,
)
from erpnext.stock import get_company_default_inventory_account, get_warehouse_account
EXTRA_TEST_RECORD_DEPENDENCIES = ["Company"]
from erpnext.tests.utils import ERPNextTestSuite
class TestAccount(IntegrationTestCase):
class TestAccount(ERPNextTestSuite):
def test_rename_account(self):
if not frappe.db.exists("Account", "1210 - Debtors - _TC"):
acc = frappe.new_doc("Account")

View File

@@ -1,6 +0,0 @@
[
{
"doctype": "Account",
"name": "_Test Account 1"
}
]

View File

@@ -2,19 +2,3 @@
# See license.txt
# import frappe
from frappe.tests import IntegrationTestCase
# On IntegrationTestCase, the doctype test records and all
# link-field test record dependencies are recursively loaded
# Use these module variables to add/remove to/from that list
EXTRA_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
IGNORE_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
class IntegrationTestAccountCategory(IntegrationTestCase):
"""
Integration tests for AccountCategory.
Use this class for testing interactions between multiple components.
"""
pass

View File

@@ -1,8 +1,8 @@
// Copyright (c) 2023, Frappe Technologies Pvt. Ltd. and contributors
// For license information, please see license.txt
// frappe.ui.form.on("Account Closing Balance", {
// refresh(frm) {
// },
// });
frappe.ui.form.on("Account Closing Balance", {
refresh(frm) {
frm.page.btn_secondary.hide();
},
});

View File

@@ -5,6 +5,7 @@
"doctype": "DocType",
"document_type": "Document",
"engine": "InnoDB",
"is_submittable": 1,
"field_order": [
"closing_date",
"account",

View File

@@ -2,8 +2,9 @@
# See license.txt
# import frappe
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountClosingBalance(IntegrationTestCase):
class TestAccountClosingBalance(ERPNextTestSuite):
pass

View File

@@ -103,10 +103,6 @@ class AccountingDimension(Document):
if not self.fieldname:
self.fieldname = scrub(self.label)
def on_update(self):
frappe.flags.accounting_dimensions = None
frappe.flags.accounting_dimensions_details = None
def make_dimension_in_accounting_doctypes(doc, doclist=None):
if not doclist:
@@ -210,7 +206,7 @@ def delete_accounting_dimension(doc):
@frappe.whitelist()
def disable_dimension(doc):
def disable_dimension(doc: str):
if frappe.in_test:
toggle_disabling(doc=doc)
else:
@@ -241,34 +237,26 @@ def get_doctypes_with_dimensions():
return frappe.get_hooks("accounting_dimension_doctypes")
def get_accounting_dimensions(as_list=True, filters=None):
if not filters:
filters = {"disabled": 0}
if frappe.flags.accounting_dimensions is None:
frappe.flags.accounting_dimensions = frappe.get_all(
"Accounting Dimension",
fields=["label", "fieldname", "disabled", "document_type"],
filters=filters,
)
def get_accounting_dimensions(as_list=True):
accounting_dimensions = frappe.get_all(
"Accounting Dimension",
fields=["label", "fieldname", "disabled", "document_type"],
filters={"disabled": 0},
)
if as_list:
return [d.fieldname for d in frappe.flags.accounting_dimensions]
return [d.fieldname for d in accounting_dimensions]
else:
return frappe.flags.accounting_dimensions
return accounting_dimensions
def get_checks_for_pl_and_bs_accounts():
if frappe.flags.accounting_dimensions_details is None:
# nosemgrep
frappe.flags.accounting_dimensions_details = frappe.db.sql(
"""SELECT p.label, p.disabled, p.fieldname, c.default_dimension, c.company, c.mandatory_for_pl, c.mandatory_for_bs
return frappe.db.sql(
"""SELECT p.label, p.disabled, p.fieldname, c.default_dimension, c.company, c.mandatory_for_pl, c.mandatory_for_bs
FROM `tabAccounting Dimension`p ,`tabAccounting Dimension Detail` c
WHERE p.name = c.parent AND p.disabled = 0""",
as_dict=1,
)
return frappe.flags.accounting_dimensions_details
as_dict=1,
)
def get_dimension_with_children(doctype, dimensions):
@@ -286,7 +274,7 @@ def get_dimension_with_children(doctype, dimensions):
@frappe.whitelist()
def get_dimensions(with_cost_center_and_project=False):
def get_dimensions(with_cost_center_and_project: str | bool = False):
c = frappe.qb.DocType("Accounting Dimension Detail")
p = frappe.qb.DocType("Accounting Dimension")
dimension_filters = (

View File

@@ -1,17 +1,14 @@
# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
EXTRA_TEST_RECORD_DEPENDENCIES = ["Cost Center", "Location", "Warehouse", "Department"]
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountingDimension(IntegrationTestCase):
class TestAccountingDimension(ERPNextTestSuite):
def setUp(self):
create_dimension()
@@ -80,11 +77,6 @@ class TestAccountingDimension(IntegrationTestCase):
si.save()
self.assertRaises(frappe.ValidationError, si.submit)
def tearDown(self):
disable_dimension()
frappe.flags.accounting_dimensions_details = None
frappe.flags.dimension_filter_map = None
def create_dimension():
frappe.set_user("Administrator")

View File

@@ -3,7 +3,7 @@
import frappe
from frappe import _, scrub
from frappe import _
from frappe.model.document import Document
@@ -69,37 +69,34 @@ class AccountingDimensionFilter(Document):
def get_dimension_filter_map():
if not frappe.flags.get("dimension_filter_map"):
filters = frappe.db.sql(
"""
SELECT
a.applicable_on_account, d.dimension_value, p.accounting_dimension,
p.allow_or_restrict, p.fieldname, a.is_mandatory
FROM
`tabApplicable On Account` a,
`tabAccounting Dimension Filter` p
LEFT JOIN `tabAllowed Dimension` d ON d.parent = p.name
WHERE
p.name = a.parent
AND p.disabled = 0
""",
as_dict=1,
filters = frappe.db.sql(
"""
SELECT
a.applicable_on_account, d.dimension_value, p.accounting_dimension,
p.allow_or_restrict, p.fieldname, a.is_mandatory
FROM
`tabApplicable On Account` a,
`tabAccounting Dimension Filter` p
LEFT JOIN `tabAllowed Dimension` d ON d.parent = p.name
WHERE
p.name = a.parent
AND p.disabled = 0
""",
as_dict=1,
)
dimension_filter_map = {}
for f in filters:
build_map(
dimension_filter_map,
f.fieldname,
f.applicable_on_account,
f.dimension_value,
f.allow_or_restrict,
f.is_mandatory,
)
dimension_filter_map = {}
for f in filters:
build_map(
dimension_filter_map,
f.fieldname,
f.applicable_on_account,
f.dimension_value,
f.allow_or_restrict,
f.is_mandatory,
)
frappe.flags.dimension_filter_map = dimension_filter_map
return frappe.flags.dimension_filter_map
return dimension_filter_map
def build_map(map_object, dimension, account, filter_value, allow_or_restrict, is_mandatory):

View File

@@ -1,21 +1,17 @@
# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from erpnext.accounts.doctype.accounting_dimension.test_accounting_dimension import (
create_dimension,
disable_dimension,
)
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.exceptions import InvalidAccountDimensionError, MandatoryAccountDimensionError
EXTRA_TEST_RECORD_DEPENDENCIES = ["Location", "Cost Center", "Department"]
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountingDimensionFilter(unittest.TestCase):
class TestAccountingDimensionFilter(ERPNextTestSuite):
def setUp(self):
create_dimension()
create_accounting_dimension_filter()
@@ -44,17 +40,6 @@ class TestAccountingDimensionFilter(unittest.TestCase):
self.assertRaises(MandatoryAccountDimensionError, si.submit)
self.invoice_list.append(si)
def tearDown(self):
disable_dimension_filter()
disable_dimension()
frappe.flags.accounting_dimensions_details = None
frappe.flags.dimension_filter_map = None
for si in self.invoice_list:
si.load_from_db()
if si.docstatus == 1:
si.cancel()
def create_accounting_dimension_filter():
if not frappe.db.get_value("Accounting Dimension Filter", {"accounting_dimension": "Cost Center"}):

View File

@@ -20,7 +20,6 @@
{
"fieldname": "period_name",
"fieldtype": "Data",
"in_list_view": 1,
"label": "Period Name",
"reqd": 1,
"unique": 1
@@ -79,7 +78,7 @@
}
],
"links": [],
"modified": "2025-12-01 16:53:44.631299",
"modified": "2026-03-09 17:15:33.577217",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Accounting Period",

View File

@@ -97,7 +97,7 @@ def validate_accounting_period_on_doc_save(doc, method=None):
if doc.doctype == "Bank Clearance":
return
elif doc.doctype == "Asset":
if doc.is_existing_asset:
if doc.asset_type == "Existing Asset":
return
else:
date = doc.available_for_use_date

View File

@@ -1,9 +1,7 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import add_months, nowdate
from erpnext.accounts.doctype.accounting_period.accounting_period import (
@@ -11,11 +9,10 @@ from erpnext.accounts.doctype.accounting_period.accounting_period import (
OverlapError,
)
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
EXTRA_TEST_RECORD_DEPENDENCIES = ["Item"]
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountingPeriod(IntegrationTestCase):
class TestAccountingPeriod(ERPNextTestSuite):
def test_overlap(self):
ap1 = create_accounting_period(
start_date="2018-04-01", end_date="2018-06-30", company="Wind Power LLC"
@@ -90,10 +87,6 @@ class TestAccountingPeriod(IntegrationTestCase):
doc.submit() # Should not raise
self.assertEqual(doc.docstatus, 1)
def tearDown(self):
for d in frappe.get_all("Accounting Period"):
frappe.delete_doc("Accounting Period", d.name)
def create_accounting_period(**args):
args = frappe._dict(args)

View File

@@ -20,6 +20,10 @@
"enable_common_party_accounting",
"allow_multi_currency_invoices_against_single_party_account",
"confirm_before_resetting_posting_date",
"analytics_section",
"enable_accounting_dimensions",
"column_break_vtnr",
"enable_discounts_and_margin",
"journals_section",
"merge_similar_account_heads",
"deferred_accounting_settings_section",
@@ -51,12 +55,16 @@
"allow_pegged_currencies_exchange_rates",
"column_break_yuug",
"stale_days",
"payments_tab",
"section_break_jpd0",
"auto_reconcile_payments",
"auto_reconciliation_job_trigger",
"reconciliation_queue_size",
"column_break_resa",
"exchange_gain_loss_posting_date",
"payment_options_section",
"enable_loyalty_point_program",
"column_break_ctam",
"invoicing_settings_tab",
"accounts_transactions_settings_section",
"over_billing_allowance",
@@ -197,7 +205,7 @@
"description": "Payment Terms from orders will be fetched into the invoices as is",
"fieldname": "automatically_fetch_payment_terms",
"fieldtype": "Check",
"label": "Automatically Fetch Payment Terms from Order"
"label": "Automatically Fetch Payment Terms from Order/Quotation"
},
{
"description": "The percentage you are allowed to bill more against the amount ordered. For example, if the order value is $100 for an item and tolerance is set as 10%, then you are allowed to bill up to $110 ",
@@ -281,7 +289,7 @@
},
{
"default": "0",
"description": "Learn about <a href=\"https://docs.erpnext.com/docs/v13/user/manual/en/accounts/articles/common_party_accounting#:~:text=Common%20Party%20Accounting%20in%20ERPNext,Invoice%20against%20a%20primary%20Supplier.\">Common Party</a>",
"description": "Learn about <a href=\"https://docs.frappe.io/erpnext/user/manual/en/common_party_accounting\" rel=\"noopener noreferrer\">Common Party</a>",
"fieldname": "enable_common_party_accounting",
"fieldtype": "Check",
"label": "Enable Common Party Accounting"
@@ -637,16 +645,59 @@
"fieldname": "budget_section",
"fieldtype": "Section Break",
"label": "Budget"
},
{
"fieldname": "analytics_section",
"fieldtype": "Section Break",
"label": "Analytical Accounting"
},
{
"fieldname": "column_break_vtnr",
"fieldtype": "Column Break"
},
{
"default": "0",
"description": "Apply discounts and margins on products",
"fieldname": "enable_discounts_and_margin",
"fieldtype": "Check",
"label": "Enable Discounts and Margin"
},
{
"fieldname": "payments_tab",
"fieldtype": "Tab Break",
"label": "Payments"
},
{
"fieldname": "payment_options_section",
"fieldtype": "Section Break",
"label": "Payment Options"
},
{
"default": "0",
"fieldname": "enable_loyalty_point_program",
"fieldtype": "Check",
"label": "Enable Loyalty Point Program"
},
{
"fieldname": "column_break_ctam",
"fieldtype": "Column Break"
},
{
"default": "0",
"description": "Enable cost center, projects and other custom accounting dimensions",
"fieldname": "enable_accounting_dimensions",
"fieldtype": "Check",
"label": "Enable Accounting Dimensions"
}
],
"grid_page_length": 50,
"hide_toolbar": 1,
"hide_toolbar": 0,
"icon": "icon-cog",
"idx": 1,
"index_web_pages_for_search": 1,
"issingle": 1,
"links": [],
"modified": "2026-01-11 18:30:45.968531",
"modified": "2026-02-27 01:04:09.415288",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Accounts Settings",

View File

@@ -12,6 +12,28 @@ from frappe.utils import cint
from erpnext.accounts.utils import sync_auto_reconcile_config
SELLING_DOCTYPES = [
"Sales Invoice",
"Sales Order",
"Delivery Note",
"Quotation",
"Sales Invoice Item",
"Sales Order Item",
"Delivery Note Item",
"Quotation Item",
"POS Invoice",
"POS Invoice Item",
]
BUYING_DOCTYPES = [
"Purchase Invoice",
"Purchase Order",
"Purchase Receipt",
"Purchase Invoice Item",
"Purchase Order Item",
"Purchase Receipt Item",
]
class AccountsSettings(Document):
# begin: auto-generated types
@@ -43,9 +65,12 @@ class AccountsSettings(Document):
default_ageing_range: DF.Data | None
delete_linked_ledger_entries: DF.Check
determine_address_tax_category_from: DF.Literal["Billing Address", "Shipping Address"]
enable_accounting_dimensions: DF.Check
enable_common_party_accounting: DF.Check
enable_discounts_and_margin: DF.Check
enable_fuzzy_matching: DF.Check
enable_immutable_ledger: DF.Check
enable_loyalty_point_program: DF.Check
enable_party_matching: DF.Check
exchange_gain_loss_posting_date: DF.Literal["Invoice", "Payment", "Reconciliation Date"]
fetch_valuation_rate_for_internal_transaction: DF.Check
@@ -98,6 +123,18 @@ class AccountsSettings(Document):
if old_doc.show_payment_schedule_in_print != self.show_payment_schedule_in_print:
self.enable_payment_schedule_in_print()
if old_doc.enable_accounting_dimensions != self.enable_accounting_dimensions:
toggle_accounting_dimension_sections(not self.enable_accounting_dimensions)
clear_cache = True
if old_doc.enable_discounts_and_margin != self.enable_discounts_and_margin:
toggle_sales_discount_section(not self.enable_discounts_and_margin)
clear_cache = True
if old_doc.enable_loyalty_point_program != self.enable_loyalty_point_program:
toggle_loyalty_point_program_section(not self.enable_loyalty_point_program)
clear_cache = True
if clear_cache:
frappe.clear_cache()
@@ -154,3 +191,36 @@ class AccountsSettings(Document):
frappe.db.sql(f"drop procedure if exists {InitSQLProceduresForAR.init_procedure_name}")
frappe.db.sql(f"drop procedure if exists {InitSQLProceduresForAR.allocate_procedure_name}")
def toggle_accounting_dimension_sections(hide):
accounting_dimension_doctypes = frappe.get_hooks("accounting_dimension_doctypes")
for doctype in accounting_dimension_doctypes:
create_property_setter_for_hiding_field(doctype, "accounting_dimensions_section", hide)
def toggle_sales_discount_section(hide):
for doctype in SELLING_DOCTYPES + BUYING_DOCTYPES:
meta = frappe.get_meta(doctype)
if meta.has_field("additional_discount_section"):
create_property_setter_for_hiding_field(doctype, "additional_discount_section", hide)
if meta.has_field("discount_and_margin"):
create_property_setter_for_hiding_field(doctype, "discount_and_margin", hide)
def toggle_loyalty_point_program_section(hide):
for doctype in SELLING_DOCTYPES:
meta = frappe.get_meta(doctype)
if meta.has_field("loyalty_points_redemption"):
create_property_setter_for_hiding_field(doctype, "loyalty_points_redemption", hide)
def create_property_setter_for_hiding_field(doctype, field_name, hide):
make_property_setter(
doctype,
field_name,
"hidden",
hide,
"Check",
validate_fields_for_doctype=False,
)

View File

@@ -1,17 +1,9 @@
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsSettings(IntegrationTestCase):
def tearDown(self):
# Just in case `save` method succeeds, we need to take things back to default so that other tests
# don't break
cur_settings = frappe.get_doc("Accounts Settings", "Accounts Settings")
cur_settings.allow_stale = 1
cur_settings.save()
class TestAccountsSettings(ERPNextTestSuite):
def test_stale_days(self):
cur_settings = frappe.get_doc("Accounts Settings", "Accounts Settings")
cur_settings.allow_stale = 0

View File

@@ -3,6 +3,7 @@
frappe.ui.form.on("Advance Payment Ledger Entry", {
refresh(frm) {
frm.page.btn_secondary.hide();
frm.set_currency_labels(["amount"], frm.doc.currency);
frm.set_currency_labels(["base_amount"], erpnext.get_currency(frm.doc.company));
},

View File

@@ -4,6 +4,7 @@
"creation": "2024-10-16 16:57:12.085072",
"doctype": "DocType",
"engine": "InnoDB",
"is_submittable": 1,
"field_order": [
"company",
"voucher_type",
@@ -50,6 +51,7 @@
"fieldname": "amount",
"fieldtype": "Currency",
"label": "Amount",
"options": "currency",
"read_only": 1
},
{

View File

@@ -2,7 +2,6 @@
# See license.txt
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import nowdate, today
from erpnext.accounts.doctype.payment_entry.test_payment_entry import get_payment_entry
@@ -10,14 +9,13 @@ from erpnext.accounts.test.accounts_mixin import AccountsTestMixin
from erpnext.buying.doctype.purchase_order.test_purchase_order import create_purchase_order
from erpnext.selling.doctype.sales_order.test_sales_order import make_sales_order
# On IntegrationTestCase, the doctype test records and all
# On ERPNextTestSuite, the doctype test records and all
# link-field test record depdendencies are recursively loaded
# Use these module variables to add/remove to/from that list
EXTRA_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
IGNORE_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
from erpnext.tests.utils import ERPNextTestSuite
class TestAdvancePaymentLedgerEntry(AccountsTestMixin, IntegrationTestCase):
class TestAdvancePaymentLedgerEntry(AccountsTestMixin, ERPNextTestSuite):
"""
Integration tests for AdvancePaymentLedgerEntry.
Use this class for testing interactions between multiple components.
@@ -30,9 +28,6 @@ class TestAdvancePaymentLedgerEntry(AccountsTestMixin, IntegrationTestCase):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_sales_order(self, qty=1, rate=100, currency="INR", do_not_submit=False):
"""
Helper method

View File

@@ -3,9 +3,6 @@
frappe.provide("erpnext.integrations");
frappe.ui.form.on("Bank", {
onload: function (frm) {
add_fields_to_mapping_table(frm);
},
refresh: function (frm) {
add_fields_to_mapping_table(frm);
frm.toggle_display(["address_html", "contact_html"], !frm.doc.__islocal);
@@ -37,11 +34,11 @@ let add_fields_to_mapping_table = function (frm) {
});
});
frm.fields_dict.bank_transaction_mapping.grid.update_docfield_property(
"bank_transaction_field",
"options",
options
);
const grid = frm.fields_dict.bank_transaction_mapping?.grid;
if (grid) {
grid.update_docfield_property("bank_transaction_field", "options", options);
}
};
erpnext.integrations.refreshPlaidLink = class refreshPlaidLink {
@@ -116,7 +113,7 @@ erpnext.integrations.refreshPlaidLink = class refreshPlaidLink {
"There was an issue connecting to Plaid's authentication server. Check browser console for more information"
)
);
console.log(error);
console.error(error);
}
plaid_success(token, response) {

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestBank(IntegrationTestCase):
class TestBank(ERPNextTestSuite):
pass

View File

@@ -42,8 +42,4 @@ frappe.ui.form.on("Bank Account", {
});
}
},
is_company_account: function (frm) {
frm.set_df_property("account", "reqd", frm.doc.is_company_account);
},
});

View File

@@ -52,6 +52,7 @@
"fieldtype": "Link",
"in_list_view": 1,
"label": "Company Account",
"mandatory_depends_on": "is_company_account",
"options": "Account"
},
{
@@ -98,6 +99,7 @@
"in_list_view": 1,
"in_standard_filter": 1,
"label": "Company",
"mandatory_depends_on": "is_company_account",
"options": "Company"
},
{
@@ -252,7 +254,7 @@
"link_fieldname": "default_bank_account"
}
],
"modified": "2025-08-29 12:32:01.081687",
"modified": "2026-01-20 00:46:16.633364",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Bank Account",

View File

@@ -51,25 +51,29 @@ class BankAccount(Document):
delete_contact_and_address("Bank Account", self.name)
def validate(self):
self.validate_company()
self.validate_account()
self.validate_is_company_account()
self.update_default_bank_account()
def validate_account(self):
if self.account:
if accounts := frappe.db.get_all(
"Bank Account", filters={"account": self.account, "name": ["!=", self.name]}, as_list=1
):
frappe.throw(
_("'{0}' account is already used by {1}. Use another account.").format(
frappe.bold(self.account),
frappe.bold(comma_and([get_link_to_form(self.doctype, x[0]) for x in accounts])),
)
)
def validate_is_company_account(self):
if self.is_company_account:
if not self.company:
frappe.throw(_("Company is mandatory for company account"))
def validate_company(self):
if self.is_company_account and not self.company:
frappe.throw(_("Company is mandatory for company account"))
if not self.account:
frappe.throw(_("Company Account is mandatory"))
self.validate_account()
def validate_account(self):
if accounts := frappe.db.get_all(
"Bank Account", filters={"account": self.account, "name": ["!=", self.name]}, as_list=1
):
frappe.throw(
_("'{0}' account is already used by {1}. Use another account.").format(
frappe.bold(self.account),
frappe.bold(comma_and([get_link_to_form(self.doctype, x[0]) for x in accounts])),
)
)
def update_default_bank_account(self):
if self.is_default and not self.disabled:
@@ -111,7 +115,7 @@ def get_default_company_bank_account(company, party_type, party):
@frappe.whitelist()
def get_bank_account_details(bank_account):
def get_bank_account_details(bank_account: str):
return frappe.get_cached_value(
"Bank Account", bank_account, ["account", "bank", "bank_account_no"], as_dict=1
)

View File

@@ -1,11 +1,8 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe import ValidationError
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestBankAccount(IntegrationTestCase):
class TestBankAccount(ERPNextTestSuite):
pass

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestBankAccountSubtype(IntegrationTestCase):
class TestBankAccountSubtype(ERPNextTestSuite):
pass

View File

@@ -1,10 +1,9 @@
# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
# import frappe
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestBankAccountType(IntegrationTestCase):
class TestBankAccountType(ERPNextTestSuite):
pass

View File

@@ -5,8 +5,10 @@
import frappe
from frappe import _, msgprint
from frappe.model.document import Document
from frappe.query_builder import Case
from frappe.query_builder.custom import ConstantColumn
from frappe.utils import cint, flt, fmt_money, get_link_to_form, getdate
from frappe.query_builder.functions import Coalesce, Sum
from frappe.utils import cint, flt, fmt_money, getdate
from pypika import Order
import erpnext
@@ -182,65 +184,162 @@ def get_payment_entries_for_bank_clearance(
):
entries = []
condition = ""
pe_condition = ""
journal_entry = frappe.qb.DocType("Journal Entry")
journal_entry_account = frappe.qb.DocType("Journal Entry Account")
journal_entry_query = (
frappe.qb.from_(journal_entry_account)
.inner_join(journal_entry)
.on(journal_entry_account.parent == journal_entry.name)
.select(
ConstantColumn("Journal Entry").as_("payment_document"),
journal_entry.name.as_("payment_entry"),
journal_entry.cheque_no.as_("cheque_number"),
journal_entry.cheque_date,
Sum(journal_entry_account.debit_in_account_currency).as_("debit"),
Sum(journal_entry_account.credit_in_account_currency).as_("credit"),
journal_entry.posting_date,
journal_entry_account.against_account,
journal_entry.clearance_date,
journal_entry_account.account_currency,
)
.where(
(journal_entry_account.account == account)
& (journal_entry.docstatus == 1)
& (journal_entry.posting_date >= from_date)
& (journal_entry.posting_date <= to_date)
& (journal_entry.is_opening == "No")
)
)
if not include_reconciled_entries:
condition = "and (clearance_date IS NULL or clearance_date='0000-00-00')"
pe_condition = "and (pe.clearance_date IS NULL or pe.clearance_date='0000-00-00')"
journal_entry_query = journal_entry_query.where(
(journal_entry.clearance_date.isnull()) | (journal_entry.clearance_date == "0000-00-00")
)
journal_entries = frappe.db.sql(
f"""
select
"Journal Entry" as payment_document, t1.name as payment_entry,
t1.cheque_no as cheque_number, t1.cheque_date,
sum(t2.debit_in_account_currency) as debit, sum(t2.credit_in_account_currency) as credit,
t1.posting_date, t2.against_account, t1.clearance_date, t2.account_currency
from
`tabJournal Entry` t1, `tabJournal Entry Account` t2
where
t2.parent = t1.name and t2.account = %(account)s and t1.docstatus=1
and t1.posting_date >= %(from)s and t1.posting_date <= %(to)s
and ifnull(t1.is_opening, 'No') = 'No' {condition}
group by t2.account, t1.name
order by t1.posting_date ASC, t1.name DESC
""",
{"account": account, "from": from_date, "to": to_date},
as_dict=1,
journal_entries = (
journal_entry_query.groupby(journal_entry_account.account, journal_entry.name)
.orderby(journal_entry.posting_date)
.orderby(journal_entry.name, order=Order.desc)
).run(as_dict=True)
pe = frappe.qb.DocType("Payment Entry")
company = frappe.qb.DocType("Company")
payment_entry_query = (
frappe.qb.from_(pe)
.join(company)
.on(pe.company == company.name)
.select(
ConstantColumn("Payment Entry").as_("payment_document"),
pe.name.as_("payment_entry"),
pe.reference_no.as_("cheque_number"),
pe.reference_date.as_("cheque_date"),
(
Case()
.when(
pe.paid_from == account,
(
pe.paid_amount
+ (
Case()
.when(
(pe.payment_type == "Pay")
& (company.default_currency == pe.paid_from_account_currency),
pe.base_total_taxes_and_charges,
)
.else_(pe.total_taxes_and_charges)
)
),
)
.else_(0)
).as_("credit"),
(
Case()
.when(pe.paid_from == account, 0)
.else_(
pe.received_amount
+ (
Case()
.when(
company.default_currency == pe.paid_to_account_currency,
pe.base_total_taxes_and_charges,
)
.else_(pe.total_taxes_and_charges)
)
)
).as_("debit"),
pe.posting_date,
Coalesce(pe.party, Case().when(pe.paid_from == account, pe.paid_to).else_(pe.paid_from)).as_(
"against_account"
),
pe.clearance_date,
(
Case()
.when(pe.paid_to == account, pe.paid_to_account_currency)
.else_(pe.paid_from_account_currency)
).as_("account_currency"),
)
.where(
((pe.paid_from == account) | (pe.paid_to == account))
& (pe.docstatus == 1)
& (pe.posting_date >= from_date)
& (pe.posting_date <= to_date)
)
)
payment_entries = frappe.db.sql(
f"""
select
"Payment Entry" as payment_document, pe.name as payment_entry,
pe.reference_no as cheque_number, pe.reference_date as cheque_date,
if(pe.paid_from=%(account)s, pe.paid_amount + if(pe.payment_type = 'Pay' and c.default_currency = pe.paid_from_account_currency, pe.base_total_taxes_and_charges, pe.total_taxes_and_charges) , 0) as credit,
if(pe.paid_from=%(account)s, 0, pe.received_amount + pe.total_taxes_and_charges) as debit,
pe.posting_date, ifnull(pe.party,if(pe.paid_from=%(account)s,pe.paid_to,pe.paid_from)) as against_account, pe.clearance_date,
if(pe.paid_to=%(account)s, pe.paid_to_account_currency, pe.paid_from_account_currency) as account_currency
from `tabPayment Entry` as pe
join `tabCompany` c on c.name = pe.company
where
(pe.paid_from=%(account)s or pe.paid_to=%(account)s) and pe.docstatus=1
and pe.posting_date >= %(from)s and pe.posting_date <= %(to)s
{pe_condition}
order by
pe.posting_date ASC, pe.name DESC
""",
{
"account": account,
"from": from_date,
"to": to_date,
},
as_dict=1,
if not include_reconciled_entries:
payment_entry_query = payment_entry_query.where(
(pe.clearance_date.isnull()) | (pe.clearance_date == "0000-00-00")
)
payment_entries = (payment_entry_query.orderby(pe.posting_date).orderby(pe.name, order=Order.desc)).run(
as_dict=True
)
pos_sales_invoices, pos_purchase_invoices = [], []
acc = frappe.qb.DocType("Account")
pi = frappe.qb.DocType("Purchase Invoice")
paid_purchase_invoices_query = (
frappe.qb.from_(pi)
.inner_join(acc)
.on(pi.cash_bank_account == acc.name)
.select(
ConstantColumn("Purchase Invoice").as_("payment_document"),
pi.name.as_("payment_entry"),
pi.paid_amount.as_("credit"),
pi.posting_date,
pi.supplier.as_("against_account"),
pi.bill_no.as_("cheque_number"),
pi.clearance_date,
acc.account_currency,
ConstantColumn(0).as_("debit"),
)
.where(
(pi.docstatus == 1)
& (pi.is_paid == 1)
& (pi.cash_bank_account == account)
& (pi.posting_date >= from_date)
& (pi.posting_date <= to_date)
)
)
if not include_reconciled_entries:
paid_purchase_invoices_query = paid_purchase_invoices_query.where(
(pi.clearance_date.isnull()) | (pi.clearance_date == "0000-00-00")
)
paid_purchase_invoices = (
paid_purchase_invoices_query.orderby(pi.posting_date).orderby(pi.name, order=Order.desc)
).run(as_dict=True)
pos_sales_invoices = []
if include_pos_transactions:
si_payment = frappe.qb.DocType("Sales Invoice Payment")
si = frappe.qb.DocType("Sales Invoice")
acc = frappe.qb.DocType("Account")
pos_sales_invoices = (
pos_sales_invoices_query = (
frappe.qb.from_(si_payment)
.inner_join(si)
.on(si_payment.parent == si.name)
@@ -263,38 +362,22 @@ def get_payment_entries_for_bank_clearance(
& (si.posting_date >= from_date)
& (si.posting_date <= to_date)
)
.orderby(si.posting_date)
.orderby(si.name, order=Order.desc)
).run(as_dict=True)
)
pi = frappe.qb.DocType("Purchase Invoice")
if not include_reconciled_entries:
pos_sales_invoices_query = pos_sales_invoices_query.where(
(si_payment.clearance_date.isnull()) | (si_payment.clearance_date == "0000-00-00")
)
pos_purchase_invoices = (
frappe.qb.from_(pi)
.inner_join(acc)
.on(pi.cash_bank_account == acc.name)
.select(
ConstantColumn("Purchase Invoice").as_("payment_document"),
pi.name.as_("payment_entry"),
pi.paid_amount.as_("credit"),
pi.posting_date,
pi.supplier.as_("against_account"),
pi.clearance_date,
acc.account_currency,
ConstantColumn(0).as_("debit"),
)
.where(
(pi.docstatus == 1)
& (pi.cash_bank_account == account)
& (pi.posting_date >= from_date)
& (pi.posting_date <= to_date)
)
.orderby(pi.posting_date)
.orderby(pi.name, order=Order.desc)
pos_sales_invoices = (
pos_sales_invoices_query.orderby(si.posting_date).orderby(si.name, order=Order.desc)
).run(as_dict=True)
entries = (
list(payment_entries) + list(journal_entries) + list(pos_sales_invoices) + list(pos_purchase_invoices)
list(payment_entries)
+ list(journal_entries)
+ list(pos_sales_invoices)
+ list(paid_purchase_invoices)
)
return entries

View File

@@ -1,9 +1,7 @@
# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import add_months, getdate
from erpnext.accounts.doctype.cost_center.test_cost_center import create_cost_center
@@ -15,13 +13,12 @@ from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import make
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.stock.doctype.item.test_item import create_item
from erpnext.stock.doctype.warehouse.test_warehouse import create_warehouse
from erpnext.tests.utils import if_lending_app_installed, if_lending_app_not_installed
from erpnext.tests.utils import ERPNextTestSuite, if_lending_app_installed, if_lending_app_not_installed
class TestBankClearance(IntegrationTestCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
class TestBankClearance(ERPNextTestSuite):
def setUp(self):
frappe.clear_cache()
create_warehouse(
warehouse_name="_Test Warehouse",
properties={"parent_warehouse": "All Warehouses - _TC"},

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestBankGuarantee(IntegrationTestCase):
class TestBankGuarantee(ERPNextTestSuite):
pass

View File

@@ -1,8 +1,8 @@
# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and contributors
# For license information, please see license.txt
import json
from datetime import date
import frappe
from frappe import _
@@ -47,7 +47,9 @@ class BankReconciliationTool(Document):
@frappe.whitelist()
def get_bank_transactions(bank_account, from_date=None, to_date=None):
def get_bank_transactions(
bank_account: str, from_date: str | date | None = None, to_date: str | date | None = None
):
# returns bank transactions for a bank account
filters = []
filters.append(["bank_account", "=", bank_account])
@@ -57,7 +59,7 @@ def get_bank_transactions(bank_account, from_date=None, to_date=None):
filters.append(["date", "<=", to_date])
if from_date:
filters.append(["date", ">=", from_date])
transactions = frappe.get_all(
transactions = frappe.get_list(
"Bank Transaction",
fields=[
"date",
@@ -80,8 +82,9 @@ def get_bank_transactions(bank_account, from_date=None, to_date=None):
@frappe.whitelist()
def get_account_balance(bank_account, till_date, company):
def get_account_balance(bank_account: str, till_date: str | date, company: str):
# returns account balance till the specified date
frappe.has_permission("Bank Account", "read", bank_account, throw=True)
account = frappe.db.get_value("Bank Account", bank_account, "account")
filters = frappe._dict(
{
@@ -106,7 +109,9 @@ def get_account_balance(bank_account, till_date, company):
@frappe.whitelist()
def update_bank_transaction(bank_transaction_name, reference_number, party_type=None, party=None):
def update_bank_transaction(
bank_transaction_name: str, reference_number: str, party_type: str | None = None, party: str | None = None
):
# updates bank transaction based on the new parameters provided by the user from Vouchers
bank_transaction = frappe.get_doc("Bank Transaction", bank_transaction_name)
bank_transaction.reference_number = reference_number
@@ -135,16 +140,16 @@ def update_bank_transaction(bank_transaction_name, reference_number, party_type=
@frappe.whitelist()
def create_journal_entry_bts(
bank_transaction_name,
reference_number=None,
reference_date=None,
posting_date=None,
entry_type=None,
second_account=None,
mode_of_payment=None,
party_type=None,
party=None,
allow_edit=None,
bank_transaction_name: str,
reference_number: str | None = None,
reference_date: str | None = None,
posting_date: str | date | None = None,
entry_type: str | None = None,
second_account: str | None = None,
mode_of_payment: str | None = None,
party_type: str | None = None,
party: str | None = None,
allow_edit: bool | None = None,
):
# Create a new journal entry based on the bank transaction
bank_transaction = frappe.db.get_values(
@@ -294,17 +299,17 @@ def create_journal_entry_bts(
@frappe.whitelist()
def create_payment_entry_bts(
bank_transaction_name,
reference_number=None,
reference_date=None,
party_type=None,
party=None,
posting_date=None,
mode_of_payment=None,
project=None,
cost_center=None,
allow_edit=None,
company_bank_account=None,
bank_transaction_name: str,
reference_number: str | None = None,
reference_date: str | None = None,
party_type: str | None = None,
party: str | None = None,
posting_date: str | None = None,
mode_of_payment: str | None = None,
project: str | None = None,
cost_center: str | None = None,
allow_edit: bool | None = None,
company_bank_account: str | None = None,
):
# Create a new payment entry based on the bank transaction
bank_transaction = frappe.db.get_values(
@@ -371,12 +376,12 @@ def create_payment_entry_bts(
@frappe.whitelist()
def auto_reconcile_vouchers(
bank_account,
from_date=None,
to_date=None,
filter_by_reference_date=None,
from_reference_date=None,
to_reference_date=None,
bank_account: str,
from_date: str | date | None = None,
to_date: str | date | None = None,
filter_by_reference_date: bool | None = None,
from_reference_date: bool | None = None,
to_reference_date: str | None = None,
):
bank_transactions = get_bank_transactions(bank_account)
@@ -471,7 +476,7 @@ def get_auto_reconcile_message(partially_reconciled, reconciled):
@frappe.whitelist()
def reconcile_vouchers(bank_transaction_name, vouchers):
def reconcile_vouchers(bank_transaction_name: str, vouchers: str):
# updated clear date of all the vouchers based on the bank transaction
vouchers = json.loads(vouchers)
transaction = frappe.get_doc("Bank Transaction", bank_transaction_name)
@@ -487,13 +492,13 @@ def reconcile_vouchers(bank_transaction_name, vouchers):
@frappe.whitelist()
def get_linked_payments(
bank_transaction_name,
document_types=None,
from_date=None,
to_date=None,
filter_by_reference_date=None,
from_reference_date=None,
to_reference_date=None,
bank_transaction_name: str,
document_types: str | list[str] | None = None,
from_date: str | date | None = None,
to_date: str | date | None = None,
filter_by_reference_date: bool | None = None,
from_reference_date: bool | None = None,
to_reference_date: str | None = None,
):
# get all matching payments for a bank transaction
transaction = frappe.get_doc("Bank Transaction", bank_transaction_name)

View File

@@ -4,7 +4,6 @@
import frappe
from frappe import qb
from frappe.tests import IntegrationTestCase
from frappe.utils import add_days, today
from erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool import (
@@ -13,9 +12,10 @@ from erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool
)
from erpnext.accounts.doctype.payment_entry.test_payment_entry import create_payment_entry
from erpnext.accounts.test.accounts_mixin import AccountsTestMixin
from erpnext.tests.utils import ERPNextTestSuite
class TestBankReconciliationTool(AccountsTestMixin, IntegrationTestCase):
class TestBankReconciliationTool(AccountsTestMixin, ERPNextTestSuite):
def setUp(self):
self.create_company()
self.create_customer()
@@ -24,9 +24,6 @@ class TestBankReconciliationTool(AccountsTestMixin, IntegrationTestCase):
qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()
self.create_bank_account()
def tearDown(self):
frappe.db.rollback()
def create_bank_account(self):
bank = frappe.get_doc(
{
@@ -43,6 +40,7 @@ class TestBankReconciliationTool(AccountsTestMixin, IntegrationTestCase):
"bank": bank.name,
"is_company_account": True,
"account": self.bank, # account from Chart of Accounts
"company": self.company,
}
)
.insert()

View File

@@ -14,7 +14,6 @@ import openpyxl
from frappe import _
from frappe.core.doctype.data_import.data_import import DataImport
from frappe.core.doctype.data_import.importer import Importer, ImportFile
from frappe.query_builder.functions import Count
from frappe.utils.background_jobs import enqueue
from frappe.utils.file_manager import get_file, save_file
from frappe.utils.xlsxutils import ILLEGAL_CHARACTERS_RE, handle_html
@@ -144,7 +143,7 @@ def preprocess_mt940_content(content: str) -> str:
@frappe.whitelist()
def convert_mt940_to_csv(data_import, mt940_file_path):
def convert_mt940_to_csv(data_import: str, mt940_file_path: str):
doc = frappe.get_doc("Bank Statement Import", data_import)
_file_doc, content = get_file(mt940_file_path)
@@ -209,26 +208,28 @@ def convert_mt940_to_csv(data_import, mt940_file_path):
@frappe.whitelist()
def get_preview_from_template(data_import, import_file=None, google_sheets_url=None):
def get_preview_from_template(
data_import: str, import_file: str | None = None, google_sheets_url: str | None = None
):
return frappe.get_doc("Bank Statement Import", data_import).get_preview_from_template(
import_file, google_sheets_url
)
@frappe.whitelist()
def form_start_import(data_import):
def form_start_import(data_import: str):
job_id = frappe.get_doc("Bank Statement Import", data_import).start_import()
return job_id is not None
@frappe.whitelist()
def download_errored_template(data_import_name):
def download_errored_template(data_import_name: str):
data_import = frappe.get_doc("Bank Statement Import", data_import_name)
data_import.export_errored_rows()
@frappe.whitelist()
def download_import_log(data_import_name):
def download_import_log(data_import_name: str):
return frappe.get_doc("Bank Statement Import", data_import_name).download_import_log()
@@ -364,7 +365,7 @@ def write_xlsx(data, sheet_name, wb=None, column_widths=None, file_path=None):
@frappe.whitelist()
def get_import_status(docname):
def get_import_status(docname: str):
import_status = {}
data_import = frappe.get_doc("Bank Statement Import", docname)

View File

@@ -1,15 +1,14 @@
# Copyright (c) 2020, Frappe Technologies and Contributors
# See license.txt
import unittest
from erpnext.accounts.doctype.bank_statement_import.bank_statement_import import (
is_mt940_format,
preprocess_mt940_content,
)
from erpnext.tests.utils import ERPNextTestSuite
class TestBankStatementImport(unittest.TestCase):
class TestBankStatementImport(ERPNextTestSuite):
"""Unit tests for Bank Statement Import functions"""
def test_preprocess_mt940_content_with_long_statement_number(self):

View File

@@ -139,6 +139,8 @@ class BankTransaction(Document):
self.set_status()
def on_cancel(self):
self.ignore_linked_doctypes = ["GL Entry"]
for payment_entry in self.payment_entries:
self.delink_payment_entry(payment_entry)
@@ -373,11 +375,12 @@ def get_clearance_details(transaction, payment_entry, bt_allocations, gl_entries
("unallocated_amount", "bank_account"),
as_dict=True,
)
bt_bank_account = frappe.db.get_value("Bank Account", bt.bank_account, "account")
if bt.bank_account != gl_bank_account:
if bt_bank_account != gl_bank_account:
frappe.throw(
_("Bank Account {} in Bank Transaction {} is not matching with Bank Account {}").format(
bt.bank_account, payment_entry.payment_entry, gl_bank_account
bt_bank_account, payment_entry.payment_entry, gl_bank_account
)
)

View File

@@ -35,7 +35,7 @@ def upload_bank_statement():
@frappe.whitelist()
def create_bank_entries(columns, data, bank_account):
def create_bank_entries(columns: str, data: str, bank_account: str):
header_map = get_header_mapping(columns, bank_account)
success = 0

View File

@@ -2,27 +2,20 @@
# License: GNU General Public License v3. See license.txt
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import nowdate
from erpnext.accounts.doctype.bank_transaction.test_bank_transaction import create_bank_account
from erpnext.tests.utils import ERPNextTestSuite
IBAN_1 = "DE02000000003716541159"
IBAN_2 = "DE02500105170137075030"
class TestAutoMatchParty(IntegrationTestCase):
@classmethod
def setUpClass(cls):
class TestAutoMatchParty(ERPNextTestSuite):
def setUp(self):
create_bank_account()
frappe.db.set_single_value("Accounts Settings", "enable_party_matching", 1)
frappe.db.set_single_value("Accounts Settings", "enable_fuzzy_matching", 1)
return super().setUpClass()
@classmethod
def tearDownClass(cls):
frappe.db.set_single_value("Accounts Settings", "enable_party_matching", 0)
frappe.db.set_single_value("Accounts Settings", "enable_fuzzy_matching", 0)
def test_match_by_account_number(self):
create_supplier_for_match(account_no=IBAN_1[11:])

View File

@@ -6,7 +6,6 @@ import json
import frappe
from frappe import utils
from frappe.model.docstatus import DocStatus
from frappe.tests import IntegrationTestCase
from erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool import (
get_linked_payments,
@@ -19,12 +18,10 @@ from erpnext.accounts.doctype.payment_entry.test_payment_entry import get_paymen
from erpnext.accounts.doctype.pos_profile.test_pos_profile import make_pos_profile
from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import make_purchase_invoice
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.tests.utils import if_lending_app_installed
EXTRA_TEST_RECORD_DEPENDENCIES = ["Item", "Cost Center"]
from erpnext.tests.utils import ERPNextTestSuite, if_lending_app_installed
class TestBankTransaction(IntegrationTestCase):
class TestBankTransaction(ERPNextTestSuite):
def setUp(self):
make_pos_profile()

View File

@@ -2,8 +2,10 @@
# See license.txt
# import frappe
from frappe.tests import IntegrationTestCase
class TestBisectAccountingStatements(IntegrationTestCase):
from erpnext.tests.utils import ERPNextTestSuite
class TestBisectAccountingStatements(ERPNextTestSuite):
pass

View File

@@ -2,8 +2,10 @@
# See license.txt
# import frappe
from frappe.tests import IntegrationTestCase
class TestBisectNodes(IntegrationTestCase):
from erpnext.tests.utils import ERPNextTestSuite
class TestBisectNodes(ERPNextTestSuite):
pass

View File

@@ -2,14 +2,12 @@
# For license information, please see license.txt
from datetime import date
import frappe
from frappe import _
from frappe.model.document import Document
from frappe.query_builder.functions import Sum
from frappe.utils import add_months, flt, fmt_money, get_last_day, getdate, month_diff
from frappe.utils.data import get_first_day, nowdate
from frappe.utils import add_months, flt, fmt_money, get_last_day, getdate
from frappe.utils.data import get_first_day
from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import (
get_accounting_dimensions,
@@ -847,7 +845,7 @@ def get_fiscal_year_date_range(from_fiscal_year, to_fiscal_year):
@frappe.whitelist()
def revise_budget(budget_name):
def revise_budget(budget_name: str):
old_budget = frappe.get_doc("Budget", budget_name)
if old_budget.docstatus == 1:

View File

@@ -1,10 +1,8 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.client import submit
from frappe.utils import add_days, flt, get_first_day, get_last_day, getdate, now_datetime, nowdate
from frappe.utils import flt, now_datetime, nowdate
from erpnext.accounts.doctype.budget.budget import (
BudgetError,
@@ -19,12 +17,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestBudget(ERPNextTestSuite):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.make_monthly_distribution()
cls.make_projects()
def setUp(self):
frappe.db.set_single_value("Accounts Settings", "use_legacy_budget_controller", False)
self.company = "_Test Company"

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestCashierClosing(IntegrationTestCase):
class TestCashierClosing(ERPNextTestSuite):
pass

View File

@@ -57,7 +57,7 @@ def validate_columns(data):
@frappe.whitelist()
def validate_company(company):
def validate_company(company: str):
parent_company, allow_account_creation_against_child_company = frappe.get_cached_value(
"Company", company, ["parent_company", "allow_account_creation_against_child_company"]
)
@@ -74,7 +74,7 @@ def validate_company(company):
@frappe.whitelist()
def import_coa(file_name, company):
def import_coa(file_name: str, company: str):
# delete existing data for accounts
unset_existing_data(company)
@@ -159,7 +159,9 @@ def generate_data_from_excel(file_doc, extension, as_dict=False):
@frappe.whitelist()
def get_coa(doctype, parent, is_root=False, file_name=None, for_validate=0):
def get_coa(
doctype: str, parent: str, is_root: bool = False, file_name: str | None = None, for_validate: int = 0
):
"""called by tree view (to fetch node's children)"""
file_doc, extension = get_file(file_name)
@@ -307,7 +309,7 @@ def build_response_as_excel(writer):
@frappe.whitelist()
def download_template(file_type, template_type, company):
def download_template(file_type: str, template_type: str, company: str):
writer = get_template(template_type, company)
if file_type == "CSV":
@@ -361,7 +363,7 @@ def get_sample_template(writer, company):
@frappe.whitelist()
def validate_accounts(file_doc, extension):
def validate_accounts(file_doc: Document, extension: str):
if extension == "csv":
accounts = generate_data_from_csv(file_doc, as_dict=True)
else:

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestChartofAccountsImporter(IntegrationTestCase):
class TestChartofAccountsImporter(ERPNextTestSuite):
pass

View File

@@ -47,7 +47,7 @@ class ChequePrintTemplate(Document):
@frappe.whitelist()
def create_or_update_cheque_print_format(template_name):
def create_or_update_cheque_print_format(template_name: str):
if not frappe.db.exists("Print Format", template_name):
cheque_print = frappe.new_doc("Print Format")
cheque_print.update(

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestChequePrintTemplate(IntegrationTestCase):
class TestChequePrintTemplate(ERPNextTestSuite):
pass

View File

@@ -1,12 +1,12 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# License: GNU General Public License v3. See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestCostCenter(IntegrationTestCase):
class TestCostCenter(ERPNextTestSuite):
def test_cost_center_creation_against_child_node(self):
cost_center = frappe.get_doc(
{

View File

@@ -1,23 +0,0 @@
[
{
"company": "_Test Company",
"cost_center_name": "_Test Cost Center",
"doctype": "Cost Center",
"is_group": 0,
"parent_cost_center": "_Test Company - _TC"
},
{
"company": "_Test Company",
"cost_center_name": "_Test Cost Center 2",
"doctype": "Cost Center",
"is_group": 0,
"parent_cost_center": "_Test Company - _TC"
},
{
"company": "_Test Company",
"cost_center_name": "_Test Write Off Cost Center",
"doctype": "Cost Center",
"is_group": 0,
"parent_cost_center": "_Test Company - _TC"
}
]

View File

@@ -1,10 +1,8 @@
# Copyright (c) 2022, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.query_builder.functions import Sum
from frappe.tests import IntegrationTestCase
from frappe.utils import add_days, today
from erpnext.accounts.doctype.cost_center.test_cost_center import create_cost_center
@@ -16,9 +14,10 @@ from erpnext.accounts.doctype.cost_center_allocation.cost_center_allocation impo
WrongPercentageAllocation,
)
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.tests.utils import ERPNextTestSuite
class TestCostCenterAllocation(IntegrationTestCase):
class TestCostCenterAllocation(ERPNextTestSuite):
def setUp(self):
cost_centers = [
"Main Cost Center 1",
@@ -191,7 +190,7 @@ class TestCostCenterAllocation(IntegrationTestCase):
coa2.cancel()
jv.cancel()
@IntegrationTestCase.change_settings("System Settings", {"rounding_method": "Commercial Rounding"})
@ERPNextTestSuite.change_settings("System Settings", {"rounding_method": "Commercial Rounding"})
def test_debit_credit_on_cost_center_allocation_for_commercial_rounding(self):
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice

View File

@@ -1,13 +1,10 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from erpnext.selling.doctype.sales_order.test_sales_order import make_sales_order
EXTRA_TEST_RECORD_DEPENDENCIES = ["Item"]
from erpnext.tests.utils import ERPNextTestSuite
def test_create_test_data():
@@ -88,6 +85,7 @@ def test_create_test_data():
"partner_name": "_Test Coupon Partner",
"commission_rate": 2,
"referral_code": "COPART",
"territory": "All Territories",
}
)
sales_partner.insert()
@@ -110,13 +108,10 @@ def test_create_test_data():
coupon_code.insert()
class TestCouponCode(IntegrationTestCase):
class TestCouponCode(ERPNextTestSuite):
def setUp(self):
test_create_test_data()
def tearDown(self):
frappe.set_user("Administrator")
def test_sales_order_with_coupon_code(self):
frappe.db.set_value("Coupon Code", "SAVE30", "used", 0)

View File

@@ -101,11 +101,11 @@
"label": "Use HTTP Protocol"
}
],
"hide_toolbar": 1,
"hide_toolbar": 0,
"index_web_pages_for_search": 1,
"issingle": 1,
"links": [],
"modified": "2026-01-02 18:19:02.873815",
"modified": "2026-03-16 13:28:21.075743",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Currency Exchange Settings",

View File

@@ -1,10 +1,9 @@
# Copyright (c) 2021, Wahni Green Technologies Pvt. Ltd. and contributors
# For license information, please see license.txt
# import frappe
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestCurrencyExchangeSettings(IntegrationTestCase):
class TestCurrencyExchangeSettings(ERPNextTestSuite):
pass

View File

@@ -4,37 +4,20 @@ import json
import frappe
from frappe.model import mapper
from frappe.tests import IntegrationTestCase
from frappe.utils import add_days, nowdate, today
from erpnext import get_default_cost_center
from erpnext.accounts.doctype.payment_entry.test_payment_entry import get_payment_entry
from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import (
unlink_payment_on_cancel_of_invoice,
)
from erpnext.accounts.doctype.sales_invoice.sales_invoice import (
create_dunning as create_dunning_from_sales_invoice,
)
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import (
create_sales_invoice_against_cost_center,
)
EXTRA_TEST_RECORD_DEPENDENCIES = ["Company", "Cost Center"]
from erpnext.tests.utils import ERPNextTestSuite
class TestDunning(IntegrationTestCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
create_dunning_type("First Notice", fee=0.0, interest=0.0, is_default=1)
create_dunning_type("Second Notice", fee=10.0, interest=10.0, is_default=0)
unlink_payment_on_cancel_of_invoice()
@classmethod
def tearDownClass(cls):
unlink_payment_on_cancel_of_invoice(0)
super().tearDownClass()
class TestDunning(ERPNextTestSuite):
def test_dunning_without_fees(self):
dunning = create_dunning(overdue_days=20)

View File

@@ -1,10 +1,9 @@
# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
# import frappe
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestDunningType(IntegrationTestCase):
class TestDunningType(ERPNextTestSuite):
pass

View File

@@ -1,36 +0,0 @@
[
{
"doctype": "Dunning Type",
"dunning_type": "_Test First Notice",
"company": "_Test Company",
"is_default": 1,
"dunning_fee": 0.0,
"rate_of_interest": 0.0,
"dunning_letter_text": [
{
"language": "en",
"body_text": "We have still not received payment for our invoice",
"closing_text": "We kindly request that you pay the outstanding amount immediately, including interest and late fees."
}
],
"income_account": "Sales - _TC",
"cost_center": "_Test Cost Center - _TC"
},
{
"doctype": "Dunning Type",
"dunning_type": "_Test Second Notice",
"company": "_Test Company",
"is_default": 0,
"dunning_fee": 10.0,
"rate_of_interest": 10.0,
"dunning_letter_text": [
{
"language": "en",
"body_text": "We have still not received payment for our invoice",
"closing_text": "We kindly request that you pay the outstanding amount immediately, including interest and late fees."
}
],
"income_account": "Sales - _TC",
"cost_center": "_Test Cost Center - _TC"
}
]

View File

@@ -1,6 +1,7 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and contributors
# For license information, please see license.txt
from datetime import date
import frappe
from frappe import _, qb
@@ -614,7 +615,12 @@ def calculate_exchange_rate_using_last_gle(company, account, party_type, party):
@frappe.whitelist()
def get_account_details(
company, posting_date, account, party_type=None, party=None, rounding_loss_allowance: float | None = None
company: str,
posting_date: str | date,
account: str,
party_type: str | None = None,
party: str | None = None,
rounding_loss_allowance: float = 0.0,
):
if not (company and posting_date):
frappe.throw(_("Company and Posting Date is mandatory"))

View File

@@ -5,15 +5,15 @@
import frappe
from frappe.query_builder import functions
from frappe.query_builder.utils import DocType
from frappe.tests import IntegrationTestCase
from frappe.utils import add_days, flt, today
from erpnext.accounts.doctype.payment_entry.payment_entry import get_payment_entry
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.accounts.test.accounts_mixin import AccountsTestMixin
from erpnext.tests.utils import ERPNextTestSuite
class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
class TestExchangeRateRevaluation(AccountsTestMixin, ERPNextTestSuite):
def setUp(self):
self.create_company()
self.create_usd_receivable_account()
@@ -22,14 +22,13 @@ class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
self.clear_old_entries()
self.set_system_and_company_settings()
def tearDown(self):
frappe.db.rollback()
def set_system_and_company_settings(self):
# set number and currency precision
system_settings = frappe.get_doc("System Settings")
system_settings.float_precision = 2
system_settings.currency_precision = 2
system_settings.language = "en"
system_settings.time_zone = "Asia/Kolkata"
system_settings.save()
# Using Exchange Gain/Loss account for unrealized as well.
@@ -37,7 +36,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
company_doc.unrealized_exchange_gain_loss_account = company_doc.exchange_gain_loss_account
company_doc.save()
@IntegrationTestCase.change_settings(
@ERPNextTestSuite.change_settings(
"Accounts Settings",
{"allow_multi_currency_invoices_against_single_party_account": 1, "allow_stale": 0},
)
@@ -91,7 +90,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
)[0]
self.assertEqual(acc_balance.balance, 8500.0)
@IntegrationTestCase.change_settings(
@ERPNextTestSuite.change_settings(
"Accounts Settings",
{"allow_multi_currency_invoices_against_single_party_account": 1, "allow_stale": 0},
)
@@ -164,7 +163,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
self.assertEqual(acc_balance.balance, 0.0)
self.assertEqual(acc_balance.balance_in_account_currency, 0.0)
@IntegrationTestCase.change_settings(
@ERPNextTestSuite.change_settings(
"Accounts Settings",
{"allow_multi_currency_invoices_against_single_party_account": 1, "allow_stale": 0},
)
@@ -259,7 +258,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, IntegrationTestCase):
self.assertEqual(flt(acc_balance.balance, precision), 0.0)
self.assertEqual(flt(acc_balance.balance_in_account_currency, precision), 0.0)
@IntegrationTestCase.change_settings(
@ERPNextTestSuite.change_settings(
"Accounts Settings",
{"allow_multi_currency_invoices_against_single_party_account": 1, "allow_stale": 0},
)

View File

@@ -1,14 +1,13 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.tests.utils import ERPNextTestSuite
class TestFinanceBook(IntegrationTestCase):
class TestFinanceBook(ERPNextTestSuite):
def test_finance_book(self):
finance_book = create_finance_book()

View File

@@ -15,7 +15,7 @@ from frappe.database.operator_map import OPERATOR_MAP
from frappe.query_builder import Case
from frappe.query_builder.functions import Sum
from frappe.utils import cstr, date_diff, flt, getdate
from pypika.terms import LiteralValue
from pypika.terms import Bracket, LiteralValue
from erpnext import get_company_currency
from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import (
@@ -541,7 +541,7 @@ class FinancialQueryBuilder:
.where(acb_table.period_closing_voucher == closing_voucher)
)
query = self._apply_standard_filters(query, acb_table)
query = self._apply_standard_filters(query, acb_table, "Account Closing Balance")
results = self._execute_with_permissions(query, "Account Closing Balance")
for row in results:
@@ -636,12 +636,15 @@ class FinancialQueryBuilder:
return self._execute_with_permissions(query, "GL Entry")
def _calculate_running_balances(self, balances_data: dict, gl_data: list[dict]) -> dict:
for row in gl_data:
account = row["account"]
gl_dict = {row["account"]: row for row in gl_data}
accounts = set(balances_data.keys()) | set(gl_dict.keys())
for account in accounts:
if account not in balances_data:
balances_data[account] = AccountData(account=account, **self._get_account_meta(account))
account_data: AccountData = balances_data[account]
gl_movement = gl_dict.get(account, {})
if account_data.has_periods():
first_period = account_data.get_period(self.periods[0]["key"])
@@ -651,20 +654,13 @@ class FinancialQueryBuilder:
for period in self.periods:
period_key = period["key"]
movement = row.get(period_key, 0.0)
movement = gl_movement.get(period_key, 0.0)
closing_balance = current_balance + movement
account_data.add_period(PeriodValue(period_key, current_balance, closing_balance, movement))
current_balance = closing_balance
# Accounts with no movements
for account_data in balances_data.values():
for period in self.periods:
period_key = period["key"]
if period_key not in account_data.period_values:
account_data.add_period(PeriodValue(period_key, 0.0, 0.0, 0.0))
def _handle_balance_accumulation(self, balances_data):
for account_data in balances_data.values():
account_data: AccountData
@@ -683,12 +679,12 @@ class FinancialQueryBuilder:
else:
account_data.unaccumulate_values()
def _apply_standard_filters(self, query, table):
def _apply_standard_filters(self, query, table, doctype: str = "GL Entry"):
if self.filters.get("ignore_closing_entries"):
if hasattr(table, "is_period_closing_voucher_entry"):
query = query.where(table.is_period_closing_voucher_entry == 0)
else:
if doctype == "GL Entry":
query = query.where(table.voucher_type != "Period Closing Voucher")
else:
query = query.where(table.is_period_closing_voucher_entry == 0)
if self.filters.get("project"):
projects = self.filters.get("project")
@@ -736,7 +732,7 @@ class FinancialQueryBuilder:
user_conditions = build_match_conditions(doctype)
if user_conditions:
query = query.where(LiteralValue(user_conditions))
query = query.where(Bracket(LiteralValue(user_conditions)))
return query.run(as_dict=True)

View File

@@ -5,7 +5,6 @@ import os
import shutil
import frappe
from frappe import _
from frappe.model.document import Document
from erpnext.accounts.doctype.account_category.account_category import import_account_categories

View File

@@ -1,18 +1,15 @@
# Copyright (c) 2025, Frappe Technologies Pvt. Ltd. and contributors
# For license information, please see license.txt
import ast
import json
import re
from abc import ABC, abstractmethod
from dataclasses import dataclass, field
from enum import Enum
from typing import Any, ClassVar
from typing import Any
import frappe
from frappe import _
from frappe.database.operator_map import OPERATOR_MAP
from frappe.database.query import SQLFunctionParser
@dataclass

View File

@@ -5,24 +5,16 @@ import frappe
from frappe.utils import flt
from erpnext.accounts.doctype.financial_report_template.financial_report_engine import (
AccountData,
DataCollector,
DependencyResolver,
FilterExpressionParser,
FinancialQueryBuilder,
FormulaCalculator,
PeriodValue,
)
from erpnext.accounts.doctype.financial_report_template.test_financial_report_template import (
FinancialReportTemplateTestCase,
)
from erpnext.accounts.utils import get_currency_precision
# On IntegrationTestCase, the doctype test records and all
# link-field test record dependencies are recursively loaded
# Use these module variables to add/remove to/from that list
EXTRA_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
IGNORE_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.accounts.utils import get_currency_precision, get_fiscal_year
class TestDependencyResolver(FinancialReportTemplateTestCase):
@@ -1672,3 +1664,360 @@ class TestFilterExpressionParser(FinancialReportTemplateTestCase):
mock_row_invalid = self._create_mock_report_row(invalid_formula)
condition = parser.build_condition(mock_row_invalid, account_table)
self.assertIsNone(condition)
class TestFinancialQueryBuilder(FinancialReportTemplateTestCase):
def test_fetch_balances_with_journal_entries(self):
company = "_Test Company"
cash_account = "_Test Cash - _TC"
bank_account = "_Test Bank - _TC"
# Create journal entries in different periods
# October: Transfer 1000 from Bank to Cash
jv_oct = make_journal_entry(
account1=cash_account,
account2=bank_account,
amount=1000,
posting_date="2024-10-15",
company=company,
submit=True,
)
# November: Transfer 500 from Bank to Cash
jv_nov = make_journal_entry(
account1=cash_account,
account2=bank_account,
amount=500,
posting_date="2024-11-20",
company=company,
submit=True,
)
# December: No transactions (test zero movement period)
try:
# Set up filters and periods for Q4 2024
filters = {
"company": company,
"from_fiscal_year": "2024",
"to_fiscal_year": "2024",
"period_start_date": "2024-10-01",
"period_end_date": "2024-12-31",
"filter_based_on": "Date Range",
"periodicity": "Monthly",
}
periods = [
{"key": "2024_oct", "from_date": "2024-10-01", "to_date": "2024-10-31"},
{"key": "2024_nov", "from_date": "2024-11-01", "to_date": "2024-11-30"},
{"key": "2024_dec", "from_date": "2024-12-01", "to_date": "2024-12-31"},
]
query_builder = FinancialQueryBuilder(filters, periods)
# Create account objects as expected by fetch_account_balances
accounts = [
frappe._dict({"name": cash_account, "account_name": "Cash", "account_number": "1001"}),
frappe._dict({"name": bank_account, "account_name": "Bank", "account_number": "1002"}),
]
# Fetch balances using the full workflow
balances_data = query_builder.fetch_account_balances(accounts)
# Verify Cash account balances
cash_data = balances_data.get(cash_account)
self.assertIsNotNone(cash_data, "Cash account should exist in results")
# October: movement = +1000 (debit)
oct_cash = cash_data.get_period("2024_oct")
self.assertIsNotNone(oct_cash, "October period should exist for cash")
self.assertEqual(oct_cash.movement, 1000.0, "October cash movement should be 1000")
# November: movement = +500
nov_cash = cash_data.get_period("2024_nov")
self.assertIsNotNone(nov_cash, "November period should exist for cash")
self.assertEqual(nov_cash.movement, 500.0, "November cash movement should be 500")
self.assertEqual(
nov_cash.opening, oct_cash.closing, "November opening should equal October closing"
)
# December: movement = 0 (no transactions)
dec_cash = cash_data.get_period("2024_dec")
self.assertIsNotNone(dec_cash, "December period should exist for cash")
self.assertEqual(dec_cash.movement, 0.0, "December cash movement should be 0")
self.assertEqual(
dec_cash.closing,
nov_cash.closing,
"December closing should equal November closing when no movement",
)
# Verify Bank account balances (opposite direction)
bank_data = balances_data.get(bank_account)
self.assertIsNotNone(bank_data, "Bank account should exist in results")
oct_bank = bank_data.get_period("2024_oct")
self.assertEqual(oct_bank.movement, -1000.0, "October bank movement should be -1000")
nov_bank = bank_data.get_period("2024_nov")
self.assertEqual(nov_bank.movement, -500.0, "November bank movement should be -500")
finally:
# Clean up: cancel journal entries
jv_nov.cancel()
jv_oct.cancel()
def test_opening_balance_from_previous_period_closing(self):
company = "_Test Company"
cash_account = "_Test Cash - _TC"
sales_account = "Sales - _TC"
posting_date_2023 = "2023-06-15"
# Create journal entry in prior period (2023)
# Cash Dr 5000, Sales Cr 5000
jv_2023 = make_journal_entry(
account1=cash_account,
account2=sales_account,
amount=5000,
posting_date=posting_date_2023,
company=company,
submit=True,
)
pcv = None
jv_2024 = None
original_pcv_setting = frappe.db.get_single_value(
"Accounts Settings", "use_legacy_controller_for_pcv"
)
try:
# Create Period Closing Voucher for 2023
# This will create Account Closing Balance entries
closing_account = frappe.db.get_value(
"Account",
{
"company": company,
"root_type": "Liability",
"is_group": 0,
"account_type": ["not in", ["Payable", "Receivable"]],
},
"name",
)
fy_2023 = get_fiscal_year(posting_date_2023, company=company)
frappe.db.set_single_value("Accounts Settings", "use_legacy_controller_for_pcv", 1)
pcv = frappe.get_doc(
{
"doctype": "Period Closing Voucher",
"transaction_date": "2023-12-31",
"period_start_date": fy_2023[1],
"period_end_date": fy_2023[2],
"company": company,
"fiscal_year": fy_2023[0],
"cost_center": "_Test Cost Center - _TC",
"closing_account_head": closing_account,
"remarks": "Test Period Closing",
}
)
pcv.insert()
pcv.submit()
pcv.reload()
# Now create a small transaction in 2024 to ensure the account appears
jv_2024 = make_journal_entry(
account1=cash_account,
account2=sales_account,
amount=100,
posting_date="2024-01-15",
company=company,
submit=True,
)
# Set up filters for Q1 2024 (after the period closing)
filters = {
"company": company,
"from_fiscal_year": "2024",
"to_fiscal_year": "2024",
"period_start_date": "2024-01-01",
"period_end_date": "2024-03-31",
"filter_based_on": "Date Range",
"periodicity": "Monthly",
"ignore_closing_entries": True, # Don't include PCV entries in movements
}
periods = [
{"key": "2024_jan", "from_date": "2024-01-01", "to_date": "2024-01-31"},
{"key": "2024_feb", "from_date": "2024-02-01", "to_date": "2024-02-29"},
{"key": "2024_mar", "from_date": "2024-03-01", "to_date": "2024-03-31"},
]
query_builder = FinancialQueryBuilder(filters, periods)
accounts = [
frappe._dict({"name": cash_account, "account_name": "Cash", "account_number": "1001"}),
]
balances_data = query_builder.fetch_account_balances(accounts)
# Verify Cash account has opening balance from 2023 transactions
cash_data = balances_data.get(cash_account)
self.assertIsNotNone(cash_data, "Cash account should exist in results")
jan_cash = cash_data.get_period("2024_jan")
self.assertIsNotNone(jan_cash, "January period should exist")
# Opening balance should be from prior period
# Cash had 5000 debit in 2023, so opening in 2024 should be >= 5000
# (may be higher if there were other test transactions)
self.assertEqual(
jan_cash.opening,
5000.0,
"January opening should equal to balance from 2023 (5000)",
)
# Verify running balance logic
# Movement in January is 100 (from jv_2024)
self.assertEqual(jan_cash.movement, 100.0, "January movement should be 100")
self.assertEqual(
jan_cash.closing, jan_cash.opening + jan_cash.movement, "Closing = Opening + Movement"
)
# February and March should have no movement but carry the balance
feb_cash = cash_data.get_period("2024_feb")
self.assertEqual(feb_cash.opening, jan_cash.closing, "Feb opening = Jan closing")
self.assertEqual(feb_cash.movement, 0.0, "February should have no movement")
self.assertEqual(feb_cash.closing, feb_cash.opening, "Feb closing = opening when no movement")
mar_cash = cash_data.get_period("2024_mar")
self.assertEqual(mar_cash.opening, feb_cash.closing, "Mar opening = Feb closing")
self.assertEqual(mar_cash.movement, 0.0, "March should have no movement")
self.assertEqual(mar_cash.closing, mar_cash.opening, "Mar closing = opening when no movement")
# Set up filters for Q2 2024
filters_q2 = {
"company": company,
"from_fiscal_year": "2024",
"to_fiscal_year": "2024",
"period_start_date": "2024-04-01",
"period_end_date": "2024-06-30",
"filter_based_on": "Date Range",
"periodicity": "Monthly",
"ignore_closing_entries": True,
}
periods_q2 = [
{"key": "2024_apr", "from_date": "2024-04-01", "to_date": "2024-04-30"},
{"key": "2024_may", "from_date": "2024-05-01", "to_date": "2024-05-31"},
{"key": "2024_jun", "from_date": "2024-06-01", "to_date": "2024-06-30"},
]
query_builder_q2 = FinancialQueryBuilder(filters_q2, periods_q2)
balances_data_q2 = query_builder_q2.fetch_account_balances(accounts)
# Verify Cash account in Q2
cash_data_q2 = balances_data_q2.get(cash_account)
self.assertIsNotNone(cash_data_q2, "Cash account should exist in Q2 results")
apr_cash = cash_data_q2.get_period("2024_apr")
self.assertIsNotNone(apr_cash, "April period should exist")
# Opening balance in April should equal closing in March
self.assertEqual(
apr_cash.opening,
mar_cash.closing,
"April opening should equal March closing balance",
)
self.assertEqual(apr_cash.closing, apr_cash.opening, "April closing = opening when no movement")
finally:
# Clean up
frappe.db.set_single_value(
"Accounts Settings", "use_legacy_controller_for_pcv", original_pcv_setting or 0
)
if jv_2024:
jv_2024.cancel()
if pcv:
pcv.reload()
if pcv.docstatus == 1:
pcv.cancel()
jv_2023.cancel()
def test_account_with_gl_entries_but_no_prior_closing_balance(self):
company = "_Test Company"
cash_account = "_Test Cash - _TC"
bank_account = "_Test Bank - _TC"
# Create journal entries WITHOUT any prior Period Closing Voucher
# This ensures the account exists in gl_dict but NOT in balances_data
jv = make_journal_entry(
account1=cash_account,
account2=bank_account,
amount=2500,
posting_date="2024-07-15",
company=company,
submit=True,
)
try:
# Set up filters - use a period with no prior PCV
filters = {
"company": company,
"from_fiscal_year": "2024",
"to_fiscal_year": "2024",
"period_start_date": "2024-07-01",
"period_end_date": "2024-09-30",
"filter_based_on": "Date Range",
"periodicity": "Monthly",
}
periods = [
{"key": "2024_jul", "from_date": "2024-07-01", "to_date": "2024-07-31"},
{"key": "2024_aug", "from_date": "2024-08-01", "to_date": "2024-08-31"},
{"key": "2024_sep", "from_date": "2024-09-01", "to_date": "2024-09-30"},
]
query_builder = FinancialQueryBuilder(filters, periods)
# Use accounts that have GL entries but may not have Account Closing Balance
accounts = [
frappe._dict({"name": cash_account, "account_name": "Cash", "account_number": "1001"}),
frappe._dict({"name": bank_account, "account_name": "Bank", "account_number": "1002"}),
]
balances_data = query_builder.fetch_account_balances(accounts)
# Verify accounts are present in results even without prior closing balance
cash_data = balances_data.get(cash_account)
self.assertIsNotNone(cash_data, "Cash account should exist in results")
bank_data = balances_data.get(bank_account)
self.assertIsNotNone(bank_data, "Bank account should exist in results")
# Verify July has the movement from journal entry
jul_cash = cash_data.get_period("2024_jul")
self.assertIsNotNone(jul_cash, "July period should exist for cash")
self.assertEqual(jul_cash.movement, 2500.0, "July cash movement should be 2500")
jul_bank = bank_data.get_period("2024_jul")
self.assertIsNotNone(jul_bank, "July period should exist for bank")
self.assertEqual(jul_bank.movement, -2500.0, "July bank movement should be -2500")
# Verify subsequent periods exist with zero movement
aug_cash = cash_data.get_period("2024_aug")
self.assertIsNotNone(aug_cash, "August period should exist for cash")
self.assertEqual(aug_cash.movement, 0.0, "August cash movement should be 0")
self.assertEqual(aug_cash.opening, jul_cash.closing, "August opening = July closing")
sep_cash = cash_data.get_period("2024_sep")
self.assertIsNotNone(sep_cash, "September period should exist for cash")
self.assertEqual(sep_cash.movement, 0.0, "September cash movement should be 0")
self.assertEqual(sep_cash.opening, aug_cash.closing, "September opening = August closing")
finally:
jv.cancel()

View File

@@ -2,29 +2,16 @@
# For license information, please see license.txt
import frappe
from frappe.tests import IntegrationTestCase
from frappe.tests.utils import make_test_records
# On IntegrationTestCase, the doctype test records and all
# link-field test record dependencies are recursively loaded
# Use these module variables to add/remove to/from that list
EXTRA_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
IGNORE_TEST_RECORD_DEPENDENCIES = [] # eg. ["User"]
from erpnext.tests.utils import ERPNextTestSuite
class TestFinancialReportTemplate(IntegrationTestCase):
pass
class FinancialReportTemplateTestCase(IntegrationTestCase):
class FinancialReportTemplateTestCase(ERPNextTestSuite):
"""Utility class with common setup and helper methods for all test classes"""
@classmethod
def setUpClass(cls):
def setUp(self):
"""Set up test data"""
make_test_records("Company")
make_test_records("Fiscal Year")
cls.create_test_template()
self.create_test_template()
@classmethod
def create_test_template(cls):

View File

@@ -4,7 +4,7 @@
import frappe
from dateutil.relativedelta import relativedelta
from frappe import _
from frappe import _, cint
from frappe.model.document import Document
from frappe.utils import add_days, add_years, cstr, getdate
@@ -33,23 +33,11 @@ class FiscalYear(Document):
self.validate_dates()
self.validate_overlap()
if not self.is_new():
year_start_end_dates = frappe.db.sql(
"""select year_start_date, year_end_date
from `tabFiscal Year` where name=%s""",
(self.name),
)
def on_update(self):
frappe.cache().delete_key("fiscal_years")
if year_start_end_dates:
if (
getdate(self.year_start_date) != year_start_end_dates[0][0]
or getdate(self.year_end_date) != year_start_end_dates[0][1]
):
frappe.throw(
_(
"Cannot change Fiscal Year Start Date and Fiscal Year End Date once the Fiscal Year is saved."
)
)
def on_trash(self):
frappe.cache().delete_key("fiscal_years")
def validate_dates(self):
self.validate_from_to_dates("year_start_date", "year_end_date")
@@ -66,28 +54,20 @@ class FiscalYear(Document):
frappe.exceptions.InvalidDates,
)
def on_update(self):
check_duplicate_fiscal_year(self)
frappe.cache().delete_value("fiscal_years")
def on_trash(self):
frappe.cache().delete_value("fiscal_years")
def validate_overlap(self):
existing_fiscal_years = frappe.db.sql(
"""select name from `tabFiscal Year`
where (
(%(year_start_date)s between year_start_date and year_end_date)
or (%(year_end_date)s between year_start_date and year_end_date)
or (year_start_date between %(year_start_date)s and %(year_end_date)s)
or (year_end_date between %(year_start_date)s and %(year_end_date)s)
) and name!=%(name)s""",
{
"year_start_date": self.year_start_date,
"year_end_date": self.year_end_date,
"name": self.name or "No Name",
},
as_dict=True,
fy = frappe.qb.DocType("Fiscal Year")
name = self.name or self.year
existing_fiscal_years = (
frappe.qb.from_(fy)
.select(fy.name)
.where(
(fy.year_start_date <= self.year_end_date)
& (fy.year_end_date >= self.year_start_date)
& (fy.name != name)
)
.run(as_dict=True)
)
if existing_fiscal_years:
@@ -110,37 +90,30 @@ class FiscalYear(Document):
frappe.throw(
_(
"Year start date or end date is overlapping with {0}. To avoid please set company"
).format(existing.name),
).format(frappe.get_desk_link("Fiscal Year", existing.name, open_in_new_tab=True)),
frappe.NameError,
)
@frappe.whitelist()
def check_duplicate_fiscal_year(doc):
year_start_end_dates = frappe.db.sql(
"""select name, year_start_date, year_end_date from `tabFiscal Year` where name!=%s""",
(doc.name),
)
for fiscal_year, ysd, yed in year_start_end_dates:
if (getdate(doc.year_start_date) == ysd and getdate(doc.year_end_date) == yed) and (
not frappe.in_test
):
frappe.throw(
_(
"Fiscal Year Start Date and Fiscal Year End Date are already set in Fiscal Year {0}"
).format(fiscal_year)
)
@frappe.whitelist()
def auto_create_fiscal_year():
for d in frappe.db.sql(
"""select name from `tabFiscal Year` where year_end_date = date_add(current_date, interval 3 day)"""
):
fy = frappe.qb.DocType("Fiscal Year")
# Skipped auto-creating Short Year, as it has very rare use case.
# Reference: https://www.irs.gov/businesses/small-businesses-self-employed/tax-years (US)
follow_up_date = add_days(getdate(), days=3)
fiscal_year = (
frappe.qb.from_(fy)
.select(fy.name)
.where((fy.year_end_date == follow_up_date) & (fy.is_short_year == 0))
.run()
)
for d in fiscal_year:
try:
current_fy = frappe.get_doc("Fiscal Year", d[0])
new_fy = frappe.copy_doc(current_fy, ignore_no_copy=False)
new_fy = frappe.new_doc("Fiscal Year")
new_fy.disabled = cint(current_fy.disabled)
new_fy.year_start_date = add_days(current_fy.year_end_date, 1)
new_fy.year_end_date = add_years(current_fy.year_end_date, 1)
@@ -148,6 +121,10 @@ def auto_create_fiscal_year():
start_year = cstr(new_fy.year_start_date.year)
end_year = cstr(new_fy.year_end_date.year)
new_fy.year = start_year if start_year == end_year else (start_year + "-" + end_year)
for row in current_fy.companies:
new_fy.append("companies", {"company": row.company})
new_fy.auto_created = 1
new_fy.insert(ignore_permissions=True)

View File

@@ -1,15 +1,13 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# License: GNU General Public License v3. See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import now_datetime
IGNORE_TEST_RECORD_DEPENDENCIES = ["Company"]
from erpnext.tests.utils import ERPNextTestSuite
class TestFiscalYear(IntegrationTestCase):
class TestFiscalYear(ERPNextTestSuite):
def test_extra_year(self):
if frappe.db.exists("Fiscal Year", "_Test Fiscal Year 2000"):
frappe.delete_doc("Fiscal Year", "_Test Fiscal Year 2000")

View File

@@ -15,20 +15,22 @@
"ignore_user_permissions": 1,
"in_list_view": 1,
"label": "Company",
"options": "Company"
"options": "Company",
"reqd": 1
}
],
"index_web_pages_for_search": 1,
"istable": 1,
"links": [],
"modified": "2024-03-27 13:09:44.659251",
"modified": "2026-02-20 23:02:26.193606",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Fiscal Year Company",
"owner": "Administrator",
"permissions": [],
"row_format": "Dynamic",
"sort_field": "creation",
"sort_order": "DESC",
"states": [],
"track_changes": 1
}
}

View File

@@ -14,7 +14,7 @@ class FiscalYearCompany(Document):
if TYPE_CHECKING:
from frappe.types import DF
company: DF.Link | None
company: DF.Link
parent: DF.Data
parentfield: DF.Data
parenttype: DF.Data

View File

@@ -5,6 +5,7 @@
"doctype": "DocType",
"document_type": "Document",
"engine": "InnoDB",
"is_submittable": 1,
"field_order": [
"dates_section",
"posting_date",

View File

@@ -1,16 +1,15 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# License: GNU General Public License v3. See license.txt
import unittest
import frappe
from frappe.model.naming import parse_naming_series
from frappe.tests import IntegrationTestCase
from erpnext.accounts.doctype.gl_entry.gl_entry import rename_gle_sle_docs
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.tests.utils import ERPNextTestSuite
class TestGLEntry(IntegrationTestCase):
class TestGLEntry(ERPNextTestSuite):
def test_round_off_entry(self):
frappe.db.set_value("Company", "_Test Company", "round_off_account", "_Test Write Off - _TC")
frappe.db.set_value("Company", "_Test Company", "round_off_cost_center", "_Test Cost Center - _TC")

View File

@@ -317,7 +317,7 @@ class InvoiceDiscounting(AccountsController):
@frappe.whitelist()
def get_invoices(filters):
def get_invoices(filters: str):
filters = frappe._dict(json.loads(filters))
cond = []
if filters.customer:

View File

@@ -1,18 +1,17 @@
# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
import frappe
from frappe.tests import IntegrationTestCase
from frappe.utils import add_days, flt, nowdate
from erpnext.accounts.doctype.account.test_account import create_account
from erpnext.accounts.doctype.journal_entry.journal_entry import get_payment_entry_against_invoice
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.stock.doctype.purchase_receipt.test_purchase_receipt import get_gl_entries
from erpnext.tests.utils import ERPNextTestSuite
class TestInvoiceDiscounting(IntegrationTestCase):
class TestInvoiceDiscounting(ERPNextTestSuite):
def setUp(self):
self.ar_credit = create_account(
account_name="_Test Accounts Receivable Credit",

View File

@@ -1,9 +1,8 @@
# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
# See license.txt
import unittest
from frappe.tests import IntegrationTestCase
from erpnext.tests.utils import ERPNextTestSuite
class TestItemTaxTemplate(IntegrationTestCase):
class TestItemTaxTemplate(ERPNextTestSuite):
pass

View File

@@ -1,79 +0,0 @@
[
{
"doctype": "Item Tax Template",
"title": "_Test Account Excise Duty @ 10",
"company": "_Test Company",
"taxes": [
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 10,
"tax_type": "_Test Account Excise Duty - _TC"
}
]
},
{
"doctype": "Item Tax Template",
"title": "_Test Account Excise Duty @ 12",
"company": "_Test Company",
"taxes": [
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 12,
"tax_type": "_Test Account Excise Duty - _TC"
}
]
},
{
"doctype": "Item Tax Template",
"title": "_Test Account Excise Duty @ 15",
"company": "_Test Company",
"taxes": [
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 15,
"tax_type": "_Test Account Excise Duty - _TC"
}
]
},
{
"doctype": "Item Tax Template",
"title": "_Test Account Excise Duty @ 20",
"company": "_Test Company",
"taxes": [
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 20,
"tax_type": "_Test Account Excise Duty - _TC"
}
]
},
{
"doctype": "Item Tax Template",
"title": "_Test Item Tax Template 1",
"company": "_Test Company",
"taxes": [
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 5,
"tax_type": "_Test Account Excise Duty - _TC"
},
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 10,
"tax_type": "_Test Account Education Cess - _TC"
},
{
"doctype": "Item Tax Template Detail",
"parentfield": "taxes",
"tax_rate": 15,
"tax_type": "_Test Account S&H Education Cess - _TC"
}
]
}
]

View File

@@ -277,7 +277,21 @@ frappe.ui.form.on("Journal Entry", {
var update_jv_details = function (doc, r) {
$.each(r, function (i, d) {
var row = frappe.model.add_child(doc, "Journal Entry Account", "accounts");
frappe.model.set_value(row.doctype, row.name, "account", d.account);
const {
idx,
name,
owner,
parent,
parenttype,
parentfield,
creation,
modified,
modified_by,
doctype,
docstatus,
...fields
} = d;
frappe.model.set_value(row.doctype, row.name, fields);
});
refresh_field("accounts");
};
@@ -289,10 +303,6 @@ erpnext.accounts.JournalEntry = class JournalEntry extends frappe.ui.form.Contro
erpnext.accounts.dimensions.setup_dimension_filters(this.frm, this.frm.doctype);
}
onload_post_render() {
this.frm.get_field("accounts").grid.set_multiple_add("account");
}
load_defaults() {
//this.frm.show_print_first = true;
if (this.frm.doc.__islocal && this.frm.doc.company) {

Some files were not shown because too many files have changed in this diff Show More