refactor(test): remove redundant tearDown, tearDownClass and rollback

This commit is contained in:
ruthra kumar
2026-01-30 14:31:29 +05:30
parent 8090caa026
commit 12ae84401a
88 changed files with 0 additions and 332 deletions

View File

@@ -77,11 +77,6 @@ class TestAccountingDimension(ERPNextTestSuite):
si.save()
self.assertRaises(frappe.ValidationError, si.submit)
def tearDown(self):
disable_dimension()
frappe.flags.accounting_dimensions_details = None
frappe.flags.dimension_filter_map = None
def create_dimension():
frappe.set_user("Administrator")

View File

@@ -43,17 +43,6 @@ class TestAccountingDimensionFilter(ERPNextTestSuite):
self.assertRaises(MandatoryAccountDimensionError, si.submit)
self.invoice_list.append(si)
def tearDown(self):
disable_dimension_filter()
disable_dimension()
frappe.flags.accounting_dimensions_details = None
frappe.flags.dimension_filter_map = None
for si in self.invoice_list:
si.load_from_db()
if si.docstatus == 1:
si.cancel()
def create_accounting_dimension_filter():
if not frappe.db.get_value("Accounting Dimension Filter", {"accounting_dimension": "Cost Center"}):

View File

@@ -87,10 +87,6 @@ class TestAccountingPeriod(ERPNextTestSuite):
doc.submit() # Should not raise
self.assertEqual(doc.docstatus, 1)
def tearDown(self):
for d in frappe.get_all("Accounting Period"):
frappe.delete_doc("Accounting Period", d.name)
def create_accounting_period(**args):
args = frappe._dict(args)

View File

@@ -4,13 +4,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsSettings(ERPNextTestSuite):
def tearDown(self):
# Just in case `save` method succeeds, we need to take things back to default so that other tests
# don't break
cur_settings = frappe.get_doc("Accounts Settings", "Accounts Settings")
cur_settings.allow_stale = 1
cur_settings.save()
def test_stale_days(self):
cur_settings = frappe.get_doc("Accounts Settings", "Accounts Settings")
cur_settings.allow_stale = 0

View File

@@ -28,9 +28,6 @@ class TestAdvancePaymentLedgerEntry(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_sales_order(self, qty=1, rate=100, currency="INR", do_not_submit=False):
"""
Helper method

View File

@@ -24,9 +24,6 @@ class TestBankReconciliationTool(AccountsTestMixin, ERPNextTestSuite):
qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()
self.create_bank_account()
def tearDown(self):
frappe.db.rollback()
def create_bank_account(self):
bank = frappe.get_doc(
{

View File

@@ -112,9 +112,6 @@ class TestCouponCode(ERPNextTestSuite):
def setUp(self):
test_create_test_data()
def tearDown(self):
frappe.set_user("Administrator")
def test_sales_order_with_coupon_code(self):
frappe.db.set_value("Coupon Code", "SAVE30", "used", 0)

View File

@@ -22,9 +22,6 @@ class TestExchangeRateRevaluation(AccountsTestMixin, ERPNextTestSuite):
self.clear_old_entries()
self.set_system_and_company_settings()
def tearDown(self):
frappe.db.rollback()
def set_system_and_company_settings(self):
# set number and currency precision
system_settings = frappe.get_doc("System Settings")

View File

@@ -150,7 +150,6 @@ class TestJournalEntry(ERPNextTestSuite):
if account_bal == stock_bal:
self.assertRaises(StockAccountInvalidTransaction, jv.save)
frappe.db.rollback()
else:
jv.submit()
jv.cancel()

View File

@@ -17,9 +17,6 @@ class TestLedgerHealth(AccountsTestMixin, ERPNextTestSuite):
self.configure_monitoring_tool()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def configure_monitoring_tool(self):
monitor_settings = frappe.get_doc("Ledger Health Monitor")
monitor_settings.enable_health_monitor = True

View File

@@ -100,16 +100,3 @@ class TestLedgerMerge(ERPNextTestSuite):
self.assertFalse(frappe.db.exists("Account", "Indirect Test Income - _TC"))
self.assertTrue(frappe.db.exists("Account", "Administrative Test Income - _TC"))
def tearDown(self):
for entry in frappe.db.get_all("Ledger Merge"):
frappe.delete_doc("Ledger Merge", entry.name)
test_accounts = [
"Indirect Test Expenses - _TC",
"Administrative Test Expenses - _TC",
"Indirect Test Income - _TC",
"Administrative Test Income - _TC",
]
for account in test_accounts:
frappe.delete_doc_if_exists("Account", account)

View File

@@ -147,9 +147,6 @@ class TestOpeningInvoiceCreationTool(ERPNextTestSuite):
}
self.check_expected_values(invoices, expected_value, invoice_type="Sales")
def tearDown(self):
disable_dimension()
def get_opening_invoice_creation_dict(**args):
party = "Customer" if args.get("invoice_type", "Sales") == "Sales" else "Supplier"

View File

@@ -27,9 +27,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestPaymentEntry(ERPNextTestSuite):
def tearDown(self):
frappe.db.rollback()
def get_journals_for(self, voucher_type: str, voucher_no: str) -> list:
journals = []
if voucher_type and voucher_no:

View File

@@ -21,9 +21,6 @@ class TestPaymentLedgerEntry(ERPNextTestSuite):
self.create_customer()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_company(self):
company_name = "_Test Payment Ledger"
company = None

View File

@@ -26,9 +26,6 @@ class TestPaymentOrder(ERPNextTestSuite):
gl_account=self.gl_account, bank_account_name="Checking Account " + uniq_identifier
)
def tearDown(self):
frappe.db.rollback()
def test_payment_order_creation_against_payment_entry(self):
purchase_invoice = make_purchase_invoice()
payment_entry = get_payment_entry(

View File

@@ -28,9 +28,6 @@ class TestPaymentReconciliation(ERPNextTestSuite):
self.create_cost_center()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_company(self):
company = None
if frappe.db.exists("Company", "_Test Payment Reconciliation"):

View File

@@ -98,9 +98,6 @@ class TestPaymentRequest(ERPNextTestSuite):
self._get_payment_gateway_controller = _get_payment_gateway_controller.start()
self.addCleanup(_get_payment_gateway_controller.stop)
def tearDown(self):
frappe.db.rollback()
def test_payment_request_linkings(self):
so_inr = make_sales_order(currency="INR", do_not_save=True)
so_inr.disable_rounded_total = 1

View File

@@ -7,9 +7,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestPaymentTermsTemplate(ERPNextTestSuite):
def tearDown(self):
frappe.delete_doc("Payment Terms Template", "_Test Payment Terms Template For Test", force=1)
def test_create_template(self):
template = frappe.get_doc(
{

View File

@@ -39,10 +39,6 @@ class TestPOSClosingEntry(ERPNextTestSuite):
frappe.db.sql("delete from `tabPOS Opening Entry`")
make_stock_entry(target="_Test Warehouse - _TC", qty=2, basic_rate=100)
def tearDown(self):
frappe.set_user("Administrator")
frappe.db.sql("delete from `tabPOS Profile`")
def test_pos_closing_entry(self):
test_user, pos_profile = init_user_and_profile()
opening_entry = create_opening_entry(pos_profile, test_user.name)

View File

@@ -45,9 +45,6 @@ class POSInvoiceTestMixin(ERPNextTestSuite):
mode_of_payment = frappe.get_doc("Mode of Payment", "Bank Draft")
set_default_account_for_mode_of_payment(mode_of_payment, "_Test Company", "_Test Bank - _TC")
def tearDown(self):
frappe.db.rollback()
class TestPOSInvoice(POSInvoiceTestMixin):
def setUp(self):

View File

@@ -23,10 +23,6 @@ class TestPOSInvoiceMerging(POSInvoiceTestMixin):
self.opening_entry = create_opening_entry(self.pos_profile, self.test_user.name)
def tearDown(self):
self.clear_pos_data()
frappe.db.commit()
def test_merging_into_sales_invoice_with_discount(self):
from erpnext.accounts.doctype.pos_closing_entry.pos_closing_entry import (
make_closing_entry_from_opening,

View File

@@ -33,11 +33,6 @@ class TestPOSInvoiceMergeLog(ERPNextTestSuite):
def setUp(self):
frappe.db.sql("delete from `tabPOS Invoice`")
def tearDown(self):
frappe.set_user("Administrator")
frappe.db.sql("delete from `tabPOS Profile`")
frappe.db.sql("delete from `tabPOS Invoice`")
def test_consolidated_invoice_creation(self):
test_user, pos_profile = init_user_and_profile()
opening_entry = create_opening_entry(pos_profile, test_user.name)

View File

@@ -30,10 +30,6 @@ class TestPOSOpeningEntry(ERPNextTestSuite):
self.init_user_and_profile = init_user_and_profile
def tearDown(self):
frappe.set_user("Administrator")
frappe.db.sql("delete from `tabPOS Profile`")
def test_pos_opening_entry(self):
test_user, pos_profile = self.init_user_and_profile()
opening_entry = create_opening_entry(pos_profile, test_user.name)

View File

@@ -19,9 +19,6 @@ class TestPricingRule(ERPNextTestSuite):
setup_pricing_rule_data()
self.enterClassContext(self.change_settings("Selling Settings", validate_selling_price=0))
def tearDown(self):
delete_existing_pricing_rules()
def test_pricing_rule_for_discount(self):
from frappe import MandatoryError

View File

@@ -101,9 +101,6 @@ class TestProcessStatementOfAccounts(AccountsTestMixin, ERPNextTestSuite):
for age_range in expected_ageing:
self.assertEqual(expected_ageing[age_range], ageing.get(age_range))
def tearDown(self):
frappe.db.rollback()
def create_process_soa(**args):
args = frappe._dict(args)

View File

@@ -28,9 +28,6 @@ class TestRepostAccountingLedger(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
update_repost_settings()
def tearDown(self):
frappe.db.rollback()
def test_01_basic_functions(self):
si = create_sales_invoice(
item=self.item,

View File

@@ -86,9 +86,6 @@ class TestSalesInvoice(ERPNextTestSuite):
pi.submit()
self.assertIn("Rate must be same", str(e.exception))
def tearDown(self):
frappe.db.rollback()
def make(self):
w = frappe.copy_doc(self.globalTestRecords["Sales Invoice"][0])
w.is_pos = 0

View File

@@ -27,9 +27,6 @@ class TestSubscription(ERPNextTestSuite):
reset_settings()
frappe.db.set_value("Company", "_Test Company", "accounts_frozen_till_date", None)
def tearDown(self):
frappe.db.rollback()
def test_create_subscription_with_trial_with_correct_period(self):
subscription = create_subscription(
trial_period_start=nowdate(), trial_period_end=add_months(nowdate(), 1)

View File

@@ -22,9 +22,6 @@ class TestTaxWithholdingCategory(ERPNextTestSuite):
create_tax_withholding_category_records()
make_pan_no_field()
def tearDown(self):
frappe.db.rollback()
def validate_tax_withholding_entries(self, doctype, docname, expected_entries):
"""Validate tax withholding entries for a document"""
entries = frappe.get_all(

View File

@@ -23,9 +23,6 @@ class TestUnreconcilePayment(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_sales_invoice(self, do_not_submit=False):
si = create_sales_invoice(
item=self.item,

View File

@@ -15,9 +15,6 @@ class TestAccountsPayable(AccountsTestMixin, ERPNextTestSuite):
self.create_supplier(currency="USD", supplier_name="Test Supplier2")
self.create_usd_payable_account()
def tearDown(self):
frappe.db.rollback()
def test_accounts_payable_for_foreign_currency_supplier(self):
pi = self.create_purchase_invoice(do_not_submit=True)
pi.currency = "USD"

View File

@@ -18,9 +18,6 @@ class TestAccountsReceivable(AccountsTestMixin, ERPNextTestSuite):
self.create_usd_receivable_account()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_sales_invoice(self, no_payment_schedule=False, do_not_submit=False, **args):
frappe.set_user("Administrator")
si = create_sales_invoice(

View File

@@ -16,9 +16,6 @@ class TestAccountsReceivable(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def test_01_receivable_summary_output(self):
"""
Test for Invoices, Paid, Advance and Outstanding

View File

@@ -17,9 +17,6 @@ class TestCustomerLedgerSummary(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_sales_invoice(self, do_not_submit=False, **args):
si = create_sales_invoice(
item=self.item,

View File

@@ -67,9 +67,6 @@ class TestDeferredRevenueAndExpense(ERPNextTestSuite, AccountsTestMixin):
self.setup_deferred_accounts_and_items()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
@ERPNextTestSuite.change_settings("Accounts Settings", {"book_deferred_entries_based_on": "Months"})
def test_deferred_revenue(self):
self.create_item("_Test Internet Subscription", 0, self.warehouse, self.company)

View File

@@ -15,9 +15,6 @@ class TestGeneralAndPaymentLedger(ERPNextTestSuite, AccountsTestMixin):
self.create_company()
self.cleanup()
def tearDown(self):
frappe.db.rollback()
def cleanup(self):
doctypes = []
doctypes.append(qb.DocType("GL Entry"))

View File

@@ -21,9 +21,6 @@ class TestGrossProfit(ERPNextTestSuite):
self.create_sales_invoice()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_company(self):
company_name = "_Test Gross Profit"
abbr = "_GP"

View File

@@ -13,9 +13,6 @@ class TestItemWisePurchaseRegister(AccountsTestMixin, ERPNextTestSuite):
self.create_supplier()
self.create_item()
def tearDown(self):
frappe.db.rollback()
def create_purchase_invoice(self, do_not_submit=False):
pi = make_purchase_invoice(
item=self.item,

View File

@@ -13,9 +13,6 @@ class TestItemWiseSalesRegister(AccountsTestMixin, ERPNextTestSuite):
self.create_customer()
self.create_item()
def tearDown(self):
frappe.db.rollback()
def create_sales_invoice(self, item=None, taxes=None, do_not_submit=False):
si = create_sales_invoice(
item=item or self.item,

View File

@@ -18,9 +18,6 @@ class TestProfitAndLossStatement(AccountsTestMixin, ERPNextTestSuite):
self.create_customer()
self.create_item()
def tearDown(self):
frappe.db.rollback()
def create_sales_invoice(self, qty=1, rate=150, no_payment_schedule=False, do_not_submit=False):
frappe.set_user("Administrator")
si = create_sales_invoice(

View File

@@ -14,9 +14,6 @@ class TestItemWiseSalesRegister(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.create_child_cost_center()
def tearDown(self):
frappe.db.rollback()
def create_child_cost_center(self):
cc_name = "South Wing"
if frappe.db.exists("Cost Center", cc_name):

View File

@@ -14,9 +14,6 @@ class TestSupplierLedgerSummary(AccountsTestMixin, ERPNextTestSuite):
self.create_item()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_purchase_invoice(self, do_not_submit=False):
frappe.set_user("Administrator")
pi = make_purchase_invoice(

View File

@@ -126,9 +126,6 @@ class TestTaxWithholdingDetails(AccountsTestMixin, ERPNextTestSuite):
)
self.assertSequenceEqual(voucher_actual_values, voucher_expected_values)
def tearDown(self):
self.clear_old_entries()
def create_tax_accounts():
account_names = ["TCS", "TDS"]

View File

@@ -62,10 +62,6 @@ class TestTrialBalance(ERPNextTestSuite):
total_row = execute(filters)[1][-1]
self.assertEqual(total_row["debit"], total_row["credit"])
def tearDown(self):
clear_dimension_defaults("Branch")
disable_dimension()
def create_company(**args):
args = frappe._dict(args)

View File

@@ -22,10 +22,6 @@ class TestUtils(ERPNextTestSuite):
super().setUpClass()
make_test_objects("Address", ADDRESS_RECORDS)
@classmethod
def tearDownClass(cls):
frappe.db.rollback()
def test_get_party_shipping_address(self):
address = get_party_shipping_address("Customer", "_Test Customer 1")
self.assertEqual(address, "_Test Billing Address 2 Title-Billing")

View File

@@ -17,10 +17,6 @@ class TestAssetShiftAllocation(ERPNextTestSuite):
super().setUpClass()
create_asset_shift_factors()
@classmethod
def tearDownClass(cls):
frappe.db.rollback()
def test_asset_shift_allocation(self):
asset = create_asset(
calculate_depreciation=1,

View File

@@ -27,9 +27,6 @@ class TestRequestedItemsToOrderAndReceive(ERPNextTestSuite):
item_code="Test MR Report Item",
)
def tearDown(self) -> None:
frappe.db.rollback()
def test_date_range(self):
data = get_data(self.filters)
self.assertEqual(len(data), 2) # MRs today should be fetched

View File

@@ -73,9 +73,6 @@ class TestAccountsController(ERPNextTestSuite):
self.create_parties()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def create_company(self):
company_name = "_Test Company"
self.company_abbr = abbr = "_TC"

View File

@@ -125,12 +125,3 @@ class TestTaxes(ERPNextTestSuite):
doc.insert()
self.assertEqual(doc.taxes[0].tax_amount, 600)
self.created_docs.append(doc)
def tearDown(self):
for doc in self.created_docs:
doc.delete()
self.item.delete()
self.item_group.delete()
self.item_tax_template.delete()
self.account.delete()
self.company.delete()

View File

@@ -15,9 +15,6 @@ class TestReactivity(AccountsTestMixin, ERPNextTestSuite):
self.create_price_list()
self.clear_old_entries()
def tearDown(self):
frappe.db.rollback()
def disable_dimensions(self):
res = frappe.db.get_all("Accounting Dimension", filters={"disabled": False})
for x in res:

View File

@@ -16,19 +16,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestPlaidSettings(ERPNextTestSuite):
def setUp(self):
pass
def tearDown(self):
for bt in frappe.get_all("Bank Transaction"):
doc = frappe.get_doc("Bank Transaction", bt.name)
doc.cancel()
doc.delete()
for doctype in ("Bank Account", "Bank Account Type", "Bank Account Subtype"):
for d in frappe.get_all(doctype):
frappe.delete_doc(doctype, d.name, force=True)
def test_plaid_disabled(self):
frappe.db.set_single_value("Plaid Settings", "enabled", 0)
self.assertTrue(get_plaid_configuration() == "disabled")

View File

@@ -140,8 +140,6 @@ class TestMaintenanceSchedule(ERPNextTestSuite):
serial_nos = get_serial_nos_from_schedule(mvi.item_name, ms.name)
self.assertEqual(serial_nos, ["TEST001", "TEST002"])
frappe.db.rollback()
def test_schedule_with_serials(self):
# Checks whether serials are automatically updated when changing in items table.
# Also checks if other fields trigger generate schdeule if changed in items table.
@@ -170,8 +168,6 @@ class TestMaintenanceSchedule(ERPNextTestSuite):
ms.save()
self.assertEqual(len(ms.schedules), 2)
frappe.db.rollback()
def make_serial_item_with_serial(self, item_code):
serial_item_doc = create_item(item_code, is_stock_item=1)

View File

@@ -34,9 +34,6 @@ class TestBOMUpdateLog(ERPNextTestSuite):
self.new_bom_doc = bom_doc
def tearDown(self):
frappe.db.rollback()
def test_bom_update_log_validate(self):
"""
1) Test if BOM presence is validated.

View File

@@ -21,9 +21,6 @@ class TestBOMUpdateTool(ERPNextTestSuite):
super().setUpClass()
cls.load_test_records("BOM")
def tearDown(self):
frappe.db.rollback()
@timeout
def test_replace_bom(self):
current_bom = "BOM-_Test Item Home Desktop Manufactured-001"

View File

@@ -69,9 +69,6 @@ class TestJobCard(ERPNextTestSuite):
basic_rate=100,
)
def tearDown(self):
frappe.db.rollback()
def test_quality_inspection_mandatory_check(self):
from erpnext.manufacturing.doctype.operation.test_operation import make_operation

View File

@@ -56,9 +56,6 @@ class TestProductionPlan(ERPNextTestSuite):
if not frappe.db.get_value("BOM", {"item": item}):
make_bom(item=item, raw_materials=raw_materials)
def tearDown(self) -> None:
frappe.db.rollback()
def test_production_plan_mr_creation(self):
"Test if MRs are created for unavailable raw materials."
pln = create_production_plan(item_code="Test Production Item 1")
@@ -972,8 +969,6 @@ class TestProductionPlan(ERPNextTestSuite):
self.assertEqual(pln.po_items[0].item_code, "PIV-RED")
self.assertEqual(pln.po_items[0].bom_no, parent_bom.name)
frappe.db.rollback()
def test_get_sales_order_items_for_product_bundle(self):
"""Testing the Planned Qty for Product Bundle Item"""
from erpnext.manufacturing.doctype.work_order.test_work_order import (

View File

@@ -42,10 +42,6 @@ class TestWorkOrder(ERPNextTestSuite):
self.item = "_Test Item"
prepare_data_for_backflush_based_on_materials_transferred()
def tearDown(self):
frappe.local.future_sle = {}
frappe.db.rollback()
def check_planned_qty(self):
planned0 = (
frappe.db.get_value(

View File

@@ -7,9 +7,6 @@ class TestManufacturingReports(ERPNextTestSuite):
def setUp(self):
self.setup_default_filters()
def tearDown(self):
frappe.db.rollback()
def setup_default_filters(self):
self.last_bom = frappe.get_last_doc("BOM").name
self.DEFAULT_FILTERS = {

View File

@@ -41,7 +41,3 @@ class TestDelayedTasksSummary(ERPNextTestSuite):
for key in ["subject", "status", "priority", "delay"]:
self.assertEqual(expected_data[1].get(key), data.get(key))
def tearDown(self):
for task in ["_Test Task 98", "_Test Task 99"]:
frappe.get_doc("Task", {"subject": task}).delete()

View File

@@ -41,10 +41,6 @@ class TestVATAuditReport(TestCase):
make_sales_invoices()
create_purchase_invoices()
def tearDown(self):
frappe.db.sql("delete from `tabSales Invoice` where company='_Test Company SA VAT'")
frappe.db.sql("delete from `tabPurchase Invoice` where company='_Test Company SA VAT'")
def test_vat_audit_report(self):
filters = {"company": "_Test Company SA VAT", "from_date": today(), "to_date": today()}
columns, data = execute(filters)

View File

@@ -18,9 +18,6 @@ from erpnext.tests.utils import ERPNextTestSuite, create_test_contact_and_addres
class TestCustomer(ERPNextTestSuite):
def tearDown(self):
set_credit_limit("_Test Customer", "_Test Company", 0)
def test_get_customer_group_details(self):
doc = frappe.new_doc("Customer Group")
doc.customer_group_name = "_Testing Customer Group"
@@ -180,8 +177,6 @@ class TestCustomer(ERPNextTestSuite):
# rename back to original
frappe.rename_doc("Customer", new_name, "_Test Customer 1")
frappe.db.rollback()
def test_freezed_customer(self):
frappe.db.set_value("Customer", "_Test Customer", "is_frozen", 1)

View File

@@ -54,9 +54,6 @@ class TestSalesOrder(AccountsTestMixin, ERPNextTestSuite):
def setUp(self):
self.create_customer("_Test Customer Credit")
def tearDown(self):
frappe.db.rollback()
@IntegrationTestCase.change_settings(
"Stock Settings",
{

View File

@@ -13,9 +13,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestPaymentTermsStatusForSalesOrder(ERPNextTestSuite):
def tearDown(self):
frappe.db.rollback()
def create_payment_terms_template(self):
# create template for 50-50 payments
template = None

View File

@@ -17,9 +17,6 @@ class TestSalesPartnerTargetVarianceBasedOnItemGroup(ERPNextTestSuite):
def setUp(self):
self.fiscal_year = get_fiscal_year(nowdate())[0]
def tearDown(self):
frappe.db.rollback()
def test_achieved_target_and_variance_for_partner(self):
# Create a Target Distribution
distribution = create_target_distribution(self.fiscal_year)

View File

@@ -13,9 +13,6 @@ class TestSalesPersonTargetVarianceBasedOnItemGroup(ERPNextTestSuite):
def setUp(self):
self.fiscal_year = get_fiscal_year(nowdate())[0]
def tearDown(self):
frappe.db.rollback()
def test_achieved_target_and_variance(self):
# Create a Target Distribution
distribution = create_target_distribution(self.fiscal_year)

View File

@@ -89,10 +89,6 @@ class TestCurrencyExchange(ERPNextTestSuite):
key = "currency_exchange_rate_{}:{}:{}".format(date, "USD", "INR")
cache.delete(key)
def tearDown(self):
frappe.db.set_single_value("Accounts Settings", "allow_stale", 1)
self.clear_cache()
def test_exchange_rate(self, mock_get):
save_new_records(self.globalTestRecords["Currency Exchange"])

View File

@@ -63,9 +63,6 @@ class TestEmployee(ERPNextTestSuite):
self.assertEqual(qb_employee_list, employee_list)
frappe.set_user("Administrator")
def tearDown(self):
frappe.db.rollback()
def make_employee(user, company=None, **kwargs):
if not frappe.db.get_value("User", user):

View File

@@ -13,11 +13,6 @@ class TestTransactionDeletionRecord(ERPNextTestSuite):
self._clear_all_deletion_cache_flags()
create_company("Dunder Mifflin Paper Co")
def tearDown(self):
# Clean up all deletion cache flags after each test
self._clear_all_deletion_cache_flags()
frappe.db.rollback()
def _clear_all_deletion_cache_flags(self):
"""Clear all deletion_running_doctype:* cache keys"""
# Get all keys matching the pattern

View File

@@ -26,8 +26,6 @@ class TestBin(ERPNextTestSuite):
bin = _create_bin(item_code, warehouse)
self.assertEqual(bin.item_code, item_code)
frappe.db.rollback()
def test_index_exists(self):
indexes = frappe.db.sql("show index from tabBin where Non_unique = 0", as_dict=1)
if not any(index.get("Key_name") == "unique_item_warehouse" for index in indexes):

View File

@@ -930,9 +930,6 @@ class TestDeliveryNote(ERPNextTestSuite):
for _i, gle in enumerate(gl_entries):
self.assertEqual([gle.debit, gle.credit], expected_values.get(gle.account))
# tear down
frappe.db.rollback()
def test_closed_delivery_note(self):
from erpnext.stock.doctype.delivery_note.delivery_note import update_delivery_note_status
@@ -1580,10 +1577,6 @@ class TestDeliveryNote(ERPNextTestSuite):
# Test that item qty is not reserved on sales return, if selling setting don't reserve qty is checked.
self.assertEqual(get_reserved_qty(item, warehouse), 0 if dont_reserve_qty else qty_to_reserve)
def tearDown(self):
frappe.db.rollback()
frappe.db.set_single_value("Selling Settings", "dont_reserve_sales_order_qty_on_sales_return", 0)
def test_non_internal_transfer_delivery_note(self):
from erpnext.stock.doctype.warehouse.test_warehouse import create_warehouse

View File

@@ -24,9 +24,6 @@ class TestDeliveryTrip(ERPNextTestSuite):
self.delivery_trip = create_delivery_trip(driver, address, company=self.companies[0].name)
def tearDown(self):
frappe.db.rollback()
def test_delivery_trip_notify_customers(self):
# set default outgoing
outgoing = frappe.get_doc(

View File

@@ -408,7 +408,6 @@ class TestItem(ERPNextTestSuite):
frappe.flags.attribute_values = None
self.assertRaises(InvalidItemAttributeValueError, attribute.save)
frappe.db.rollback()
def test_make_item_variant(self):
frappe.delete_doc_if_exists("Item", "_Test Variant Item-L", force=1)

View File

@@ -195,6 +195,5 @@ class TestItemPrice(ERPNextTestSuite):
)
price = get_price_list_rate_for(ctx, doc.item_code)
frappe.db.rollback()
self.assertEqual(price, 21)

View File

@@ -29,9 +29,6 @@ class TestMaterialRequest(ERPNextTestSuite):
super().setUpClass()
cls.load_test_records("Material Request")
def tearDown(self):
frappe.db.rollback()
def test_material_request_qty(self):
mr = frappe.copy_doc(self.globalTestRecords["Material Request"][0])
mr.items[0].qty = 0

View File

@@ -37,9 +37,6 @@ class TestPurchaseReceipt(ERPNextTestSuite):
def setUp(self):
frappe.local.future_sle = {}
def tearDown(self):
frappe.db.rollback()
def test_purchase_receipt_qty(self):
pr = make_purchase_receipt(qty=0, rejected_qty=0, do_not_save=True)
with self.assertRaises(InvalidQtyError):

View File

@@ -22,9 +22,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestRepostItemValuation(ERPNextTestSuite, StockTestMixin):
def tearDown(self):
frappe.flags.dont_execute_stock_reposts = False
def test_repost_time_slot(self):
repost_settings = frappe.get_doc("Stock Reposting Settings")

View File

@@ -28,9 +28,6 @@ class TestSerialNo(ERPNextTestSuite):
super().setUpClass()
cls.load_test_records("Stock Entry")
def tearDown(self):
frappe.db.rollback()
def test_cannot_create_direct(self):
frappe.delete_doc_if_exists("Serial No", "_TCSER0001")

View File

@@ -59,10 +59,6 @@ class TestStockEntry(ERPNextTestSuite):
def setUp(self):
self.load_test_records("Stock Entry")
def tearDown(self):
frappe.db.rollback()
frappe.set_user("Administrator")
def test_stock_entry_qty(self):
item_code = "_Test Item 2"
warehouse = "_Test Warehouse - _TC"

View File

@@ -45,9 +45,6 @@ class TestStockLedgerEntry(ERPNextTestSuite, StockTestMixin):
"delete from `tabBin` where item_code in (%s)" % (", ".join(["%s"] * len(items))), items
)
def tearDown(self):
frappe.db.rollback()
def test_item_cost_reposting(self):
company = "_Test Company"

View File

@@ -43,9 +43,6 @@ class TestStockReconciliation(ERPNextTestSuite, StockTestMixin):
frappe.local.future_sle = {}
frappe.flags.pop("dont_execute_stock_reposts", None)
def tearDown(self):
frappe.db.rollback()
def test_reco_for_fifo(self):
self._test_reco_sle_gle("FIFO")

View File

@@ -697,10 +697,6 @@ class TestStockReservationEntry(ERPNextTestSuite):
# Test - 1: ValidationError should be thrown as the inwarded stock is reserved.
self.assertRaises(frappe.ValidationError, se.cancel)
def tearDown(self) -> None:
cancel_all_stock_reservation_entries()
return super().tearDown()
def create_items() -> dict:
items_properties = [

View File

@@ -24,9 +24,6 @@ class TestStockLedgerReeport(ERPNextTestSuite):
item_code="_Test Item With Serial No",
)
def tearDown(self) -> None:
frappe.db.rollback()
def test_available_serial_no(self):
report = frappe.get_doc("Report", "Available Serial No")

View File

@@ -20,10 +20,6 @@ class TestReservedStock(ERPNextTestSuite):
self.stock_qty = 100
self.warehouse = "_Test Warehouse - _TC"
def tearDown(self) -> None:
cancel_all_stock_reservation_entries()
return super().tearDown()
@ERPNextTestSuite.change_settings(
"Stock Settings",
{

View File

@@ -29,9 +29,6 @@ class TestStockBalance(ERPNextTestSuite):
}
)
def tearDown(self):
frappe.db.rollback()
def assertPartialDictEq(self, expected: dict[str, Any], actual: dict[str, Any]):
for k, v in expected.items():
self.assertEqual(v, actual[k], msg=f"{expected=}\n{actual=}")

View File

@@ -19,6 +19,3 @@ class TestStockLedgerReeport(ERPNextTestSuite):
to_date=add_days(today(), 30),
item_code=["_Test Stock Report Serial Item"],
)
def tearDown(self) -> None:
frappe.db.rollback()

View File

@@ -18,11 +18,6 @@ class TestFIFOValuation(ERPNextTestSuite):
def setUp(self):
self.queue = FIFOValuation([])
def tearDown(self):
qty, value = self.queue.get_total_stock_and_value()
self.assertTotalQty(qty)
self.assertTotalValue(value)
def assertTotalQty(self, qty):
self.assertAlmostEqual(sum(q for q, _ in self.queue), qty, msg=f"queue: {self.queue}", places=4)
@@ -198,11 +193,6 @@ class TestLIFOValuation(ERPNextTestSuite):
def setUp(self):
self.stack = LIFOValuation([])
def tearDown(self):
qty, value = self.stack.get_total_stock_and_value()
self.assertTotalQty(qty)
self.assertTotalValue(value)
def assertTotalQty(self, qty):
self.assertAlmostEqual(sum(q for q, _ in self.stack), qty, msg=f"stack: {self.stack}", places=4)

View File

@@ -40,9 +40,6 @@ class TestSubcontractingOrder(ERPNextTestSuite):
make_service_items()
make_bom_for_subcontracted_items()
def tearDown(self):
frappe.db.rollback()
def test_set_missing_values(self):
sco = get_subcontracting_order()
before = {sco.total_qty, sco.total, sco.total_additional_costs}

View File

@@ -358,10 +358,6 @@ class TestServiceLevelAgreement(ERPNextTestSuite):
applied_sla = frappe.db.get_value("Lead", lead.name, "service_level_agreement")
self.assertFalse(applied_sla)
def tearDown(self):
for d in frappe.get_all("Service Level Agreement"):
frappe.delete_doc("Service Level Agreement", d.name, force=1)
def get_service_level_agreement(
default_service_level_agreement=None, entity_type=None, entity=None, doctype="Issue"