Merge pull request #52743 from Mutantpenguin/patch-3

bug: fix comparison regarding `None` values
This commit is contained in:
Mihir Kandoi
2026-02-17 21:21:25 +05:30
committed by GitHub

View File

@@ -278,7 +278,9 @@ class QualityInspection(Document):
def set_status_based_on_acceptance_values(self, reading):
if not cint(reading.numeric):
result = reading.get("reading_value") == reading.get("value")
reading_value = reading.get("reading_value") or ""
value = reading.get("value") or ""
result = reading_value == value
else:
# numeric readings
result = self.min_max_criteria_passed(reading)