Srujan N
cdeeb36fe4
test: add comprehensive unit tests for MT940 preprocessing
...
Added 9 test cases covering all scenarios:
- Statement numbers >5 digits truncated correctly (167619 → 67619)
- Normal statement numbers (≤5 digits) remain unchanged
- Sequence numbers (/1, /2) preserved during truncation
- Multiple :28C: occurrences in same document
- Edge cases (empty content, missing :28C: tags)
- Full MT940 document processing
- MT940 format detection with required tags
- Boundary conditions (exactly 5/6 digits, very long numbers)
- Real-world production case (sanitized for privacy)
All tests pass successfully ensuring robust MT940 parsing
across various real-world scenarios and edge cases.
2025-10-05 22:38:11 +00:00
Srujan N
8598ca9a9d
fix: remove unnecessary whitelist from internal helper function
2025-10-05 22:37:12 +00:00
Srujan N
82285e236f
fix: handle MT940 statement numbers longer than 5 digits
...
The MT940 standard expects statement numbers to be maximum 5 digits,
but some banks provide longer statement numbers that cause parsing errors.
Problem:
- MT940 files with statement numbers > 5 digits fail to parse
- Error: "Unable to parse StatementNumber object from '167619/1'"
- This breaks bank statement import functionality
Solution:
- Add preprocess_mt940_content() function to truncate long statement numbers
- Preserve sequence numbers (e.g., '/1') when present
- Apply preprocessing before mt940.parse() to ensure compatibility
The fix truncates statement numbers to the last 5 digits while maintaining
the MT940 format structure, allowing successful parsing of previously
failing bank statements.
2025-09-22 20:46:44 +00:00
MochaMind
7d4785784b
fix: sync translations from crowdin ( #49625 )
2025-09-21 14:01:24 +02:00
MochaMind
35b503932d
chore: update POT file ( #49655 )
2025-09-21 13:59:21 +02:00
Mihir Kandoi
7e63f1d220
Merge pull request #49615 from aerele/fixed-support-48949
...
fix(stock): NoneType object error on stock entry
2025-09-18 20:16:40 +05:30
MochaMind
3d8502f408
fix: sync translations from crowdin ( #49607 )
2025-09-18 15:44:21 +02:00
ruthra kumar
c3e869c701
Merge pull request #49467 from aerele/qb-user-perm
...
fix: add condition for name
2025-09-18 16:41:16 +05:30
Kavin
aee03417de
fix(stock): NoneType object error on stock entry
2025-09-18 16:31:07 +05:30
Diptanil Saha
14d8b87c8e
Merge pull request #49608 from diptanilsaha/psoa_ar_show_future_payments
...
fix(process statement of accounts): total row in accounts receivable with future payments
2025-09-18 15:31:16 +05:30
rohitwaghchaure
2a86a1fb98
Merge pull request #49609 from rohitwaghchaure/fixed-drop-indexes-from-sle
...
fix: drop index batch_no_item_code_warehouse_index
2025-09-18 13:26:19 +05:30
Rohit Waghchaure
28180ccaa4
fix: drop index batch_no_item_code_warehouse_index
2025-09-18 13:08:26 +05:30
diptanilsaha
7bf17372b0
fix(process statement of accounts): total row in accounts receivable with future payments
2025-09-18 11:30:53 +05:30
venkat102
a5b881ea74
test: add test to validate user permission in qb
2025-09-18 00:02:10 +05:30
rohitwaghchaure
ac40b46a6d
Merge pull request #49589 from rohitwaghchaure/fixed-op-cost-for-sfg
...
fix: operation cost for Semi FG item
2025-09-17 22:18:51 +05:30
Rohit Waghchaure
69682cb064
fix: operation cost for Semi FG item
2025-09-17 21:57:34 +05:30
Raheel Khan
8b543e5503
fix: skip receivable/payable account validation in payroll entry if party is not available ( #49585 )
...
* fix: skip receivable/payable account validation if party is not available in creation of payroll entry
* refactor: rename flag
2025-09-17 13:06:00 +00:00
Diógenes Souza
c4f90c3b34
fix: 'NoneType' object has no attribute 'get' in get_item_details.py ( #49381 )
2025-09-17 18:05:49 +05:30
Anwar Patel
244dce5098
fix: Incorrect filters in Voucher Child Table of Land Cost Voucher DocType ( #49500 )
...
* fix: company filter in receipt_document in landed cost voucher
* refactor: use strict equality
2025-09-17 17:43:29 +05:30
Bhavansathru
194ab87fef
fix(payment-reconciliation): apply field precision for allocated and difference amounts ( #49448 )
...
fix(payment-reconciliation): handle allocated and difference amount with field precision for accurate exchange rate calculations
2025-09-17 17:04:02 +05:30
Logesh Periyasamy
e0299e1cbd
fix: add option for currency field ( #49572 )
2025-09-17 17:01:53 +05:30
MochaMind
9c970acbda
fix: sync translations from crowdin ( #49581 )
...
* fix: Norwegian Bokmal translations
* fix: French translations
2025-09-17 17:01:18 +05:30
rohitwaghchaure
06dde659c2
Merge pull request #49587 from rohitwaghchaure/fixed-support-48584
...
fix: incorrect current qty calculation for the batch
2025-09-17 17:00:23 +05:30
Logesh Periyasamy
9fc17e0e3a
fix: project accounting dimension and gl posting date column width ( #49563 )
...
* fix: add width for posting_date
* fix: add project field for missing doctype
* fix: remove allow_on_submit to align with cost center
2025-09-17 16:57:48 +05:30
Rohit Waghchaure
535f8657ed
fix: incorrect current qty calculation for the batch
2025-09-17 16:33:26 +05:30
Diptanil Saha
c77781a14f
Merge pull request #49584 from diptanilsaha/custom-print-format-psoa
...
feat(accounts): enable print format selection in Process Statement of Accounts
2025-09-17 12:19:04 +05:30
diptanilsaha
c9d22386ed
fix: added print format validation on process statement of accounts
2025-09-17 11:42:36 +05:30
diptanilsaha
2e7c3207c4
feat(accounts): enable print format selection in Process Statement of Accounts
2025-09-17 11:23:44 +05:30
Diptanil Saha
0aef591f5d
Merge pull request #49281 from diptanilsaha/reporting_currency
...
feat: adding reporting_currency and dr/cr in reporting currency fields in GL Entry and Account Closing Balance
2025-09-17 10:44:04 +05:30
rohitwaghchaure
39049948b8
Merge pull request #49558 from rohitwaghchaure/fixed-valuation-rate-issue
...
fix: set basic rate on selection of the batch
2025-09-16 12:55:04 +05:30
ruthra kumar
39b9d798d9
Merge pull request #49511 from aerele/sales-invoice-tax-id
...
fix(sales invoice): fetch tax id from customer
2025-09-16 12:01:33 +05:30
Rohit Waghchaure
bebb8ae1ea
fix: set basic rate on selection of the batch
2025-09-16 11:57:43 +05:30
ruthra kumar
1c8266af39
Merge pull request #49557 from frappe/l10n_develop
...
fix: sync translations from crowdin
2025-09-16 10:17:44 +05:30
MochaMind
73729f6ab0
fix: French translations
2025-09-16 07:06:51 +05:30
MochaMind
a287201011
fix: Norwegian Bokmal translations
2025-09-16 07:06:45 +05:30
MochaMind
a4e2fbdcf9
fix: Persian translations
2025-09-16 07:06:34 +05:30
MochaMind
21dc0a0b1a
fix: Swedish translations
2025-09-16 07:06:18 +05:30
MochaMind
98626aaa6c
fix: Portuguese translations
2025-09-16 07:06:09 +05:30
MochaMind
86a8015cea
fix: German translations
2025-09-16 07:05:56 +05:30
MochaMind
8330b349d2
fix: Danish translations
2025-09-16 07:05:53 +05:30
Diptanil Saha
29197af11a
Merge pull request #49438 from pipech/fix-thai-fiscal-year
...
fix(acc): thai fiscal year
2025-09-16 00:50:30 +05:30
rohitwaghchaure
a00a3868ed
Merge pull request #49549 from rohitwaghchaure/fixed-not-allow-backdated-entries
...
fix: do not allow backdated entries if stock reco exists in future for serial or batch
2025-09-15 15:40:42 +05:30
Rohit Waghchaure
335dcc976c
fix: do not allow backdated entries if stock reco exists in future for serial or batch
2025-09-15 15:22:41 +05:30
Raffael Meyer
6972f161b8
fix(accounts): dynamic zero cutoff ( #48899 )
...
* fix(accounts): dynamic zero cutoff
The cutoff for displaying zero values in accounting reports has so far been hardcoded to 0.005, giving wrong results for currencies that require a higher precision. This PR changes this to a dynamic value calculated from the Currency's _Fraction Units_.
* style: fix typo
2025-09-15 08:33:03 +02:00
Khushi Rawat
79b8505972
Merge pull request #49524 from KerollesFathy/fix-assets-movement-typos
...
fix: Assets Movement Typos
2025-09-15 11:54:56 +05:30
MochaMind
fe7b797e5f
fix: sync translations from crowdin ( #49550 )
...
* fix: Spanish translations
* fix: Arabic translations
* fix: Czech translations
* fix: Danish translations
* fix: German translations
* fix: Hungarian translations
* fix: Italian translations
* fix: Dutch translations
* fix: Polish translations
* fix: Portuguese translations
* fix: Russian translations
* fix: Serbian (Cyrillic) translations
* fix: Swedish translations
* fix: Turkish translations
* fix: Chinese Simplified translations
* fix: Vietnamese translations
* fix: Portuguese, Brazilian translations
* fix: Indonesian translations
* fix: Persian translations
* fix: Thai translations
* fix: Croatian translations
* fix: Bosnian translations
* fix: Norwegian Bokmal translations
* fix: Serbian (Latin) translations
* fix: French translations
* fix: Esperanto translations
2025-09-15 07:45:05 +02:00
ravibharathi656
df329964dd
fix(sales invoice): fetch tax id from customer
2025-09-15 10:12:20 +05:30
MochaMind
1845d12951
Merge pull request #49532 from frappe/l10n_develop
2025-09-14 20:33:38 +02:00
Raffael Meyer
67c2ab4c9f
Merge pull request #49546 from frappe/pot_develop_2025-09-14
...
chore: update POT file
2025-09-14 13:40:25 +02:00
frappe-pr-bot
405e1ab6d3
chore: update POT file
2025-09-14 09:35:06 +00:00
