Mihir Kandoi
ec0da0f113
chore: remove unneccessary flt
...
(cherry picked from commit 3a63f61832 )
2026-07-17 16:09:12 +00:00
Mihir Kandoi
aa08f753b4
fix: dont overwrite rate with 0 if not found
...
(cherry picked from commit 1ef3cd1d3f )
2026-07-17 16:09:12 +00:00
Mihir Kandoi
c3aea9ca9c
fix: pass ctx keys get_price_list_rate_for reads, skip rate update on insert
...
update_item_rates passed price_not_uom_dependent, a key
get_price_list_rate_for never reads, and omitted conversion_factor, so a
stock-UOM price was never converted to the row UOM. The function's
(historically misnamed) price_list_uom_dependant ctx key carries the
Price List's price_not_uom_dependent value: truthy returns the found
rate as-is, falsy multiplies by conversion_factor.
Also guard on_update with is_new(): has_value_changed returns True when
there is no doc_before_save, so every first save re-wrote item rates.
(cherry picked from commit 6dcc0cab3a )
2026-07-17 16:09:11 +00:00
Mihir Kandoi
025b2f2922
fix: validate buying price list on material request and update item rates on change
...
(cherry picked from commit 18b15f2ca9 )
2026-07-17 16:09:11 +00:00
mergify[bot]
5f6952b15c
fix: restrict jinja globals in process statement of accounts templates (backport #56458 ) ( #57232 )
...
fix: restrict jinja globals in process statement of accounts templates
(cherry picked from commit ecb6d48ec0 )
Co-authored-by: Shllokkk <shllokosan23@gmail.com >
2026-07-17 08:20:41 +00:00
mergify[bot]
3948951904
fix: added missing validations for Dunning Type (backport #57224 ) ( #57227 )
...
* fix: added missing validations for `Dunning Type`
(cherry picked from commit c8e7674d63 )
* test: added tests for `Dunning Type` validation
(cherry picked from commit 2325068b19 )
# Conflicts:
# erpnext/accounts/doctype/dunning_type/test_dunning_type.py
* chore: resolve conflict
---------
Co-authored-by: diptanilsaha <diptanil@frappe.io >
2026-07-17 06:57:37 +00:00
Shllokkk
915562c7a8
Merge pull request #57219 from frappe/mergify/bp/version-16-hotfix/pr-57198
...
fix: strip account number when building account name in COA importer (backport #57198 )
2026-07-17 11:39:00 +05:30
Mihir Kandoi
dfd05caeb0
Merge pull request #57017 from frappe/mergify/bp/version-16-hotfix/pr-56693
...
fix(stock): correct stock ageing value for moving average and lifo items (backport #56693 )
2026-07-17 07:49:09 +05:30
MochaMind
827831a247
fix: sync translations from crowdin ( #57187 )
2026-07-16 18:00:39 +02:00
Shllokkk
e1ebfa7163
fix: strip account number when building account name in COA importer
...
(cherry picked from commit cbe406ee2a )
2026-07-16 15:21:50 +00:00
mergify[bot]
c055de2da6
refactor(dunning): converted get_dunning_letter_text to doc method and restrict_globals on render_template (backport #57205 ) ( #57214 )
...
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2026-07-16 11:33:41 +00:00
Mihir Kandoi
c5d94d5fc3
Merge pull request #57211 from frappe/mergify/bp/version-16-hotfix/pr-57179
...
feat(stock): automatically link portal users to their associated contact profiles for customers and suppliers (backport #57179 )
2026-07-16 16:29:56 +05:30
Afsal Syed
74451366c2
test(stock): add portal user contact link verification for customer and supplier
...
(cherry picked from commit 9ae2069bd9 )
2026-07-16 15:46:06 +05:30
Afsal Syed
134d63de78
feat(stock): automatically link portal users to their associated contact profiles for customers and suppliers
...
(cherry picked from commit 337a06dfb6 )
2026-07-16 15:44:45 +05:30
Mihir Kandoi
8946fc41a2
Merge pull request #57208 from mihir-kandoi/fix-production-plan-min-order-qty-v16
...
fix: consider min order qty in the purchase/transfer flow of production plan (backport #57204 )
2026-07-16 13:46:23 +05:30
Mihir Kandoi
cbd4f93f3d
fix: consider min order qty in the purchase/transfer flow of production plan (backport #57204 )
...
The transfer flow ignored Consider Minimum Order Qty twice: the JS
handler force-reset the checkbox before fetching items, and the
purchase remainder left after allocating transfers from other
warehouses was never raised to min_order_qty (the check runs on the
total requirement before the split).
Drop the JS reset and apply min order qty to the purchase remainder,
in stock UOM before the purchase UOM conversion.
2026-07-16 13:36:04 +05:30
mergify[bot]
0817d1064c
fix: permission issue (backport #57112 ) (backport #57142 ) ( #57184 )
...
* fix: permission issue (backport #57112 ) (#57142 )
* fix: permission issue (#57112 )
(cherry picked from commit 1fd2faa68d )
# Conflicts:
# erpnext/controllers/stock_controller.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
(cherry picked from commit 6b23b007a4 )
# Conflicts:
# erpnext/controllers/stock_controller.py
* chore: fix conflicts
* chore: fix conflicts
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2026-07-15 15:05:17 +05:30
mergify[bot]
b1adec7e9e
fix(project): improved access control for project users (backport #56675 ) ( #57181 )
...
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2026-07-15 14:19:07 +05:30
mergify[bot]
caea21208e
Revert "chore: remove unused whitelisted method from project" (backport #56660 ) ( #57178 )
...
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2026-07-15 07:09:36 +00:00
Mihir Kandoi
2808b34d42
Merge pull request #57170 from mihir-kandoi/backport-57169-version-16-hotfix
...
fix: allow delivery when a batch is reserved across multiple sales orders (backport #57169 )
2026-07-15 12:31:39 +05:30
Mihir Kandoi
7ccb2584c4
test: set delivered batch on the row explicitly on v16
...
The v16 reserved-stock mapper attaches neither a bundle nor row
serial/batch fields when use_serial_batch_fields is enabled, and
update_stock_reservation_entries crashes on the missing bundle (fixed
on develop by 9c5f9218b5 , not backported). Deliver via an explicit row
batch_no like the guard test so the bundle is built from row fields
before the reservation update runs.
2026-07-15 12:19:21 +05:30
Mihir Kandoi
f3e1b3fca7
fix: round outstanding qty guard consistently with the conflict gate
2026-07-15 12:00:02 +05:30
Mihir Kandoi
555c607f2f
fix: exclude fully-delivered reservations from the conflict message
2026-07-15 12:00:02 +05:30
Mihir Kandoi
7cd7e4ab0f
test: deliver reserved batches via bundles on v16
...
use_serial_batch_fields delivery of reserved stock crashes on v16 with
'Serial and Batch Bundle None not found' (fixed on develop only), so
deliver through auto-created bundles like test_auto_reserve_serial_and_batch.
2026-07-15 12:00:02 +05:30
Mihir Kandoi
839fd5e3b6
fix: name every conflicting voucher in the reserved batch error
2026-07-15 12:00:02 +05:30
Mihir Kandoi
56bbca0203
fix: allow delivery when a batch is reserved across multiple sales orders (backport #57169 )
...
validate_reserved_batches compared the voucher's own qty against the
remaining batch qty, so delivering one order's reserved unit threw
Reserved Batch Conflict whenever the remainder exactly matched another
order's reservation. Compare the remaining batch qty against the
aggregated outstanding reserved qty (qty - delivered_qty) of other
vouchers instead, excluding reservations the voucher itself delivers.
2026-07-15 12:00:02 +05:30
Mihir Kandoi
478719b828
Merge pull request #57173 from frappe/mergify/bp/version-16-hotfix/pr-57137
...
feat: add on hold status to project (backport #57137 )
2026-07-15 11:29:14 +05:30
Poovitha Palanivelu
57a49ce168
feat: add on hold status to project
...
(cherry picked from commit 672fadaa78 )
2026-07-15 05:47:16 +00:00
Mihir Kandoi
6d47c51c5b
Merge pull request #57166 from frappe/mergify/bp/version-16-hotfix/pr-57163
...
fix: hide job card field in purchase order item (backport #57163 )
2026-07-15 11:03:06 +05:30
Mihir Kandoi
6ab1668b37
Merge pull request #57168 from frappe/mergify/bp/version-16-hotfix/pr-57164
...
fix: set correct currency in supplier quotation net rate field (backport #57164 )
2026-07-15 10:58:18 +05:30
Mihir Kandoi
b256c76c3b
chore: resolve conflicts
2026-07-15 10:48:51 +05:30
Mihir Kandoi
e24ef847dc
fix: set correct currency in supplier quotation net rate field
...
(cherry picked from commit 27672851cd )
2026-07-15 05:17:11 +00:00
Mihir Kandoi
20f6ac81b9
fix: hide job card field in purchase order item
...
(cherry picked from commit f44bcae47d )
# Conflicts:
# erpnext/buying/doctype/purchase_order_item/purchase_order_item.json
2026-07-15 05:13:39 +00:00
Mihir Kandoi
b1ca9c26cb
Merge pull request #57136 from frappe/mergify/bp/version-16-hotfix/pr-57129
...
fix: prevent duplicate material request items in purchase order (backport #57129 )
2026-07-14 16:43:09 +05:30
Mihir Kandoi
4d931a7108
test: remove test
...
(cherry picked from commit b2ec906ff3 )
2026-07-14 11:01:57 +00:00
SandraFrappe
4d951c1cf8
fix: prevent duplicate material request items in purchase order
...
(cherry picked from commit 2d6f89a7f5 )
2026-07-14 11:01:57 +00:00
Mihir Kandoi
3a38316c26
Merge pull request #57126 from aerele/fix/job-card-work-order-transferred-qty-v16
...
fix(manufacturing): preserve job card transferred quantity
2026-07-14 13:40:29 +05:30
Sudharsanan11
fd6c9a71cd
test(manufacturing): cover transferred quantity across job cards
2026-07-14 13:23:49 +05:30
Sudharsanan11
d7e9321746
fix(manufacturing): preserve job card transferred quantity
2026-07-14 13:23:28 +05:30
mergify[bot]
e8a532587d
fix(accounts): added permission checks on get_account_balances_coa (backport #57107 ) ( #57122 )
...
Co-authored-by: Diptanil Saha <diptanil@frappe.io >
2026-07-14 13:07:12 +05:30
Mihir Kandoi
8d7fe755e3
Merge pull request #57118 from frappe/mergify/bp/version-16-hotfix/pr-57116
...
fix(stock): fix sqlparse token limit in get_bundle_wise_serial_nos (backport #57116 )
2026-07-14 12:33:43 +05:30
Khushi Rawat
2947f030e8
Merge pull request #57119 from frappe/mergify/bp/version-16-hotfix/pr-57111
...
chore: remove dead assets dashboard_fixtures with broken imports (backport #57111 )
2026-07-14 12:14:47 +05:30
Afsal Syed
cec1e87c90
test(stock): add unit test for get_bundle_wise_serial_nos query
...
(cherry picked from commit e748bf512b )
2026-07-14 12:13:42 +05:30
khushi8112
345c508be7
chore: remove dead assets dashboard_fixtures with broken imports ( #57079 )
...
erpnext.accounts.dashboard_fixtures and erpnext.buying.dashboard_fixtures
were removed in 2020 when dashboards were exported to JSON fixtures.
The assets module's dashboard_fixtures.py was left behind unreferenced;
its dashboard, charts and number cards already exist as exported JSON.
(cherry picked from commit 14a15cc6f9 )
2026-07-14 06:23:40 +00:00
Afsal Syed
5a99dd6016
fix(stock): fix sqlparse token limit in get_bundle_wise_serial_nos
...
(cherry picked from commit 4544a6c935 )
2026-07-14 06:00:14 +00:00
Mihir Kandoi
3b7467daab
Merge pull request #57113 from PranavDarade/fix/transfer-reservation-stock-uom
...
fix(stock): set stock_uom on transferred Stock Reservation Entries
2026-07-14 10:14:59 +05:30
Khushi Rawat
db737da22e
Merge pull request #57077 from frappe/mergify/bp/version-16-hotfix/pr-55276
...
fix(asset): allow asset repair creation for fully depreciated assets (backport #55276 )
2026-07-14 00:24:20 +05:30
Khushi Rawat
138a44e450
Merge pull request #56966 from frappe/mergify/bp/version-16-hotfix/pr-56964
...
fix: match depreciation schedule rows at currency precision to avoid duplicate JEs (backport #56964 )
2026-07-14 00:09:32 +05:30
Diptanil Saha
40c85a0087
fix(tnc): get_terms_and_conditions render_template with safe_exec (backport #56944 ) ( #56977 )
2026-07-13 23:22:55 +05:30
Mihir Kandoi
4f59e57151
Merge pull request #57105 from frappe/mergify/bp/version-16-hotfix/pr-57091
...
fix(stock): show qty (company) and qty (warehouse) in sales transactions (backport #57091 )
2026-07-13 21:27:54 +05:30