nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 06:01:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tnc): get_terms_and_conditions render_template with safe_exec (backport #56944) (#56977)

Browse Source
This commit is contained in:
Diptanil Saha
2026-07-13 23:22:55 +05:30
committed by GitHub
parent 4f59e57151
commit 40c85a0087
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py
View File

@@ -30,7 +30,7 @@ class TermsandConditions(Document):
def validate(self):
if self.terms:
validate_template(self.terms)
validate_template(self.terms, restrict_globals=True)
if not cint(self.buying) and not cint(self.selling) and not cint(self.hr) and not cint(self.disabled):
throw(_("At least one of the Applicable Modules should be selected"))
@@ -40,7 +40,10 @@ def get_terms_and_conditions(template_name, doc):
if isinstance(doc, str):
doc = json.loads(doc)
terms_and_conditions = frappe.get_doc("Terms and Conditions", template_name)
tnc = frappe.get_cached_doc("Terms and Conditions", template_name)
tnc.check_permission()
if terms_and_conditions.terms:
return frappe.render_template(terms_and_conditions.terms, doc)
if not tnc.terms:
return
return frappe.render_template(tnc.terms, doc, restrict_globals=1)

2
pyproject.toml
View File

@@ -43,7 +43,7 @@ skip_namespaces = [
]
[tool.bench.frappe-dependencies]
frappe = ">=16.0.0,<17.0.0"
frappe = ">=16.21.0,<17.0.0"
[tool.bench.assets]
build_dir = "./banking"