nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-16 07:58:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
59,426 Commits 604 Branches 1,799 Tags
a7c1ebacbe722e2a2c6acfd90369501373ef4db9
Commit Graph

59426 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mohd Haris
a7c1ebacbe fix(asset): conditionally show Is Fully Depreciated field 
The "Is Fully Depreciated" field was hidden on the Asset form (hidden: 1),
so it could never be set for manually entered existing assets.

Make it visible based on context:
- Existing Asset with Calculate Depreciation off -> visible and editable
- Calculate Depreciation on -> visible but read-only and forced unchecked
  (it is only meaningful for manually entered assets)

The unchecked value is enforced in the form script (immediate feedback on
toggle and on load) and in server-side validate() so it can never be saved
as checked while depreciation is being calculated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-06-26 17:34:49 +05:30
Diptanil Saha
1e2adc0706 ci: bump pre-commit actions to v3.0.1 (#56562) 2026-06-26 11:14:57 +00:00
Mihir Kandoi
05e7317375 Merge pull request #56559 from Shllokkk/serial-batch-bundle-print-none-fix 
fix: remove dead bundle helper call from purchase receipt print format
 2026-06-26 16:37:09 +05:30
Mihir Kandoi
c5700f5df4 Merge pull request #56467 from mihir-kandoi/messages/stock 
chore: rewrite user-facing messages in stock module
 2026-06-26 15:29:32 +05:30
Shllokkk
b9f5a77fa7 fix: remove dead bundle helper call from purchase receipt print format 2026-06-26 15:00:54 +05:30
Nabin Hait
1ffdfbe86e Merge pull request #56539 from frappe/chore/test-delayed-order-report 
test: Delayed Order Report report coverage
 2026-06-26 14:58:10 +05:30
Nabin Hait
c3ae7a0b95 Merge pull request #56538 from frappe/chore/test-delayed-item-report 
test: Delayed Item Report report coverage
 2026-06-26 14:57:51 +05:30
Nabin Hait
99e85bfd82 Merge pull request #56537 from frappe/chore/test-batch-item-expiry-status 
test: Batch Item Expiry Status report coverage
 2026-06-26 14:56:31 +05:30
Nabin Hait
dca5d2ca3a Merge pull request #56523 from frappe/chore/test-stock-ledger-invariant-check 
test: Stock Ledger Invariant Check report coverage
 2026-06-26 14:38:21 +05:30
Nabin Hait
dc59ee8034 Merge pull request #56533 from frappe/chore/test-item-variant-details 
test: Item Variant Details report coverage
 2026-06-26 14:36:58 +05:30
Nabin Hait
76da65ab4c Merge pull request #56531 from frappe/chore/test-item-price-stock 
test: Item Price Stock report coverage
 2026-06-26 14:36:25 +05:30
Nabin Hait
bde23492fb Merge pull request #56528 from frappe/chore/test-serial-no-ledger 
test: Serial No Ledger report coverage
 2026-06-26 14:34:51 +05:30
Nabin Hait
d47bc64576 Merge pull request #56527 from frappe/chore/test-serial-and-batch-summary 
test: Serial and Batch Summary report coverage
 2026-06-26 14:33:55 +05:30
Nabin Hait
4ac863d653 Merge pull request #56515 from frappe/chore/test-batch-wise-balance-history 
test: Batch-Wise Balance History report coverage
 2026-06-26 14:29:30 +05:30
Nabin Hait
5fe84305fc Merge pull request #56503 from frappe/chore/trial-balance-for-party-test-coverage 
test: Trial Balance for Party report coverage
 2026-06-26 14:28:04 +05:30
Mihir Kandoi
a972ef313a Merge pull request #56127 from harisansari008/fix/qip-allow-rename-develop 
fix: allow rename for Quality Inspection Parameter
 2026-06-26 13:43:40 +05:30
Nabin Hait
245925815e test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:36:26 +05:30
Nabin Hait
7f5f2ccfa3 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:28:05 +05:30
Nabin Hait
dc4f5ce0ab test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:27:56 +05:30
Nabin Hait
182ef8a8e8 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:27:48 +05:30
Nabin Hait
67ac8f64e8 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:27:14 +05:30
Nabin Hait
9158d5f893 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:27:04 +05:30
Nabin Hait
0e6f50ca24 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:26:28 +05:30
Nabin Hait
6ceddd7a83 test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:26:24 +05:30
Nabin Hait
293ca4e96f test: reuse BootStrapTestData master data to reduce runtime 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 13:26:08 +05:30
Mihir Kandoi
05e44ca63a Merge pull request #56546 from mihir-kandoi/pg-rawsql-to-orm 
refactor: convert convertible raw frappe.db.sql to ORM
 2026-06-26 12:21:25 +05:30
Mihir Kandoi
0583349ae4 test: convert aggregate/pluck/positional raw SQL to ORM 
A deeper re-audit (with an adversarial skeptic) of the queries left raw
in the prior commit found more that have exact ORM equivalents:

- scalar SUM/MAX  -> frappe.qb + Sum/Max .run()[0][0]
- SUM ... GROUP BY -> frappe.qb .groupby().select(Sum().as_()) run(as_dict)
- name IN (values) -> get_all(filters={'f': ['in', ...]})
- sql_list(select col) -> get_all(pluck='col')
- bulk UPDATE ... = NULL/value -> frappe.db.set_value(filters, field, val)
- positional as_list reads -> get_all(..., as_list=True) (+ sorted())

Note: get_value(dt, filters, 'sum(x)') and get_all(fields=['sum(x)'])
are rejected by frappe ('SQL functions are not allowed as strings'), so
aggregates go through frappe.qb. get_all(as_list=True) returns a tuple
(not a list), so consumers that mutate use sorted().

All affected test modules pass on MariaDB.
 2026-06-26 11:34:31 +05:30
Mihir Kandoi
0776f7f7fa test: convert trivially-equivalent raw SQL to ORM helpers 
Convert test-only raw frappe.db.sql calls that have an exact ORM
equivalent: full-table/filtered deletes -> frappe.db.delete, count ->
frappe.db.count, row-existence assertions -> frappe.db.exists,
single-row scalar fetches -> frappe.db.get_value, and simple
equality/range-filter selects -> frappe.get_all. No behaviour change.

Raw SQL that genuinely needs it is left as-is (dynamic identifiers,
aggregates/group-by, positional as_list consumers, DB-catalog
introspection).
 2026-06-26 10:44:17 +05:30
Mihir Kandoi
0e54e532ff refactor(accounts): use frappe.get_all for trial balance account fetch 
The Account metadata fetch in the DuckDB trial-balance path is a plain
static SELECT (fixed columns, single company filter, order by lft).
Convert it to frappe.get_all. Verified on Postgres: identical 98 rows,
same order and same dict payload as the raw query.
 2026-06-26 10:44:05 +05:30
Nabin Hait
b537e8b183 test: add coverage for Delayed Order Report report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:33:20 +05:30
Nabin Hait
ce5239132c test: add coverage for Delayed Item Report report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:33:12 +05:30
Nabin Hait
8bef2b13a1 test: add coverage for Batch Item Expiry Status report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:33:05 +05:30
Nabin Hait
4a6b189221 test: add coverage for Item Variant Details report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:25:55 +05:30
Nabin Hait
08ce18fe58 test: add coverage for Item Price Stock report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:25:40 +05:30
Nabin Hait
7661e5ed96 test: add coverage for Serial No Ledger report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:25:18 +05:30
Nabin Hait
dddaa80f99 test: add coverage for Serial and Batch Summary report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:25:11 +05:30
Nabin Hait
09be6fed9a test: add coverage for Stock Ledger Invariant Check report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:19:59 +05:30
Nabin Hait
5790bcf99d test: add coverage for Batch-Wise Balance History report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 10:19:04 +05:30
Mihir Kandoi
ea9bf932d8 Merge pull request #56510 from frappe/revert-56497-serial-batch-bundle-print-none-fix 
Revert "fix: handle missing serial and batch bundle in print format"
 2026-06-26 10:18:43 +05:30
Mihir Kandoi
993a011005 Revert "fix: handle missing serial and batch bundle in print format" 2026-06-26 10:07:23 +05:30
Nabin Hait
d18177665b test: add coverage for Trial Balance for Party report 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-26 09:11:45 +05:30
Nabin Hait
507bc0930e Merge pull request #56412 from frappe/chore/fixed-asset-register-test-coverage 
test: Fixed Asset Register report coverage
 2026-06-25 22:13:39 +05:30
MochaMind
c3d2ebd734 fix: sync translations from crowdin (#56396) 2026-06-25 16:35:56 +02:00
Shllokkk
142d80d7de Merge pull request #56497 from Shllokkk/serial-batch-bundle-print-none-fix 
fix: handle missing serial and batch bundle in print format
 2026-06-25 19:22:23 +05:30
Mihir Kandoi
c8f86099e2 Merge pull request #56479 from mihir-kandoi/messages/crm 
chore: rewrite user-facing messages in crm module
 2026-06-25 18:47:25 +05:30
Mihir Kandoi
ab1e949752 Merge pull request #56482 from mihir-kandoi/messages/erpnext_integrations 
chore: rewrite user-facing messages in erpnext_integrations module
 2026-06-25 18:43:52 +05:30
Mihir Kandoi
8ad90338a3 Merge pull request #56469 from mihir-kandoi/messages/controllers 
chore: rewrite user-facing messages in controllers module
 2026-06-25 18:38:23 +05:30
Mihir Kandoi
d2ff0913df Merge pull request #56476 from mihir-kandoi/messages/projects 
chore: rewrite user-facing messages in projects module
 2026-06-25 18:35:00 +05:30
Mihir Kandoi
05dd44246f Merge pull request #56475 from mihir-kandoi/messages/subcontracting 
chore: rewrite user-facing messages in subcontracting module
 2026-06-25 18:33:55 +05:30
Mihir Kandoi
6e22f4b063 Merge pull request #56498 from mihir-kandoi/messages/exchange-rate-server-grammar 
chore: fix grammar in Exchange Rate Revaluation validation message
 2026-06-25 18:28:11 +05:30