nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 14:11:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56475 from mihir-kandoi/messages/subcontracting

Browse Source 
chore: rewrite user-facing messages in subcontracting module
This commit is contained in:
Mihir Kandoi
2026-06-25 18:33:55 +05:30
committed by GitHub
parent 6e22f4b063 f5bf915104
commit 05dd44246f
3 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/subcontracting/doctype/subcontracting_inward_order/subcontracting_inward_order.py
View File

@@ -224,7 +224,7 @@ class SubcontractingInwardOrder(SubcontractingController):
if not any([rm.is_customer_provided_item for rm in raw_materials]):
frappe.throw(
_(
"Atleast one raw material for Finished Good Item {0} should be customer provided."
"At least one raw material for Finished Good Item {0} should be customer provided."
).format(frappe.bold(item.item_code))
)

17
erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py
View File

@@ -139,12 +139,14 @@ class SubcontractingOrder(SubcontractingController):
frappe.throw(_("Please select a valid Purchase Order that is configured for Subcontracting."))
if po.docstatus != 1:
msg = f"Please submit Purchase Order {po.name} before proceeding."
frappe.throw(_(msg))
frappe.throw(_("Please submit Purchase Order {0} before proceeding.").format(po.name))
if po.per_received == 100:
msg = f"Cannot create more Subcontracting Orders against the Purchase Order {po.name}."
frappe.throw(_(msg))
frappe.throw(
_("Cannot create more Subcontracting Orders against the Purchase Order {0}.").format(
po.name
)
)
else:
self.service_items = self.items = self.supplied_items = None
frappe.throw(_("Please select a Subcontracting Purchase Order."))
@@ -172,8 +174,11 @@ class SubcontractingOrder(SubcontractingController):
if self.supplier_warehouse:
for item in self.supplied_items:
if self.supplier_warehouse == item.reserve_warehouse:
msg = f"Reserve Warehouse must be different from Supplier Warehouse for Supplied Item {item.main_item_code}."
frappe.throw(_(msg))
frappe.throw(
_(
"Reserve Warehouse must be different from Supplier Warehouse for Supplied Item {0}."
).format(item.main_item_code)
)
def set_missing_values(self):
self.calculate_additional_costs()

2
erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
View File

@@ -143,7 +143,7 @@ class SubcontractingReceipt(SubcontractingController):
self.validate_inspection()
if getdate(self.posting_date) > getdate(nowdate()):
frappe.throw(_("Posting Date cannot be future date"))
frappe.throw(_("Posting Date cannot be a future date"))
super().validate()