nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-15 03:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: added permission validation for deactivate_sales_person (backport #54884) (#54886)

Browse Source 
* fix: added permission validation for `deactivate_sales_person` (#54884)

(cherry picked from commit 9134db9cd3)

# Conflicts:
#	erpnext/setup/doctype/employee/employee.py

* chore: resolved conflict

---------

Co-authored-by: diptanilsaha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-05-12 16:31:21 +00:00
committed by GitHub
parent b962a1a0cd
commit 98de025a09
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/setup/doctype/employee/employee.py
View File

@@ -417,6 +417,7 @@ def is_holiday(employee, date=None, raise_exception=True, only_non_weekly=False,
@frappe.whitelist() @frappe.whitelist()
def deactivate_sales_person(status=None, employee=None): def deactivate_sales_person(status=None, employee=None):
frappe.has_permission("Employee", doc=employee, ptype="write", throw=True)
if status == "Left": if status == "Left":
sales_person = frappe.db.get_value("Sales Person", {"Employee": employee}) sales_person = frappe.db.get_value("Sales Person", {"Employee": employee})
if sales_person: if sales_person: