From 98de025a09f215c3d9c0d3fe633d03e6de0a095a Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Tue, 12 May 2026 16:31:21 +0000 Subject: [PATCH] fix: added permission validation for `deactivate_sales_person` (backport #54884) (#54886) * fix: added permission validation for `deactivate_sales_person` (#54884) (cherry picked from commit 9134db9cd3d1779f08247e8c99dc1edf8efd5734) # Conflicts: # erpnext/setup/doctype/employee/employee.py * chore: resolved conflict --------- Co-authored-by: diptanilsaha --- erpnext/setup/doctype/employee/employee.py | 1 + 1 file changed, 1 insertion(+) diff --git a/erpnext/setup/doctype/employee/employee.py b/erpnext/setup/doctype/employee/employee.py index 81324fb89ba..d73ce511360 100755 --- a/erpnext/setup/doctype/employee/employee.py +++ b/erpnext/setup/doctype/employee/employee.py @@ -417,6 +417,7 @@ def is_holiday(employee, date=None, raise_exception=True, only_non_weekly=False, @frappe.whitelist() def deactivate_sales_person(status=None, employee=None): + frappe.has_permission("Employee", doc=employee, ptype="write", throw=True) if status == "Left": sales_person = frappe.db.get_value("Sales Person", {"Employee": employee}) if sales_person: