nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-13 18:21:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: added permission validation for deactivate_sales_person (#54884)

Browse Source
This commit is contained in:
diptanilsaha
2026-05-12 21:31:08 +05:30
committed by GitHub
parent 6e349569c7
commit 9134db9cd3
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/setup/doctype/employee/employee.py
View File

@@ -416,7 +416,8 @@ def is_holiday(employee, date=None, raise_exception=True, only_non_weekly=False,
@frappe.whitelist()
def deactivate_sales_person(status: str | None = None, employee: str | None = None):
def deactivate_sales_person(status: str, employee: str):
frappe.has_permission("Employee", doc=employee, ptype="write", throw=True)
if status == "Left":
sales_person = frappe.db.get_value("Sales Person", {"Employee": employee})
if sales_person: