nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 19:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sales_order): Replace SQL with ORM in make_maintenance_schedule (#55206)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-23 08:27:27 +02:00
committed by GitHub
parent 6f9f6d3b7d
commit 983ae011f0
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/selling/doctype/sales_order/sales_order.py
View File

@@ -1599,11 +1599,8 @@ def make_sales_invoice(
@frappe.whitelist() @frappe.whitelist()
def make_maintenance_schedule(source_name: str, target_doc: str | Document | None = None): def make_maintenance_schedule(source_name: str, target_doc: str | Document | None = None):
maint_schedule = frappe.db.sql( maint_schedule = frappe.db.exists(
"""select t1.name "Maintenance Schedule Item", {"sales_order": source_name, "docstatus": 1}
from `tabMaintenance Schedule` t1, `tabMaintenance Schedule Item` t2
where t2.parent=t1.name and t2.sales_order=%s and t1.docstatus=1""",
source_name,
) )
if not maint_schedule: if not maint_schedule: