From 983ae011f0b1366d8603e93c368a08a8a5691e49 Mon Sep 17 00:00:00 2001 From: Loic Oberle Date: Sat, 23 May 2026 08:27:27 +0200 Subject: [PATCH] refactor(sales_order): Replace SQL with ORM in make_maintenance_schedule (#55206) --- erpnext/selling/doctype/sales_order/sales_order.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index cbad5faa22d..5104e1a360e 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -1599,11 +1599,8 @@ def make_sales_invoice( @frappe.whitelist() def make_maintenance_schedule(source_name: str, target_doc: str | Document | None = None): - maint_schedule = frappe.db.sql( - """select t1.name - from `tabMaintenance Schedule` t1, `tabMaintenance Schedule Item` t2 - where t2.parent=t1.name and t2.sales_order=%s and t1.docstatus=1""", - source_name, + maint_schedule = frappe.db.exists( + "Maintenance Schedule Item", {"sales_order": source_name, "docstatus": 1} ) if not maint_schedule: