nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 08:54:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sales_order): Replace SQL with ORM in validate_proj_cust (#55202)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-23 08:26:25 +02:00
committed by GitHub
parent 9546374ac3
commit 6f9f6d3b7d
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/selling/doctype/sales_order/sales_order.py
View File

@@ -438,12 +438,10 @@ class SalesOrder(SellingController):
def validate_proj_cust(self):
if self.project and self.customer_name:
res = frappe.db.sql(
"""select name from `tabProject` where name = %s
and (customer = %s or ifnull(customer,'')='')""",
(self.project, self.customer),
project_has_valid_customer = frappe.db.exists(
"Project", {"name": self.project, "customer": ["in", [self.customer, "", None]]}
)
if not res:
if not project_has_valid_customer:
frappe.throw(
_("Customer {0} does not belong to project {1}").format(self.customer, self.project)
)