From 9134db9cd3d1779f08247e8c99dc1edf8efd5734 Mon Sep 17 00:00:00 2001 From: diptanilsaha Date: Tue, 12 May 2026 21:31:08 +0530 Subject: [PATCH] fix: added permission validation for `deactivate_sales_person` (#54884) --- erpnext/setup/doctype/employee/employee.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/setup/doctype/employee/employee.py b/erpnext/setup/doctype/employee/employee.py index f4f447bd5a8..850bc3f1b44 100755 --- a/erpnext/setup/doctype/employee/employee.py +++ b/erpnext/setup/doctype/employee/employee.py @@ -416,7 +416,8 @@ def is_holiday(employee, date=None, raise_exception=True, only_non_weekly=False, @frappe.whitelist() -def deactivate_sales_person(status: str | None = None, employee: str | None = None): +def deactivate_sales_person(status: str, employee: str): + frappe.has_permission("Employee", doc=employee, ptype="write", throw=True) if status == "Left": sales_person = frappe.db.get_value("Sales Person", {"Employee": employee}) if sales_person: