nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 22:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: avoid needless submit in SCO validation tests

Browse Source 
Use do_not_submit=1 for the service-item and reserve-warehouse validation
tests; they only exercise in-memory validation methods, so submitting the
Subcontracting Order is unnecessary.
This commit is contained in:
Nabin Hait
2026-06-22 14:25:34 +05:30
parent d68f7ea9d1
commit 8cb94ebedb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/subcontracting/doctype/subcontracting_order/test_subcontracting_order.py
View File

@@ -118,12 +118,12 @@ class TestSubcontractingOrder(ERPNextTestSuite):
self.assertRaises(frappe.ValidationError, sco.validate_purchase_order_for_subcontracting)
def test_service_item_must_be_non_stock(self):
sco = get_subcontracting_order()
sco = get_subcontracting_order(do_not_submit=1)
sco.service_items[0].item_code = "_Test Item" # a stock item
self.assertRaises(frappe.ValidationError, sco.validate_service_items)
def test_reserve_warehouse_must_differ_from_supplier_warehouse(self):
sco = get_subcontracting_order()
sco = get_subcontracting_order(do_not_submit=1)
sco.supplied_items[0].reserve_warehouse = sco.supplier_warehouse
self.assertRaises(frappe.ValidationError, sco.validate_supplied_items)