From 8cb94ebedb8dc8ad87f94909c39e312eba2511c6 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 22 Jun 2026 14:25:34 +0530 Subject: [PATCH] test: avoid needless submit in SCO validation tests Use do_not_submit=1 for the service-item and reserve-warehouse validation tests; they only exercise in-memory validation methods, so submitting the Subcontracting Order is unnecessary. --- .../doctype/subcontracting_order/test_subcontracting_order.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/subcontracting/doctype/subcontracting_order/test_subcontracting_order.py b/erpnext/subcontracting/doctype/subcontracting_order/test_subcontracting_order.py index dfae830a97b..0186549bb4d 100644 --- a/erpnext/subcontracting/doctype/subcontracting_order/test_subcontracting_order.py +++ b/erpnext/subcontracting/doctype/subcontracting_order/test_subcontracting_order.py @@ -118,12 +118,12 @@ class TestSubcontractingOrder(ERPNextTestSuite): self.assertRaises(frappe.ValidationError, sco.validate_purchase_order_for_subcontracting) def test_service_item_must_be_non_stock(self): - sco = get_subcontracting_order() + sco = get_subcontracting_order(do_not_submit=1) sco.service_items[0].item_code = "_Test Item" # a stock item self.assertRaises(frappe.ValidationError, sco.validate_service_items) def test_reserve_warehouse_must_differ_from_supplier_warehouse(self): - sco = get_subcontracting_order() + sco = get_subcontracting_order(do_not_submit=1) sco.supplied_items[0].reserve_warehouse = sco.supplier_warehouse self.assertRaises(frappe.ValidationError, sco.validate_supplied_items)