nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-18 08:58:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(setup): rollback before logging in update_regional_tax_settings (Postgres)

Browse Source 
Regional tax-template setup writes docs; on failure the except calls frappe.log_error with no rollback -> InFailedSqlTransaction on Postgres. Full rollback before log_error. No-op on MariaDB.
This commit is contained in:
Mihir Kandoi
2026-06-29 22:42:49 +05:30
parent 8c0b4a99cf
commit 44458b0ba5
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/setup/setup_wizard/operations/taxes_setup.py
View File

@@ -127,6 +127,7 @@ def update_regional_tax_settings(country, company):
pass
except Exception:
# Log error and ignore if failed to setup regional tax settings
frappe.db.rollback()
frappe.log_error("Unable to setup regional tax settings")