From 44458b0ba5d345794560e7aad4594afcb93e00f1 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 29 Jun 2026 22:42:49 +0530 Subject: [PATCH] fix(setup): rollback before logging in update_regional_tax_settings (Postgres) Regional tax-template setup writes docs; on failure the except calls frappe.log_error with no rollback -> InFailedSqlTransaction on Postgres. Full rollback before log_error. No-op on MariaDB. --- erpnext/setup/setup_wizard/operations/taxes_setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/erpnext/setup/setup_wizard/operations/taxes_setup.py b/erpnext/setup/setup_wizard/operations/taxes_setup.py index 5de54ddf53f..2e5e2c0c092 100644 --- a/erpnext/setup/setup_wizard/operations/taxes_setup.py +++ b/erpnext/setup/setup_wizard/operations/taxes_setup.py @@ -127,6 +127,7 @@ def update_regional_tax_settings(country, company): pass except Exception: # Log error and ignore if failed to setup regional tax settings + frappe.db.rollback() frappe.log_error("Unable to setup regional tax settings")