nsinnovations/fusionpbx
2
0
Fork 0
mirror of https://github.com/fusionpbx/fusionpbx.git synced 2025-12-30 00:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix adding Faxes (#6614)

Browse Source 
$fax_email_outbound_authorized_senders is only filled when fax_extension_advanced permission is set. However, the edit part doesn't verify that sizeof(NULL) creates a fatal error.

Fatal error: Uncaught TypeError: sizeof(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/fusionpbx/app/fax/fax_edit.php:286 Stack trace: #0 {main} thrown in /var/www/fusionpbx/app/fax/fax_edit.php on line 286

This patch verifies that $fax_email_outbound_authorized_senders is an array before sizeof() evaluates it. You can now add faxes with the fax_extension_advanced disabled.
This commit is contained in:
Luis Daniel Lucio Quiroz
2023-04-24 23:06:58 -04:00
committed by GitHub
parent 2edfb9a0c2
commit 0c28221ae2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/fax/fax_edit.php
View File

@@ -283,7 +283,7 @@
if ($_POST["persistformvar"] != "true") {
//prep authorized senders
if (sizeof($fax_email_outbound_authorized_senders) > 0) {
if (is_array($fax_email_outbound_authorized_senders) && (sizeof($fax_email_outbound_authorized_senders) > 0)) {
foreach ($fax_email_outbound_authorized_senders as $sender_num => $sender) {
if ($sender == '' || (substr_count($sender, '@') == 1 && !valid_email($sender)) || substr_count($sender, '.') == 0) {
unset($fax_email_outbound_authorized_senders[$sender_num]);