erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-08-14 23:18:40 +00:00

Files

Mihir Kandoi 3abadc7a5f fix(controllers): fix supplier-RFQ portal list query (wrong column + Postgres DISTINCT)

rfq_transaction_list had two defects introduced when it was converted to the query
builder:

1. `party.supplier == party[0]` compared supplier to a column literally named "0"
   (a stray index on the DocType, not the intended `parties[0]` value). This renders
   as `supplier = \`0\`` / `supplier = "0"` and errors on BOTH engines
   (MariaDB: Unknown column '0'; Postgres: column "0" does not exist), so the
   supplier portal RFQ list was completely broken.
2. SELECT DISTINCT ordered by `creation`, which is not in the select list. Postgres
   rejects this ("for SELECT DISTINCT, ORDER BY expressions must appear in select list").

Compare against `parties[0]` and add `creation` to the select list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
(cherry picked from commit a7d9078bf4)

# Conflicts:
#	erpnext/controllers/tests/test_website_list_for_contact.py

2026-06-29 08:24:18 +00:00

__init__.py

[fix] removed bad import

2016-06-09 16:56:54 +05:30

test_accounts_controller.py

refactor(test): broken test case in accounts controller

2026-06-29 09:41:48 +05:30

test_distributed_discount.py

refactor(test): remove AccountsTestMixin from distributed discount

2026-03-31 09:32:44 +00:00

test_item_variant.py

feat: allow creation of any number of variants in multiple item variant creation dialog