nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-11 19:05:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): hardcoded names over dynamic ones

Browse Source 
Much faster bootstrap without those get_doc calls
This commit is contained in:
ruthra kumar
2026-03-01 21:33:45 +05:30
parent 41de44f905
commit 495e585ab6
26 changed files with 67 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/accounts/doctype/process_deferred_accounting/test_process_deferred_accounting.py
View File

@@ -53,7 +53,7 @@ class TestProcessDeferredAccounting(ERPNextTestSuite):
start_date="2023-05-01",
end_date="2023-06-30",
type="Income",
company=self.companies[0].name,
company="_Test Company",
)
process_deferred_accounting.insert()
@@ -84,7 +84,7 @@ class TestProcessDeferredAccounting(ERPNextTestSuite):
start_date="2019-01-01",
end_date="2019-01-31",
type="Income",
company=self.companies[0].name,
company="_Test Company",
)
pda.submit()
pda.cancel()

4
erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
View File

@@ -2272,7 +2272,7 @@ class TestPurchaseInvoice(ERPNextTestSuite, StockTestMixin):
def test_create_purchase_invoice_without_mandatory(self):
pi = frappe.new_doc("Purchase Invoice")
pi.company = self.companies[0].name
pi.company = "_Test Company"
pi.flags.ignore_mandatory = True
pi.insert(ignore_permissions=True)
@@ -2401,7 +2401,7 @@ class TestPurchaseInvoice(ERPNextTestSuite, StockTestMixin):
"doctype": "Serial No",
"item_code": serial_item,
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()

2
erpnext/controllers/tests/test_mapper.py
View File

@@ -40,7 +40,7 @@ class TestMapper(ERPNextTestSuite):
"order_type": "Sales",
"transaction_date": nowdate(),
"valid_till": add_months(nowdate(), 1),
"company": self.companies[0].name,
"company": "_Test Company",
}
)
for item in item_list:

2
erpnext/controllers/tests/test_subcontracting_controller.py
View File

@@ -742,7 +742,7 @@ class TestSubcontractingController(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": "Subcontracted SRM Item 2",
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()

2
erpnext/crm/doctype/lead/test_lead.py
View File

@@ -122,7 +122,7 @@ class TestLead(ERPNextTestSuite):
create_todo("followup", "Lead", lead.name)
opportunity = make_opportunity(lead.name)
opportunity.company = self.companies[0].name
opportunity.company = "_Test Company"
opportunity.save()
self.assertEqual(opportunity.get("party_name"), lead.name)

2
erpnext/crm/doctype/opportunity/test_opportunity.py
View File

@@ -56,7 +56,7 @@ class TestOpportunity(ERPNextTestSuite):
self.assertEqual(doc.status, "Quotation")
def test_make_new_lead_if_required(self):
opp_doc = make_opportunity_from_lead(self.companies[0].name)
opp_doc = make_opportunity_from_lead("_Test Company")
self.assertTrue(opp_doc.party_name)
self.assertEqual(opp_doc.opportunity_from, "Lead")

4
erpnext/crm/doctype/prospect/test_prospect.py
View File

@@ -12,7 +12,7 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestProspect(ERPNextTestSuite):
def test_add_lead_to_prospect_and_address_linking(self):
company = self.companies[0].name
company = "_Test Company"
lead_doc = make_lead()
address_doc = make_address(address_title=lead_doc.name)
address_doc.append("links", {"link_doctype": lead_doc.doctype, "link_name": lead_doc.name})
@@ -38,7 +38,7 @@ class TestProspect(ERPNextTestSuite):
"doctype": "Prospect",
"company_name": "_Test Prospect",
"customer_group": "_Test Customer Group",
"company": self.companies[0].name,
"company": "_Test Company",
}
)
prospect.insert()

2
erpnext/erpnext_integrations/doctype/plaid_settings/test_plaid_settings.py
View File

@@ -56,7 +56,7 @@ class TestPlaidSettings(ERPNextTestSuite):
}
bank = json.dumps(frappe.get_doc("Bank", "Citi").as_dict(), default=json_handler)
company = self.companies[0].name
company = "_Test Company"
add_bank_accounts(bank_accounts, bank, company)

10
erpnext/manufacturing/doctype/bom/test_bom.py
View File

@@ -392,7 +392,7 @@ class TestBOM(ERPNextTestSuite):
item_code = make_item(properties={"is_stock_item": 1}).name
bom = frappe.new_doc("BOM")
bom.company = self.companies[0].name
bom.company = "_Test Company"
bom.item = item_code
bom.append("items", frappe._dict(item_code=item_code))
bom.save()
@@ -406,13 +406,13 @@ class TestBOM(ERPNextTestSuite):
item2 = make_item(properties={"is_stock_item": 1}).name
bom1 = frappe.new_doc("BOM")
bom1.company = self.companies[0].name
bom1.company = "_Test Company"
bom1.item = item1
bom1.append("items", frappe._dict(item_code=item2))
bom1.save()
bom2 = frappe.new_doc("BOM")
bom2.company = self.companies[0].name
bom2.company = "_Test Company"
bom2.item = item2
bom2.append("items", frappe._dict(item_code=item1))
bom2.save()
@@ -570,7 +570,7 @@ class TestBOM(ERPNextTestSuite):
@timeout
def test_clear_inpection_quality(self):
bom = frappe.copy_doc(self.globalTestRecords["BOM"][2], ignore_no_copy=True)
bom.company = self.companies[0].name
bom.company = "_Test Company"
bom.docstatus = 0
bom.is_default = 0
bom.quality_inspection_template = "_Test Quality Inspection Template"
@@ -616,7 +616,7 @@ class TestBOM(ERPNextTestSuite):
# Step 1: Create BOM
bom = frappe.new_doc("BOM")
bom.company = self.companies[0].name
bom.company = "_Test Company"
bom.item = fg_item.item_code
bom.quantity = 1
bom.append(

4
erpnext/manufacturing/doctype/job_card/test_job_card.py
View File

@@ -87,7 +87,7 @@ class TestJobCard(ERPNextTestSuite):
quantity=1,
with_operations=1,
track_semi_finished_goods=1,
company=self.companies[9].name,
company="_Test Company",
)
final_bom.append("items", {"item_code": raw.name, "qty": 1})
final_bom.append(
@@ -121,7 +121,7 @@ class TestJobCard(ERPNextTestSuite):
final_bom.append("items", {"item_code": stitch_fg.name, "qty": 1, "operation_row_id": 3})
final_bom.submit()
work_order = make_work_order(final_bom.name, final.name, 1, variant_items=[], use_multi_level_bom=0)
work_order.company = self.companies[9].name
work_order.company = "_Test Company"
work_order.wip_warehouse = "Work In Progress - WP"
work_order.fg_warehouse = "Finished Goods - WP"
work_order.scrap_warehouse = "All Warehouses - WP"

4
erpnext/manufacturing/doctype/work_order/test_work_order.py
View File

@@ -960,7 +960,7 @@ class TestWorkOrder(ERPNextTestSuite):
bom_item,
fg_qty=1,
process_loss_percentage=10,
company=self.companies[0].name,
company="_Test Company",
)
bom_doc.submit()
@@ -1147,7 +1147,7 @@ class TestWorkOrder(ERPNextTestSuite):
"is_active": 1,
"is_default": 1,
"quantity": 1.0,
"company": self.companies[0].name,
"company": "_Test Company",
"with_operations": 1,
"operations": [
{

2
erpnext/projects/doctype/project/test_project.py
View File

@@ -18,7 +18,7 @@ class TestProject(ERPNextTestSuite):
from erpnext.setup.doctype.employee.test_employee import make_employee
project_name = "Test Project Costing"
employee = make_employee("employee@frappe.io", company=self.companies[0].name)
employee = make_employee("employee@frappe.io", company="_Test Company")
project = make_project({"project_name": project_name})
timesheet = make_timesheet(
employee=employee,

2
erpnext/projects/doctype/task/test_task.py
View File

@@ -16,7 +16,7 @@ class TestTask(ERPNextTestSuite):
from erpnext.setup.doctype.employee.test_employee import make_employee
project_name = "Test Project Costing"
employee = make_employee("employee@frappe.io", company=self.companies[0].name)
employee = make_employee("employee@frappe.io", company="_Test Company")
project = make_project({"project_name": project_name})
task = create_task("_Test Task 1")
task.project = project.name

18
erpnext/projects/doctype/timesheet/test_timesheet.py
View File

@@ -65,7 +65,7 @@ class TestTimesheet(ERPNextTestSuite):
)
def test_timesheet_base_amount(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
timesheet = make_timesheet(emp, simulate=True, is_billable=1)
self.assertEqual(timesheet.time_logs[0].base_billing_rate, 50)
@@ -74,7 +74,7 @@ class TestTimesheet(ERPNextTestSuite):
self.assertEqual(timesheet.time_logs[0].base_costing_amount, 40)
def test_timesheet_billing_amount(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
timesheet = make_timesheet(emp, simulate=True, is_billable=1)
self.assertEqual(timesheet.total_hours, 2)
@@ -84,7 +84,7 @@ class TestTimesheet(ERPNextTestSuite):
self.assertEqual(timesheet.total_billable_amount, 100)
def test_timesheet_billing_amount_not_billable(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
timesheet = make_timesheet(emp, simulate=True, is_billable=0)
self.assertEqual(timesheet.total_hours, 2)
@@ -94,7 +94,7 @@ class TestTimesheet(ERPNextTestSuite):
self.assertEqual(timesheet.total_billable_amount, 0)
def test_sales_invoice_from_timesheet(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
timesheet = make_timesheet(emp, simulate=True, is_billable=1)
sales_invoice = make_sales_invoice(timesheet.name, "_Test Item", "_Test Customer", currency="INR")
@@ -112,7 +112,7 @@ class TestTimesheet(ERPNextTestSuite):
@ERPNextTestSuite.change_settings("Projects Settings", {"fetch_timesheet_in_sales_invoice": 1})
def test_timesheet_billing_based_on_project(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
project = frappe.get_value("Project", {"project_name": "_Test Project"})
timesheet = make_timesheet(
@@ -128,7 +128,7 @@ class TestTimesheet(ERPNextTestSuite):
self.assertEqual(ts.time_logs[0].sales_invoice, sales_invoice.name)
def test_timesheet_time_overlap(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
settings = frappe.get_single("Projects Settings")
initial_setting = settings.ignore_employee_time_overlap
@@ -184,7 +184,7 @@ class TestTimesheet(ERPNextTestSuite):
settings.save()
def test_timesheet_not_overlapping_with_continuous_timelogs(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
update_activity_type("_Test Activity Type")
timesheet = frappe.new_doc("Timesheet")
@@ -213,7 +213,7 @@ class TestTimesheet(ERPNextTestSuite):
timesheet.save() # should not throw an error
def test_to_time(self):
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
from_time = now_datetime()
timesheet = frappe.new_doc("Timesheet")
@@ -279,7 +279,7 @@ class TestTimesheet(ERPNextTestSuite):
This test ensures Timesheet status is recalculated correctly
across billing and return lifecycle events.
"""
emp = make_employee("test_employee_6@salary.com", company=self.companies[0].name)
emp = make_employee("test_employee_6@salary.com", company="_Test Company")
timesheet = make_timesheet(emp, simulate=True, is_billable=1, do_not_submit=True)
timesheet_detail = timesheet.append("time_logs", {})

2
erpnext/setup/doctype/department/test_department.py
View File

@@ -9,7 +9,7 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestDepartment(ERPNextTestSuite):
def test_remove_department_data(self):
doc = create_department("Test Department", company=self.companies[0].name)
doc = create_department("Test Department", company="_Test Company")
frappe.delete_doc("Department", doc.name)

12
erpnext/setup/doctype/employee/test_employee.py
View File

@@ -14,8 +14,8 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestEmployee(ERPNextTestSuite):
def test_employee_status_left(self):
employee1 = make_employee("test_employee_1@company.com", company=self.companies[0].name)
employee2 = make_employee("test_employee_2@company.com", company=self.companies[0].name)
employee1 = make_employee("test_employee_1@company.com", company="_Test Company")
employee2 = make_employee("test_employee_2@company.com", company="_Test Company")
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)
employee2_doc.reload()
@@ -26,7 +26,7 @@ class TestEmployee(ERPNextTestSuite):
self.assertRaises(InactiveEmployeeStatusError, employee1_doc.save)
def test_user_has_employee(self):
employee = make_employee("test_emp_user_creation@company.com", company=self.companies[0].name)
employee = make_employee("test_emp_user_creation@company.com", company="_Test Company")
employee_doc = frappe.get_doc("Employee", employee)
user = employee_doc.user_id
self.assertTrue("Employee" in frappe.get_roles(user))
@@ -36,12 +36,12 @@ class TestEmployee(ERPNextTestSuite):
def test_employee_user_permission(self):
employee1 = make_employee(
"employee_1_test@company.com", create_user_permission=1, company=self.companies[0].name
"employee_1_test@company.com", create_user_permission=1, company="_Test Company"
)
employee2 = make_employee(
"employee_2_test@company.com", create_user_permission=1, company=self.companies[0].name
"employee_2_test@company.com", create_user_permission=1, company="_Test Company"
)
make_employee("employee_3_test@company.com", create_user_permission=1, company=self.companies[0].name)
make_employee("employee_3_test@company.com", create_user_permission=1, company="_Test Company")
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)

6
erpnext/stock/doctype/delivery_note/test_delivery_note.py
View File

@@ -161,7 +161,7 @@ class TestDeliveryNote(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": "_Test Serialized Item With Series",
"serial_no": make_autoname("SRDD", "Serial No"),
"company": self.companies[0].name,
"company": "_Test Company",
}
)
serial_no.save()
@@ -226,7 +226,7 @@ class TestDeliveryNote(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": sn_item,
"serial_no": sn,
"company": self.companies[0].name,
"company": "_Test Company",
}
)
sn_doc.insert()
@@ -1837,7 +1837,7 @@ class TestDeliveryNote(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": sn_item,
"serial_no": sn,
"company": self.companies[0].name,
"company": "_Test Company",
}
)
sn_doc.insert()

4
erpnext/stock/doctype/delivery_trip/test_delivery_trip.py
View File

@@ -22,14 +22,14 @@ class TestDeliveryTrip(ERPNextTestSuite):
create_test_contact_and_address()
address = create_address(driver)
self.delivery_trip = create_delivery_trip(driver, address, company=self.companies[0].name)
self.delivery_trip = create_delivery_trip(driver, address, company="_Test Company")
def test_delivery_trip_notify_customers(self):
# set default outgoing
outgoing = frappe.get_doc(
{
"doctype": "Email Account",
"company": self.companies[0].name,
"company": "_Test Company",
"enable_outgoing": 1,
"default_outgoing": 1,
"awaiting_password": 1,

8
erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py
View File

@@ -401,7 +401,7 @@ class TestLandedCostVoucher(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": item_code,
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()
@@ -670,7 +670,7 @@ class TestLandedCostVoucher(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": sn_item,
"serial_no": sn,
"company": self.companies[0].name,
"company": "_Test Company",
}
)
sn_doc.insert()
@@ -821,7 +821,7 @@ class TestLandedCostVoucher(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": sn_item,
"serial_no": sn,
"company": self.companies[0].name,
"company": "_Test Company",
}
)
sn_doc.insert()
@@ -1012,7 +1012,7 @@ class TestLandedCostVoucher(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": sn_item,
"serial_no": sn,
"company": self.companies[0].name,
"company": "_Test Company",
}
)
sn_doc.insert()

6
erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
View File

@@ -739,7 +739,7 @@ class TestPurchaseReceipt(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": item_code,
"serial_no": serial_no[0],
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()
@@ -2698,7 +2698,7 @@ class TestPurchaseReceipt(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": serial_item,
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()
@@ -3992,7 +3992,7 @@ class TestPurchaseReceipt(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": serial_item,
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()

6
erpnext/stock/doctype/serial_and_batch_bundle/test_serial_and_batch_bundle.py
View File

@@ -40,7 +40,7 @@ class TestSerialandBatchBundle(ERPNextTestSuite):
"doctype": "Serial No",
"serial_no": sn,
"item_code": serial_item_code,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert(ignore_permissions=True)
@@ -707,7 +707,7 @@ class TestSerialandBatchBundle(ERPNextTestSuite):
"doctype": "Serial No",
"serial_no": serial_no,
"item_code": item,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert(ignore_permissions=True)
@@ -805,7 +805,7 @@ class TestSerialandBatchBundle(ERPNextTestSuite):
"doctype": "Serial No",
"serial_no": serial_no,
"item_code": sn_item,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert(ignore_permissions=True)
serial_nos.append(serial_no)

4
erpnext/stock/doctype/serial_no/test_serial_no.py
View File

@@ -34,7 +34,7 @@ class TestSerialNo(ERPNextTestSuite):
sr.warehouse = "_Test Warehouse - _TC"
sr.serial_no = "_TCSER0001"
sr.purchase_rate = 10
sr.company = self.companies[0].name
sr.company = "_Test Company"
self.assertRaises(SerialNoCannotCreateDirectError, sr.insert)
sr.warehouse = None
@@ -198,7 +198,7 @@ class TestSerialNo(ERPNextTestSuite):
"doctype": "Serial No",
"item_code": item_code,
"serial_no": serial_no,
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()

2
erpnext/stock/doctype/stock_entry/test_stock_entry.py
View File

@@ -649,7 +649,7 @@ class TestStockEntry(ERPNextTestSuite):
doc = frappe.new_doc("Serial No")
doc.serial_no = serial_no
doc.item_code = "_Test Serialized Item"
doc.company = self.companies[0].name
doc.company = "_Test Company"
doc.insert(ignore_permissions=True)
se = frappe.copy_doc(self.globalTestRecords["Stock Entry"][0])

2
erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py
View File

@@ -612,7 +612,7 @@ class TestStockReconciliation(ERPNextTestSuite, StockTestMixin):
"doctype": "Serial No",
"item_code": item_code,
"serial_no": "SR-CREATED-SR-NO",
"company": self.companies[0].name,
"company": "_Test Company",
}
).insert()

2
erpnext/stock/tests/test_utils.py
View File

@@ -89,7 +89,7 @@ class TestStockUtilities(ERPNextTestSuite, StockTestMixin):
doctype="Serial No",
item_code=serial_item.name,
serial_no=frappe.generate_hash(),
company=self.companies[0].name,
company="_Test Company",
).insert()
serial_scan = scan_barcode(serial.name)

9
erpnext/tests/utils.py
View File

@@ -2992,9 +2992,18 @@ class ERPNextTestSuite(unittest.TestCase):
return decorator
@classmethod
def setUpClass(cls):
cls.globalTestRecords = {}
def tearDown(self):
frappe.db.rollback()
def load_test_records(self, doctype):
if doctype not in self.globalTestRecords:
records = load_test_records_for(doctype)
self.globalTestRecords[doctype] = records[doctype]
@contextmanager
def set_user(self, user: str):
try: