erpnext

mirror of https://github.com/frappe/erpnext.git synced 2026-08-24 04:26:38 +00:00

Files

R-Jayaraman aa71cd695b fix(sales): reject sales returns where every item has zero quantity

validate_returned_items() set items_returned=True whenever a row matched
a valid item from the original document, even if its qty was 0. This let
a Sales Invoice, Delivery Note, or POS Invoice return be submitted with
every line at qty=0 - a no-op document with no stock or financial effect
that still consumed a document number and linked back to the original
transaction.

Scoped to the Sales side only: items_returned now flips to True for
Sales Invoice/Delivery Note/POS Invoice only when qty (or received_qty)
is actually negative, so an all-zero sales return correctly hits the
existing "At least one item should be entered with negative quantity"
check. Purchase Invoice, Purchase Receipt, and Subcontracting Receipt
are unchanged.

(cherry picked from commit a3e9d13da3)

2026-08-03 07:35:29 +00:00

tests

test(purchase): drop unrelated sales-return test from the backport

2026-08-03 12:42:10 +05:30

__init__.py

moved modules inside erpnext folder

2013-12-11 10:43:52 +05:30

accounts_controller.py

fix(selling): don't require cancel and delete perms to remove items via Update Items (backport #57419 ) (#57601 )

2026-07-29 11:30:36 +00:00

budget_controller.py

fix: multiple minor fixes