fix(stock): keep the source warehouse qty on purchase receipts only

The stock ledger of a Purchase Invoice that updates stock is built by the same controller, but its GL entries have no accounting for rejected material at all. Taking the rejected qty out of the in-transit warehouse there would move stock that the invoice never books, so the two ledgers would disagree.
style(stock): shorten the source warehouse qty docstring
2026-09-22 12:57:14 +00:00 · 2026-09-21 11:55:13 +05:30 · 2026-09-21 11:48:12 +05:30 · 2026-09-19 13:21:16 +05:30 · 2026-09-19 13:21:16 +05:30
368 changed files with 2303 additions and 4675 deletions
--- a/.github/workflows/review-translation-changes.yaml
+++ b/.github/workflows/review-translation-changes.yaml
@@ -22,6 +22,6 @@ jobs:
      pull-requests: write

    steps:
-      - uses: alyf-de/po-review-action@57fff275f4a0518a2ca55869ec6776fa3813b3d5 # v1.2.0
+      - uses: alyf-de/po-review-action@5928f84d6bc9094f9ad6e2c5780f01c0044b800e # v1.1.1
        with:
          hidden-po-files: eo.po
--- a/erpnext/accounts/custom/address.py
+++ b/erpnext/accounts/custom/address.py
@@ -47,13 +47,10 @@ class ERPNextAddress(Address):
 			super().on_update()

 		address_display = get_address_display(self.as_dict())
-		customers = frappe.db.get_all(
-			"Customer", filters={"customer_primary_address": self.name}, pluck="name"
-		)
-		for customer in customers:
-			frappe.db.set_value(
-				"Customer", customer, "primary_address", address_display, update_modified=False
-			)
+		filters = {"customer_primary_address": self.name}
+		customers = frappe.db.get_all("Customer", filters=filters, as_list=True)
+		for customer_name in customers:
+			frappe.db.set_value("Customer", customer_name[0], "primary_address", address_display)


@frappe.whitelist()
--- a/erpnext/accounts/doctype/account/account.json
+++ b/erpnext/accounts/doctype/account/account.json
@@ -7,7 +7,6 @@
 "description": "Heads (or groups) against which Accounting Entries are made and balances are maintained.",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/chart-of-accounts",
 "engine": "InnoDB",
 "field_order": [
  "properties",
@@ -201,7 +200,7 @@
   "options": "Account Category"
  }
 ],
- "icon": "vault",
+ "icon": "fa fa-money",
 "idx": 1,
 "is_tree": 1,
 "links": [],
--- a/erpnext/accounts/doctype/account_category/account_category.json
+++ b/erpnext/accounts/doctype/account_category/account_category.json
@@ -40,7 +40,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "folder-tree",
 "index_web_pages_for_search": 1,
 "links": [
  {
--- a/erpnext/accounts/doctype/account_closing_balance/account_closing_balance.json
+++ b/erpnext/accounts/doctype/account_closing_balance/account_closing_balance.json
@@ -148,7 +148,7 @@
   "precision": "9"
  }
 ],
- "icon": "scale",
+ "icon": "fa fa-list",
 "in_create": 1,
 "links": [],
 "modified": "2025-08-22 19:13:50.400404",
--- a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.json
+++ b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.json
@@ -3,7 +3,6 @@
 "autoname": "field:label",
 "creation": "2019-05-04 18:13:37.002352",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/accounting-dimensions",
 "engine": "InnoDB",
 "field_order": [
  "document_type",
@@ -50,7 +49,6 @@
   "options": "Accounting Dimension Detail"
  }
 ],
- "icon": "layers",
 "links": [],
 "modified": "2024-03-27 13:05:56.890002",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.json
+++ b/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.json
@@ -3,7 +3,6 @@
 "autoname": "format:{accounting_dimension}-{#####}",
 "creation": "2020-11-08 18:28:11.906146",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/accounting-dimension-filter",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -100,7 +99,6 @@
   "label": "Fieldname"
  }
 ],
- "icon": "funnel",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2025-08-08 14:13:22.203011",
--- a/erpnext/accounts/doctype/accounting_period/accounting_period.json
+++ b/erpnext/accounts/doctype/accounting_period/accounting_period.json
@@ -3,7 +3,6 @@
 "autoname": "field:period_name",
 "creation": "2018-04-13 18:50:14.672323",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/accounting-period",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -78,7 +77,6 @@
   "options": "Role"
  }
 ],
- "icon": "calendar-range",
 "links": [],
 "modified": "2026-03-09 17:15:33.577217",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json
+++ b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json
@@ -3,7 +3,6 @@
 "creation": "2013-06-24 15:49:57",
 "doctype": "DocType",
 "document_type": "Other",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/accounts-settings",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -802,7 +801,7 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "settings",
+ "icon": "icon-cog",
 "idx": 1,
 "index_web_pages_for_search": 1,
 "issingle": 1,
--- a/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json
+++ b/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json
@@ -4,7 +4,6 @@
 "creation": "2024-10-16 16:57:12.085072",
 "doctype": "DocType",
 "engine": "InnoDB",
- "icon": "book-open",
 "is_submittable": 1,
 "field_order": [
  "company",
--- a/erpnext/accounts/doctype/bank/bank.json
+++ b/erpnext/accounts/doctype/bank/bank.json
@@ -6,7 +6,6 @@
 "creation": "2018-04-07 16:59:59.496668",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/bank",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -101,7 +100,6 @@
   "read_only": 1
  }
 ],
- "icon": "landmark",
 "links": [],
 "modified": "2026-08-21 23:11:39.423431",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/bank_account/bank_account.json
+++ b/erpnext/accounts/doctype/bank_account/bank_account.json
@@ -5,7 +5,6 @@
 "creation": "2017-05-29 21:35:13.136357",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/bank-account",
 "engine": "InnoDB",
 "field_order": [
  "account_name",
@@ -228,7 +227,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "credit-card",
 "links": [
  {
   "group": "Transactions",
--- a/erpnext/accounts/doctype/bank_account_balance/bank_account_balance.json
+++ b/erpnext/accounts/doctype/bank_account_balance/bank_account_balance.json
@@ -44,7 +44,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "wallet",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-06-16 22:17:48.007982",
--- a/erpnext/accounts/doctype/bank_account_subtype/bank_account_subtype.json
+++ b/erpnext/accounts/doctype/bank_account_subtype/bank_account_subtype.json
@@ -18,7 +18,6 @@
   "unique": 1
  }
 ],
- "icon": "credit-card",
 "links": [],
 "modified": "2024-03-27 13:06:37.221876",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/bank_account_type/bank_account_type.json
+++ b/erpnext/accounts/doctype/bank_account_type/bank_account_type.json
@@ -18,7 +18,6 @@
   "unique": 1
  }
 ],
- "icon": "credit-card",
 "links": [],
 "modified": "2024-03-27 13:06:37.347035",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/bank_clearance/bank_clearance.json
+++ b/erpnext/accounts/doctype/bank_clearance/bank_clearance.json
@@ -87,7 +87,7 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "badge-check",
+ "icon": "fa fa-check",
 "idx": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/bank_guarantee/bank_guarantee.json
+++ b/erpnext/accounts/doctype/bank_guarantee/bank_guarantee.json
@@ -5,7 +5,6 @@
 "creation": "2016-12-17 10:43:35.731631",
 "doctype": "DocType",
 "document_type": "Document",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/bank-guarantee",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -217,7 +216,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "shield-check",
 "is_submittable": 1,
 "links": [],
 "modified": "2026-05-25 18:12:10.768835",
--- a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.json
+++ b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.json
@@ -116,7 +116,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "arrow-left-right",
 "index_web_pages_for_search": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
+++ b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py
@@ -792,7 +792,6 @@ def create_bulk_payment_entry_and_reconcile(
 				"deposit",
 				"withdrawal",
 				"bank_account",
-				"company",
 				"currency",
 				"unallocated_amount",
 				"date",
@@ -827,7 +826,11 @@ def create_bulk_payment_entry_and_reconcile(
 				"paid_from": paid_from,
 				"paid_to": paid_to,
 				"paid_amount": bank_transaction.unallocated_amount,
+				"base_paid_amount": bank_transaction.unallocated_amount,
 				"received_amount": bank_transaction.unallocated_amount,
+				"base_received_amount": bank_transaction.unallocated_amount,
+				"target_exchange_rate": 1,
+				"source_exchange_rate": 1,
 				"reference_date": bank_transaction.date,
 				"posting_date": bank_transaction.date,
 				"reference_no": (bank_transaction.reference_number or bank_transaction.description or "")[
@@ -836,8 +839,6 @@ def create_bulk_payment_entry_and_reconcile(
 			}
 		)

-		set_multi_currency_amounts(payment_entry_doc)
-
 		payment_entry_doc.insert()
 		payment_entry_doc.submit()

@@ -876,7 +877,6 @@ def create_payment_entry_and_reconcile(bank_transaction_name: str | int, payment
 			"doctype": "Payment Entry",
 		}
 	)
-	set_multi_currency_amounts(payment_entry)
 	payment_entry.insert()
 	payment_entry.submit()
 	transaction = reconcile_vouchers(
@@ -899,33 +899,6 @@ def create_payment_entry_and_reconcile(bank_transaction_name: str | int, payment
 	}


-def set_multi_currency_amounts(pe):
-	"""Set real exchange rates when the bank and party accounts differ in currency."""
-	company_currency = frappe.get_cached_value("Company", pe.company, "default_currency")
-	pe.paid_from_account_currency = frappe.get_cached_value("Account", pe.paid_from, "account_currency")
-	pe.paid_to_account_currency = frappe.get_cached_value("Account", pe.paid_to, "account_currency")
-
-	pe.source_exchange_rate = (
-		1.0
-		if pe.paid_from_account_currency == company_currency
-		else get_exchange_rate(pe.paid_from_account_currency, company_currency, pe.posting_date)
-	)
-	pe.target_exchange_rate = (
-		1.0
-		if pe.paid_to_account_currency == company_currency
-		else get_exchange_rate(pe.paid_to_account_currency, company_currency, pe.posting_date)
-	)
-
-	# derive the party-side amount from the authoritative bank-side amount; Payment Entry books any
-	# rounding residual to Exchange Gain/Loss during validation (set_exchange_gain_loss)
-	if pe.payment_type == "Receive" and pe.source_exchange_rate:
-		base_amount = flt(pe.received_amount) * pe.target_exchange_rate
-		pe.paid_amount = flt(base_amount / pe.source_exchange_rate, pe.precision("paid_amount"))
-	elif pe.payment_type == "Pay" and pe.target_exchange_rate:
-		base_amount = flt(pe.paid_amount) * pe.source_exchange_rate
-		pe.received_amount = flt(base_amount / pe.target_exchange_rate, pe.precision("received_amount"))
-
-
@frappe.whitelist(methods=["GET"])
 def search_for_transfer_transaction(transaction_id: str | int):
 	"""
--- a/erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py
+++ b/erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py
@@ -2,16 +2,12 @@
 # See license.txt


-from unittest.mock import patch
-
 import frappe
 from frappe import qb
 from frappe.utils import add_days, today

 from erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool import (
 	auto_reconcile_vouchers,
-	create_bulk_payment_entry_and_reconcile,
-	create_payment_entry_and_reconcile,
 	get_auto_reconcile_message,
 	get_bank_transactions,
 	get_linked_payments,
@@ -20,8 +16,6 @@ from erpnext.accounts.doctype.payment_entry.test_payment_entry import create_pay
 from erpnext.accounts.test.accounts_mixin import AccountsTestMixin
 from erpnext.tests.utils import ERPNextTestSuite

-RATE_METHOD = "erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool.get_exchange_rate"
-

 class TestBankReconciliationTool(ERPNextTestSuite, AccountsTestMixin):
 	def setUp(self):
@@ -236,117 +230,3 @@ class TestBankReconciliationTool(ERPNextTestSuite, AccountsTestMixin):
 		self.assertIn("1 Transaction Partially Reconciled", singular)
 		plural, _ = get_auto_reconcile_message(["p1", "p2"], [])
 		self.assertIn("2 Transactions Partially Reconciled", plural)
-
-	def test_multi_currency_pay_converts_and_balances(self):
-		# withdrawal from an INR bank paying a USD supplier; rate 3.0 makes 100/3 non-exact
-		self.enable_multi_currency_setup()
-		pe = self.reconcile_new_payment(
-			self.make_multi_currency_txn(withdrawal=100),
-			payment_type="Pay",
-			party_type="Supplier",
-			party=self.supplier,
-			party_account=self.creditors_usd,
-			paid_from=self.bank,
-			paid_to=self.creditors_usd,
-			rate=3.0,
-		)
-		self.assertEqual(pe.docstatus, 1)  # submits despite the rounding residual
-		self.assertEqual((pe.source_exchange_rate, pe.target_exchange_rate), (1.0, 3.0))
-		self.assertEqual((pe.paid_amount, pe.received_amount), (100, 33.33))  # bank side kept, 100/3
-		self.assertEqual(pe.difference_amount, 0)
-		# Payment Entry auto-books the rounding residual to Exchange Gain/Loss
-		self.assertTrue(pe.deductions[0].is_exchange_gain_loss)
-		self.assertEqual(pe.deductions[0].amount, 0.01)  # 100 - 33.33 * 3
-
-	def test_multi_currency_receive_converts_and_balances(self):
-		# deposit into an INR bank from a USD customer; the party side must convert
-		self.enable_multi_currency_setup()
-		pe = self.reconcile_new_payment(
-			self.make_multi_currency_txn(deposit=100),
-			payment_type="Receive",
-			party_type="Customer",
-			party=self.customer,
-			party_account=self.debtors_usd,
-			paid_from=self.debtors_usd,
-			paid_to=self.bank,
-			rate=3.0,
-		)
-		self.assertEqual(pe.docstatus, 1)
-		self.assertEqual((pe.source_exchange_rate, pe.target_exchange_rate), (3.0, 1.0))
-		self.assertEqual((pe.received_amount, pe.paid_amount), (100, 33.33))  # bank side kept, 100/3
-		self.assertEqual(pe.difference_amount, 0)
-
-	def test_multi_currency_bulk_pay_converts_and_balances(self):
-		# the bulk path builds the Payment Entry itself, so it must convert too
-		self.enable_multi_currency_setup()
-		txn = self.make_multi_currency_txn(withdrawal=100)
-		with patch(RATE_METHOD, return_value=3.0):
-			result = create_bulk_payment_entry_and_reconcile(
-				[txn.name], "Supplier", self.supplier, self.creditors_usd
-			)
-
-		pe = frappe.get_doc("Payment Entry", result[0]["payment_entry"].name)
-		self.assertEqual(pe.docstatus, 1)
-		self.assertEqual(pe.target_exchange_rate, 3.0)
-		self.assertEqual((pe.paid_amount, pe.received_amount), (100, 33.33))
-		self.assertEqual(pe.difference_amount, 0)
-
-	def enable_multi_currency_setup(self):
-		# USD party/accounts + a company gain/loss account to absorb rounding residuals
-		self.company_abbr = "_TC"
-		self.create_supplier(supplier_name="_Test Supplier USD", currency="USD")
-		self.create_customer(customer_name="_Test Customer USD", currency="USD")
-		self.create_usd_payable_account()
-		self.create_usd_receivable_account()
-		self.set_party_account("Supplier", self.supplier, self.creditors_usd)
-		if not frappe.db.get_value("Company", self.company, "exchange_gain_loss_account"):
-			frappe.db.set_value(
-				"Company", self.company, "exchange_gain_loss_account", "Exchange Gain/Loss - _TC"
-			)
-
-	def set_party_account(self, party_type, party, account):
-		doc = frappe.get_doc(party_type, party)
-		if not any(row.company == self.company for row in doc.accounts):
-			doc.append("accounts", {"company": self.company, "account": account})
-			doc.save()
-
-	def make_multi_currency_txn(self, withdrawal=0, deposit=0):
-		return (
-			frappe.get_doc(
-				{
-					"doctype": "Bank Transaction",
-					"date": today(),
-					"withdrawal": withdrawal,
-					"deposit": deposit,
-					"bank_account": self.bank_account,
-					"currency": "INR",
-					"reference_number": "TEST-FX-REF",
-				}
-			)
-			.save()
-			.submit()
-		)
-
-	def reconcile_new_payment(
-		self, txn, *, payment_type, party_type, party, party_account, paid_from, paid_to, rate
-	):
-		# mimics the /banking frontend, which sends a hardcoded 1:1 rate
-		payment_entry_doc = {
-			"payment_type": payment_type,
-			"company": self.company,
-			"party_type": party_type,
-			"party": party,
-			"party_account": party_account,
-			"paid_from": paid_from,
-			"paid_to": paid_to,
-			"paid_amount": txn.unallocated_amount,
-			"received_amount": txn.unallocated_amount,
-			"source_exchange_rate": 1,
-			"target_exchange_rate": 1,
-			"posting_date": today(),
-			"reference_no": f"TEST-FX-{payment_type}",
-			"reference_date": today(),
-		}
-		with patch(RATE_METHOD, return_value=rate):
-			result = create_payment_entry_and_reconcile(txn.name, payment_entry_doc)
-		return frappe.get_doc("Payment Entry", result["payment_entry"].name)
--- a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.json
+++ b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.json
@@ -225,7 +225,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "file-down",
 "links": [],
 "modified": "2026-06-19 14:18:00.000000",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/bank_statement_import_log/bank_statement_import_log.json
+++ b/erpnext/accounts/doctype/bank_statement_import_log/bank_statement_import_log.json
@@ -188,7 +188,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "file-clock",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-07-09 17:55:25.615942",
--- a/erpnext/accounts/doctype/bank_transaction/bank_transaction.json
+++ b/erpnext/accounts/doctype/bank_transaction/bank_transaction.json
@@ -4,7 +4,6 @@
 "autoname": "naming_series:",
 "creation": "2018-10-22 18:19:02.784533",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/bank-transaction",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -278,7 +277,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "arrow-left-right",
 "is_submittable": 1,
 "links": [],
 "modified": "2026-04-11 20:41:15.124085",
--- a/erpnext/accounts/doctype/bank_transaction_rule/bank_transaction_rule.json
+++ b/erpnext/accounts/doctype/bank_transaction_rule/bank_transaction_rule.json
@@ -140,7 +140,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "zap",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-04-11 21:36:26.754667",
--- a/erpnext/accounts/doctype/bisect_accounting_statements/bisect_accounting_statements.json
+++ b/erpnext/accounts/doctype/bisect_accounting_statements/bisect_accounting_statements.json
@@ -167,7 +167,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "split",
 "index_web_pages_for_search": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/bisect_nodes/bisect_nodes.json
+++ b/erpnext/accounts/doctype/bisect_nodes/bisect_nodes.json
@@ -68,7 +68,6 @@
   "label": "Generated"
  }
 ],
- "icon": "git-branch",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2024-03-27 13:06:39.766063",
--- a/erpnext/accounts/doctype/budget/budget.json
+++ b/erpnext/accounts/doctype/budget/budget.json
@@ -4,7 +4,6 @@
 "autoname": "naming_series:",
 "creation": "2016-05-16 11:42:29.632528",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/budgeting",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -331,7 +330,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "piggy-bank",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/cashier_closing/cashier_closing.json
+++ b/erpnext/accounts/doctype/cashier_closing/cashier_closing.json
@@ -122,7 +122,6 @@
   "read_only": 1
  }
 ],
- "icon": "lock",
 "is_submittable": 1,
 "links": [],
 "modified": "2024-03-27 13:06:44.260440",
--- a/erpnext/accounts/doctype/chart_of_accounts_importer/chart_of_accounts_importer.json
+++ b/erpnext/accounts/doctype/chart_of_accounts_importer/chart_of_accounts_importer.json
@@ -5,7 +5,6 @@
 "description": "Import Chart of Accounts from a csv file",
 "doctype": "DocType",
 "document_type": "Other",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/chart-of-accounts-importer",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -48,7 +47,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "file-input",
 "in_create": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/cheque_print_template/cheque_print_template.json
+++ b/erpnext/accounts/doctype/cheque_print_template/cheque_print_template.json
@@ -4,7 +4,6 @@
 "autoname": "field:bank_name",
 "creation": "2016-05-04 14:35:00.402544",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/cheque-print-template",
 "engine": "InnoDB",
 "field_order": [
  "settings",
@@ -294,7 +293,6 @@
   "fieldtype": "HTML"
  }
 ],
- "icon": "printer",
 "links": [],
 "max_attachments": 1,
 "modified": "2026-06-08 12:10:35.829531",
--- a/erpnext/accounts/doctype/cost_center/cost_center.json
+++ b/erpnext/accounts/doctype/cost_center/cost_center.json
@@ -7,7 +7,6 @@
 "description": "Track separate Income and Expense for product verticals or divisions.",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/cost-center",
 "engine": "InnoDB",
 "field_order": [
  "sb0",
@@ -123,7 +122,7 @@
   "label": "Disabled"
  }
 ],
- "icon": "chart-pie",
+ "icon": "fa fa-money",
 "idx": 1,
 "is_tree": 1,
 "links": [],
--- a/erpnext/accounts/doctype/cost_center_allocation/cost_center_allocation.json
+++ b/erpnext/accounts/doctype/cost_center_allocation/cost_center_allocation.json
@@ -4,7 +4,6 @@
 "autoname": "CC-ALLOC-.#####",
 "creation": "2022-01-13 20:07:29.871109",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/cost_center_allocation",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -66,7 +65,6 @@
   "read_only": 1
  }
 ],
- "icon": "chart-pie",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/coupon_code/coupon_code.js
+++ b/erpnext/accounts/doctype/coupon_code/coupon_code.js
@@ -5,10 +5,7 @@ frappe.ui.form.on("Coupon Code", {
 	setup: function (frm) {
 		frm.set_query("pricing_rule", function () {
 			return {
-				filters: {
-					coupon_code_based: 1,
-					disable: 0,
-				},
+				filters: [["Pricing Rule", "coupon_code_based", "=", "1"]],
 			};
 		});
 	},
--- a/erpnext/accounts/doctype/coupon_code/coupon_code.json
+++ b/erpnext/accounts/doctype/coupon_code/coupon_code.json
@@ -5,7 +5,6 @@
 "creation": "2018-01-22 14:34:39.701832",
 "doctype": "DocType",
 "document_type": "Other",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/coupon-code",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -125,7 +124,6 @@
   "label": "From External Ecomm Platform"
  }
 ],
- "icon": "ticket-percent",
 "links": [],
 "modified": "2026-08-21 23:11:41.010871",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/coupon_code/coupon_code.py
+++ b/erpnext/accounts/doctype/coupon_code/coupon_code.py
@@ -42,23 +42,7 @@ class CouponCode(Document):
 				self.coupon_code = frappe.generate_hash()[:10].upper()

 	def validate(self):
-		self.validate_from_to_dates("valid_from", "valid_upto")
-		self.validate_pricing_rule()
-
 		if self.coupon_type == "Gift Card":
 			self.maximum_use = 1
 			if not self.customer:
 				frappe.throw(_("Please select the customer."))
-
-	def validate_pricing_rule(self):
-		if not self.pricing_rule or self.from_external_ecomm_platform:
-			return
-
-		# Allow existing coupons to be updated after their pricing rule is disabled.
-		if not (
-			self.has_value_changed("pricing_rule") or self.has_value_changed("from_external_ecomm_platform")
-		):
-			return
-
-		if frappe.db.get_value("Pricing Rule", self.pricing_rule, "disable"):
-			frappe.throw(_("Pricing Rule {0} is disabled").format(frappe.bold(self.pricing_rule)))
--- a/erpnext/accounts/doctype/coupon_code/test_coupon_code.py
+++ b/erpnext/accounts/doctype/coupon_code/test_coupon_code.py
@@ -112,43 +112,6 @@ class TestCouponCode(ERPNextTestSuite):
 	def setUp(self):
 		test_create_test_data()

-	def test_disabled_pricing_rule_validation(self):
-		coupon = frappe.get_doc("Coupon Code", "SAVE30")
-		rule = frappe.get_doc("Pricing Rule", coupon.pricing_rule)
-		rule.disable = 1
-		rule.save()
-
-		with self.subTest("new coupon cannot select a disabled rule"):
-			new_coupon = frappe.copy_doc(coupon)
-			new_coupon.coupon_name = "Festival Savings"
-			new_coupon.coupon_code = "FESTSAVE"
-			with self.assertRaisesRegex(frappe.ValidationError, "is disabled"):
-				new_coupon.insert()
-
-		with self.subTest("existing coupon can retain a disabled rule"):
-			coupon.description = "Offer paused"
-			coupon.save()
-			coupon.reload()
-			self.assertEqual(coupon.description, "Offer paused")
-			self.assertEqual(coupon.pricing_rule, rule.name)
-
-		with self.subTest("existing coupon cannot switch to a disabled rule"):
-			disabled_rule = frappe.copy_doc(rule)
-			disabled_rule.insert()
-			coupon.reload()
-			coupon.pricing_rule = disabled_rule.name
-			with self.assertRaisesRegex(frappe.ValidationError, "is disabled"):
-				coupon.save()
-			coupon.reload()
-			self.assertEqual(coupon.pricing_rule, rule.name)
-
-	def test_cannot_save_coupon_with_reversed_validity_dates(self):
-		coupon = frappe.get_doc("Coupon Code", "SAVE30")
-		coupon.valid_from = "2026-09-17"
-		coupon.valid_upto = "2026-09-02"
-		with self.assertRaises(frappe.exceptions.InvalidDates):
-			coupon.save()
-
 	def test_sales_order_with_coupon_code(self):
 		frappe.db.set_value("Coupon Code", "SAVE30", "used", 0)

--- a/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.json
+++ b/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.json
@@ -2,7 +2,6 @@
 "actions": [],
 "creation": "2022-01-10 13:03:26.237081",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/currency-exchange-settings",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -102,7 +101,6 @@
   "label": "Use HTTP Protocol"
  }
 ],
- "icon": "refresh-cw",
 "index_web_pages_for_search": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/dunning/dunning.json
+++ b/erpnext/accounts/doctype/dunning/dunning.json
@@ -5,7 +5,6 @@
 "autoname": "naming_series:",
 "creation": "2019-07-05 16:34:31.013238",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/dunning",
 "engine": "InnoDB",
 "field_order": [
  "naming_series",
@@ -399,7 +398,6 @@
   "fieldtype": "Column Break"
  }
 ],
- "icon": "bell-ring",
 "is_submittable": 1,
 "links": [],
 "modified": "2026-05-30 23:18:04.712528",
--- a/erpnext/accounts/doctype/dunning_type/dunning_type.json
+++ b/erpnext/accounts/doctype/dunning_type/dunning_type.json
@@ -101,7 +101,6 @@
   "fieldtype": "Column Break"
  }
 ],
- "icon": "bell",
 "links": [
  {
   "link_doctype": "Dunning",
--- a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.json
+++ b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.json
@@ -4,7 +4,6 @@
 "autoname": "ACC-ERR-.YYYY.-.#####",
 "creation": "2018-04-13 18:25:55.943587",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/exchange-rate-revaluation",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -108,7 +107,6 @@
   "precision": "9"
  }
 ],
- "icon": "arrow-right-left",
 "is_submittable": 1,
 "links": [],
 "modified": "2024-03-27 13:09:42.951164",
--- a/erpnext/accounts/doctype/finance_book/finance_book.json
+++ b/erpnext/accounts/doctype/finance_book/finance_book.json
@@ -5,7 +5,6 @@
 "creation": "2018-04-13 17:42:43.252224",
 "doctype": "DocType",
 "document_type": "Document",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/finance-book",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -19,7 +18,7 @@
   "unique": 1
  }
 ],
- "icon": "book",
+ "icon": "fa fa-book",
 "links": [],
 "modified": "2026-08-21 23:11:42.386104",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/financial_report_template/financial_report_template.json
+++ b/erpnext/accounts/doctype/financial_report_template/financial_report_template.json
@@ -3,7 +3,6 @@
 "autoname": "field:template_name",
 "creation": "2025-08-02 04:44:15.184541",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/financial-report-template",
 "engine": "InnoDB",
 "field_order": [
  "template_name",
@@ -65,7 +64,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "file-spreadsheet",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-02-23 01:04:05.797161",
--- a/erpnext/accounts/doctype/fiscal_year/fiscal_year.json
+++ b/erpnext/accounts/doctype/fiscal_year/fiscal_year.json
@@ -6,7 +6,6 @@
 "description": "Represents a Financial Year. All accounting entries and other major transactions are tracked against the Fiscal Year.",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/fiscal-year",
 "engine": "InnoDB",
 "field_order": [
  "year",
@@ -80,7 +79,7 @@
   "set_only_once": 1
  }
 ],
- "icon": "calendar",
+ "icon": "fa fa-calendar",
 "idx": 1,
 "links": [],
 "modified": "2026-08-21 23:11:42.509102",
--- a/erpnext/accounts/doctype/gl_entry/gl_entry.json
+++ b/erpnext/accounts/doctype/gl_entry/gl_entry.json
@@ -377,7 +377,7 @@
   "precision": "9"
  }
 ],
- "icon": "book-open",
+ "icon": "fa fa-list",
 "idx": 1,
 "in_create": 1,
 "links": [],
--- a/erpnext/accounts/doctype/invoice_discounting/invoice_discounting.json
+++ b/erpnext/accounts/doctype/invoice_discounting/invoice_discounting.json
@@ -5,7 +5,6 @@
 "autoname": "ACC-INV-DISC-.YYYY.-.#####",
 "creation": "2019-03-07 12:01:56.296952",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/invoice_discounting",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -170,7 +169,6 @@
   "read_only": 1
  }
 ],
- "icon": "ticket-percent",
 "is_submittable": 1,
 "links": [],
 "modified": "2026-09-09 17:04:59.512294",
--- a/erpnext/accounts/doctype/item_tax_template/item_tax_template.json
+++ b/erpnext/accounts/doctype/item_tax_template/item_tax_template.json
@@ -5,7 +5,6 @@
 "creation": "2022-01-19 01:09:13.297137",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/item-tax-template",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -57,7 +56,6 @@
   "fieldtype": "Section Break"
  }
 ],
- "icon": "circle-percent",
 "links": [],
 "modified": "2026-08-21 23:11:43.571355",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/journal_entry/journal_entry.json
+++ b/erpnext/accounts/doctype/journal_entry/journal_entry.json
@@ -6,7 +6,6 @@
 "creation": "2022-01-25 10:29:58.717206",
 "doctype": "DocType",
 "document_type": "Document",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/journal-entry",
 "engine": "InnoDB",
 "field_order": [
  "entry_type_and_date",
@@ -662,7 +661,7 @@
   "label": "Custom Remark"
  }
 ],
- "icon": "notebook-pen",
+ "icon": "fa fa-file-text",
 "idx": 176,
 "is_submittable": 1,
 "links": [
--- a/erpnext/accounts/doctype/journal_entry/mapper.py
+++ b/erpnext/accounts/doctype/journal_entry/mapper.py
@@ -253,10 +253,6 @@ def make_reverse_journal_entry(source_name: str, target_doc: str | dict | Docume

 	def post_process(source, target) -> None:
 		target.reversal_of = source.name
-		target.naming_series = source.naming_series
-		if source.voucher_type == "Bank Entry":
-			target.cheque_no = source.cheque_no
-			target.cheque_date = source.cheque_date

 	doclist = get_mapped_doc(
 		"Journal Entry",
--- a/erpnext/accounts/doctype/journal_entry_template/journal_entry_template.json
+++ b/erpnext/accounts/doctype/journal_entry_template/journal_entry_template.json
@@ -4,7 +4,6 @@
 "creation": "2020-04-09 01:32:51.332301",
 "doctype": "DocType",
 "document_type": "Document",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/journal-entry-template",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -86,7 +85,6 @@
   "label": "Multi Currency"
  }
 ],
- "icon": "notebook-text",
 "links": [],
 "modified": "2024-03-27 13:09:58.814734",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/ledger_health/ledger_health.json
+++ b/erpnext/accounts/doctype/ledger_health/ledger_health.json
@@ -40,7 +40,6 @@
   "label": "General and Payment Ledger mismatch"
  }
 ],
- "icon": "heart-pulse",
 "in_create": 1,
 "index_web_pages_for_search": 1,
 "links": [],
--- a/erpnext/accounts/doctype/ledger_health_monitor/ledger_health_monitor.json
+++ b/erpnext/accounts/doctype/ledger_health_monitor/ledger_health_monitor.json
@@ -57,7 +57,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "activity",
 "index_web_pages_for_search": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/ledger_merge/ledger_merge.json
+++ b/erpnext/accounts/doctype/ledger_merge/ledger_merge.json
@@ -92,7 +92,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "merge",
 "links": [],
 "modified": "2024-03-27 13:10:02.198009",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/loyalty_point_entry/loyalty_point_entry.json
+++ b/erpnext/accounts/doctype/loyalty_point_entry/loyalty_point_entry.json
@@ -97,7 +97,6 @@
   "label": "Discretionary Reason"
  }
 ],
- "icon": "star",
 "in_create": 1,
 "links": [],
 "modified": "2024-07-01 08:51:13.927009",
--- a/erpnext/accounts/doctype/loyalty_program/loyalty_program.json
+++ b/erpnext/accounts/doctype/loyalty_program/loyalty_program.json
@@ -3,7 +3,6 @@
 "autoname": "field:loyalty_program_name",
 "creation": "2018-01-23 06:23:05.731431",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/loyalty-program",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -154,7 +153,6 @@
   "options": "Project"
  }
 ],
- "icon": "gift",
 "links": [],
 "modified": "2026-08-21 23:11:44.144864",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.json
+++ b/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.json
@@ -6,7 +6,6 @@
 "creation": "2012-12-04 17:49:20",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/mode-of-payment",
 "engine": "InnoDB",
 "field_order": [
  "mode_of_payment",
@@ -45,7 +44,7 @@
   "label": "Enabled"
  }
 ],
- "icon": "wallet",
+ "icon": "fa fa-credit-card",
 "idx": 1,
 "index_web_pages_for_search": 1,
 "links": [],
--- a/erpnext/accounts/doctype/monthly_distribution/monthly_distribution.json
+++ b/erpnext/accounts/doctype/monthly_distribution/monthly_distribution.json
@@ -43,7 +43,7 @@
   "options": "Monthly Distribution Percentage"
  }
 ],
- "icon": "chart-bar",
+ "icon": "fa fa-bar-chart",
 "idx": 1,
 "links": [],
 "modified": "2026-08-21 23:11:44.908490",
--- a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.json
+++ b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.json
@@ -4,7 +4,6 @@
 "allow_copy": 1,
 "creation": "2017-08-29 02:22:54.947711",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/opening-invoice-creation-tool",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -89,7 +88,6 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "file-plus",
 "issingle": 1,
 "links": [],
 "modified": "2026-05-30 23:18:48.691227",
--- a/erpnext/accounts/doctype/party_link/party_link.json
+++ b/erpnext/accounts/doctype/party_link/party_link.json
@@ -50,7 +50,6 @@
   "options": "secondary_role"
  }
 ],
- "icon": "link",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2024-03-27 13:10:08.607170",
--- a/erpnext/accounts/doctype/payment_entry/payment_entry.json
+++ b/erpnext/accounts/doctype/payment_entry/payment_entry.json
@@ -5,7 +5,6 @@
 "autoname": "naming_series:",
 "creation": "2016-06-01 14:38:51.012597",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-entry",
 "engine": "InnoDB",
 "field_order": [
  "type_of_payment",
@@ -785,7 +784,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "banknote",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [
--- a/erpnext/accounts/doctype/payment_gateway_account/payment_gateway_account.json
+++ b/erpnext/accounts/doctype/payment_gateway_account/payment_gateway_account.json
@@ -84,7 +84,6 @@
   "reqd": 1
  }
 ],
- "icon": "credit-card",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2025-07-14 16:49:55.210352",
--- a/erpnext/accounts/doctype/payment_ledger_entry/payment_ledger_entry.json
+++ b/erpnext/accounts/doctype/payment_ledger_entry/payment_ledger_entry.json
@@ -5,7 +5,6 @@
 "doctype": "DocType",
 "editable_grid": 1,
 "engine": "InnoDB",
- "icon": "book-open",
 "is_submittable": 1,
 "field_order": [
  "posting_date",
--- a/erpnext/accounts/doctype/payment_order/payment_order.json
+++ b/erpnext/accounts/doctype/payment_order/payment_order.json
@@ -3,7 +3,6 @@
 "autoname": "naming_series:",
 "creation": "2018-07-20 16:43:08.505978",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-order",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -108,7 +107,6 @@
   "label": "Account"
  }
 ],
- "icon": "send",
 "is_submittable": 1,
 "links": [],
 "modified": "2024-03-27 13:10:10.186727",
--- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json
+++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json
@@ -3,7 +3,6 @@
 "allow_copy": 1,
 "creation": "2014-07-09 12:04:51.681583",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-reconciliation",
 "engine": "InnoDB",
 "field_order": [
  "company",
@@ -236,7 +235,7 @@
  }
 ],
 "hide_toolbar": 1,
- "icon": "arrow-left-right",
+ "icon": "icon-resize-horizontal",
 "is_virtual": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/payment_request/payment_request.json
+++ b/erpnext/accounts/doctype/payment_request/payment_request.json
@@ -3,7 +3,6 @@
 "autoname": "naming_series:",
 "creation": "2015-12-15 22:23:24.745065",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-request",
 "engine": "InnoDB",
 "field_order": [
  "payment_request_type",
@@ -475,7 +474,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "hand-coins",
 "in_create": 1,
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
--- a/erpnext/accounts/doctype/payment_term/payment_term.json
+++ b/erpnext/accounts/doctype/payment_term/payment_term.json
@@ -5,7 +5,6 @@
 "autoname": "field:payment_term_name",
 "creation": "2017-08-10 15:24:54.876365",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-terms",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -116,7 +115,6 @@
   "fieldtype": "Column Break"
  }
 ],
- "icon": "calendar-clock",
 "links": [],
 "modified": "2026-08-21 23:11:45.693762",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/payment_terms_template/payment_terms_template.json
+++ b/erpnext/accounts/doctype/payment_terms_template/payment_terms_template.json
@@ -5,7 +5,6 @@
 "autoname": "field:template_name",
 "creation": "2017-08-10 15:34:28.058054",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/payment-terms-template",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -35,7 +34,6 @@
   "label": "Allocate Payment Based On Payment Terms"
  }
 ],
- "icon": "calendar-clock",
 "links": [],
 "modified": "2024-04-07 11:26:42.021585",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/pegged_currencies/pegged_currencies.json
+++ b/erpnext/accounts/doctype/pegged_currencies/pegged_currencies.json
@@ -20,7 +20,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "anchor",
 "index_web_pages_for_search": 1,
 "issingle": 1,
 "links": [],
--- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.json
+++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.json
@@ -3,7 +3,6 @@
 "autoname": "ACC-PCV-.YYYY.-.#####",
 "creation": "2013-01-10 16:34:07",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/period-closing-voucher",
 "engine": "InnoDB",
 "field_order": [
  "transaction_date",
@@ -111,7 +110,7 @@
   "reqd": 1
  }
 ],
- "icon": "folder-lock",
+ "icon": "fa fa-file-text",
 "idx": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
+++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
@@ -280,13 +280,12 @@ class PeriodClosingVoucher(AccountsController):

 			data = self.get_data_for_mapreduce()
 			mapreduce(
-				"erpnext.accounts.doctype.period_closing_voucher.period_closing_voucher.process_date_range",
-				"erpnext.accounts.doctype.period_closing_voucher.period_closing_voucher.aggregate_partial_result",
+				"erpnext.accounts.doctype.period_closing_voucher.period_closing_voucher.mapper",
+				"erpnext.accounts.doctype.period_closing_voucher.period_closing_voucher.reducer",
 				"erpnext.accounts.doctype.period_closing_voucher.period_closing_voucher.summarize_and_post_ledger",
 				data,
 				self.doctype,
 				self.name,
-				f"Closing FY {self.fiscal_year}",
 			)

 	def on_cancel(self):
@@ -331,8 +330,8 @@ class PeriodClosingVoucher(AccountsController):

 	def make_gl_entries(self):
 		if frappe.db.estimate_count("GL Entry") > 100_000:
-			frappe.enqueue_task(
-				method=process_gl_and_closing_entries,
+			frappe.enqueue(
+				process_gl_and_closing_entries,
 				doc=self,
 				timeout=1800,
 			)
@@ -835,7 +834,7 @@ def get_previous_closed_period_in_current_year(fiscal_year, company):
 	return prev_closed_period_end_date


-def process_date_range(val):
+def mapper(val):
 	start_date = val.from_date
 	end_date = val.to_date
 	pcv = val.pcv
@@ -882,7 +881,7 @@ def process_date_range(val):
 	return res


-def aggregate_partial_result(final, partial_res):
+def reducer(final, partial_res):
 	if final is None:
 		final = []

--- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher_list.js
+++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher_list.js
@@ -1,28 +0,0 @@
-// Copyright (c) 2026, Frappe Technologies Pvt. Ltd. and Contributors
-// License: GNU General Public License v3. See license.txt
-
-frappe.listview_settings["Period Closing Voucher"] = {
-	add_fields: ["gle_processing_status"],
-	get_indicator: function (doc) {
-		const status_colors = {
-			Draft: "red",
-			Submitted: "blue",
-			Cancelled: "red",
-		};
-
-		const gle_processing_status = {
-			"In Progress": [__("Processing GL Entries"), "blue"],
-			Completed: [__("Period Closed"), "green"],
-			Failed: [__("Period Closing Failed"), "red"],
-		};
-		if (doc.docstatus != 0) {
-			return [
-				gle_processing_status[doc.gle_processing_status][0],
-				gle_processing_status[doc.gle_processing_status][1],
-				"gle_processing_status,=," + doc.gle_processing_status,
-			];
-		}
-
-		return [__(doc.docstatus), status_colors[doc.docstatus], "docstatus,=," + doc.docstatus];
-	},
-};
--- a/erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.json
+++ b/erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.json
@@ -254,7 +254,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "book-lock",
 "is_submittable": 1,
 "links": [
  {
--- a/erpnext/accounts/doctype/pos_invoice/pos_invoice.json
+++ b/erpnext/accounts/doctype/pos_invoice/pos_invoice.json
@@ -1640,7 +1640,7 @@
   "print_hide": 1
  }
 ],
- "icon": "receipt-text",
+ "icon": "fa fa-file-text",
 "is_submittable": 1,
 "links": [],
 "modified": "2026-08-21 23:11:45.029925",
--- a/erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.json
+++ b/erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.json
@@ -126,7 +126,6 @@
   "reqd": 1
  }
 ],
- "icon": "merge",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/pos_opening_entry/pos_opening_entry.json
+++ b/erpnext/accounts/doctype/pos_opening_entry/pos_opening_entry.json
@@ -129,7 +129,6 @@
   "reqd": 1
  }
 ],
- "icon": "folder-open",
 "is_submittable": 1,
 "links": [],
 "modified": "2024-03-27 13:10:16.034296",
--- a/erpnext/accounts/doctype/pos_profile/pos_profile.json
+++ b/erpnext/accounts/doctype/pos_profile/pos_profile.json
@@ -4,7 +4,6 @@
 "autoname": "Prompt",
 "creation": "2013-05-24 12:15:51",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/pos-profile",
 "engine": "InnoDB",
 "field_order": [
  "company",
@@ -558,7 +557,7 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "monitor",
+ "icon": "icon-cog",
 "idx": 1,
 "index_web_pages_for_search": 1,
 "links": [
--- a/erpnext/accounts/doctype/pos_settings/pos_settings.json
+++ b/erpnext/accounts/doctype/pos_settings/pos_settings.json
@@ -51,7 +51,6 @@
  }
 ],
 "hide_toolbar": 0,
- "icon": "settings",
 "issingle": 1,
 "links": [],
 "modified": "2026-03-16 13:28:19.677217",
--- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.json
+++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.json
@@ -5,7 +5,6 @@
 "autoname": "naming_series:",
 "creation": "2014-02-21 15:02:51",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/pricing-rule",
 "engine": "InnoDB",
 "field_order": [
  "applicability_section",
@@ -655,7 +654,7 @@
   "label": "Don't Enforce Free Item Qty"
  }
 ],
- "icon": "badge-percent",
+ "icon": "fa fa-gift",
 "idx": 1,
 "links": [],
 "modified": "2026-02-17 12:24:07.553505",
--- a/erpnext/accounts/doctype/process_deferred_accounting/process_deferred_accounting.json
+++ b/erpnext/accounts/doctype/process_deferred_accounting/process_deferred_accounting.json
@@ -3,7 +3,6 @@
 "autoname": "ACC-PDA-.#####",
 "creation": "2019-11-04 18:01:23.454775",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/process-deferred-accounting",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -75,7 +74,6 @@
   "reqd": 1
  }
 ],
- "icon": "list-clock",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.json
+++ b/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.json
@@ -154,7 +154,6 @@
   "reqd": 0
  }
 ],
- "icon": "scale",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/process_payment_reconciliation_log/process_payment_reconciliation_log.json
+++ b/erpnext/accounts/doctype/process_payment_reconciliation_log/process_payment_reconciliation_log.json
@@ -106,7 +106,6 @@
   "read_only": 1
  }
 ],
- "icon": "file-clock",
 "in_create": 1,
 "index_web_pages_for_search": 1,
 "links": [],
--- a/erpnext/accounts/doctype/process_period_closing_voucher/process_period_closing_voucher.json
+++ b/erpnext/accounts/doctype/process_period_closing_voucher/process_period_closing_voucher.json
@@ -80,7 +80,6 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "lock",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json
+++ b/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json
@@ -4,7 +4,6 @@
 "autoname": "Prompt",
 "creation": "2020-05-22 16:46:18.712954",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/process-statement-of-accounts",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -425,7 +424,6 @@
   "label": "Show Opening Entries"
  }
 ],
- "icon": "mail",
 "links": [],
 "modified": "2026-06-01 15:37:07.660442",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/process_subscription/process_subscription.json
+++ b/erpnext/accounts/doctype/process_subscription/process_subscription.json
@@ -35,7 +35,6 @@
   "options": "Subscription"
  }
 ],
- "icon": "repeat",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json
+++ b/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json
@@ -5,7 +5,6 @@
 "autoname": "Prompt",
 "creation": "2019-02-08 17:10:36.077402",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/promotional-scheme",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -280,7 +279,6 @@
   "options": "Promotional Scheme Product Discount"
  }
 ],
- "icon": "megaphone",
 "links": [],
 "modified": "2025-08-20 11:48:23.231081",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json
+++ b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json
@@ -6,7 +6,6 @@
 "creation": "2013-05-21 16:16:39",
 "doctype": "DocType",
 "document_type": "Document",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/purchase-invoice",
 "email_append_to": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -1693,7 +1692,7 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "receipt-text",
+ "icon": "fa fa-file-text",
 "idx": 204,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/purchase_taxes_and_charges_template/purchase_taxes_and_charges_template.json
+++ b/erpnext/accounts/doctype/purchase_taxes_and_charges_template/purchase_taxes_and_charges_template.json
@@ -6,7 +6,6 @@
 "description": "Standard tax template that can be applied to all Purchase Transactions. This template can contain a list of tax heads and also other expense heads like \"Shipping\", \"Insurance\", \"Handling\", etc.",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/purchase-taxes-and-charges-template",
 "engine": "InnoDB",
 "field_order": [
  "title",
@@ -75,7 +74,7 @@
   "options": "Tax Category"
  }
 ],
- "icon": "badge-percent",
+ "icon": "fa fa-money",
 "idx": 1,
 "links": [],
 "modified": "2026-08-21 23:11:47.506282",
--- a/erpnext/accounts/doctype/repost_accounting_ledger/repost_accounting_ledger.json
+++ b/erpnext/accounts/doctype/repost_accounting_ledger/repost_accounting_ledger.json
@@ -4,7 +4,6 @@
 "creation": "2023-07-04 13:07:32.923675",
 "default_view": "List",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/repost-accounting-ledger",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -102,7 +101,6 @@
   "read_only": 1
  }
 ],
- "icon": "list-restart",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/repost_payment_ledger/repost_payment_ledger.json
+++ b/erpnext/accounts/doctype/repost_payment_ledger/repost_payment_ledger.json
@@ -95,7 +95,6 @@
   "label": "Repost Error Log"
  }
 ],
- "icon": "list-restart",
 "index_web_pages_for_search": 1,
 "is_submittable": 1,
 "links": [],
--- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.json
+++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.json
@@ -4,7 +4,6 @@
 "autoname": "naming_series:",
 "creation": "2022-01-25 10:29:57.771398",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/sales-invoice",
 "engine": "InnoDB",
 "field_order": [
  "customer_section",
@@ -2396,7 +2395,7 @@
  }
 ],
 "grid_page_length": 50,
- "icon": "receipt-text",
+ "icon": "fa fa-file-text",
 "idx": 181,
 "is_submittable": 1,
 "links": [
--- a/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.json
+++ b/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.json
@@ -6,7 +6,6 @@
 "description": "Standard tax template that can be applied to all Sales Transactions. This template can contain a list of tax heads and also other expense/income heads like \"Shipping\", \"Insurance\", \"Handling\" etc.",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/sales-taxes-and-charges-template",
 "engine": "InnoDB",
 "field_order": [
  "title",
@@ -77,7 +76,7 @@
   "options": "Tax Category"
  }
 ],
- "icon": "badge-percent",
+ "icon": "fa fa-money",
 "idx": 1,
 "links": [],
 "modified": "2026-08-21 23:11:48.797423",
--- a/erpnext/accounts/doctype/share_transfer/share_transfer.json
+++ b/erpnext/accounts/doctype/share_transfer/share_transfer.json
@@ -3,7 +3,6 @@
 "autoname": "ACC-SHT-.YYYY.-.#####",
 "creation": "2017-12-25 17:18:03.143726",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/share-transfer",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -191,7 +190,6 @@
   "fieldtype": "Column Break"
  }
 ],
- "icon": "arrow-right-left",
 "is_submittable": 1,
 "links": [],
 "modified": "2024-03-27 13:10:40.003178",
--- a/erpnext/accounts/doctype/share_type/share_type.json
+++ b/erpnext/accounts/doctype/share_type/share_type.json
@@ -24,7 +24,6 @@
   "label": "Description"
  }
 ],
- "icon": "tag",
 "links": [],
 "modified": "2024-03-27 13:10:40.190914",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/shareholder/shareholder.json
+++ b/erpnext/accounts/doctype/shareholder/shareholder.json
@@ -3,7 +3,6 @@
 "autoname": "naming_series:",
 "creation": "2017-12-25 16:50:53.878430",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/shareholder",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -113,7 +112,6 @@
   "read_only": 1
  }
 ],
- "icon": "user-star",
 "links": [],
 "modified": "2024-03-27 13:10:40.356171",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/shipping_rule/shipping_rule.json
+++ b/erpnext/accounts/doctype/shipping_rule/shipping_rule.json
@@ -5,7 +5,6 @@
 "creation": "2013-06-25 11:48:03",
 "description": "Specify conditions to calculate shipping amount",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/shipping-rule",
 "engine": "InnoDB",
 "field_order": [
  "label",
@@ -147,7 +146,7 @@
   "options": "Project"
  }
 ],
- "icon": "truck",
+ "icon": "fa fa-truck",
 "idx": 1,
 "links": [],
 "modified": "2026-08-21 23:11:49.532098",
--- a/erpnext/accounts/doctype/subscription/subscription.json
+++ b/erpnext/accounts/doctype/subscription/subscription.json
@@ -3,7 +3,6 @@
 "autoname": "ACC-SUB-.YYYY.-.#####",
 "creation": "2017-07-18 17:50:43.967266",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/subscription",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -300,7 +299,6 @@
   "fieldtype": "Section Break"
  }
 ],
- "icon": "calendar-sync",
 "index_web_pages_for_search": 1,
 "links": [
  {
--- a/erpnext/accounts/doctype/subscription_plan/subscription_plan.json
+++ b/erpnext/accounts/doctype/subscription_plan/subscription_plan.json
@@ -4,7 +4,6 @@
 "autoname": "field:plan_name",
 "creation": "2018-02-24 11:31:23.066506",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/subscription-plan",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -149,7 +148,6 @@
   "label": "Product Price ID"
  }
 ],
- "icon": "calendar-sync",
 "links": [],
 "modified": "2024-03-27 13:10:47.998597",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/subscription_settings/subscription_settings.json
+++ b/erpnext/accounts/doctype/subscription_settings/subscription_settings.json
@@ -2,7 +2,6 @@
 "actions": [],
 "creation": "2018-02-26 06:13:37.910139",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/subscription-settings",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -33,7 +32,6 @@
 ],
 "grid_page_length": 50,
 "hide_toolbar": 0,
- "icon": "settings",
 "issingle": 1,
 "links": [],
 "modified": "2026-03-16 13:28:20.485964",
--- a/erpnext/accounts/doctype/tax_category/tax_category.json
+++ b/erpnext/accounts/doctype/tax_category/tax_category.json
@@ -4,7 +4,6 @@
 "autoname": "field:title",
 "creation": "2022-01-19 01:09:28.920486",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/tax-category",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -28,7 +27,6 @@
   "label": "Disabled"
  }
 ],
- "icon": "badge-percent",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-08-21 23:11:50.740962",
--- a/erpnext/accounts/doctype/tax_rule/tax_rule.json
+++ b/erpnext/accounts/doctype/tax_rule/tax_rule.json
@@ -6,7 +6,6 @@
 "creation": "2015-08-07 02:33:52.670866",
 "doctype": "DocType",
 "document_type": "Setup",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/tax-rule",
 "engine": "InnoDB",
 "field_order": [
  "tax_type",
@@ -226,7 +225,6 @@
   "remember_last_selected_value": 1
  }
 ],
- "icon": "badge-percent",
 "links": [],
 "modified": "2024-03-27 13:10:52.121252",
 "modified_by": "Administrator",
--- a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.json
+++ b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.json
@@ -5,7 +5,6 @@
 "autoname": "Prompt",
 "creation": "2018-04-13 18:42:06.431683",
 "doctype": "DocType",
- "documentation": "https://docs.frappe.io/erpnext/user/manual/en/tax-withholding-category",
 "editable_grid": 1,
 "engine": "InnoDB",
 "field_order": [
@@ -99,7 +98,6 @@
   "label": "Disable Transaction Threshold"
  }
 ],
- "icon": "badge-percent",
 "index_web_pages_for_search": 1,
 "links": [],
 "modified": "2026-08-21 23:11:50.979676",
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Mihir Kandoi	423383fb89	fix(stock): keep the source warehouse qty on purchase receipts only The stock ledger of a Purchase Invoice that updates stock is built by the same controller, but its GL entries have no accounting for rejected material at all. Taking the rejected qty out of the in-transit warehouse there would move stock that the invoice never books, so the two ledgers would disagree.	2026-09-21 11:55:13 +05:30
Mihir Kandoi	fb905f9d6f	style(stock): shorten the source warehouse qty docstring	2026-09-21 11:48:12 +05:30
Mihir Kandoi	8921f160d1	test(stock): cover rejected qty on an internal transfer receipt	2026-09-19 13:21:16 +05:30
Mihir Kandoi	3eef93e792	fix(stock): deduct rejected qty from the in-transit warehouse On an internal transfer the Purchase Receipt only took the accepted qty out of the in-transit warehouse, while the rejected qty was booked into the rejected warehouse. The rejected material stayed in transit and was counted twice. The rejected material also carried stock value, because an internal-transfer receipt anchors every inward entry to the delivery note rate, but the rejected warehouse got no GL entry unless "Set valuation rate for rejected Materials" was enabled. That left the stock value and the account value out of sync. The outgoing entry now covers accepted plus rejected qty, and the rejected warehouse is booked on an internal transfer whatever that setting says. Rows tracked by a serial and batch package are unchanged: their qty comes from the package, which still holds the accepted material only.	2026-09-19 13:21:16 +05:30