Mihir Kandoi
99152b8300
fix(item): rework multiple variant dialog for large numeric ranges
...
The 'Create Multiple Variants' dialog rendered one checkbox per attribute
value and read the numeric config from the variant attribute child row. This
broke in several ways:
- A template whose attribute was made numeric after being added kept
numeric_values=0 on the child row, so the dialog treated it as non-numeric,
queried the empty Item Attribute Value table, and showed no values.
- Enumerating a large range (e.g. 1-100000) into checkboxes froze the browser.
Rework the dialog:
- Read numeric_values / from_range / to_range / increment from the Item
Attribute master, and guard increment > 0.
- Replace the checkbox-per-value list with one MultiSelectPills per attribute,
with a search placeholder.
- Stop enumerating numeric ranges: preview the first few values and validate
typed input against the range on demand, so huge ranges stay instant.
- Block variant creation with a modal error if any selected value or pending
input is invalid (out of range, off-increment, or not a number), so garbage
like '00A' can't reach creation.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-07-01 23:28:03 +05:30
Mihir Kandoi
4afbd4d3d9
fix(item-attribute): clear attribute values when marking numeric
...
Marking an attribute numeric hides the Item Attribute Values grid but leaves
its rows in the doc, whose mandatory Attribute Value / Abbreviation block the
save client-side before the server can clear them. Clear the table on the
client too so the save goes through.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-07-01 23:27:51 +05:30
Nabin Hait
e3e62a2211
Merge pull request #56716 from frappe/chore/test-voucher-wise-balance
...
test: Voucher-wise Balance report coverage
2026-07-01 22:55:12 +05:30
Nabin Hait
8b7780d494
test: add coverage for Exponential Smoothing Forecasting report
2026-07-01 22:54:38 +05:30
Nabin Hait
c38363c16d
test: add coverage for Production Plan Summary report
2026-07-01 22:54:31 +05:30
Nabin Hait
304a247dc8
test: add coverage for BOM Operations Time report
2026-07-01 22:54:23 +05:30
Nabin Hait
8abef22a49
Merge pull request #56715 from frappe/chore/test-invalid-ledger-entries
...
fix: Invalid Ledger Entries account filter + test coverage
2026-07-01 22:54:22 +05:30
Nabin Hait
75ba81c79a
test: add coverage for Cost of Poor Quality Report report
2026-07-01 22:54:16 +05:30
Nabin Hait
222842b7d1
test: add coverage for Process Loss Report report
2026-07-01 22:54:09 +05:30
Nabin Hait
376a5a2aee
test: add coverage for BOM Variance Report report
2026-07-01 22:54:02 +05:30
Nabin Hait
47ee1d126d
test: add coverage for Work Order Consumed Materials report
2026-07-01 22:53:54 +05:30
Nabin Hait
e179100afd
Merge pull request #56714 from frappe/chore/test-purchase-invoice-trends
...
test: Purchase Invoice Trends report coverage
2026-07-01 22:52:16 +05:30
Nabin Hait
44aa01b115
Merge pull request #56713 from frappe/chore/test-sales-invoice-trends
...
test: Sales Invoice Trends report coverage
2026-07-01 22:51:47 +05:30
Nabin Hait
1a8ef852f1
test: add coverage for Downtime Analysis report
2026-07-01 22:49:01 +05:30
Nabin Hait
e0bf3713ea
test: add coverage for Quality Inspection Summary report
2026-07-01 22:48:53 +05:30
Nabin Hait
eadaf37606
test: add coverage for BOM Explorer report
2026-07-01 22:48:43 +05:30
Nabin Hait
baae9bfb22
test: add coverage for Production Analytics report
2026-07-01 22:48:35 +05:30
Nabin Hait
4f3dcd9e39
test: add coverage for Job Card Summary report
2026-07-01 22:48:27 +05:30
Nabin Hait
7a9e901e5e
test: add coverage for Work Order Summary report
2026-07-01 22:48:13 +05:30
Mihir Kandoi
bb184f90a7
perf: serialize concurrent reposts with an advisory lock
...
Wraps per-(item, warehouse) reposting in repost_future_sle with a session-level advisory lock in front of the existing for-update row locks -- an outer gate that turns lock-order deadlocks into an orderly wait. Postgres/MariaDB only; nullcontext elsewhere. Row locks still enforce correctness. Requires frappe advisory_lock.
2026-07-01 22:11:43 +05:30
Mihir Kandoi
b2ad93be81
perf: use recursive CTEs for BOM and Task tree traversal
...
Reimplements get_ancestor_boms, BOM.traverse_tree, Task.check_recursion and the BOM Explorer report as single recursive-CTE queries (frappe.qb recursive=True), replacing query-per-node walks (N->1). Task cycle detection now catches cycles at any depth (was capped at 15 nodes). Requires the framework recursive-CTE support (frappe#40464).
2026-07-01 22:10:57 +05:30
Mihir Kandoi
65cb89cc40
Merge pull request #56552 from aerele/fix-quotation-conversion-rate-from-customer
...
fix: set conversion_rate on quotation created from customer
2026-07-01 21:46:28 +05:30
Mihir Kandoi
26a646aae5
Merge pull request #56701 from aerele/fix/pick-list-status-issue
...
feat(stock): support partial transfer from pick list
2026-07-01 21:45:17 +05:30
Mihir Kandoi
7d5efaf124
Merge pull request #56670 from aerele/fix/pick-list-wo-status-not-started
...
fix: recompute transferred qty before deciding work order status
2026-07-01 21:44:35 +05:30
Nabin Hait
0e8b152c68
fix: avoid double-counting the total in accumulated Consolidated Financial Statement
2026-07-01 21:26:04 +05:30
Nabin Hait
028cc2cf49
fix: age payments by the payment period (payment date - invoice date)
2026-07-01 21:23:58 +05:30
Nabin Hait
249d519d02
fix: compute Share Balance as-on the selected date
2026-07-01 21:20:57 +05:30
Nabin Hait
e9aac23913
fix: filter Billed Items To Be Received by invoice name, not per_received
2026-07-01 21:18:01 +05:30
Nabin Hait
f4088d48a1
fix: accept a scalar account filter in Invalid Ledger Entries report
2026-07-01 21:16:20 +05:30
Nabin Hait
2c3285286c
test: add coverage for Consolidated Financial Statement report
2026-07-01 21:13:21 +05:30
Nabin Hait
8e560f1d1c
test: add coverage for Share Ledger report
2026-07-01 21:13:12 +05:30
Nabin Hait
02460b4684
test: add coverage for Share Balance report
2026-07-01 21:13:02 +05:30
Nabin Hait
2a1461c754
test: add coverage for Bank Clearance Summary report
2026-07-01 21:08:05 +05:30
Nabin Hait
ee8e6e806f
test: add coverage for Payment Period Based On Invoice Date report
2026-07-01 21:07:56 +05:30
Nabin Hait
cccfdc72c9
test: add coverage for Billed Items To Be Received report
2026-07-01 21:07:45 +05:30
Nabin Hait
196482348d
test: add coverage for Delivered Items To Be Billed report
2026-07-01 21:07:31 +05:30
Nabin Hait
237605889f
test: add coverage for Received Items To Be Billed report
2026-07-01 21:07:21 +05:30
Nabin Hait
293f737e4a
test: add coverage for Calculated Discount Mismatch report
2026-07-01 21:02:36 +05:30
Nabin Hait
38ebfd7bd6
test: add coverage for Voucher-wise Balance report
2026-07-01 21:02:29 +05:30
Nabin Hait
9ec2945e6e
test: add coverage for Invalid Ledger Entries report
2026-07-01 21:02:21 +05:30
Nabin Hait
cb9ea22b6f
test: add coverage for Purchase Invoice Trends report
2026-07-01 21:02:12 +05:30
Nabin Hait
8aec16376e
test: add coverage for Sales Invoice Trends report
2026-07-01 21:02:02 +05:30
Nabin Hait
7bc121e308
Merge pull request #56520 from frappe/chore/test-incorrect-serial-and-batch-bundle
...
test: Incorrect Serial and Batch Bundle report coverage
2026-07-01 20:54:20 +05:30
Nabin Hait
0f65004626
Merge pull request #56544 from frappe/chore/test-stock-and-account-value-comparison
...
test: Stock and Account Value Comparison report coverage
2026-07-01 20:30:25 +05:30
Nabin Hait
1fdc3875b6
Merge pull request #56513 from frappe/chore/test-warehouse-wise-stock-balance
...
test: Warehouse Wise Stock Balance report coverage
2026-07-01 20:30:12 +05:30
Nabin Hait
bea8c7bea2
Merge pull request #56507 from frappe/chore/budget-variance-report-test-coverage
...
test: Budget Variance report value coverage
2026-07-01 20:29:55 +05:30
Nabin Hait
4ea9125902
Merge pull request #56506 from frappe/chore/stock-ledger-test-coverage
...
test: Stock Ledger report coverage
2026-07-01 20:29:06 +05:30
Nabin Hait
ef877c4001
Merge pull request #56505 from frappe/chore/item-wise-purchase-history-test-coverage
...
test: Item-wise Purchase History report coverage
2026-07-01 20:28:39 +05:30
Nabin Hait
bb0a46db9e
Merge pull request #56504 from frappe/chore/item-wise-sales-history-test-coverage
...
test: Item-wise Sales History report coverage
2026-07-01 20:28:29 +05:30
Nabin Hait
ae155e916a
Merge pull request #56524 from frappe/chore/test-stock-ledger-variance
...
test: Stock Ledger Variance report coverage
2026-07-01 20:27:51 +05:30
