Merge pull request #56524 from frappe/chore/test-stock-ledger-variance

test: Stock Ledger Variance report coverage
2026-08-18 00:48:42 +00:00 · 2026-07-01 20:27:51 +05:30
parent cd6a8952e6 f47141a3b7
commit ae155e916a
1 changed files with 106 additions and 0 deletions
--- a/erpnext/stock/report/stock_ledger_variance/test_stock_ledger_variance.py
+++ b/erpnext/stock/report/stock_ledger_variance/test_stock_ledger_variance.py
@@ -0,0 +1,106 @@
+# Copyright (c) 2026, Frappe Technologies Pvt. Ltd. and Contributors
+# See license.txt
+
+import frappe
+
+from erpnext.tests.utils import ERPNextTestSuite
+
+
+class TestStockLedgerVariance(ERPNextTestSuite):
+	def run_report(self, **extra):
+		from erpnext.stock.report.stock_ledger_variance.stock_ledger_variance import execute
+
+		filters = {"company": "_Test Company"}
+		filters.update(extra)
+
+		return execute(frappe._dict(filters))[1]
+
+	def test_healthy_stock_has_no_variance(self):
+		from erpnext.stock.doctype.stock_entry.stock_entry_utils import make_stock_entry
+
+		item = "_Test Item"
+		frappe.db.set_value("Item", item, "valuation_method", "Moving Average")
+
+		make_stock_entry(
+			item_code=item,
+			to_warehouse="Stores - _TC",
+			qty=10,
+			rate=100,
+			posting_date="2026-06-01",
+		)
+		make_stock_entry(
+			item_code=item,
+			from_warehouse="Stores - _TC",
+			qty=4,
+			posting_date="2026-06-02",
+		)
+
+		# A clean receipt followed by a clean issue keeps the ledger consistent,
+		# so the corruption detector must not flag any entry for this item.
+		data = self.run_report(item_code=item)
+		self.assertFalse([row for row in data if row.get("item_code") == item])
+
+		qty_data = self.run_report(item_code=item, difference_in="Qty")
+		self.assertFalse([row for row in qty_data if row.get("item_code") == item])
+
+	def test_multiple_clean_movements_no_variance(self):
+		from erpnext.stock.doctype.stock_entry.stock_entry_utils import make_stock_entry
+
+		item = "_Test Item"
+		frappe.db.set_value("Item", item, "valuation_method", "Moving Average")
+
+		make_stock_entry(
+			item_code=item,
+			to_warehouse="Stores - _TC",
+			qty=10,
+			rate=100,
+			posting_date="2026-06-01",
+		)
+		make_stock_entry(
+			item_code=item,
+			to_warehouse="Stores - _TC",
+			qty=5,
+			rate=120,
+			posting_date="2026-06-02",
+		)
+		make_stock_entry(
+			item_code=item,
+			to_warehouse="Stores - _TC",
+			qty=8,
+			rate=90,
+			posting_date="2026-06-03",
+		)
+		make_stock_entry(
+			item_code=item,
+			from_warehouse="Stores - _TC",
+			qty=6,
+			posting_date="2026-06-04",
+		)
+
+		# Several receipts at different rates plus an issue still produce a
+		# self-consistent ledger, so no variance rows are expected.
+		data = self.run_report(item_code=item)
+		self.assertFalse([row for row in data if row.get("item_code") == item])
+
+	def test_incorrect_balance_qty_is_flagged(self):
+		from erpnext.stock.doctype.stock_entry.stock_entry_utils import make_stock_entry
+
+		item = "_Test Item 2"
+		warehouse = "Stores - _TC"
+		frappe.db.set_value("Item", item, "valuation_method", "Moving Average")
+
+		entry = make_stock_entry(
+			item_code=item, to_warehouse=warehouse, qty=10, rate=100, posting_date="2026-06-01"
+		)
+		sle = frappe.db.get_value(
+			"Stock Ledger Entry",
+			{"voucher_no": entry.name, "item_code": item, "warehouse": warehouse},
+			"name",
+		)
+
+		# corrupt the stored running balance (expected 10 from the receipt, but now claims 7)
+		frappe.db.set_value("Stock Ledger Entry", sle, "qty_after_transaction", 7, update_modified=False)
+
+		data = self.run_report(item_code=item, difference_in="Qty")
+		row = next(r for r in data if r.get("item_code") == item)
+		self.assertEqual(row["difference_in_qty"], -3)  # 7 (stored) - 10 (expected)