Pruthvi Patel
f08d7410be
refactor: use read_only_depends_on instead of code ( #27008 )
...
(cherry picked from commit 332ac105b5 )
# Conflicts:
# erpnext/accounts/doctype/pos_invoice/pos_invoice.js
# erpnext/accounts/doctype/sales_invoice/sales_invoice.js
2021-08-24 06:38:39 +00:00
Nabin Hait
352157c9fc
Merge pull request #27005 from frappe/addl_salary_fix-v13
...
fix: Additional salary processing
2021-08-24 10:35:51 +05:30
Deepesh Garg
85f582b145
Merge pull request #26725 from deepeshgarg007/payment_entry_validations_and_trigger
...
fix: Multiple fixes in payment entry
2021-08-23 18:03:11 +05:30
Frappe PR Bot
3d047b83fd
fix: Eway bill test update to check ver 1.0.0421 ( #27083 ) ( #27084 )
2021-08-23 15:43:30 +05:30
Frappe PR Bot
6814509f07
fix: eway bill version changed to 1.0.0421 ( #27077 )
2021-08-23 15:43:06 +05:30
Saqib
dbca11071e
refactor: scan barcode field scanning ( #26990 ) ( #27076 )
2021-08-23 11:23:46 +05:30
Deepesh Garg
dd688db54c
Merge pull request #27072 from frappe-pr-bot/backport/version-13-hotfix/27069
...
feat: Column for total amount due in Accounts Receivable/Payable Summary
2021-08-22 23:15:58 +05:30
Deepesh Garg
be57dee57a
Merge pull request #27068 from frappe-pr-bot/backport/version-13-hotfix/26975
...
fix: Consolidated balance sheet showing incorrect values
2021-08-22 18:14:15 +05:30
Deepesh Garg
67dbb2bd7f
feat: Column for total amount due in Accounts Receivable/Payable Summary ( #27069 )
...
(cherry picked from commit 496bff5136 )
2021-08-22 12:41:50 +00:00
Deepesh Garg
571178ffbe
fix: Revert commit 46372fe
2021-08-22 18:02:51 +05:30
Deepesh Garg
9542da80c5
test: Update test cases
2021-08-21 19:36:38 +05:30
Deepesh Garg
593ab98575
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into payment_entry_validations_and_trigger
2021-08-21 19:19:10 +05:30
Deepesh Garg
43813875ea
fix: Consolidated balance sheet showing incorrect values ( #26975 )
...
(cherry picked from commit 57e326e7d0 )
2021-08-21 12:30:23 +00:00
Ankush Menat
d0e393a4cc
fix: Incorrect mandatory error message for warehouse ( #27060 )
...
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
2021-08-20 18:33:28 +05:30
Ankush Menat
05c7905fa3
fix(ux): removed rate from grid view ( #27061 )
...
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
2021-08-20 18:33:08 +05:30
Frappe PR Bot
3f05d928a3
refactor: rectify typo ( #27057 ) ( #27059 )
...
[skip ci]
(cherry picked from commit 62c590261c )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-08-20 18:24:49 +05:30
Frappe PR Bot
2fd823ffb6
fix: Cascade deletion for Company ( #26923 ) ( #27053 )
...
* fix: Cascade deletion for Company
(cherry picked from commit 2b2572b9b9 )
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2021-08-20 15:20:50 +05:30
Frappe PR Bot
52570cc1f9
refactor: renamed varint_item_code to variant_item_code ( #27025 ) ( #27046 )
...
(cherry picked from commit f13315809e )
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
2021-08-19 20:55:45 +05:30
Frappe PR Bot
5c6f6c16d6
fix: pass planned start date to created work order ( #27031 ) ( #27042 )
...
* fix: pass planned start date to created workorder
* test: production plan to work order start date
Co-authored-by: Alan <2.alan.tom@gmail.com >
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
(cherry picked from commit 9225f02599 )
2021-08-19 18:56:26 +05:30
Anoop
ee9b6d158a
feat(Healthcare): Capacity for Service Unit, concurrent appointments based on Capacity, Patient enhancements ( #24860 )
...
* fix: (tests) get_healthcare_docs and get_medical_department separated, related changes
* feat: Service Unit option to allow overlap, overlap capacity
Appointment to allow overlapping appointments
Co-authored-by: Akash Krishna <akash@earthianslive.com >
* feat: Create multiple service units from tree view
Co-authored-by: Akash Krishna <akash@earthianslive.com >
* feat: patient address and contact
patient dashboard links, customer stats
* fix: sider review
* fix: untranslated message
* fix: enable non-negative check for service unit capacity
- incorrect depends on statement in dialog
* refactor(UX): Available Slots Dialog
* chore: remove unused field from Healthcare Service Unit Type
Co-authored-by: Akash Krishna <akash@earthianslive.com >
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-08-19 18:15:51 +05:30
Frappe PR Bot
c192e9457e
fix: add child item groups into the filters ( #26997 ) ( #27035 )
...
* fix: add child item groups into the filters
* fix: appending values to proper variable
* fix: refactor the loop
(cherry picked from commit c60d5523bc )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-19 16:44:56 +05:30
Frappe PR Bot
74af3be968
fix: set production plan to completed even on over production ( #27027 ) ( #27032 )
...
(cherry picked from commit 09f34e558e )
Co-authored-by: Alan <2.alan.tom@gmail.com >
[skip ci]
2021-08-19 10:50:06 +00:00
Subin Tom
02a23bae58
Fix: Payment Entry party validation issue ( #27022 )
...
Co-authored-by: Subin Tom <subin-home@Subins-MacBook-Air.local >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-19 15:49:16 +05:30
Frappe PR Bot
df32fe3d49
Merge pull request #27026 from ankush/eq_assign ( #27030 )
...
fix: equality check instead of assignment
[skip ci]
(cherry picked from commit 993b0532f8 )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-08-19 15:45:39 +05:30
Ankush Menat
92b3743c54
Merge pull request #27024 from ankush/whitespace_fix
...
chore: whitespace cleanup from codebase
2021-08-19 14:57:57 +05:30
Ankush Menat
b42c23cad6
chore: ignore whitespace changes in git blame
2021-08-19 14:36:17 +05:30
Ankush Menat
9bb69e711a
chore: whitespace cleanup from codebase
2021-08-19 14:33:03 +05:30
Frappe PR Bot
e536f6d13f
fix: assigning values to rows in sales register reports ( #26546 ) ( #27020 )
...
* fix: assigning values to rows in sales register reports
* fix: check for is_internal_customer for unrealized_profit_loss_account
(cherry picked from commit ecd6584c50 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-19 13:30:50 +05:30
Frappe PR Bot
f37747da25
fix: Add ignore user perms to set_target_warehouse field in sales invoice ( #27013 )
...
* fix: Add ignore user perms to set_target_warehouse field in sales invoice (#26987 )
* reverting ot v12.7.1
* fix: Ignore user permissions for set_target_warehouse in SI
Co-authored-by: Subin Tom <subin-home@Subins-MacBook-Air.local >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
(cherry picked from commit ef792971f3 )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.json
* fix: conflicts
* fix: conflicts
Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-19 12:16:15 +05:30
Frappe PR Bot
25b705e2ad
fix: sales pipeline graph issue ( #26626 ) ( #27018 )
...
(cherry picked from commit 34353df48c )
Co-authored-by: Anupam Kumar <anupamvns0099@gmail.com >
2021-08-19 11:46:55 +05:30
rohitwaghchaure
87326dd489
Merge pull request #27007 from anupamvs/email-digest-fix
...
fix: [patch]Email digest fix
2021-08-19 11:09:21 +05:30
Frappe PR Bot
8ea5782c69
fix: filtering of items in Sales and Purchase Orders ( #26936 ) ( #27012 )
...
* fix: filtering of items in Sales and Purchase Orders
* fix: slider
* fix: slider
(cherry picked from commit dc7280eef0 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-18 20:44:45 +05:30
Frappe PR Bot
6a35d580e4
fix: Dimension filter query fix to avoid including disabled dimensions ( #26988 ) ( #27006 )
...
* reverting ot v12.7.1
* fix: Dimension filter query fix to not display disabled dimensions
Co-authored-by: Subin Tom <subin-home@Subins-MacBook-Air.local >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
(cherry picked from commit 333e44eb47 )
Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-18 18:46:25 +05:30
Frappe PR Bot
77ad668a6f
fix: date_unchanged calculation in "Update Items" ( #26992 ) ( #27010 )
...
Branch corrected https://github.com/frappe/erpnext/pull/26058
ERPNext generates "Cannot set quantity less than delivered quantity" error even the delivered qty is zero when user clicks "Update Items".
"date_unchanged" variable gets false value because of new_date is string.
"getdate(new_date)" corrects the date comparison.

(cherry picked from commit d8a7abcd02 )
Co-authored-by: Türker Tunalı <turkert@hotmail.com >
2021-08-18 12:32:59 +00:00
Nabin Hait
5e1ed2d7eb
fix: Message (Received Amount should be same as Paid Amount)
2021-08-18 16:46:32 +05:30
Anupam
36f18935d3
fix: email digest recipient patch
2021-08-18 16:30:45 +05:30
Anupam
01a538123b
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into version-13-hotfix
2021-08-18 16:15:38 +05:30
Nabin Hait
44919ac807
fix: Additional salary processing
2021-08-18 16:14:48 +05:30
Frappe PR Bot
e555e8cf05
fix: Return Qty in PR/DN for legacy data ( #27001 ) ( #27003 )
...
(cherry picked from commit 112fc888f1 )
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2021-08-18 10:30:51 +00:00
Deepesh Garg
0f15ded0cd
Merge branch 'payment_entry_validations_and_trigger' of https://github.com/deepeshgarg007/erpnext into payment_entry_validations_and_trigger
2021-08-18 15:58:46 +05:30
Deepesh Garg
46372fe5cd
fix: Decide party account debit or credit on payment entry type instead of party type
2021-08-18 15:57:55 +05:30
Deepesh Garg
6950844a74
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into payment_entry_validations_and_trigger
2021-08-18 15:29:48 +05:30
Frappe PR Bot
5e17b82779
fix: set account for change amount even if pos profile not found ( #26986 ) ( #26989 )
...
(cherry picked from commit 5fec44446e )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-17 20:34:35 +05:30
Deepesh Garg
9c401e75bb
Merge pull request #26980 from deepeshgarg007/payment_entry_unallocated_fix_v13
...
fix: Incorrect unallocated amount calculation in payment entry
2021-08-17 19:14:07 +05:30
Frappe PR Bot
90818d57f1
fix: change print_format_type from Server to Jinja ( #26374 ) ( #26985 )
...
(cherry picked from commit a2966db1e5 )
Co-authored-by: Mohammed Redah <mhbu50@gmail.com >
2021-08-17 13:36:08 +00:00
Ankush Menat
333d962ac2
test: fix tests failing due to doc amend feature (bp #26656 ) ( #26907 )
...
* test: fix test due to rename change
* test: fix attendance request tests
- Use `frappe.db.get_value` instead of `get_doc` for asserting values
- Get values after cancellation as reloading attendance doc breaks due to stale doc (primary key changed after cancel of attendance request)
- rollback everything on tearDown
* test: fix Shift Request test
- Use `get_value` instead of `get_doc`
- Remove unnecessary loop, only one shift assignment is made against a shift request
- Get value after cancel again. Get doc is not reliable since primary key changed after cancel
* test: fix POS Closing Entry Test
- Separated into two tests, one checks if SI cancelling is blocked, the other checks PCE cancel impact
- This is done because after cancel via assertRaises, damage done by cancel still exists or is partially comitted
- Dont use this partially cancelled doc for any assertions further, end test at exception assertion
- Use `get_value` to check SI docstatus, as its primary key changes after cancel
* test: fixed asset movement tests
- set cwip account in company to avoid value missing
- removed unused statement
- removed trailing spaces
* Revert "test: fix POS Closing Entry Test"
This reverts commit 8f1a3aef2e .
Co-authored-by: marination <maricadsouza221197@gmail.com >
2021-08-17 18:01:39 +05:30
Deepesh Garg
2730f51ca9
test: Add test case for payment entry
2021-08-17 17:44:30 +05:30
Raffael Meyer
ace8cf965d
fix: typo ( #26967 )
2021-08-17 16:13:28 +05:30
Deepesh Garg
94f2c41475
fix: Incorrect unallocated amount calculation in payment entry
2021-08-17 13:31:17 +05:30
Sagar Vora
48a11591cc
Merge pull request #26976 from resilient-tech/fix-incorrect-modified ( #26979 )
...
fix: Incorrect `modified` time in documents that inherit from `StatusUpdater`
(cherry picked from commit d932cba38a )
Co-authored-by: Sagar Vora <sagar@resilient.tech >
2021-08-17 13:21:00 +05:30