fix: v14, Bank Reconcile Tools not cover case JV debit bank (#35000)
(cherry picked from commit c36dc3dc57)
Co-authored-by: Kitti U. @ Ecosoft <kittiu@gmail.com>
* refactor: rewrite `get_stock_value_on()` queries in `QB`
(cherry picked from commit e43bc38e05)
* refactor: sum up SLE value in query
(cherry picked from commit 9a37ac6c25)
* refactor: `get_stock_value_on()` to get stock value of multiple warehouses at once
(cherry picked from commit e782a054c8)
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
fix: Payment entry with TDS in bank reco statement (#34961)
(cherry picked from commit ecea9b44a3)
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
fix: click handler should not attempt indexed access of empty array (#35013)
fix: click handler should not attempt indexed access
of empty array
(cherry picked from commit 3d90b970d1)
Co-authored-by: tundebabzy <tundebabzy@gmail.com>
fix: wrong qty of remaining work orders to be created when using "Create" > "Work Order" (#34726)
* fix: convert asynchronous field update to synchronous
* fix: wrong qty of remaining work orders to be created when using "Create" > "Work Order"
(cherry picked from commit 189b020d22)
Co-authored-by: danjeremynavarro <46537526+danjeremynavarro@users.noreply.github.com>
fix: Use set instead of db_set as it is called from validate (#34967)
(cherry picked from commit 72b5c1f70a)
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
feat: Reconcile Payments in background (#34596)
* feat: auto reconcile in background
* chore: Option to enable auto reconciliation in settings
* refactor: validate if feature is enabled in settings
* refactor: check for running job while using reconciliation tool
* chore: using doc to get filter values
* chore: use frappe.db.get_value in validations
* chore: cleanup commented out code
* chore: replace get_list with get_all
* chore: use block scope variable
* chore: type information for functions
* refactor: flag to ignore job validation check
* refactor: update parent doc status if all reconciled
* chore: create test_records file
* test: create a bunch of vouchers for testing auto reconcile
* chore: renamed auto_reconcile to process_payment_reconciliation
* chore: another child doctype to hold payments
* chore: remove duplicate field
* chore: add fetched payments to log
* chore: Popup comment message update
* chore: replace get_all with get_value
* chore: replace label in settings page
* chore: remove unit test and records
* refactor: status in reconciliation log
* refactor: set status in log as well
* chore: fix field name
* chore: change triggered job name
* chore: use status field in list view of log
* chore: status while there are no allocations
* refactor: split trigger function into two
* chore: adding cancelled status
* refactor: function trigger queued docs
* chore: cron job scheduled
* chore: fixing accouts settings json file
* chore: typos and variable scope
* chore: use 'pluck' in db call
* chore: remove redundant whitelist decorator
* chore: use single DB call to fetch values
* chore: replace get_all with get_value
* refactor: use raw db calls to fetch reconciliation log records
Using get_doc on `Process Payment Reconciliation Log` is costly when
handling large volumes of invoices.
Use raw frappe.db.get_all to selectively pull status and reconciled count
* chore: update status on successful batch operation
* chore: make payment table readonly
* chore: ability to pause the background job
* chore: remove isolate_each_allocation
* chore: more description in progress bar
* refactor: partially working state
* refactor: update reconcile flag and setting hard limits for fetching
* chore: make allocation editable -- NEED TO REVERT
* chore: pause button
* refactor: skip setter function in Payment Entry for better performan
* refactor: split reconcile function and skip a setter function
1. Split reconcile function into 2
2. While reconciling against payment entry, skip a
set_missing_ref_details setter method
* chore: increase payment limit
* refactor: replace frappe.db.get_all with frappe.db.get_value
* chore: remove unwanted doctypes
* refactor: make allocation table readonly
* perf: update ref_details only for newly linked invoices
* chore: rename skip flag
* refactor(UI): receivable_payable field should auto populate
* refactor: no control statements in finally block
* chore: cleanup section and rename checkbox
* chore: update new fieldname in code
* chore: update error msg
* refactor: start and pause integrated into status
pause checkbox has been removed
* refactor: added cancelled status to the log doctype
1. Moved the status section to the bottom in parent doc
2. Using alerts to indicate Job trigger status
(cherry picked from commit ed14d1ce44)
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
fix: use filter_by_finance_book instead of only_depreciable_assets in fixed asset register (#35031)
fix: use filter_by_finance_book instead of only_depreciable_assets
(cherry picked from commit e08d636bf7)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
* fix: update value of asset with calc_depr on after manual depr entry
* fix: value of asset with calc_depr on after manual depr entry not reflecting in asset_depr_and_bal report
* chore: add validation for depr journal entry
* test: manual_depr_for_depreciable_asset and manual_depr_w_incorrect_jv_voucher_type
* chore: unlink depreciable asset from manual depr entry
fix: FEC report for France accountancy (#34781)
* fix: FEC report for France Accountancy legal requirement
* fix: FEC report for France Accountancy legal requirement
* fix: change to query standard
* fix: change to query standard
* fix: columns to standard dict
* fix: columns to standard dict
* fix: columns to data
* refactor: french report FEC
* refactor: french report FEC (2)
---------
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
(cherry picked from commit af8da53cf4)
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
chore: Move source and campaign to more info section (#34946)
(cherry picked from commit a02705ded7)
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>