rohitwaghchaure
ebcdcfcd84
Merge pull request #53679 from aerele/feat/SDBNB-account
...
feat: add Stock Delivered But Not Billed (SDBNB) accounting for DN and SI
2026-05-22 08:41:39 +05:30
kavin-114
91026fbdb3
fix: classify Stock Delivered But Not Billed as a Current Asset
...
This account holds a debit balance (inventory value delivered but not yet
invoiced) and clears to COGS on Sales Invoice, so it is economically a
short-term clearing asset rather than a trade payable. Move it from the
Stock Liabilities group to Stock Assets under Current Assets, with
account_category "Stock Assets" (and account_number 1420 in the numbered
chart). The account_type "Stock Delivered But Not Billed" is unchanged,
so posting logic in Sales Invoice and Delivery Note continues to key off
the correct account.
2026-05-22 06:50:23 +05:30
rohitwaghchaure
61547fff44
chore: fixed test case
2026-05-22 06:50:23 +05:30
Rohit Waghchaure
ba1f40fdd9
fix: posting date and time
2026-05-22 06:50:23 +05:30
Pugazhendhi Velu
9ff3e28f5d
fix: validate expense account for items linked to sales invoice
2026-05-22 06:50:23 +05:30
kavin-114
78993c1ebe
fix: update cost center tests to use dynamic expense account
...
Existing tests hardcoded "Cost of Goods Sold" as expected GL account,
but SDBNB overrides it on DN submission. Use dn.items[0].expense_account
to work with both SDBNB-enabled and legacy companies.
2026-05-22 06:50:23 +05:30
kavin-114
6ee7dc0b49
test: add unit test cases for Stock Delivered But Not Billed
2026-05-22 06:50:23 +05:30
kavin-114
05877140d1
feat: handle post delivery invoices gl reposting
2026-05-22 01:13:12 +05:30
Pugazhendhi Velu
3364ee9274
feat(stock): add Stock Delivered But Not Billed GL entries on Delivery Note and Sales Invoice
2026-05-22 01:13:12 +05:30
Pugazhendhi Velu
8596d98ac4
feat(accounts): add Stock Delivered But Not Billed account type and defaults
2026-05-22 01:13:12 +05:30
Pugazhendhi Velu
bb5d4d8682
feat(company): add Stock Delivered But Not Billed account configuration
2026-05-22 01:13:12 +05:30
Khushi Rawat
8ea7efc01d
Merge pull request #55146 from khushi8112/payment-entry-foreign-currency-remarks
...
fix: correct remarks for foreign currency payment entries
2026-05-21 20:11:38 +05:30
Khushi Rawat
23b5afc5de
Merge pull request #54946 from Shllokkk/letter-head-fix
...
feat(company): add a default_letter_head_report field in company doctype
2026-05-21 20:05:56 +05:30
rohitwaghchaure
160b92f9cd
Merge pull request #54466 from rohitwaghchaure/revamp-stock-entry
...
refactor: stock_entry file to improve readability and maintainability
2026-05-21 19:47:04 +05:30
Khushi Rawat
70b9f549a4
Merge pull request #55147 from khushi8112/debit-note-rate-adjustment-description
...
fix: correct description for Is Rate Adjustment Entry (Debit Note) checkbox
2026-05-21 18:06:51 +05:30
khushi8112
92c969478e
fix: correct description for Is Rate Adjustment Entry (Debit Note) checkbox
2026-05-21 17:33:59 +05:30
khushi8112
c6cde700b5
fix: correct remarks for foreign currency payment entries
2026-05-21 17:25:55 +05:30
Rohit Waghchaure
068f7b9a8d
refactor: split large functions into smaller functions
2026-05-21 17:12:59 +05:30
Khushi Rawat
83f100bae1
Merge pull request #55142 from khushi8112/composite-asset-net-purchase-amount-reset
...
fix: don't reset net_purchase_amount for Composite Asset if already set
2026-05-21 17:07:41 +05:30
khushi8112
98dae6e43a
fix: don't reset net_purchase_amount for Composite Asset if already set
2026-05-21 17:04:33 +05:30
diptanilsaha
18bdd0afd3
Merge pull request #55127 from diptanilsaha/fix/tax-rule-date-filter
...
refactor: migrate get_tax_template to query builder with hierarchical group matching
2026-05-21 17:04:02 +05:30
diptanilsaha
8c43118725
test: add tests for supplier group hierarchy and use_for_shopping_cart filter
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-21 16:43:00 +05:30
diptanilsaha
4d43c74f5f
fix: default use_for_shopping_cart to 0 in set_taxes
...
Ensures regular transactions only match tax rules where
use_for_shopping_cart = 0, preventing webshop-specific rules
from applying to standard documents.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-21 16:43:00 +05:30
diptanilsaha
f98975f51a
refactor: rewrite get_tax_template using query builder
...
Migrates from raw frappe.db.sql with string interpolation to frappe.qb.
Adds hierarchical supplier_group matching (mirrors customer_group behaviour).
Removes unused get_customer_group_condition helper.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-21 16:43:00 +05:30
diptanilsaha
cb610b79d2
feat: add get_parent_supplier_groups using query builder
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-21 16:42:56 +05:30
diptanilsaha
91a2a7b0a0
refactor: migrate get_parent_customer_groups to query builder
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-21 16:41:53 +05:30
rohitwaghchaure
8aaa7c0993
Merge pull request #55134 from rohitwaghchaure/fixed-removed-redundant-code
...
fix: removed redundant code
2026-05-21 15:24:41 +05:30
Pandiyan P
1a81265c2c
fix(manufacturing): remove forecast_qty and adjust_qty fields from sa… ( #55129 )
2026-05-21 15:01:55 +05:30
Rohit Waghchaure
14b17cd8a6
fix: removed redundant code
2026-05-21 14:56:35 +05:30
Mihir Kandoi
2f35660142
fix: consumed operation cost calculation ( #54858 )
2026-05-21 14:55:46 +05:30
Jatin3128
06477119d1
fix: corrected the pricing rule taking the wrong value ( #54894 )
2026-05-21 12:04:45 +05:30
Rohit Waghchaure
961cbc3625
refactor: using agentic AI
2026-05-21 09:52:55 +05:30
Raffael Meyer
341891e326
fix: status for settled credit notes in sales invoice list ( #54764 )
2026-05-20 21:50:41 +02:00
Rohit Waghchaure
4d14727b26
fix: linter issue
2026-05-20 23:31:09 +05:30
Mihir Kandoi
33dc1f5f09
fix: set weight in update items ( #55089 )
2026-05-20 16:38:37 +00:00
Rohit Waghchaure
a3a7733440
test: fixed test cases
2026-05-20 21:59:17 +05:30
Daniel Radl
d85f6a4541
chore: migrate to new docker publish workflow ( #54499 )
2026-05-20 16:22:09 +00:00
Raffael Meyer
8845be9419
fix: allow direct drop-ship on Purchase Orders without Sales Order ( #54930 )
2026-05-20 18:03:21 +02:00
Mihir Kandoi
3084e3654c
fix: item price with party condition ( #55100 )
2026-05-20 11:48:15 +00:00
Mihir Kandoi
00057b1798
fix: valuation rate missing for standalone credit notes for moving av… ( #55102 )
2026-05-20 11:28:01 +00:00
Mihir Kandoi
0bbddf4994
fix: set bin details when adding item using update items ( #55096 )
2026-05-20 09:46:05 +00:00
Shllokkk
bd84434d34
fix: incorrect error message string in sales order ( #55090 )
2026-05-20 14:41:06 +05:30
Pandiyan P
a3950590da
fix(manufacturing): fetch from_bom name in production plan ( #55085 )
2026-05-20 14:22:17 +05:30
diptanilsaha
6c6fa722af
chore: migrate Address/Contact custom fields from JSON fixtures to install ( #55084 )
...
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-20 08:39:24 +00:00
MochaMind
eb67afa01a
fix: sync translations from crowdin ( #55065 )
2026-05-20 13:53:53 +05:30
diptanilsaha
12bb86d688
chore: remove frappe-semgrep-rules submodule ( #55083 )
2026-05-20 07:28:01 +00:00
Rohit Waghchaure
38eeb6994c
test: fixed test cases
2026-05-20 12:02:44 +05:30
ruthra kumar
dd782d96bf
Merge pull request #55072 from ruthra-kumar/faster_opening_balance_range_calculation
...
perf: faster opening balance range calculation in process period closing voucher
2026-05-20 11:48:10 +05:30
Sudharsanan Ashok
b9e08f3ce4
fix(stock): remove recalculate current qty function ( #54774 )
2026-05-20 11:37:26 +05:30
ruthra kumar
eba58b2837
refactor: ppcv select with for update and skip locked
2026-05-20 11:23:06 +05:30