Nabin Hait
7f01d6b24e
test: reuse BootStrapTestData master data in Stock Balance report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:13 +05:30
Nabin Hait
f474c10f89
test: reuse BootStrapTestData master data in General Ledger report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:06 +05:30
Nabin Hait
a797c31b57
test: reuse BootStrapTestData master data in Cash Flow report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:09:00 +05:30
Nabin Hait
1a820abe3c
test: reuse BootStrapTestData master data in Accounts Receivable/Payable report tests
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 14:08:53 +05:30
Mihir Kandoi
a972ef313a
Merge pull request #56127 from harisansari008/fix/qip-allow-rename-develop
...
fix: allow rename for Quality Inspection Parameter
2026-06-26 13:43:40 +05:30
Nabin Hait
245925815e
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:36:26 +05:30
Nabin Hait
7f5f2ccfa3
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:28:05 +05:30
Nabin Hait
dc4f5ce0ab
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:56 +05:30
Nabin Hait
182ef8a8e8
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:48 +05:30
Nabin Hait
b11a2c3e9f
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:19 +05:30
Nabin Hait
67ac8f64e8
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:14 +05:30
Nabin Hait
9158d5f893
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:04 +05:30
Nabin Hait
2aff857561
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:27:00 +05:30
Nabin Hait
0e6f50ca24
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:28 +05:30
Nabin Hait
6ceddd7a83
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:24 +05:30
Nabin Hait
f2d64d1a2a
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:14 +05:30
Nabin Hait
293ca4e96f
test: reuse BootStrapTestData master data to reduce runtime
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 13:26:08 +05:30
Mihir Kandoi
05e44ca63a
Merge pull request #56546 from mihir-kandoi/pg-rawsql-to-orm
...
refactor: convert convertible raw frappe.db.sql to ORM
2026-06-26 12:21:25 +05:30
Mihir Kandoi
0583349ae4
test: convert aggregate/pluck/positional raw SQL to ORM
...
A deeper re-audit (with an adversarial skeptic) of the queries left raw
in the prior commit found more that have exact ORM equivalents:
- scalar SUM/MAX -> frappe.qb + Sum/Max .run()[0][0]
- SUM ... GROUP BY -> frappe.qb .groupby().select(Sum().as_()) run(as_dict)
- name IN (values) -> get_all(filters={'f': ['in', ...]})
- sql_list(select col) -> get_all(pluck='col')
- bulk UPDATE ... = NULL/value -> frappe.db.set_value(filters, field, val)
- positional as_list reads -> get_all(..., as_list=True) (+ sorted())
Note: get_value(dt, filters, 'sum(x)') and get_all(fields=['sum(x)'])
are rejected by frappe ('SQL functions are not allowed as strings'), so
aggregates go through frappe.qb. get_all(as_list=True) returns a tuple
(not a list), so consumers that mutate use sorted().
All affected test modules pass on MariaDB.
2026-06-26 11:34:31 +05:30
Mihir Kandoi
0776f7f7fa
test: convert trivially-equivalent raw SQL to ORM helpers
...
Convert test-only raw frappe.db.sql calls that have an exact ORM
equivalent: full-table/filtered deletes -> frappe.db.delete, count ->
frappe.db.count, row-existence assertions -> frappe.db.exists,
single-row scalar fetches -> frappe.db.get_value, and simple
equality/range-filter selects -> frappe.get_all. No behaviour change.
Raw SQL that genuinely needs it is left as-is (dynamic identifiers,
aggregates/group-by, positional as_list consumers, DB-catalog
introspection).
2026-06-26 10:44:17 +05:30
Mihir Kandoi
0e54e532ff
refactor(accounts): use frappe.get_all for trial balance account fetch
...
The Account metadata fetch in the DuckDB trial-balance path is a plain
static SELECT (fixed columns, single company filter, order by lft).
Convert it to frappe.get_all. Verified on Postgres: identical 98 rows,
same order and same dict payload as the raw query.
2026-06-26 10:44:05 +05:30
Nabin Hait
de45ab7fc9
test: add coverage for Incorrect Stock Value Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:40:32 +05:30
Nabin Hait
5ad8ea3f17
test: add coverage for Item Where Used report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:39:59 +05:30
Nabin Hait
b537e8b183
test: add coverage for Delayed Order Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:20 +05:30
Nabin Hait
ce5239132c
test: add coverage for Delayed Item Report report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:12 +05:30
Nabin Hait
8bef2b13a1
test: add coverage for Batch Item Expiry Status report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:33:05 +05:30
Nabin Hait
c69077cd3a
test: add coverage for BOM Search report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:32:58 +05:30
Nabin Hait
4a6b189221
test: add coverage for Item Variant Details report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:25:55 +05:30
Nabin Hait
08ce18fe58
test: add coverage for Item Price Stock report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:25:40 +05:30
Nabin Hait
7661e5ed96
test: add coverage for Serial No Ledger report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:25:18 +05:30
Nabin Hait
dddaa80f99
test: add coverage for Serial and Batch Summary report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:25:11 +05:30
Nabin Hait
09be6fed9a
test: add coverage for Stock Ledger Invariant Check report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:19:59 +05:30
Nabin Hait
5790bcf99d
test: add coverage for Batch-Wise Balance History report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 10:19:04 +05:30
Mihir Kandoi
ea9bf932d8
Merge pull request #56510 from frappe/revert-56497-serial-batch-bundle-print-none-fix
...
Revert "fix: handle missing serial and batch bundle in print format"
2026-06-26 10:18:43 +05:30
Mihir Kandoi
993a011005
Revert "fix: handle missing serial and batch bundle in print format"
2026-06-26 10:07:23 +05:30
Nabin Hait
d18177665b
test: add coverage for Trial Balance for Party report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 09:11:45 +05:30
Nabin Hait
507bc0930e
Merge pull request #56412 from frappe/chore/fixed-asset-register-test-coverage
...
test: Fixed Asset Register report coverage
2026-06-25 22:13:39 +05:30
MochaMind
c3d2ebd734
fix: sync translations from crowdin ( #56396 )
2026-06-25 16:35:56 +02:00
Shllokkk
142d80d7de
Merge pull request #56497 from Shllokkk/serial-batch-bundle-print-none-fix
...
fix: handle missing serial and batch bundle in print format
2026-06-25 19:22:23 +05:30
Mihir Kandoi
c8f86099e2
Merge pull request #56479 from mihir-kandoi/messages/crm
...
chore: rewrite user-facing messages in crm module
2026-06-25 18:47:25 +05:30
Mihir Kandoi
ab1e949752
Merge pull request #56482 from mihir-kandoi/messages/erpnext_integrations
...
chore: rewrite user-facing messages in erpnext_integrations module
2026-06-25 18:43:52 +05:30
Mihir Kandoi
8ad90338a3
Merge pull request #56469 from mihir-kandoi/messages/controllers
...
chore: rewrite user-facing messages in controllers module
2026-06-25 18:38:23 +05:30
Mihir Kandoi
d2ff0913df
Merge pull request #56476 from mihir-kandoi/messages/projects
...
chore: rewrite user-facing messages in projects module
2026-06-25 18:35:00 +05:30
Mihir Kandoi
05dd44246f
Merge pull request #56475 from mihir-kandoi/messages/subcontracting
...
chore: rewrite user-facing messages in subcontracting module
2026-06-25 18:33:55 +05:30
Mihir Kandoi
6e22f4b063
Merge pull request #56498 from mihir-kandoi/messages/exchange-rate-server-grammar
...
chore: fix grammar in Exchange Rate Revaluation validation message
2026-06-25 18:28:11 +05:30
Mihir Kandoi
d737c39131
Merge pull request #56473 from mihir-kandoi/messages/selling
...
chore: rewrite user-facing messages in selling module
2026-06-25 18:24:13 +05:30
Nabin Hait
38385432f6
test: assert group-by totals on delta to avoid shared-category leak
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-25 18:22:58 +05:30
Nabin Hait
78fd06048f
style: apply ruff formatting
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-25 18:21:08 +05:30
Mihir Kandoi
1b68445313
Merge pull request #56480 from mihir-kandoi/messages/utilities
...
chore: rewrite user-facing messages in utilities module
2026-06-25 18:17:50 +05:30
Nabin Hait
3a3f56350f
Merge remote-tracking branch 'origin/develop' into chore/fixed-asset-register-test-coverage
...
# Conflicts:
# erpnext/assets/report/fixed_asset_register/test_fixed_asset_register.py
2026-06-25 18:10:53 +05:30