Rohit Waghchaure
e2c4e16d72
test: added test case
...
(cherry picked from commit f9f662679f )
2023-06-15 13:43:20 +00:00
Rohit Waghchaure
3355dc2a41
fix: incorrect gl entries for standalone debit note with update stock
...
(cherry picked from commit 6e198188ff )
# Conflicts:
# erpnext/controllers/buying_controller.py
2023-06-15 13:43:20 +00:00
mergify[bot]
77b0c5f722
fix: don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport #35714 ) ( #35715 )
...
fix: don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (#35714 )
fix: on asset scrap, don't add gl entry for acc. depr. if no acc. depr.
(cherry picked from commit bb39a2cac7 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-15 17:37:12 +05:30
Sagar Sharma
9d1fac19e5
Merge pull request #35702 from frappe/mergify/bp/version-14-hotfix/pr-35700
...
fix: update `Stock Reconciliation` diff qty while reposting (backport #35700 )
2023-06-15 11:44:14 +05:30
s-aga-r
bdb5cc8ad4
fix: update Stock Reconciliation diff qty while reposting
...
(cherry picked from commit 6a1b0a2fab )
2023-06-15 06:13:10 +00:00
mergify[bot]
4a8ce226f6
fix: Validation for delivery date in Sales Order ( #35597 )
...
fix: Validation for delivery date in Sales Order (#35597 )
* fix: Validation for delivery date in Sales Order
* chore: update utils
* chore: revert
* chore: Add default delivery date
(cherry picked from commit 984f89d274 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-14 09:01:38 +05:30
mergify[bot]
6f59fa9e5b
fix: Lower deduction certificate not getting applied ( #35667 )
...
* fix: Lower deduction certificate not getting applied (#35667 )
(cherry picked from commit 937c0feefe )
# Conflicts:
# erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
* chore: resolve conflicts
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-14 09:01:04 +05:30
mergify[bot]
f39ae9dbb1
fix: make showing taxes as table in print configurable (backport #35672 ) ( #35678 )
...
* fix: make showing taxes as table in print configurable (#35672 )
(cherry picked from commit 491a50a027 )
# Conflicts:
# erpnext/accounts/doctype/accounts_settings/accounts_settings.json
* chore: fix conflict
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-13 20:44:05 +05:30
mergify[bot]
4add1b4374
fix(accounts): validate payment entry references with latest data. ( #31166 )
...
fix(accounts): validate payment entry references with latest data. (#31166 )
* test: payment entry over allocation.
* fix: validate allocated_amount against latest outstanding amount.
* fix: payment entry get outstanding documents for advance payments
* fix: only fetch latest outstanding_amount.
* fix: throw if reference is allocated
* test: throw error if a reference has been partially allocated after inital creation.
* chore: test name
* fix: remove unused part of test
* chore: linter
* chore: more user friendly error messages
* fix: only validate outstanding amount if partly paid and don't filter by cost center
* chore: minor refactor for doc.cost_center
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 20de27d480 )
Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com >
2023-06-13 19:47:20 +05:30
mergify[bot]
dffa682b80
Stock aging report fix when called in dashboard chart (backport #35671 ) ( #35675 )
...
fix: get_range_age conditions fixed (#35671 )
see https://github.com/frappe/erpnext/issues/35669
(cherry picked from commit 9f669d4c2f )
Co-authored-by: Hossein Yousefian <86075967+ihosseinu@users.noreply.github.com >
2023-06-13 19:22:25 +05:30
rohitwaghchaure
74ffb1d59c
Merge pull request #35658 from frappe/mergify/bp/version-14-hotfix/pr-35629
...
fix: added process loss in job card (backport #35629 )
2023-06-13 11:52:52 +05:30
rohitwaghchaure
2060a003c8
fix: conflicts
2023-06-13 11:22:59 +05:30
ruthra kumar
9d18b40fb0
Merge pull request #35661 from frappe/mergify/bp/version-14-hotfix/pr-35659
...
fix: attribute error on payment reconciliation tool (backport #35659 )
2023-06-13 10:44:51 +05:30
ruthra kumar
25b3c7736b
fix: attribute error on payment reconciliation tool
...
(cherry picked from commit bada5796fa )
2023-06-13 04:47:20 +00:00
ruthra kumar
6a08d04706
Merge pull request #35660 from frappe/mergify/bp/version-14-hotfix/pr-35620
...
fix: allow higher debit-credit diff tolerance in Exchange Rate Revaluation (backport #35620 )
2023-06-13 10:16:47 +05:30
ruthra kumar
cf14858909
fix: allow user to set rounding loss allowance for accounts balance
...
(cherry picked from commit 96a0132501 )
2023-06-13 04:16:55 +00:00
Rohit Waghchaure
7af03800c9
fix: test case
...
(cherry picked from commit 0382eecff4 )
2023-06-12 17:59:56 +00:00
Rohit Waghchaure
6a21d617ce
fix: added process loss in job card
...
(cherry picked from commit e9a6191af9 )
# Conflicts:
# erpnext/manufacturing/doctype/job_card/job_card.json
2023-06-12 17:59:56 +00:00
Sagar Sharma
48c2c82dc4
Merge pull request #35649 from frappe/mergify/bp/version-14-hotfix/pr-35646
...
fix: Stock Reconciliation document update while reposting (backport #35646 )
2023-06-12 18:45:12 +05:30
s-aga-r
8b617fb75e
fix: Stock Reconciliation document update while reposting
...
(cherry picked from commit db159dd11f )
2023-06-12 13:13:17 +00:00
Anand Baburajan
79483cc90e
fix: don't set default payment amount in case of invoice return ( #35645 )
2023-06-12 18:34:13 +05:30
mergify[bot]
81ef2babe9
fix: Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ( #35642 )
...
fix: Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report (#35642 )
* fix: payment against credit note should be linked to parent invoice
* test: AR/AP report for payment against cr note scenario
* fix: cr_note shows up as outstanding invoice
Payment made against cr_note causes it be reported as outstanding invoice
(cherry picked from commit 42f4f80e0c )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-06-12 18:06:26 +05:30
mergify[bot]
043815e745
fix: Make difference entry button not working ( #35622 )
...
fix: Make difference entry button not working (#35622 )
(cherry picked from commit 2f24546b21 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-12 15:35:48 +05:30
Trusted Computer
2cf871c21e
fix: CSS not applied to product title ( #35630 )
2023-06-11 19:35:24 +05:30
Sagar Sharma
a59dffe42a
Merge pull request #35619 from frappe/mergify/bp/version-14-hotfix/pr-35617
...
fix: `TypeError` in Closing Stock Balance (backport #35617 )
2023-06-09 12:24:27 +05:30
s-aga-r
32e5bbbb46
fix: TypeError in Closing Stock Balance
...
(cherry picked from commit 446253ff39 )
2023-06-09 06:07:07 +00:00
Anand Baburajan
feb5d0089b
fix: calculate wdv depr schedule properly for existing assets [v14] ( #35613 )
...
* fix: calculate wdv depr schedule properly for existing assets
* fix: calculate wdv depr schedule properly for existing assets properly
2023-06-08 23:16:28 +05:30
mergify[bot]
059141df52
refactor: get default contact or address ( #35248 )
...
refactor: get default contact or address (#35248 )
* refactor: get_party_shipping_address
* refactor: get_default_contact
* chore: adding docstrings
* fix: keep original order
* fix: use get_all instead of get_list
---------
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
(cherry picked from commit b91bb17779 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-06-08 22:04:13 +05:30
mergify[bot]
29e079d5d6
refactor: use delete_contact_and_address ( #34497 )
...
refactor: use delete_contact_and_address (#34497 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 0dde4d4c69 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-06-08 19:59:22 +05:30
mergify[bot]
7737b9061f
fix: Project in item-wise sales register ( #35596 )
...
fix: Project in item-wise sales register (#35596 )
(cherry picked from commit f732cac678 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-07 22:36:31 +05:30
mergify[bot]
2077f6e89c
fix: Update de.csv ( #35278 )
...
fix: Update de.csv (#35278 )
added many fixes on the base of 'No' which is often wrongly translated to 'Kein'.
Also removed translation of Naming Seris like ACC-INV-.YYYY.- to ACC-INV-.YYYY.-
(cherry picked from commit c236979508 )
Co-authored-by: Wolfram Schmidt <wolfram.schmidt@phamos.eu >
2023-06-07 22:04:14 +05:30
mergify[bot]
dee82754ab
fix: based on status_update.py update opportunity status to converted… ( #35145 )
...
fix: based on status_update.py update opportunity status to converted… (#35145 )
fix: based on status_update.py update opportunity status to converted on sales submit
(cherry picked from commit a9a47a51e4 )
Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com >
2023-06-07 22:02:03 +05:30
mergify[bot]
e5055160fb
fix: enqueue_after_commit wherever it makes sense (backport #35588 ) ( #35590 )
...
fix: `enqueue_after_commit` wherever it makes sense (#35588 )
(cherry picked from commit 4507cb3cd7 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-06-07 15:27:45 +05:30
Ankush Menat
a8ac2a088d
chore: extend default role profiles
...
(cherry picked from commit 0166f69b31 )
2023-06-07 15:10:20 +05:30
Deepesh Garg
0e82932de1
Merge branch 'version-14' into version-14-hotfix
2023-06-07 10:45:44 +05:30
mergify[bot]
7798bab0d8
chore: Default role profiles ( #35584 )
...
chore: Default role profiles (#35584 )
(cherry picked from commit 76197cc437 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-07 10:30:28 +05:30
mergify[bot]
6140f13f3a
fix: Interest Accrual on Loan Topup ( #35555 )
...
fix: Interest Accrual on Loan Topup (#35555 )
* fix: Interest Accrual on Loan Topup
* chore: CI
* chore: Ignore test
(cherry picked from commit 2ffcca6f10 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-07 10:12:12 +05:30
Nabin Hait
c7c1a6e501
Merge pull request #35579 from frappe/mergify/bp/version-14-hotfix/pr-35572
...
feat: ability to create quotation against a prospect (backport #35572 )
2023-06-06 21:55:48 +05:30
Nabin Hait
c7391c8a0f
fix: get party details
...
(cherry picked from commit 5a0aacc0b6 )
2023-06-06 16:25:11 +00:00
Nabin Hait
d82d1597ac
feat: ability to create quotation against a prospect
...
(cherry picked from commit 47ce6de57d )
2023-06-06 16:25:11 +00:00
Sagar Vora
307fadc8e2
Merge pull request #35560 from frappe/mergify/bp/version-14-hotfix/pr-35550
...
fix(regional): allow regional override for updating gl_dict (backport #35550 )
2023-06-05 13:58:03 +05:30
Smit Vora
57b502b9de
fix(regional): allow regional override for updating gl_dict ( #35550 )
...
(cherry picked from commit b1ef19a0cd )
2023-06-05 08:27:44 +00:00
Sagar Sharma
5b92334e95
Merge pull request #35544 from frappe/mergify/bp/version-14-hotfix/pr-35510
...
fix: ignore `Non-Stock Item` while calculating `% Picked` in Sales Order (backport #35510 )
2023-06-03 11:52:19 +05:30
s-aga-r
c0d82710b7
fix: ignore Non-Stock Item while calculating % Picked in Sales Order
...
(cherry picked from commit 0305a925fe )
2023-06-03 05:48:53 +00:00
s-aga-r
200166bc24
fix: ignore Non-Stock Item mapping in Pick List
...
(cherry picked from commit 03d7742737 )
2023-06-03 05:48:52 +00:00
Sagar Sharma
4ed701b477
fix: add validation for existing Serial No Manufactured/Received again ( #35534 )
...
* feat: add new field `Allow existing Serial No` in `Stock Settings`
* fix: add validation for existing Serial No to be Manufactured/Received again
2023-06-03 11:15:55 +05:30
Suraj Shetty
9e71f3263d
Merge pull request #35531 from frappe/mergify/bp/version-14-hotfix/pr-35530
...
fix: Task gantt popup style and info (backport #35530 )
2023-06-02 11:10:46 +05:30
Suraj Shetty
20e224224b
fix: Task gantt popup style
...
(cherry picked from commit f7b2d103e7 )
2023-06-02 05:39:53 +00:00
rohitwaghchaure
90c79cb24f
Merge pull request #35481 from s-aga-r/FIX-ISS-23-24-01138
...
fix: update `Stock Reconciliation` document while reposting
2023-06-01 21:23:14 +05:30
ruthra kumar
114cb98b8e
Merge pull request #35362 from frappe/mergify/bp/version-14-hotfix/pr-35299
...
refactor: replace join with subquery in PCV (backport #35299 )
2023-06-01 15:43:37 +05:30