Deepesh Garg
e28f6b7d31
test: fix property name
...
(cherry picked from commit c10a22529c )
# Conflicts:
# erpnext/healthcare/doctype/patient_appointment/patient_appointment.py
2022-05-25 11:33:42 +00:00
Deepesh Garg
8f969fbd66
test: Update test cases for currency change validation
...
(cherry picked from commit 60915e874d )
# Conflicts:
# erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py
# erpnext/healthcare/doctype/patient_appointment/patient_appointment.py
# erpnext/healthcare/doctype/therapy_plan/therapy_plan.py
# erpnext/non_profit/doctype/membership/membership.py
2022-05-25 11:33:42 +00:00
Deepesh Garg
9d43a90eb0
Revert "fix: Add party account validation for journal entry"
...
This reverts commit f00620a3ca .
(cherry picked from commit 0a618817dc )
2022-05-25 11:33:39 +00:00
Deepesh Garg
09a42a122f
fix: Healthcare module accounting test cases
...
(cherry picked from commit bcaf475295 )
# Conflicts:
# erpnext/healthcare/doctype/lab_test/test_lab_test.py
2022-05-25 11:33:39 +00:00
Deepesh Garg
7f853b1f0f
fix: Add party account validation for journal entry
...
(cherry picked from commit f00620a3ca )
2022-05-25 11:33:38 +00:00
Deepesh Garg
228f10bf30
fix: Account currency validation for first transaction
...
(cherry picked from commit 80c85dd17c )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2022-05-25 11:33:38 +00:00
Deepesh Garg
3528d6fbdb
Merge pull request #31121 from frappe/mergify/bp/version-13-hotfix/pr-31077
...
fix: Loan repayment entries for payroll payable account (backport #31077 )
2022-05-25 12:37:17 +05:30
Deepesh Garg
2ae085d258
Merge pull request #31123 from deepeshgarg007/hsn_wise_tax_rate_none_type
...
fix: Handle missing HSN Codes
2022-05-25 12:34:26 +05:30
Deepesh Garg
187768892d
Merge pull request #31120 from frappe/mergify/bp/version-13-hotfix/pr-31080
...
fix(India): Async issue in company address trigger (backport #31080 )
2022-05-25 12:33:37 +05:30
mergify[bot]
98eb7da06a
fix(pos): paid amount calculation for multicurrency invoice ( #31122 )
2022-05-25 12:24:09 +05:30
Deepesh Garg
ce3a21eb03
fix: Handle missing HSN Codes
2022-05-25 11:51:07 +05:30
Deepesh Garg
ea6d754f73
fix: Loan repayment entries for payroll payable account
...
(cherry picked from commit 3128f9603e )
2022-05-25 05:54:08 +00:00
Deepesh Garg
559fc509e7
chore: Linting issues
...
(cherry picked from commit 8fd0b3b9f5 )
2022-05-25 05:53:45 +00:00
Deepesh Garg
2ea331852a
fix(India): Async issue in company address trigger
...
(cherry picked from commit c41f9f046f )
2022-05-25 05:53:45 +00:00
Rucha Mahabal
22aeacb088
Merge pull request #31104 from ruchamahabal/emp-adv-status-v13
...
feat(Employee Advance): add 'Returned' and 'Partly Claimed and Returned'
2022-05-25 11:09:52 +05:30
Rucha Mahabal
7ac0624f68
Merge branch 'version-13-hotfix' into emp-adv-status-v13
2022-05-25 10:46:25 +05:30
Rucha Mahabal
a071095886
Merge pull request #31110 from ruchamahabal/fix-npo-membership
2022-05-24 18:38:43 +05:30
Rucha Mahabal
168a9d417b
fix: don't capture payments with invoice_id as donations
...
- if donations and subscriptions are set up in the same dashboard, membership payments also trigger payment webhook
- in order to differentiate there is already a check for RP's auto generated description but if subscriptions are configured using subscription links, RP doesn't send descriptions
- use invoice_id to ignore such payments instead
2022-05-24 18:16:56 +05:30
Rucha Mahabal
34928d29f1
fix: remove bad default for Membership From Date
2022-05-24 18:14:06 +05:30
Ankush Menat
e9968cc6fc
chore: disable feed for material request
2022-05-24 14:33:57 +05:30
Rucha Mahabal
ab9744fe97
Merge branch 'version-13-hotfix' into emp-adv-status-v13
2022-05-24 11:49:24 +05:30
Rucha Mahabal
78e9e66d63
fix: replace document states with list settings
2022-05-24 11:29:58 +05:30
Rucha Mahabal
b265ca467c
test: test advance filters in expense claim and cancelled status
2022-05-24 11:19:14 +05:30
Rucha Mahabal
806752111e
test: employee advance status
2022-05-24 11:13:18 +05:30
Rucha Mahabal
d59c3d2142
fix: employee advance status update on return via additional salary
2022-05-24 11:11:44 +05:30
Rucha Mahabal
cac9e245b6
patch: Employee Advance return statuses
2022-05-24 11:11:10 +05:30
Rucha Mahabal
42e7a86a3b
feat(Employee Advance): add 'Returned' and 'Partly Claimed and Returned' status
2022-05-24 11:09:42 +05:30
mergify[bot]
c2a08f1285
chore: error logging for auto material requests (backport #31103 ) ( #31105 )
...
chore: error logging for auto material requests (#31103 )
(cherry picked from commit ecb39d81e0 )
Co-authored-by: Ankush Menat <me@ankush.dev >
2022-05-24 10:41:50 +05:30
mergify[bot]
3984f04a49
fix: Job Card excess transfer behaviour (backport #31054 ) ( #31096 )
...
* fix: Job Card excess transfer behaviour
- Block excess transfer of items if not allowed in settings
- Behaviour made consistent with js behaviour (button disappears if not pending and not allowed in settings)
- Test for same case
(cherry picked from commit e07ce6efe0 )
# Conflicts:
# erpnext/manufacturing/doctype/job_card/test_job_card.py
* chore: Run `_validate_over_transfer` only if excess transfer is blocked in settings
(cherry picked from commit 9f6e10663b )
* chore: conflicts
* chore: missing conflict resolution changes
Co-authored-by: marination <maricadsouza221197@gmail.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-05-23 15:20:47 +05:30
mergify[bot]
f6b2f36ca8
test: search test failing because of stale data (backport #31098 ) ( #31099 )
...
test: search test failing because of stale data (#31098 )
(cherry picked from commit a36174afdf )
Co-authored-by: Ankush Menat <me@ankush.dev >
2022-05-23 15:13:13 +05:30
Suraj Shetty
1c3ad13f6c
Merge pull request #31094 from frappe/mergify/bp/version-13-hotfix/pr-31092
2022-05-23 12:20:53 +05:30
mergify[bot]
ddee0893e6
fix translation German "Designation" (backport #31082 ) ( #31093 )
...
fix translation German "Designation" (#31082 )
changed "Bezeichnung" to "Position" as the is more precice in the field of employment which erpnext refers to here
(cherry picked from commit 348a674df9 )
Co-authored-by: Wolfram Schmidt <wolfram.schmidt@phamos.eu >
2022-05-23 12:02:30 +05:30
Suraj Shetty
0ab9fc0040
fix: Use directly <a> and style it as button instead of using button
...
Since few email servers (like outlook) strips out link in the button making them unclickable.
(cherry picked from commit a29b92febc )
2022-05-23 06:27:37 +00:00
mergify[bot]
ba76b6419e
fix: Leave Encashment calculations (backport #31062 ) ( #31091 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2022-05-23 10:32:41 +05:30
mergify[bot]
c17c260a65
fix: corrective job card creation (backport #31083 ) ( #31084 )
...
* test: simplify job card tests
(cherry picked from commit e625394488 )
* fix: creation of corrective job card fails
This used to fail because sub_operations is a child table that's not
initalized by default till v13, in develop branch we init tables with
empty list.
(cherry picked from commit 66cf9aa344 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-05-21 14:28:27 +05:30
mergify[bot]
f519dc613c
fix: always update item_name for stock entry (backport #31068 ) ( #31071 )
...
fix: always update item_name for stock entry (#31068 )
If item_name is already set and for some reason becomes outdated then
it's not updated in backend.
Fix: always set item_name and stock_uom when fetching item details
(cherry picked from commit 6d6616dbcd )
Co-authored-by: Ankush Menat <me@ankush.dev >
2022-05-19 16:02:20 +05:30
mergify[bot]
0efbabe7cf
fix: payments duplicate on pos closing entry (backport #30976 ) ( #31005 )
2022-05-19 14:27:19 +05:30
mergify[bot]
1461d66dda
fix(india): error while parsing e-invoice ( #31061 )
2022-05-18 12:44:24 +05:30
mergify[bot]
95491e1718
fix(india): eway bill cancel api is disabled ( #31060 )
2022-05-18 12:44:07 +05:30
mergify[bot]
e03fe97a6e
fix: unlink Attendance from Employee Checkins on cancellation (backport #31045 ) ( #31049 )
...
* fix: unlink Attendance from Employee Checkins on cancellation (#31045 )
(cherry picked from commit 28fe4f3d54 )
* fix: import missing function
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2022-05-17 12:35:27 +05:30
mergify[bot]
c3417e4103
fix: discount ledger entry in case of multicurrency invoice ( #31047 )
2022-05-17 12:22:08 +05:30
mergify[bot]
9c21eb5b94
feat: select multiple values for accounting dimension (backport #31015 ) ( #31041 )
...
fix: select multiple values for accounting dimenssion
(cherry picked from commit 69be22ba7c )
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com >
2022-05-17 11:56:31 +05:30
mergify[bot]
e24bb1dbf1
fix: TypeError in add_indicator_for_multicompany (backport #31042 ) ( #31048 )
...
fix: TypeError in add_indicator_for_multicompany (#31042 )
Minor fix in add_indicator_for_multicompany
In case of multi-company transactions add (+) buttons in connection dashboard pf customer aren't being loaded due to TypeError (TypeError: e.dashboard.stats_area.removeClass is not a function) created by "frm.dashboard.stats_area.removeClass('hidden');" during the stats section creation.
(cherry picked from commit 867f2c6282 )
Co-authored-by: Deepak <36790711+dpk404@users.noreply.github.com >
2022-05-17 11:54:50 +05:30
Ganga Manoj
408d952332
fix: pro rata calculation for monthly depreciation ( #30989 )
2022-05-17 11:21:10 +05:30
mergify[bot]
d5eb9fb3fd
fix: disable pricing rules for internal transfers (backport #31034 ) ( #31036 )
...
fix: disable pricing rules for internal transfers (#31034 )
* fix: disable pricing rules for internal transfers
* fix: only apply validation on internal transfers
* fix: internal_party_field undefined
(cherry picked from commit 3714e36b44 )
Co-authored-by: Ankush Menat <me@ankush.dev >
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2022-05-16 18:34:39 +05:30
Marica
d7bea97095
Merge pull request #31030 from frappe/mergify/bp/version-13-hotfix/pr-30992
...
fix(translations): Update ru translations (backport #30992 )
2022-05-16 17:35:17 +05:30
Marica
3abf26428c
fix: Merge Conflicts
2022-05-16 17:13:00 +05:30
mergify[bot]
477bbcc9e5
fix: IN time not captured in Attendance through Employee Checkin (backport #31029 ) ( #31031 )
...
* fix: IN time not captured in Attendance through Employee Checkin (#31029 )
(cherry picked from commit 1b7ce9649b )
# Conflicts:
# erpnext/hr/doctype/employee_checkin/test_employee_checkin.py
* fix: conflicts
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2022-05-16 17:05:26 +05:30
mergify[bot]
fc80a50640
fix: precision loss when transferring (backport #30834 ) ( #31032 )
...
* fix: stock transfer value when precision differs
(cherry picked from commit b1c90e9949 )
# Conflicts:
# erpnext/stock/doctype/stock_ledger_entry/test_stock_ledger_entry.py
* fix: Merge conflicts
* chore: Remove unused `flt` (sider)
Co-authored-by: Ankush Menat <ankush@frappe.io >
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2022-05-16 17:02:47 +05:30
Vladislav
f797005384
fix(translations): Update ru translations ( #30992 )
...
* fix incorrect translation
* Update ru.csv
* Update ru.csv
* Update erpnext/translations/ru.csv
Co-authored-by: Marica <maricadsouza221197@gmail.com >
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit af1eab5d54 )
# Conflicts:
# erpnext/translations/ru.csv
2022-05-16 09:49:23 +00:00