Mihir Kandoi
df82c7ac1c
Merge pull request #56893 from mihir-kandoi/pg-bom-groupby-phantom-pair
...
fix(manufacturing): keep bom_no/is_phantom_item pair coherent in get_bom_items_as_dict
2026-07-05 15:38:29 +05:30
Mihir Kandoi
4cb622b8e3
Merge pull request #56895 from mihir-kandoi/pg-budget-requested-amount-per-row
...
fix(controllers): compute budget requested amount per row
2026-07-05 15:37:56 +05:30
Mihir Kandoi
e52b1d6cff
fix(controllers): compute budget requested amount per row
...
get_requested_amount multiplied the pooled pending qty of all matching Material Request items by a single Max(rate), fabricating the total whenever rates differ and biasing it upward - making false Budget Exceeded stops more likely. Sum (stock_qty - ordered_qty) * rate per row instead, matching get_ordered_amount.
2026-07-05 15:09:49 +05:30
Mihir Kandoi
db5ab9fb35
fix(manufacturing): keep bom_no/is_phantom_item pair coherent in get_bom_items_as_dict
...
When a BOM lists the same item twice (one line phantom via sub-BOM P, one non-phantom via sub-BOM N), grouping by item_code and aggregating bom_no and is_phantom_item with independent Max() could pair one line's phantom flag with the other line's bom_no, exploding the wrong sub-BOM or silently dropping a direct requirement. Group by the pair instead so each line keeps a coherent (bom_no, is_phantom_item); the consumer accumulates duplicate keys and explodes phantom rows with their own qty. Same fix as 41da9eb7fc , which missed this single-level path.
2026-07-05 15:08:58 +05:30
Nabin Hait
17851ceaae
Merge pull request #56877 from frappe/chore/test-appointment-booking-settings
...
test: add coverage for Appointment Booking Settings
2026-07-05 13:16:15 +05:30
Nabin Hait
d2f0ec883e
Merge pull request #56880 from frappe/chore/test-email-campaign
...
test: add coverage for Email Campaign
2026-07-05 13:16:06 +05:30
Nabin Hait
86435bc961
Merge pull request #56891 from frappe/fix/company-coa-test-abbr-collision
...
test: fix flaky test_coa_based_on_country_template (abbreviation collision)
2026-07-05 12:57:43 +05:30
Nabin Hait
b418df595e
Merge branch 'develop' into chore/test-appointment-booking-settings
2026-07-05 12:50:53 +05:30
Nabin Hait
70e1acdb6d
Merge branch 'develop' into chore/test-email-campaign
2026-07-05 12:50:47 +05:30
Nabin Hait
2959bfcafa
Merge pull request #56888 from frappe/chore/test-lower-deduction-certificate
...
test: add coverage for Lower Deduction Certificate
2026-07-05 12:50:05 +05:30
Nabin Hait
94afc2a05b
Merge pull request #56889 from frappe/chore/test-italy-utils
...
test: add coverage for Italy e-invoice utility helpers
2026-07-05 12:49:54 +05:30
Nabin Hait
e82a9b9c3b
Merge pull request #56890 from frappe/chore/test-import-supplier-invoice
...
test: add coverage for Import Supplier Invoice
2026-07-05 12:49:31 +05:30
Nabin Hait
df4fc6b186
test: use a unique company abbreviation to fix COA-template flake
2026-07-05 12:44:31 +05:30
Nabin Hait
e86f6fc89c
Merge pull request #56849 from frappe/chore/test-stock-closing-entry
...
fix: Stock Closing Entry duplicate check misses contained date ranges
2026-07-05 12:18:35 +05:30
Nabin Hait
11023511ae
Merge pull request #56856 from frappe/chore/test-job-card-dark-paths
...
test: cover Job Card quantity, docstatus and capacity logic
2026-07-05 12:18:23 +05:30
Nabin Hait
58ee02780f
Merge pull request #56883 from nabinhait/sherlock/fix-dunning-outstanding-currency
...
fix: use transaction-currency outstanding on Dunning for foreign-currency invoices
2026-07-05 12:17:27 +05:30
Nabin Hait
8d289dfe52
Merge pull request #56881 from frappe/chore/test-campaign
...
fix: Campaign with a naming series breaks the UTM Campaign link
2026-07-05 12:16:50 +05:30
Nabin Hait
616ceb8126
test: add coverage for Import Supplier Invoice validation and country lookup
2026-07-05 12:16:09 +05:30
Nabin Hait
f2f1b2597d
test: add coverage for Italy e-invoice utility helpers
2026-07-05 12:13:48 +05:30
Nabin Hait
c293cb8871
test: add coverage for Lower Deduction Certificate date validation
2026-07-05 12:11:34 +05:30
rohitwaghchaure
29be72fae4
fix: warning message for new item standard cost ( #56885 )
2026-07-04 23:29:32 +05:30
Nabin Hait
a9bb6b31df
fix: use transaction-currency outstanding on Dunning for foreign-currency invoices
...
When a Sales Invoice is in a foreign currency (e.g. USD) but the receivable
account is in the company currency (e.g. INR), `outstanding_amount` on the
invoice is stored in the party account currency (INR). `postprocess_dunning`
was copying that value directly into the Dunning's Overdue Payment row, which
is expected to carry the transaction-currency (USD) amount.
The fix: when `party_account_currency != currency`, use
`payment_schedule[0].outstanding` (already maintained in transaction currency)
instead of `outstanding_amount`.
Closes #56006
2026-07-04 19:45:44 +05:30
Nabin Hait
2b1e922183
fix: don't hijack another Campaign's UTM mirror when display names collide
2026-07-04 19:42:13 +05:30
Nabin Hait
486a1c78b0
Merge pull request #56882 from frappe/fix/pos-invoice-reset-mop-attributeerror
...
fix: reset_mode_of_payments raises AttributeError on a POS Invoice
2026-07-04 19:37:40 +05:30
Nabin Hait
ca9dcbf2d7
fix: reuse the existing UTM Campaign mirror when campaign_name is edited
2026-07-04 18:45:58 +05:30
Nabin Hait
c969ee7bef
test: use separate documents for the invalid and valid slot cases
2026-07-04 18:44:04 +05:30
Nabin Hait
a1f6ae56ff
fix: removed unused import
...
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-07-04 18:39:52 +05:30
Nabin Hait
14c1b02025
Merge pull request #56879 from frappe/chore/test-contract-template
...
test: add coverage for Contract Template
2026-07-04 17:58:32 +05:30
Nabin Hait
3b335db64c
Merge pull request #56878 from frappe/chore/test-crm-settings
...
test: add coverage for CRM Settings
2026-07-04 17:58:18 +05:30
Nabin Hait
99ed620dad
fix: reset_mode_of_payments raises AttributeError on POS Invoice
2026-07-04 17:54:46 +05:30
Nabin Hait
e5b7c3f98c
test: cover Job Card quantity, docstatus and capacity-overlap logic
2026-07-04 17:51:52 +05:30
Nabin Hait
10c6cda6db
fix: detect contained/enclosing date ranges in Stock Closing Entry duplicate check
2026-07-04 17:47:22 +05:30
Nabin Hait
4b4afe12df
Merge pull request #56832 from frappe/chore/test-repost-payment-ledger
...
test: add coverage for Repost Payment Ledger
2026-07-04 17:45:10 +05:30
Nabin Hait
9fdcfd5f58
fix: link UTM Campaign to the Campaign's document name, not campaign_name
2026-07-04 17:40:16 +05:30
Nabin Hait
5eaafd3025
test: add coverage for Campaign naming and UTM mirroring
2026-07-04 17:33:35 +05:30
Nabin Hait
79c359ef5d
test: add coverage for Email Campaign date and recipient validation
2026-07-04 17:30:46 +05:30
Nabin Hait
34f3870f2a
test: add coverage for Contract Template validation and rendering
2026-07-04 17:28:28 +05:30
Nabin Hait
7f903b63dd
test: add coverage for CRM Settings sync and contact-us guards
2026-07-04 17:26:58 +05:30
Nabin Hait
1a2e3e03b3
test: add coverage for Appointment Booking Settings slot validation
2026-07-04 17:25:20 +05:30
Nabin Hait
4c26ec8cd9
test: make add_manually test distinguish manual mode from auto-loading
2026-07-04 16:48:52 +05:30
Nabin Hait
f68f53dec0
test: cover on-cutoff boundary in voucher loading
2026-07-04 16:48:52 +05:30
Nabin Hait
9901746e02
test: add coverage for Repost Payment Ledger
2026-07-04 16:48:52 +05:30
Nabin Hait
ae0cfbd3e1
test: assert the saved closing entry exists rather than a truthy name
2026-07-04 16:48:51 +05:30
Nabin Hait
e37ceb5f69
test: cover Stock Closing Entry duplicate date-range validation
2026-07-04 16:48:51 +05:30
Nabin Hait
807c52e32b
Merge pull request #56855 from frappe/chore/test-stock-reservation-entry-dark-paths
...
test: cover Stock Reservation Entry validations and helper
2026-07-04 16:43:55 +05:30
Nabin Hait
38b91a2800
Merge pull request #56846 from frappe/chore/test-bisect-accounting-statements
...
test: add coverage for Bisect Accounting Statements
2026-07-04 16:43:28 +05:30
Nabin Hait
0f3b77a344
Merge pull request #56841 from frappe/chore/test-exchange-rate-revaluation
...
test: cover Exchange Rate Revaluation validation and gain/loss paths
2026-07-04 16:42:22 +05:30
ruthra kumar
66e70e312d
Merge pull request #56852 from ruthra-kumar/race_condition_in_process_pcv
...
fix: race condition in process pcv
2026-07-04 16:22:16 +05:30
Mihir Kandoi
ac57e389a4
Merge pull request #56871 from mihir-kandoi/cast-error-postgres
...
fix: type cast error on postgres
2026-07-04 14:24:20 +05:30
Mihir Kandoi
093bbb07a7
fix: type cast error on postgres
2026-07-04 14:11:29 +05:30