Dany Robert
d8479a41e5
fix: tax rate being overridden in case of 0.00
...
Tax rate could be different for different expenses.
Therefore, rate is kept as 0.00 and tax amount entered manually.
But fetching used to override the rate(upon saving) and mess up the amount.
(cherry picked from commit 5ce6a4c107 )
2021-10-05 08:45:23 +00:00
Deepesh Garg
d2f5d31f98
Merge pull request #27559 from frappe-pr-bot/backport/version-13-hotfix/27524
...
fix: Tax breakup based on items, missing GST fields
2021-10-05 14:13:50 +05:30
Deepesh Garg
44ee44dec5
Merge pull request #27786 from frappe/mergify/bp/version-13-hotfix/pr-27785
...
fix: Delete linked Transaction Deletion Record docs on deleting company (backport #27785 )
2021-10-05 14:09:16 +05:30
mergify[bot]
bebd77c27d
fix: add (uom, brand) Item details in an Item Price ( #27561 ) ( #27795 )
...
* fix: add (uom, brand) and update (uom) Item details in an Item Price
* fix: order of query interpolation args
Co-authored-by: Marica <maricadsouza221197@gmail.com >
* fix: named interpolation, remove item price
* fix: sql error
Co-authored-by: Marica <maricadsouza221197@gmail.com >
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
(cherry picked from commit 7da777880b )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-10-05 13:28:43 +05:30
Afshan
0c55a98190
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-27785
2021-10-05 13:26:47 +05:30
mergify[bot]
32d72fdecb
fix: Only calculate first_respone_time if SLA is set ( #27789 ) ( #27793 )
...
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
(cherry picked from commit ad03eb25df )
Co-authored-by: Ganga Manoj <ganga.manoj98@gmail.com >
2021-10-05 12:49:06 +05:30
mergify[bot]
046ec928e0
fix: Display appropriate message if different Payment Terms are used in PE and its Payment References ( #27763 )
...
(cherry picked from commit 9f14695743 )
Co-authored-by: GangaManoj <ganga.manoj98@gmail.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-05 12:21:21 +05:30
Afshan
877820b902
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-27785
2021-10-05 11:50:25 +05:30
mergify[bot]
ab0e381cfc
fix(asset): expected value after useful life validation ( #27539 ) ( #27790 )
...
(cherry picked from commit 065a2ce983 )
Co-authored-by: Saqib <nextchamp.saqib@gmail.com >
2021-10-05 11:47:56 +05:30
GangaManoj
4ecb798585
fix: Delete linked Transaction Deletion Record docs on deleting company
...
(cherry picked from commit 38c7e42f0c )
2021-10-05 05:19:37 +00:00
mergify[bot]
91d269fe1a
fix: set item uom as stock_uom if it isn't set ( #27623 ) ( #27780 )
...
* fix: set item uom as stock_uom if it isn't set
(cherry picked from commit 5c372202d5 )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-10-04 22:41:12 +05:30
mergify[bot]
4535a9415f
ci(Mergify): configuration update ( #27777 ) ( #27778 )
...
Signed-off-by: Ankush Menat <me@ankush.dev >
(cherry picked from commit 4159361d52 )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-04 18:10:52 +05:30
Sagar Vora
e17713c9d6
fix: multiple fixes to timesheets ( #27775 )
2021-10-04 17:08:50 +05:30
mergify[bot]
21a5498d5d
fix: Merge "Accounting Ledger" and "Accounts Receivable" in "View" button ( #27769 ) ( #27771 )
...
* fix: Added a new button "View" and merged "Accounting Ledger" and "Accounts Receivable" into it
* fix: sider issues
* chore: dead code
(cherry picked from commit b483f173a6 )
Co-authored-by: Komal-Saraf0609 <81952590+Komal-Saraf0609@users.noreply.github.com >
2021-10-04 16:06:55 +05:30
Marica
e9ed379b57
Merge pull request #27743 from frappe/mergify/bp/version-13-hotfix/pr-27611
...
fix: Hero Slider Control & Alignment fixes (backport #27611 )
2021-10-03 14:29:18 +05:30
Marica
4d0d642db7
Merge pull request #27720 from marination/e-comm-web-item-name-thumbnail-fix
...
fix: Website Items with same Item name unhandled, thumbnails missing
2021-10-03 14:26:20 +05:30
Deepesh Garg
f02438eb54
Merge pull request #27712 from deepeshgarg007/internal_transfer_check_fix
...
fix(India): Internal transfer check fix
2021-10-03 13:38:51 +05:30
Marica
62fa1f0305
Merge branch 'version-13-hotfix' into e-comm-web-item-name-thumbnail-fix
2021-10-03 13:30:50 +05:30
marination
77d4849ce8
fix: Pre-commit formatting
2021-10-03 13:30:02 +05:30
Deepesh Garg
fe4df3a14a
Merge pull request #27748 from deepeshgarg007/yet_chart_of_accounts_importer_fixes
...
fix: Chart Of Accounts import button not visible
2021-10-02 21:39:07 +05:30
Deepesh Garg
ff570f48a0
fix: Linting issues
2021-10-02 20:46:20 +05:30
Deepesh Garg
e4b89d2fcd
fix: Remove unwanted comments
2021-10-02 20:37:15 +05:30
Deepesh Garg
3529622a0d
fix: Chart Of Accounts import button not visible
2021-10-02 20:35:11 +05:30
Shariq Ansari
8f98238114
chore: linter fix
...
(cherry picked from commit 18918e1b4f )
2021-10-02 11:38:31 +00:00
Shariq Ansari
86e3adf344
fix: Fixed alignment of Title, Subtitle, Action Button
...
(cherry picked from commit 0de735f20b )
2021-10-02 11:38:31 +00:00
Shariq Ansari
d6152df3b4
fix: Creating unique hash for slider id instead of slider name
...
(cherry picked from commit 3e8e6ac4e2 )
2021-10-02 11:38:30 +00:00
Anurag Mishra
4837238f3d
feat(HR): Some Enhancements and Onboarding ( #25741 )
...
* feat: Hr settings restructure
* feat: remove validation and make As warning
* feat: made leave policy Assignment feild read only
* feat: send leave Notification via 'Notification'
* patch: for field name change
* feat: removed defaults value for removed field
* feat: removed leave Notification fields
* feat: better label and description
* feat: Hr Module onboarding and Onboarding slides
* fix: sider, test, translations
* chore: remove unnecessary code formatting changes
* refactor: HR Onboarding
* refactor: HR Settings
* revert: Notification changes
* chore: remove unnecessary descriptions from leave type
* fix: linter issues
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-02 12:34:21 +05:30
mergify[bot]
e4f12f0458
fix: update variant qty in BOM, Create Work Order dialog ( #27686 ) ( #27732 )
...
(cherry picked from commit ece446ffe5 )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-10-01 23:21:08 +05:30
mergify[bot]
23431cf261
fix: option to limit reposting in certain timeslot ( #27725 ) ( #27726 )
...
(cherry picked from commit a04f9c904e )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-01 13:56:00 +05:30
Anurag Mishra
57e66f958c
feat: Tracking Multi-round interview ( #25482 )
...
* feat: Tracking Multi-round interview
* fix: releted to scheduler event and formating
* fix: job applicant UI/UX and conflicts
* test: Interview Round
* fix(test): Employee referral, Employee Onboarding, Job Offer
* fix: sider
* feat: set default value in Hr settings
* feat: added validation for designation
* test: Interview
* test: Added validatiolns for skill
* test: Interview feedback
* fix: sider
* fix: remove unnecessary validations and form label cleanups
* chore: clean-up Interview Round and Interview Type doctype
* fix: remove redundant Rating Value, only keep Rating
* fix: update interview details on feedback submission
- make interview feedback submission dialog minimizable
* fix: show submit feedback button only if feedback doesn't exist
* refactor: Interview and Feedback statuses and workflow
* fix(HR Settings): clean up interview settings
* refactor: Interview
* refactor: Interview Feedback, remove unnecessary validations
* chore: update notification messages
* chore: remove unnecessary formatting changes in attendance list and leave application
* refactor: Job Applicant to Interview mapping
* chore: sorted imports
* chore: sorted imports
* fix: sider issues
* fix: linter issues
* fix: sider issues
* fix: tests
* fix: sorted imports
* fix: tests, sider
* fix: therapy plan test
* fix: sider issues
* feat: Include From Time and To Time fields in Interview for cleaner data
* feat: Interview Calendar
* fix: allow renaming masters
* fix: add more fields to list view and standard filter
* fix: validate overlapping interviews
* fix: update tests
* fix: linter issues
* refactor: replace reminder messages with Email Templates
* fix: sider issues
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-01 00:10:47 +05:30
mergify[bot]
05374cb8b2
fix(Org Chart): use attribute selectors instead of ID selector for node IDs with special characters ( #27717 ) ( #27718 )
...
* fix(Org Chart): use attribute selectors instead of ID selector for node IDs with special chars
* fix: UI tests
(cherry picked from commit 9e08229b7b )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-09-30 18:45:22 +05:30
marination
36b519c962
fix: Website Items with same Item name unhandled, thumbnails missing
...
- Use naming series for Website Item. There could be two items with same name and different item code
- Fix: Website Item Page view breaks if cart is disabled
- Fix: thumbnails not created for Website Items after patch
- Fix: ‘Request for Quote’ button & cart summary not visible if checkout is disabled
2021-09-30 18:34:26 +05:30
mergify[bot]
15c9c08261
Merge pull request #27715 from frappe/mergify/bp/version-13-hotfix/pr-27668
...
fix: Batch scans get overwritten on the same row (backport #27668 )
2021-09-30 16:34:11 +05:30
Marica
5d1de91b68
Merge pull request #27713 from frappe-pr-bot/backport/version-13-hotfix/27554
...
fix: Maintenance Schedule child table status for legacy data
2021-09-30 15:57:27 +05:30
Marica
cf6e10ac7b
Merge branch 'version-13-hotfix' into backport/version-13-hotfix/27554
2021-09-30 15:55:04 +05:30
Ankush Menat
6d99bb5ce6
fix: remove stale doctypes and add msg for ecommerce refactor ( #27700 )
2021-09-30 15:49:26 +05:30
marination
6b38778dcb
fix: reload doc in patch
2021-09-30 14:55:57 +05:30
marination
7c47f36a4c
fix: Add patch to patches.txt
2021-09-30 14:18:35 +05:30
Marica
6ce2111b6d
fix: Maintenance Schedule child table status for legacy data ( #27554 )
...
* fix: Maintenance Schedule child table status for legacy data
* fix: Include legacy draft schedules in patch
* fix: Pre-commit formatting
(cherry picked from commit cc143bca0d )
2021-09-30 08:39:55 +00:00
Deepesh Garg
f0af24fc6d
fix(India): Internal transfer check fix
2021-09-30 13:28:53 +05:30
Mohammed Yusuf Shaikh
b478e72cef
fix: wrong company selected when marking attendance for all employees ( #27685 )
...
* fix: wrong company selected when marking attendance for all employees
* fix: enable caching for repeated queries of the same employee
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
2021-09-30 12:02:39 +05:30
mergify[bot]
471a8ddce0
fix: distribution of additional costs in mfg stock entry ( #27629 ) ( #27706 )
...
* refactor: remove unnecessary list comprehensions
* fix: correct cost distribution logic
While apportioning costs same condition should be present on both sides
so total value is representative of all items to be apportioned.
Here while calculating incoming_items_cost only FG items are considered,
but while apportioning all items with to_warehouse are considered.
Solution: only apportion additional cost on FG items
* test: test cost distribution
* fix: patch for additional cost
fix(patch): consider PCV while patching
- consider Period closing voucher while patching
- recomute rates for SLE of affected stock entries
consider only FG/scrap item SLEs for recomputation of rates
* fix: remove client side logic for addn cost
All of this is done in python code hence removed client side code.
(cherry picked from commit 4685ed5a8c )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-09-30 11:20:09 +05:30
Deepesh Garg
7fc7405be7
fix: Deferred revenue entries post account freezing ( #27551 )
...
* fix: Deferred revenue entries post account freezing
* fix: Test Case
* fix: Test case
2021-09-30 08:35:30 +05:30
rohitwaghchaure
26c16412bb
Merge pull request #27702 from frappe/mergify/bp/version-13-hotfix/pr-27701
...
fix: added project name in the purchase order analysis (backport #27701 )
2021-09-29 23:43:54 +05:30
Rohit Waghchaure
c8396f4970
fix: added project name in the purchase order analysis
...
(cherry picked from commit c1f9997a67 )
2021-09-29 18:13:25 +00:00
Deepesh Garg
aeffaf312a
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into deferred_entry_freeze_v13
2021-09-29 22:27:02 +05:30
Deepesh Garg
23863c7663
fix: Test case
2021-09-29 22:26:33 +05:30
Frappe PR Bot
887e3765bf
feat: TDS deduction using journal entry and other fixes ( #27451 ) ( #27672 )
...
* fix: TDS deduction using journal entry
* fix: Multi category application against single supplier
* refactor: TDS payable monthly report
* fix: Server side handling for default tax withholding category
* fix: Supplier filter for Journal Entry
* refactor: TDS computation summary report
(cherry picked from commit cc5dd5c67d )
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2021-09-29 20:26:43 +05:30
Frappe PR Bot
633847c514
fix: Ignore user permission for Represents Company field in Sales and Purchase docs ( #27684 ) ( #27695 )
...
* fix: Ignore user permission for Represents Company field in Sales and Purchase docs
* fix: Ignore user permission for fiscal year company
(cherry picked from commit b39f8a6215 )
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2021-09-29 20:26:16 +05:30
Deepesh Garg
72986abab9
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into deferred_entry_freeze_v13
2021-09-29 16:13:28 +05:30