Nabin Hait
cfed16ab6c
refactor(gl): give SI and PI their own precision-loss GL entry method
...
Remove the doctype-branching make_precision_loss_gl_entry from
exchange_gain_loss.py (and its accounts_controller wrapper); add a
dedicated method to each of SalesInvoiceGLComposer and
PurchaseInvoiceGLComposer. The SI variant now passes 'Sales Invoice'
as the round-off voucher type (output-equivalent) and the throwaway
return value no longer shadows the gettext _ helper.
2026-06-03 12:45:58 +05:30
Nabin Hait
d8760b76a8
refactor(sales_invoice): drop loyalty delegation shims, call LoyaltyService directly
...
The make_/delete_/apply_loyalty_points methods on SalesInvoice only existed
as an inheritance surface for POSInvoice (self.X()). Route all callers
through LoyaltyService(doc).X() directly, consistent with how related-doc
cases already worked, and remove the three forwarding methods.
2026-06-03 12:40:46 +05:30
Nabin Hait
04443ae29e
Merge upstream/develop into erpnext-refactoring
...
Resolve 4 conflicts from Phase 7 service/mapper extraction vs upstream:
- asset.py: take extraction; repoint dangling make_asset_movement JS to mapper
- job_card: port upstream field_no_map(naming_series) into mapper.make_subcontracting_po
- sales_order: port upstream rows-index fix into mapper.make_delivery_note
- sales_invoice (Phase 7): take service delegations; port upstream SQL->QB/ORM
changes for get_warehouse, get_all_mode_of_payments, get_discounting_status,
clear_unallocated_mode_of_payments, and set_pos_fields(POS DN skip) into services
2026-06-03 11:05:01 +05:30
Khushi Rawat
b1882dc83a
Merge pull request #55562 from khushi8112/budget-variance-cost-center-hierarchy
...
fix: aggregate child cost center data in Budget Variance Report
2026-06-03 03:17:57 +05:30
khushi8112
41884cfd2a
refactor: replace db.sql with frappe.qb
2026-06-03 02:48:56 +05:30
Khushi Rawat
48700a8aa3
Merge pull request #54840 from Hemil-Sangani/fix/budget-variance-report-filter
...
fix: add company filter to Budget Against dimension options
2026-06-03 02:30:52 +05:30
khushi8112
c34eeee096
fix: move Company filter at the start
2026-06-03 02:14:14 +05:30
Raffael Meyer
016b64df6d
fix(item): format integer numeric variant attributes without decimals ( #55561 )
2026-06-02 22:42:32 +02:00
khushi8112
cd7fa56ec4
fix: aggregate child cost center data in Budget Variance Report
2026-06-03 02:02:03 +05:30
Raffael Meyer
e94bd51764
perf(transaction): exit early before backend query ( #55556 )
2026-06-02 20:24:10 +02:00
rohitwaghchaure
e1ea14b135
Merge pull request #54785 from aerele/fix/support-#67579
...
fix(stock): add validation for work order serial nos and batch nos
2026-06-02 18:06:42 +05:30
ruthra kumar
7afe5d4ee3
Merge pull request #54974 from Soham-ambibuzz/philipinnes_localization_coa_v2
...
feat: added cost of goods sold
2026-06-02 17:23:48 +05:30
Khushi Rawat
d154796c82
Merge pull request #55484 from khushi8112/accounting-dashboard-number-cards-fiscal-year
...
fix: use fiscal year instead of calendar year in accounting dashboard number cards
2026-06-02 16:54:32 +05:30
ruthra kumar
d6f9e4ac3f
Merge pull request #54979 from rtdany10/ppr-adv-error
...
fix(ppr): make default_advance_account optional
2026-06-02 15:36:04 +05:30
Khushi Rawat
10c18ca801
Merge pull request #55539 from khushi8112/warn-before-cancel-reconciled-payment-entry
...
feat(payment-entry): warn user before cancelling reconciled payment entry
2026-06-02 15:29:15 +05:30
Mihir Kandoi
0a49403838
fix: unable to submit subcontracted job card ( #55537 )
2026-06-02 09:18:42 +00:00
khushi8112
f0ba54d957
feat(payment-entry): warn user before cancelling reconciled payment entry
2026-06-02 14:47:39 +05:30
Mihir Kandoi
85be72a403
fix: minor improvements to web templates, banking page and CI workflow ( #55525 )
...
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-02 08:26:23 +05:30
Mihir Kandoi
78f9434d14
refactor: resolve regression-safe CodeQL code-quality findings ( #55531 )
...
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-02 08:25:32 +05:30
Rushabh Mehta
4611dd1c36
Merge pull request #55532 from rmehta/feat/build-and-upload-assets
...
feat: build and upload assets to GitHub Releases
2026-06-02 07:37:30 +05:30
Rushabh Mehta
6ac050e624
feat: build and upload assets to GitHub Releases
2026-06-02 06:45:10 +05:30
Diptanil Saha
71fcda5ab7
fix(pos): escape html output in pos page templates ( #55527 )
...
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-06-02 00:43:08 +05:30
Diptanil Saha
86f6a8154d
Revert "ci(crowdin): mapped zh-TW with zh_TW" ( #55524 )
2026-06-01 16:50:12 +00:00
Diptanil Saha
97ec7f8837
ci(crowdin): mapped zh-TW with zh_TW ( #55520 )
2026-06-01 16:21:20 +00:00
rohitwaghchaure
ba477412ea
Merge pull request #55415 from aerele/fix/support-#68706
...
fix(stock): allow to create quality inspection after purchase/delivery
2026-06-01 21:43:24 +05:30
MochaMind
7b7732531f
fix: sync translations from crowdin ( #55464 )
2026-06-01 21:38:59 +05:30
Diptanil Saha
56f89cc392
chore(serial_and_batch_bundle): remove update_serial_or_batch method ( #55481 )
2026-06-01 21:23:32 +05:30
Gajendra Nishad
57dbac712f
fix(je): preserve account on duplicate row when party row exists ( #55180 )
2026-06-01 18:41:19 +05:30
Nabin Hait
530e587bf2
refactor: use mapper paths directly, drop re-export shims
...
Repoint all JS method strings and Python imports for mapper functions
across 18 doctypes from the doctype module to its mapper module, and
remove the now-unused re-export shims from each doctype file (keeping
only names used internally).
2026-06-01 18:17:56 +05:30
Diptanil Saha
24b28b4d29
fix(pos): escape item data on pos item selector ( #55503 )
2026-06-01 16:57:35 +05:30
Nikhil Kothari
65b87ec045
fix(banking): miscellaneous bug fixes ( #55492 )
...
* fix(banking): correct usage of hooks in rule action
* fix(banking): apply ESLint rules for hooks
* fix(banking): add lazy imports and code-splitting
2026-06-01 10:36:48 +00:00
rohitwaghchaure
fbe6754b55
Merge pull request #55480 from mihir-kandoi/nonetype-manufacturing-error
...
fix: NoneType reference error in Stock Entry
2026-06-01 15:20:00 +05:30
ruthra kumar
ed43880a7d
Merge pull request #55495 from ruthra-kumar/opening_bal_bug_in_process_pcv
...
fix: opening bal double counting in Process Period Closing Voucher
2026-06-01 15:01:36 +05:30
ruthra kumar
7f2af123ee
test: prevent double counting of opening balances
2026-06-01 14:29:05 +05:30
Mihir Kandoi
8314c22aa6
fix: NoneType reference error in Stock Entry
2026-06-01 13:48:44 +05:30
khushi8112
c68918bc18
fix: set a fallback value if no fiscal year set
2026-06-01 13:13:29 +05:30
ruthra kumar
cfeffbb354
refactor: color coded status in list view
2026-06-01 12:51:04 +05:30
khushi8112
e8fff2fdad
fix: use fiscal year instead of calendar year in accounting dashboard number cards
2026-06-01 12:47:31 +05:30
Ankush Menat
dd1d2925d5
fix: check perm for account ( #55479 )
2026-06-01 07:04:38 +00:00
Mihir Kandoi
3deab36d2e
fix: remove old subcontracting flow references in BOM ( #55477 )
2026-06-01 06:56:58 +00:00
ruthra kumar
1960c81619
refactor: tabbed view for process period closing voucher
2026-06-01 12:17:44 +05:30
ruthra kumar
a2b8334046
refactor: only consider non-opening balance for Balance sheet accounts
2026-06-01 12:13:49 +05:30
Mihir Kandoi
dbcfac839c
chore: rename type field to secondary_item_type ( #55469 )
2026-06-01 05:54:59 +00:00
Mihir Kandoi
1c94c42b28
fix: pick correct name when creating user from RFQ ( #55468 )
2026-06-01 05:36:46 +00:00
Sudharsanan11
e003fe4de0
fix(stock): add warning message to notify the user to configure the inspection
2026-06-01 10:37:29 +05:30
Sudharsanan11
c6a88ab1d2
fix(stock): allow to create quality inspection after purchase/delivery
2026-06-01 10:37:25 +05:30
Diptanil Saha
45d9af9430
fix(pos): preserve contacts and enforce permissions in set_customer_info ( #55463 )
2026-06-01 04:30:01 +05:30
Khushi Rawat
32594c97c6
Merge pull request #55461 from khushi8112/supplier-master-form-cleanup
...
fix: supplier master form cleanup
2026-06-01 02:58:57 +05:30
khushi8112
515983e016
fix: supplier status in list view
2026-06-01 02:32:36 +05:30
khushi8112
820c0caf88
fix: supplier master form cleanup
2026-06-01 02:06:42 +05:30
