mergify[bot]
cf3ec935a7
fix: precision causing outstanding issue on partly paid invoices ( #36030 )
...
fix: precision causing outstanding issue on partly paid invoices (#36030 )
* fix: precision causing outstanding issue on partly paid invoices
* chore: linters
(cherry picked from commit 5c820ecc20 )
Co-authored-by: Dany Robert <danyrt@wahni.com >
2023-07-10 16:49:41 +05:30
mergify[bot]
2732276498
chore: add asset depr posting error in error log (backport #36052 ) ( #36056 )
...
chore: add asset depr posting error in error log (#36052 )
(cherry picked from commit 0f9a6ee70a )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-07-10 14:12:43 +05:30
Deepesh Garg
4b20f2a083
Merge pull request #36034 from frappe/revert-35912-mergify/bp/version-13-hotfix/pr-35908
...
Revert "perf: improve item wise register reports (backport #35908 )"
2023-07-09 11:44:45 +05:30
Deepesh Garg
b992366246
Revert "perf: improve item wise register reports (backport #35908 ) ( #35912 )"
...
This reverts commit 41344593c9 .
2023-07-09 11:42:23 +05:30
ruthra kumar
93acde7748
Merge pull request #36028 from ruthra-kumar/fix_ambiguous_gst_hsn_code
...
fix: gst_hsn_code is ambiguous on gst reports
2023-07-08 17:51:17 +05:30
ruthra kumar
3a00052b49
fix: gst_hsn_code is ambiguous on gst reports
2023-07-08 06:49:39 +05:30
mergify[bot]
b04c190e33
fix(Payment Entry): compare rounded amount ( #36011 )
...
fix(Payment Entry): compare rounded amount (#36011 )
(cherry picked from commit 4badac8e9e )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-07-05 21:38:11 +05:30
Suraj Shetty
9b9d839835
Merge pull request #35986 from frappe/fix-report-sorting
2023-07-04 11:48:28 +05:30
Suraj Shetty
0ef0ff470f
fix: Further sort purchase_order_analysis to get consistent response
2023-07-04 11:09:38 +05:30
mergify[bot]
10c9640cbd
fix: Update no copy for received_qty field ( #35965 )
...
* fix: Update no copy for received_qty field (#35965 )
(cherry picked from commit 5448859254 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
# erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
* chore: resolve conflicts
* chore: resolve conflicts
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-07-03 16:38:26 +05:30
Raffael Meyer
da1218f324
chore: bump pandas ( #35939 )
2023-07-03 14:04:22 +05:30
rohitwaghchaure
407e5b5fa3
Merge pull request #35970 from frappe/mergify/bp/version-13-hotfix/pr-35955
...
fix: incorrect reposting causing stock adjustment entry (backport #35955 )
2023-07-03 11:08:20 +05:30
rohitwaghchaure
b9833db7bd
fix: conflicts
2023-07-03 09:53:16 +05:30
Rohit Waghchaure
d4e680c109
fix: reposting has not changed valuation rate
...
(cherry picked from commit c0c693d8b0 )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
2023-07-03 04:21:32 +00:00
mergify[bot]
b63fbe4286
fix: Expense Account filter in Sales Invoice ( #35944 )
...
fix: Expense Account filter in Sales Invoice (#35944 )
(cherry picked from commit d54f52474a )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-07-01 18:14:17 +05:30
Raffael Meyer
0602ddcfc8
feat(DATEV): against account for opening entries ( #35941 )
...
* fix: add missing german translations
* feat(DATEV): against account for opening entries
Allow to specify a separate temporary against account
for opening entries
* feat(DATEV Settings): validate account no. length
* style: format with black
* style: format with black
* test: new settings field, rename filter
2023-06-30 20:02:12 +05:30
mergify[bot]
18c3a668d9
chore: update translations ( #35905 )
...
chore: update translations
chore: update translations
(cherry picked from commit 1d1103f39c )
Co-authored-by: RJPvT <48353029+RJPvT@users.noreply.github.com >
2023-06-29 13:29:56 +05:30
mergify[bot]
0bcd0476a2
fix: asset movement (backport #35918 ) ( #35924 )
...
* fix: asset movement (#35918 )
fix: asset movement fixes
(cherry picked from commit e16c14863b )
# Conflicts:
# erpnext/assets/doctype/asset_movement/asset_movement.py
* chore: fix conflict
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-28 21:00:02 +05:30
mergify[bot]
41344593c9
perf: improve item wise register reports (backport #35908 ) ( #35912 )
...
perf: improve item wise register reports (#35908 )
(cherry picked from commit 33ee01174b )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-28 10:25:33 +05:30
mergify[bot]
bcfd7708f2
fix: filter parent warehouses not showing (backport #35897 ) ( #35900 )
...
* fix: filter parent warehouses not showing (#35897 )
(cherry picked from commit af418d2342 )
* chore: add company filter for parent warehouse
---------
Co-authored-by: HLD <hanglaoda@hotmail.com >
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-06-27 14:27:33 +05:30
mergify[bot]
4dd088cba4
fix: TDS amount calculation post LDC breach ( #35886 )
...
* fix: TDS amount calculation post LDC breach
(cherry picked from commit 1f9ef6c48f )
# Conflicts:
# erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
* chore: resolve conflicts
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-27 13:12:06 +05:30
mergify[bot]
12b62571b8
fix(ux): PO Get Items From Open Material Requests (backport #35894 ) ( #35896 )
...
fix(ux): PO Get Items From Open Material Requests
(cherry picked from commit 3a00bf83d6 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-06-27 12:30:08 +05:30
Ashish Shah
3785fe6927
fix: frappe.exceptions.DoesNotExistError: DocType KSA VAT Setting ( #35797 )
...
fix: frappe.exceptions.DoesNotExistError: DocType KSA VAT Setting not found
When migrating from v12->v13 migration fails
While migrating the doctype is not reloaded before adding permission. #35795
2023-06-24 16:40:12 +05:30
mergify[bot]
de529f0adf
fix: use correct fieldname for purchase receipt column in item_wise_purchase_register report (backport #35828 ) ( #35848 )
...
fix: use correct fieldname for purchase receipt column in item_wise_purcchase_register report
(cherry picked from commit dcfc86e3af )
Co-authored-by: phot0n <ritwikpuri5678@gmail.com >
2023-06-23 11:37:38 +05:30
mergify[bot]
2e2c319f20
fix: show non-depreciable assets in fixed asset register (backport #35858 ) ( #35861 )
...
fix: show non-depreciable assets in fixed asset register (#35858 )
fix: show non-depr assets in fixed asset register
(cherry picked from commit 42d09448ee )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-23 08:25:11 +05:30
mergify[bot]
8939e95c62
chore: asset scrap and restore fixes [v14] (backport #35851 ) ( #35854 )
...
* chore: asset scrap and restore fixes [v14] (#35851 )
chore: better err msg on cancelling JE for asset scrap and allow restoring non-depr assets
(cherry picked from commit 69780da099 )
# Conflicts:
# erpnext/assets/doctype/asset/depreciation.py
* chore: fix conflict
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-22 23:01:59 +05:30
Rucha Mahabal
6c4dff38da
fix: employee link fields in payroll reports ( #619 ) ( #35845 )
2023-06-22 18:10:54 +05:30
saeedkola
000ebe4479
Fixes issue of asset value_after_depreciation field getting updated twice if workflow is enabled in Journal Entry ( #35821 )
...
* Fixes issue of asset value_after_depreciation field getting updated twice if workflow is enabled in Journal Entry
* chore: remove unnecessary line break
* chore: formatting
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-21 14:42:16 +05:30
Daizy Modi
0fe95bf77e
chore: remove whitelisting for methods not used from UI ( #35592 )
2023-06-21 10:33:28 +05:30
mergify[bot]
aa8446d794
fix: date and finance book fixes in fixed asset register (backport #35751 ) ( #35800 )
...
* fix: date and finance book fixes in fixed asset register (#35751 )
* fix: handle finance books properly and show all assets by default in fixed asset register
* chore: rename value to depr amount
* chore: get asset value for correct fb properly
* chore: rename include_default_book_entries to include_default_book_assets
(cherry picked from commit 0d12588583 )
# Conflicts:
# erpnext/assets/report/fixed_asset_register/fixed_asset_register.py
* chore: resolving conflicts and renaming entries to assets
* chore: formatting
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-20 13:03:06 +05:30
mergify[bot]
7239e839a0
perf: index purpose in Stock Entry (backport #35782 ) ( #35784 )
...
* perf: index `purpose` in `Stock Entry`
(cherry picked from commit 4f941ac5c0 )
# Conflicts:
# erpnext/stock/doctype/stock_entry/stock_entry.json
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-06-20 12:02:04 +05:30
mergify[bot]
04990d51db
fix: fix get outstanding invoices btn and add get outstanding orders btn (backport #35776 ) ( #35788 )
...
* fix: fix get outstanding invoices btn and add get outstanding orders btn (#35776 )
* fix: fix get outstanding invoices btn and add get outstanding orders btn
* chore: remove unnecessary arg
(cherry picked from commit c1da3ddbbf )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/payment_entry.json
# erpnext/accounts/doctype/payment_entry/payment_entry.py
* chore: resolving conflicts
* chore: resolving conflicts properly
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-19 20:42:28 +05:30
ruthra kumar
af10d8080b
Merge pull request #35780 from frappe/mergify/bp/version-13-hotfix/pr-35320
...
fix: Gross and Net Profit Report - incorrect calculation of totals (backport #35320 )
2023-06-19 16:48:17 +05:30
Anoop Kurungadam
e899c30428
fix: add total col for gross and net profit
...
(cherry picked from commit cb9b4fbb91 )
2023-06-19 10:26:00 +00:00
Anoop Kurungadam
a53832e16e
refactor: merge separate loops for calculating group / leaf node totals
...
rename function
remove return statement as the list is mutated
(cherry picked from commit 1a3b9c5bdf )
2023-06-19 10:26:00 +00:00
Anoop Kurungadam
c6885e6789
refactor: remove unused parameters
...
(cherry picked from commit 50822f207e )
2023-06-19 10:26:00 +00:00
Anoop Kurungadam
f22969d266
fix: account group totals calculation to consider include_in_gross
...
(cherry picked from commit 8dcb9302b4 )
2023-06-19 10:26:00 +00:00
mergify[bot]
3d0add81fa
fix: Allocated amount validation for other party types ( #35741 )
...
* fix: Allocated amount validation for other party types (#35741 )
* fix: Allocated amount validation for other party types
* chore: Validation for return allocations
* chore: minor typo
---------
Co-authored-by: anandbaburajan <anandbaburajan@gmail.com >
(cherry picked from commit 9d27a25e5f )
* chore: remove unnecessary donor party type check
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-19 12:53:00 +05:30
mergify[bot]
46d0b7d317
fix: loan interest accrual date ( #35695 )
...
fix: loan interest accrual date (#35695 )
fix: loan interest accrual date
---------
Co-authored-by: Abhinav Raut <abhinav.raut@zerodha.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 2a24423ad2 )
Co-authored-by: Abhinav Raut <abhinavrautcs@gmail.com >
2023-06-19 09:14:01 +05:30
mergify[bot]
0a8b7148a5
fix: add validation for QI in PR (backport #35677 ) ( #35758 )
...
fix: add validation for QI in PR
(cherry picked from commit 2c1ab569a7 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-06-17 13:08:06 +05:30
Deepesh Garg
e37b6bbbf1
Merge pull request #35733 from deepeshgarg007/tax_withholding_limit_consumed
...
fix: Incorrect field while calculating Tax withholding net total
2023-06-16 12:20:44 +05:30
Deepesh Garg
bcc8a45c4e
Merge branch 'version-13-hotfix' into tax_withholding_limit_consumed
2023-06-16 12:18:57 +05:30
Deepesh Garg
571c977e8e
fix: Incorrect field while calculating Tax withholding net total
2023-06-16 12:17:31 +05:30
Deepesh Garg
1685305b53
Merge pull request #35730 from deepeshgarg007/tax_ithholding_v13
...
fix: Incorrect field while calculating Tax withholding net total
2023-06-16 11:18:22 +05:30
Deepesh Garg
b95d459812
fix: Incorrect field while calculating Tax withholding net total
2023-06-16 11:15:42 +05:30
mergify[bot]
0e11317303
fix: don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport #35714 ) ( #35716 )
...
* fix: don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (#35714 )
fix: on asset scrap, don't add gl entry for acc. depr. if no acc. depr.
(cherry picked from commit bb39a2cac7 )
# Conflicts:
# erpnext/assets/doctype/asset/depreciation.py
* chore: fix conflict
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-15 17:40:42 +05:30
mergify[bot]
c2bf8e3502
fix: Lower deduction certificate not getting applied ( #35667 )
...
* fix: Lower deduction certificate not getting applied (#35667 )
(cherry picked from commit 937c0feefe )
# Conflicts:
# erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
* chore: Resolve conflicts
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-14 09:01:54 +05:30
mergify[bot]
4d4f218175
fix(accounts): validate payment entry references with latest data. (backport #31166 ) ( #35674 )
...
* fix(accounts): validate payment entry references with latest data. (#31166 )
* test: payment entry over allocation.
* fix: validate allocated_amount against latest outstanding amount.
* fix: payment entry get outstanding documents for advance payments
* fix: only fetch latest outstanding_amount.
* fix: throw if reference is allocated
* test: throw error if a reference has been partially allocated after inital creation.
* chore: test name
* fix: remove unused part of test
* chore: linter
* chore: more user friendly error messages
* fix: only validate outstanding amount if partly paid and don't filter by cost center
* chore: minor refactor for doc.cost_center
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 20de27d480 )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/test_payment_entry.py
* chore: resolve conflicts
* chore: resolve more conflicts
* chore: don't validate allocated amount in case of donation
---------
Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-13 23:01:51 +05:30
mergify[bot]
4c2c037a86
fix: make showing taxes as table in print configurable ( #35672 )
...
* fix: make showing taxes as table in print configurable (#35672 )
(cherry picked from commit 491a50a027 )
# Conflicts:
# erpnext/accounts/doctype/accounts_settings/accounts_settings.json
* chore: fixing conflicts
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-06-13 21:38:16 +05:30
mergify[bot]
4f79214ae6
Stock aging report fix when called in dashboard chart (backport #35671 ) ( #35676 )
...
fix: get_range_age conditions fixed (#35671 )
see https://github.com/frappe/erpnext/issues/35669
(cherry picked from commit 9f669d4c2f )
Co-authored-by: Hossein Yousefian <86075967+ihosseinu@users.noreply.github.com >
2023-06-13 19:24:21 +05:30