Saqib Ansari
cf3e09588f
fix: test cases
...
(cherry picked from commit 1b556d1c53 )
2022-03-31 08:47:18 +00:00
Saqib Ansari
650274e973
fix: sider issues
...
(cherry picked from commit cb4873c019 )
2022-03-31 08:47:17 +00:00
Saqib Ansari
3bb0716dff
fix(pos): cannot close the pos if sr. no. is sold & returned
...
(cherry picked from commit cf51a0a1b8 )
# Conflicts:
# erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py
# erpnext/accounts/doctype/pos_invoice_merge_log/test_pos_invoice_merge_log.py
2022-03-31 08:47:17 +00:00
Saqib Ansari
36845a87e0
fix(pos): remove returned sr. nos. from pos reserved sr. nos. list
...
(cherry picked from commit f2ae63cbfd )
# Conflicts:
# erpnext/accounts/doctype/pos_invoice/pos_invoice.py
# erpnext/stock/doctype/serial_no/serial_no.py
2022-03-31 08:47:15 +00:00
Saqib Ansari
76f83ea559
fix(pos): allow validating stock on save
...
(cherry picked from commit aff7408775 )
# Conflicts:
# erpnext/accounts/doctype/pos_invoice/pos_invoice.py
2022-03-31 08:47:13 +00:00
Saqib Ansari
3b583c6c48
fix(pos): specific case when serialized item not removed
...
(cherry picked from commit 4afb47e869 )
2022-03-31 08:47:11 +00:00
Saqib Ansari
a3a7dc9ce6
fix(pos): customer group filter in customer selector
...
(cherry picked from commit 2f82e237ef )
2022-03-31 08:47:10 +00:00
Saqib Ansari
bd2061d6f3
fix: prevent multiple save on applying coupon code
...
(cherry picked from commit d5fd8e0ba6 )
2022-03-31 08:47:09 +00:00
Saqib Ansari
9ffe34757e
Merge pull request #30455 from frappe/mergify/bp/version-13-hotfix/pr-30419
...
fix: move item tax to item tax template patch (backport #30419 )
2022-03-31 12:43:15 +05:30
Saqib Ansari
1a169c9dc5
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-30419
2022-03-31 12:02:15 +05:30
mergify[bot]
22ec1a4996
fix: enable row deletion in reference table ( #30492 )
...
(cherry picked from commit 500870b2b0 )
Co-authored-by: rahib-hassan <rahib.hassan10@gmail.com >
2022-03-30 16:37:00 +05:30
Anoop
3f3717952c
fix: cast array slice index integer while splitting serial_nos array ( #30468 )
2022-03-30 16:36:15 +05:30
mergify[bot]
c7d8d60de6
fix: explicitly check if additional salary is recurring while fetching components for payroll (backport #30489 ) ( #30491 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2022-03-30 15:07:56 +05:30
Saqib Ansari
6397456ba6
Merge pull request #30484 from frappe/mergify/bp/version-13-hotfix/pr-30470
...
fix: credit limit validation in delivery note (backport #30470 )
2022-03-30 14:57:49 +05:30
mergify[bot]
46e6d16c49
fix: Dont set idx while adding WO items to Stock Entry (backport #30377 ) ( #30485 )
...
* fix: Dont set `idx` while adding WO items to Stock Entry
- `idx` must be computed by base document's `self.append()` function, so do not set it
(cherry picked from commit a787ebb732 )
# Conflicts:
# erpnext/stock/doctype/stock_entry/stock_entry.py
* chore: Remove redundant idx query and value setting
- idx can be removed from `select_columns` as it is already in the main query
- setting idx to '' is not required as it is not used further
(cherry picked from commit 639d380c1f )
# Conflicts:
# erpnext/stock/doctype/stock_entry/stock_entry.py
* test: idx mapping correctness
(cherry picked from commit fa3b953cf7 )
* fix: Linter
(cherry picked from commit b5ad626d23 )
* fix: resolve conflicts
Co-authored-by: marination <maricadsouza221197@gmail.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-30 12:05:26 +05:30
Saqib Ansari
c9cd3ee9aa
fix: credit limit validation in delivery note
...
(cherry picked from commit c122882884 )
2022-03-30 05:39:15 +00:00
mergify[bot]
39ff7b0b06
fix: validate 0 transfer qty in stock entry ( #30476 ) ( #30479 )
...
(cherry picked from commit b80fac03af )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-29 18:18:13 +05:30
Ankush Menat
eedfee367c
Merge pull request #30478 from ankush/format_v13
...
style: bulk formatting (v13 port)
2022-03-29 17:51:30 +05:30
Ankush Menat
14c8386040
chore: ignore black formatting commit in blame
2022-03-29 17:31:43 +05:30
Ankush Menat
c07713b860
style: bulk format code with black
...
v13 port because otherwise backports will result in conflicts always
2022-03-29 17:29:34 +05:30
Ankush Menat
7cc84dcbb4
ci: pin click for black ( #30464 )
...
[skip ci]
2022-03-29 17:26:42 +05:30
Ankush Menat
68ded18a23
ci: force black formatting (pre-commit)
2022-03-29 17:26:26 +05:30
mergify[bot]
00ad515ac7
fix: use name for links not item_code (backport #30462 ) ( #30463 )
...
* fix: use `name` for links not `item_code` (#30462 )
(cherry picked from commit 76dce2eddc )
# Conflicts:
# erpnext/selling/report/item_wise_sales_history/item_wise_sales_history.py
* fix: conflicts
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-29 17:16:31 +05:30
mergify[bot]
6b3bdb2e9e
fix: dont check for failed repost while freezing (backport #30472 ) ( #30473 )
...
* fix: dont check for failed repost while freezing (#30472 )
[skip ci]
(cherry picked from commit b12fe0f15b )
# Conflicts:
# erpnext/stock/utils.py
* fix: conflicts
[skip ci]
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-29 13:56:15 +05:30
Deepesh Garg
8e59e67197
Merge pull request #30385 from deepeshgarg007/quotation_gst
...
fix(India): Auto tax fetching based on GSTIN
2022-03-29 10:25:57 +05:30
mergify[bot]
659fa7a190
fix: bom valuation - handle lack of LPP ( #30454 ) ( #30457 )
...
(cherry picked from commit 8dff4d66a4 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-28 18:36:12 +05:30
Raffael Meyer
471a3279b9
fix(lead): reload address and contact before updating their links (Backport #29966 ) ( #29968 )
...
* fix(lead): reload address and contact before updating their links
They might have changed since they were created. Backport of #29966 .
* refactor: reload contact after insert
2022-03-28 18:01:00 +05:30
Saqib Ansari
3142e6f188
fix: move item tax to item tax template patch
...
(cherry picked from commit 936267c934 )
2022-03-28 12:05:23 +00:00
Ankush Menat
7f3651a938
fix: update picked qty on cancellation
...
(cherry picked from commit 69ae2661d2 )
2022-03-28 10:44:53 +05:30
Deepesh Garg
8fb56d57bb
Merge pull request #30438 from deepeshgarg007/amount_to_pay
...
fix: Incorrect default amount to pay for POS invoices
2022-03-27 18:00:42 +05:30
Deepesh Garg
156416bcc3
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into quotation_gst
2022-03-27 17:28:42 +05:30
Deepesh Garg
a044e92687
fix: Incorrect default amount to pay for POS invoices
2022-03-27 13:02:31 +05:30
Saqib Ansari
99dc1ecd2d
Merge pull request #30435 from frappe/mergify/bp/version-13-hotfix/pr-30420
...
fix: unsupported operand type(s) for +=: 'int' and 'NoneType' (backport #30420 )
2022-03-26 20:00:07 +05:30
Saqib Ansari
bd171fbd42
fix: unsupported operand type(s) for +=: 'int' and 'NoneType'
...
(cherry picked from commit 5450542fdb )
2022-03-26 13:46:24 +00:00
Rucha Mahabal
020a4269ae
fix(Expense Claim): validate advances after setting totals
2022-03-25 23:43:46 +05:30
Rucha Mahabal
84de986c5a
fix(test): add function for getting advances for claim
2022-03-25 23:43:46 +05:30
Rucha Mahabal
e783e3f93e
fix: do not update status to Paid if sanctioned amount is 0
2022-03-25 23:43:46 +05:30
Rucha Mahabal
ed0a685e0e
chore: sort imports
2022-03-25 23:43:46 +05:30
Rucha Mahabal
7d3c211b1f
test: expense claim against fully and partially paid advances
2022-03-25 23:43:46 +05:30
Rucha Mahabal
961e691bdc
fix: Expense Claim conditions for Paid status
...
- status doesn't change to Paid if the entire required amount is already covered via linked advances
- status doesn't change to Paid if the claim is partially paid via advances
- patch to update such uncancelled claims to Paid
2022-03-25 23:43:46 +05:30
Deepesh Garg
c2b2b3962a
Merge pull request #30429 from deepeshgarg007/transaction_issue
...
fix: Check for onload property
2022-03-25 21:51:07 +05:30
Deepesh Garg
71402b43a7
fix: Check for onload property
2022-03-25 21:49:19 +05:30
Deepesh Garg
0740158431
Merge pull request #30395 from deepeshgarg007/pos_write_off
...
fix: Write off amount wrongly calculated in POS Invoice
2022-03-25 20:56:19 +05:30
mergify[bot]
8b5fe164fd
fix: show subassembly table always ( #30422 ) ( #30423 )
...
[skip ci]
(cherry picked from commit 0534cf6c9c )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-03-25 19:04:22 +05:30
Deepesh Garg
6a50f36b31
test: test for auto write-off amount
2022-03-25 18:02:14 +05:30
Deepesh Garg
665bd4c510
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into pos_write_off
2022-03-25 16:00:33 +05:30
Deepesh Garg
26b90ffce0
Merge pull request #30406 from deepeshgarg007/rate_change_fixes
...
fix: Rate change issue on save and mapping from other doc
2022-03-25 12:59:40 +05:30
mergify[bot]
29fde6ee8b
fix: failing broken patches ( #30409 ) ( #30412 )
...
* fix: failing broken patches
* refactor: simpler conditions
[skip ci]
(cherry picked from commit c4854bb1b1 )
Co-authored-by: Shadrak Gurupnor <30501401+shadrak98@users.noreply.github.com >
2022-03-25 12:57:05 +05:30
Deepesh Garg
2e0e6ca6b1
fix: Condition
2022-03-25 12:39:59 +05:30
Deepesh Garg
6937a498e7
fix: Revert rate calculation
2022-03-25 12:28:55 +05:30