Deepesh Garg
94f2c41475
fix: Incorrect unallocated amount calculation in payment entry
2021-08-17 13:31:17 +05:30
Frappe PR Bot
321dd33015
fix: Org Chart fixes ( #26952 ) ( #26953 )
...
* fix: add z-index to filter to avoid svg wrapper overlapping
* fix: expand all nodes not working when there are only 2 levels
- added dom freeze while expanding all nodes and exporting
(cherry picked from commit 67e3971c3b )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-08-16 10:44:35 +05:30
Deepesh Garg
560483eb98
Merge pull request #26946 from GangaManoj/property-enable-discount-accounting
...
fix: Make enable_discount _accounting a class property
2021-08-14 18:06:17 +05:30
Ankush Menat
6aed9e26ac
fix: unknown attribute "string_type" ( #26947 )
2021-08-14 10:45:43 +05:30
GangaManoj
20a5795d67
fix: Make enable_discount_accounting a class property
2021-08-13 19:23:57 +05:30
Frappe PR Bot
434692ad34
fix: Copy previous balance dict object instead of assigning ( #26942 ) ( #26944 )
...
- Due to plain assignment, dict mutation gave wrong monthly values
(cherry picked from commit fe2a34f171 )
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2021-08-13 10:26:26 +00:00
Frappe PR Bot
7881536e09
ci: ignore js files in unittests ( #26937 )
...
* ci: ignore js files in unittests (#26934 )
* ci: ignore js files in unittests
- Avoid running python unittests on PRs that ONLY change JS files.
* ci: ignore md files in test workflows
(cherry picked from commit 8a6b82b196 )
# Conflicts:
# .github/workflows/server-tests.yml
* fix: resolve conflicts
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-08-13 07:59:48 +00:00
Frappe PR Bot
cb583a349f
fix: show proper currency symbol in taxes and charges table ( #26827 ) ( #26935 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com >
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
(cherry picked from commit 587d2db6a9 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-13 12:43:02 +05:30
Frappe PR Bot
a2a5800b23
fix: Deferred Revenue Section should be collapsible only if its not enabled ( #26930 )
...
* fix: Deferred Revenue Section should be collapsible only if its not enabled (#26928 )
(cherry picked from commit 1de4c01942 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
# erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
* fix: conflicts
* fix: conflicts
* fix: conflicts
* fix: conflicts
* fix: conflicts
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-13 10:58:43 +05:30
Suraj Shetty
adfa11d449
fix: Nest .level class style under .hierarchy class ( #26905 )
...
fix: Nest `.level` class style under `.hierarchy` class
2021-08-12 21:12:52 +05:30
Frappe PR Bot
9209c1f91a
fix: from_warehouse getting set to None ( #26920 ) ( #26927 )
...
(cherry picked from commit b8658d003f )
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
2021-08-12 14:54:08 +00:00
Frappe PR Bot
262c1823a5
fix: ZeroDivisionError on creating e-invoice for credit note ( #26919 )
2021-08-12 17:11:55 +05:30
Marica
703b081172
fix: Stock Analytics Report must consider warehouse during calculation ( #26908 )
...
* fix: Stock Analytics Report must consider warehouse during calculation
* fix: Brand filter in Stock Analytics
2021-08-12 10:31:01 +05:30
Frappe PR Bot
f3ae956eae
perf: various minor perf fixes for ledger postings ( #26775 ) ( #26896 )
...
* perf: only validate if voucher is journal entry
* perf: optimize merge GLE
- Order fields such that comparison will fail faster
- Break out of loops if not matched
* perf: don't try to match SLE if count mismatch
* refactor: simplify initialize_previous_data
* perf: use cache for fetching valuation_method
These are set only once fields
* refactor: simplify get_future_stock_vouchers
* refactor: simplify get_voucherwise_gl_entries
* perf: fetch only required fields for GL comparison
`select *` fetches all fields, output of this function is only used for
comparing.
* perf: reorder conditions in PL cost center check
* perf: reduce query while validating new gle
* perf: use cache for validating warehouse props
These properties don't change often, no need to query everytime.
* perf: use cached stock settings to validate SLE
* docs: update misleading docstring
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit 9152715f90 )
Co-authored-by: Ankush <ankush@iwebnotes.com >
2021-08-11 12:18:58 +05:30
Rucha Mahabal
fd325a123c
fix(style): apply svg container margin only in desktop view ( #26894 )
2021-08-10 23:49:56 +05:30
Frappe PR Bot
1167a9bf94
fix: unsetting of payment if no pos profile found ( #26891 )
...
* fix: unseting of payment if no pos profile found (#26884 )
(cherry picked from commit b614834efe )
# Conflicts:
# erpnext/public/js/controllers/taxes_and_totals.js
* fix: conflicts
* fix: conflicts
* fix: conflicts
* fix: conflicts
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
Co-authored-by: Afshan <afshan13k@gmail.com >
2021-08-10 23:18:23 +05:30
Anupam Kumar
a6aa6cd7d6
fix: timesheet amount issue ( #25993 )
...
* fix: timesheet amount issue
* fix: timesheet detail rate conversion
* fix: condition to check timesheet currency
* fix: removing console statement
2021-08-10 20:32:15 +05:30
Frappe PR Bot
1a39d1a311
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #26881 )
2021-08-10 19:38:39 +05:30
Anuja Pawar
66784a16cb
fix: Sales Return cancellation if linked with Payment Entry ( #26883 )
2021-08-10 19:38:16 +05:30
Marica
d657f39ab8
Merge pull request #25622 from noahjacob/promo_scheme_feat
...
feat: added multi-select fields to create multiple pricing rules.
2021-08-10 19:09:42 +05:30
Marica
af9863146d
fix: Grammar in Error message
2021-08-10 18:49:07 +05:30
Noah Jacob
49b7c7575e
refactor: code cleanup
2021-08-10 18:35:46 +05:30
Noah Jacob
4ee6e32d74
test(fix): fixed test case
2021-08-10 18:34:18 +05:30
Frappe PR Bot
a7e0805039
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal ( #26879 )
2021-08-10 17:16:15 +05:30
Nabin Hait
f8031d3d79
Merge pull request #26261 from ruchamahabal/org-chart
...
feat: Organizational Chart
2021-08-10 17:12:59 +05:30
Saqib
363225d2ba
fix(asset): incorrect date difference calculation ( #26805 )
2021-08-10 16:37:23 +05:30
Subin Tom
793063bf4e
fix: pos return payment mode issue ( #26875 )
2021-08-10 15:57:30 +05:30
Frappe PR Bot
1ba04fdfe5
fix: pos profile not mandatory for Sales Invoice ( #26876 )
2021-08-10 15:47:36 +05:30
Marica
1776fc44b7
Merge pull request #26878 from marination/serial-no-space-hotfix
...
fix: Clean Serial No input on Server Side
2021-08-10 15:25:29 +05:30
marination
510e31952d
test: Serial no sanitation
2021-08-10 14:35:51 +05:30
marination
f22b858253
fix: Clean Serial No input on Server Side
2021-08-10 14:35:41 +05:30
Marica
fd12f65047
Merge pull request #26854 from marination/asset-lcv-gl-entry-hotfix
...
fix: Faulty Gl Entry for Asset LCVs (#26803 )
2021-08-10 14:07:12 +05:30
Saqib
5719198576
feat: dynamic conditions for applying SLA ( #26806 )
2021-08-10 13:56:48 +05:30
Anurag Mishra
24da00cada
fix: updating lead status while customer creation ( #26607 )
...
* fix: updating lead status while customer creation
* fix: changes requested
2021-08-10 13:17:41 +05:30
marination
06b6b7e3cc
fix: Set CWIP Account in company at the start to avoid flaky test
2021-08-10 13:14:32 +05:30
Deepesh Garg
25a2f2b90e
Merge pull request #26579 from deepeshgarg007/discount_accounting_v13
...
feat: Enable discount accounting
2021-08-10 11:48:14 +05:30
Subin Tom
2ab62a4484
fix: Missing method reset_issue_metrics added back to Issue doctype ( #26574 )
2021-08-10 11:43:59 +05:30
Noah Jacob
10ce2f5d6e
refactor: added naming series for pricing rule
2021-08-10 11:42:59 +05:30
noahjacob
dd86642037
refactor: removed py2 code
2021-08-10 11:41:29 +05:30
noahjacob
b214e624bb
style: fixed formatting
2021-08-10 11:41:29 +05:30
noahjacob
74bcb987f3
style: fixed formatting
2021-08-10 11:41:29 +05:30
noahjacob
4fb1b6b80c
fix: Sider
2021-08-10 11:41:29 +05:30
noahjacob
a4cea1e56d
refactor: variable names
2021-08-10 11:41:29 +05:30
noahjacob
3a663ac77f
test: changed test item name
2021-08-10 11:41:29 +05:30
noahjacob
c95d96e7ae
refactor: changed variable names
2021-08-10 11:41:29 +05:30
noahjacob
a9ef56a107
test: added test case for creating and updating
2021-08-10 11:41:29 +05:30
noahjacob
415519af15
feat: added multi-select fields to create multiple pricing rules.
2021-08-10 11:41:29 +05:30
rohitwaghchaure
c5e7673277
Merge pull request #26814 from noahjacob/mr_allowance_feat_v13
...
feat: over transfer allowance for material transfers (bp #26264 )
2021-08-10 11:32:43 +05:30
Deepesh Garg
797170e913
fix: Linting issues
2021-08-10 11:02:21 +05:30
Deepesh Garg
428ccebad9
test: Update test cases for discount accounting
2021-08-10 10:43:01 +05:30