Deepesh Garg
933d4bfceb
Merge pull request #36711 from frappe/mergify/bp/version-14-hotfix/pr-36710
...
fix: broken consolidated report due to finance book filter (#36710 )
2023-08-19 10:25:11 +05:30
rohitwaghchaure
620b21fec5
fix: timeout error coming during reposting ( #36715 )
2023-08-18 18:33:04 +05:30
ruthra kumar
5bd2a0923f
fix: broken consolidated report due to finance book filter
...
(cherry picked from commit 96847db0ec )
2023-08-18 09:25:18 +00:00
Deepesh Garg
a623469778
Merge pull request #36645 from frappe/mergify/bp/version-14-hotfix/pr-36495
...
fix: Document Name link validation in Bank Reconciliation Tool (#36495 )
2023-08-18 09:27:10 +05:30
Deepesh Garg
ee5a1d91ff
chore: resolve conflicts
2023-08-17 20:45:53 +05:30
mergify[bot]
0a4947a8f6
fix(ux): change batch selection message to alert (backport #36500 ) ( #36697 )
...
fix(ux): change batch selection message to alert (#36500 )
* fix(ux): change batch selection message to alert
* chore: linters
(cherry picked from commit 641fe7738c )
Co-authored-by: Dany Robert <danyrt@wahni.com >
2023-08-17 18:03:58 +05:30
mergify[bot]
9668615f7e
feat: Tick on checkbox to include draft timesheets (backport #36577 ) ( #36640 )
...
feat: Tick on checkbox to include draft timesheets (#36577 )
feat: Tick on Check box to include Draft Timesheets
(cherry picked from commit 75652799cd )
Co-authored-by: ViralKansodiya <141210323+viralkansodiya@users.noreply.github.com >
2023-08-17 17:13:51 +05:30
Deepesh Garg
506ac10119
Merge pull request #36678 from frappe/mergify/bp/version-14-hotfix/pr-36677
...
fix(UX): Ignore prepared report (#36677 )
2023-08-17 16:08:36 +05:30
mergify[bot]
36147ec02c
fix(RFQ): make "update password" and "submit quotation" buttons the same size (backport #36667 ) ( #36686 )
...
fix(RFQ): make "update password" and "submit quotation" buttons the same size (#36667 )
fix(RFQ): button styling
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-08-17 16:00:17 +05:30
Shariq Ansari
3dd642441b
Merge pull request #36689 from frappe/mergify/bp/version-14-hotfix/pr-36685
...
fix: check tax and charges if it is passed (backport #36685 )
2023-08-17 13:10:42 +05:30
Shariq Ansari
f186015f58
chore: linter fix
...
(cherry picked from commit 21c1141fdb )
2023-08-17 07:40:10 +00:00
Shariq Ansari
1f76c6972b
fix: check tax and charges if it is passed
...
(cherry picked from commit 7ec6909159 )
2023-08-17 07:40:10 +00:00
mergify[bot]
c308bd5309
feat(RFQ): make email message fully configurable (backport #36353 ) ( #36531 )
...
* feat(RFQ): make email message fully configurable (#36353 )
feat: make RFQ message fully configurable
(cherry picked from commit 21080afd92 )
* fix(RFQ): hide description in print and report
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-08-17 12:11:37 +05:30
Deepesh Garg
3e23e1fb91
fix(UX): Ignore prepared report
...
(cherry picked from commit 124c0dbd88 )
2023-08-16 16:03:01 +00:00
Deepesh Garg
67c8350f70
Merge branch 'version-14' into version-14-hotfix
2023-08-16 11:08:08 +05:30
ruthra kumar
cba1c63beb
Merge pull request #36651 from frappe/mergify/bp/version-14-hotfix/pr-36642
...
refactor: toggle for negative item rates in Selling Settings (backport #36642 )
2023-08-16 10:30:24 +05:30
ruthra kumar
2f0e7fcb4a
Merge branch 'version-14-hotfix' into mergify/bp/version-14-hotfix/pr-36642
2023-08-16 09:58:31 +05:30
ruthra kumar
44c1b91ca7
Merge pull request #36633 from frappe/mergify/bp/version-14-hotfix/pr-35644
...
refactor: booking exchange gain/loss amount through journal (backport #35644 )
2023-08-16 09:41:25 +05:30
mergify[bot]
1deebe8757
fix: Tax withholding post LDC limit consumed ( #36611 )
...
* fix: Tax withholding post LDC limit consumed (#36611 )
* fix: Tax withholding post LDC limit consumed
* fix: LDC condition check
(cherry picked from commit 985ff9781b )
# Conflicts:
# erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
* chore: resolve conflicts
* chore: linting issues
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-08-16 08:09:38 +05:30
mergify[bot]
99777d3fa4
fix: re-add permission that was unintentionally removed ( #36663 )
...
fix: re-add permission that was unintentionally removed
Remove `Reversal OF ITC` and re-add permissions. Both of them
unintended changes
(cherry picked from commit 45662fa646 )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-08-16 08:09:04 +05:30
mergify[bot]
33d5250cec
chore: add validation for depreciation expense account in asset category (backport #36659 ) ( #36661 )
...
chore: add validation for depreciation expense account in asset category (#36659 )
(cherry picked from commit e0c79d3b53 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-08-15 18:27:01 +05:30
ruthra kumar
e55c160438
chore: resolve conflicts
2023-08-15 08:56:37 +05:30
ruthra kumar
3a82eb4ccf
refactor: toggle for negative rates in Selling Settings
...
(cherry picked from commit a0fc68538f )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
# erpnext/patches.txt
# erpnext/selling/doctype/selling_settings/selling_settings.json
2023-08-15 02:43:54 +00:00
Devin Slauenwhite
ca34b63470
feat: Reallow customizing company abbreviation on setup. ( #36646 )
...
Co-authored-by: Bernd Oliver Sünderhauf <pancho@mailbox.org >
2023-08-14 21:44:03 +05:30
Kevin Shenk
83cbc1bef6
fix: Document Name link validation in Bank Reconciliation Tool ( #36495 )
...
fix: format_row broke Document Name link validation
#35540 broke Voucher Matching, leading to an invalid link exception on submission. This is because the format_row() function overwrites the row data instead of just providing a formatter on the DataTable column, and therefore passes through the formatted (linked) column data instead of the Document Name only.
This patch moves the appropriate frappe.form.formatters.Link function to a dedicated format hook on the DataTable columns definition, both fixing the error and retaining the functionality of #35540 .
(cherry picked from commit 7ab55b1bb2 )
# Conflicts:
# erpnext/public/js/bank_reconciliation_tool/dialog_manager.js
2023-08-14 13:34:31 +00:00
mergify[bot]
716d5c0b98
fix: standard formula to calculate the "difference" ( #36612 )
...
fix: standard formula to calculate the "difference" (#36612 )
(cherry picked from commit 843e77e72d )
Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com >
2023-08-14 18:55:16 +05:30
Gursheen Kaur Anand
90b390c2c5
feat: add voucher totals in tds payable report ( #36568 )
...
* feat: voucher totals in tds payable monthly
* fix: naming series column in tds payable report
* fix: tds computation summary columns
2023-08-14 18:15:21 +05:30
ViralKansodiya
b131f70ed6
fix: Button Alignment center in hero slider ( #36607 )
...
fix: speling in CSS (Button alignment center is not working on hero slider)#36561
2023-08-14 16:20:58 +05:30
ruthra kumar
18cf93d1c8
refactor(test): import missing functions
2023-08-14 11:49:46 +05:30
ruthra kumar
2e6bfa36de
fix(test): replace hardcoded reference to adv with dynamic one
2023-08-14 11:30:35 +05:30
ruthra kumar
b3f4c14a26
chore: resolve conflict in payment_reconciliation.py
...
backport will merge the better remarks PR
https://github.com/frappe/erpnext/pull/36573 wil exchange gain/loss
booking refactor
2023-08-14 10:56:48 +05:30
ruthra kumar
946aadb0c0
chore: resolve conflict in test_sales_invoice.py
2023-08-14 10:52:49 +05:30
ruthra kumar
f92453ae45
chore: resolve merge conflict in accounts/utils.py and its tests
2023-08-14 10:50:31 +05:30
ruthra kumar
7469018d3e
chore: resolve merge conflict
2023-08-14 10:37:56 +05:30
ruthra kumar
61afffc908
chore: cancel gain/loss je while posting reverse gl
...
(cherry picked from commit 46ea814400 )
2023-08-14 04:51:46 +00:00
ruthra kumar
ed0881dacb
chore: don't make gain/loss journal for base currency transactions
...
(cherry picked from commit 567c0ce1e8 )
2023-08-14 04:51:46 +00:00
ruthra kumar
efb293398a
chore(test): use existing company for unit test
...
(cherry picked from commit 804afaa647 )
2023-08-14 04:51:46 +00:00
ruthra kumar
8d32a1f4b3
chore: rename some internal variables
...
(cherry picked from commit d9d6856153 )
2023-08-14 04:51:46 +00:00
ruthra kumar
4c527d6bba
chore: add msgprint for exc JE
...
(cherry picked from commit acc7322874 )
2023-08-14 04:51:45 +00:00
ruthra kumar
2a61d854d3
chore: use frappetestcase
...
(cherry picked from commit 47bbb37291 )
2023-08-14 04:51:45 +00:00
ruthra kumar
052abcb075
refactor(test): assert ledger outstanding
...
(cherry picked from commit 025091161e )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
2023-08-14 04:51:45 +00:00
ruthra kumar
3542df70f6
fix(test): test case breakage in Github Actions
...
(cherry picked from commit bfa54d5335 )
2023-08-14 04:51:45 +00:00
ruthra kumar
c5c440b7bc
test: assert ledger after cr note cancellation
...
(cherry picked from commit ae424fdfed )
2023-08-14 04:51:45 +00:00
ruthra kumar
349601b4b9
fix: cr/dr note should be posted for exc gain/loss
...
(cherry picked from commit 95543225cf )
2023-08-14 04:51:44 +00:00
ruthra kumar
09e9b16b93
test: cr notes against invoice
...
(cherry picked from commit e3d2a2c5bd )
2023-08-14 04:51:44 +00:00
ruthra kumar
39c439dc4b
fix: incorrect gain/loss on allocation change on reconciliation tool
...
(cherry picked from commit 506a5775f9 )
2023-08-14 04:51:44 +00:00
ruthra kumar
72a507f888
refactor: create gain/loss on Cr/Dr notes with different exc rates
...
(cherry picked from commit ba1f065765 )
2023-08-14 04:51:44 +00:00
ruthra kumar
22dbe52586
refactor: convert class method to standalone function
...
(cherry picked from commit 1ea1bfebc4 )
2023-08-14 04:51:44 +00:00
ruthra kumar
1999132c28
refactor: split make_exchage_gain_loss_journal into smaller function
...
(cherry picked from commit c0b3b069b5 )
2023-08-14 04:51:43 +00:00
ruthra kumar
57af6d9c21
refactor: cr/dr note will be on single exchange rate
...
(cherry picked from commit c87332d5da )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
2023-08-14 04:51:43 +00:00