1. No need to keep old PLE's on reconciliation.
2. Added Validation to catch debit-credit mismatch on JE's
3. Only update outstanding amount for newly reconciled invoices
(cherry picked from commit 11cf694d9a)
* Update bank_reconciliation_tool.py
Applying date filter on transactions and all the bank entries and also gives the filter the bank entries as per reference date. Sorted all transactions and entries as per date in ascending order.
Also added posting date columns in all bank entries and default checkbox tick of journal entry, hide the sales invoice and purchase invoice checkbox.
(cherry picked from commit e5a1189bec)
* Filters on Bank Reconciliation
Applying date filter on transactions and all the bank entries and also gives the filter the bank entries as per reference date. Sorted all transactions and entries as per date in ascending order. Also added posting date columns in all bank entries and default checkbox tick of journal entry, hide the sales invoice and purchase invoice checkbox.
(cherry picked from commit 447272aa4d)
* Update bank_reconciliation_tool.json
Adding fields in bank reconciliation tool
(cherry picked from commit 8e7c8a6482)
* Feat:Filter on Payment Entries and Journal Entries
Applying filters on Payement entries and Journal Entries as per reference date and posting date
(cherry picked from commit 408c89df03)
* feat:filters on bank reconciliation
Added date filters on bank transactions, payment entries and journal entries and sorted list as per date in ascending order.
(cherry picked from commit 05b6fce03d)
* feat: added arguments of posting date and reference date
(cherry picked from commit 645869e6ff)
* fix: linters
(cherry picked from commit 6b5276398e)
* fix: json issue
(cherry picked from commit 81e5f71172)
* fix: filtered as per reference date
On bank reconciliation, transactions will be filtered as per date selected in 'from_date' and 'to_date' fields , In dialog, all the bank entries will be fetched as per the posting date selected and if filtered by reference date checkbox is tick then then there will be two fields 'from_reference_date' and 'to_reference_date' then all bank entries in dialog box came as per reference date, selected. And by default journal entry checkbox is tick.
Also sorted the bank transactions and bank entries as per ascending order date wise.
(cherry picked from commit 3aaa2f5326)
* fix: pre-commit
(cherry picked from commit e2614b8a21)
* fix: passing from_date and to_date filters in test cases
passing from_date and to_date filters in test_linked_payments and test_debit_credit_output for unit testing
(cherry picked from commit f1810803e1)
* fix: pre-commit
(cherry picked from commit 35c29e0226)
* fix: pre-commit
(cherry picked from commit c764f14f53)
* feat: consolidated auto bank reconciliation
Added a button of Auto Reconcile, to reconcile the bank entries as per the matching reference number with the bank transaction and count of transactions reconciled message will be pop up on clicking the auto reconcile button.
(cherry picked from commit d65243eb65)
* fix: data format
(cherry picked from commit 12822f7c36)
* fix: remove comments
(cherry picked from commit 917b2190aa)
* chore: fix fieldnames and order
(cherry picked from commit 232726288a)
Co-authored-by: sonali <sonali@8848digital.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
fix: only group similar items in print format if group_same_items is checked in pick list (#33627)
* fix: only group similar items if group same items is checked in pick list
* test: non grouping of locations if group_same_items is false
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit cfb0bb1eaa)
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
fix(accounts): currency fields no longer read as strings by validation function in Payment Entry (#33535)
explicitly cast paid_amount and received_amount to float in the Payment Entry set_unallocated_amount validation function
(cherry picked from commit 4d5067d6d4)
Co-authored-by: Gughan Ravikumar <gughanrk@gmail.com>
* fix: timeout error in the Purchase Invoice
(cherry picked from commit 7249657d15)
* feat: provision to disable get last purchase rate
fix: set_incoming_rate condition
(cherry picked from commit d1d4671320)
* fix: linters issue
(cherry picked from commit 05df8579cd)
* test: test case to check disable last purchase rate
(cherry picked from commit ec171fc7c1)
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
fix: Exchange gain and loss booking on multi-currency invoice reconciliation (#32900)
* fix: Exchange gain and loss booking on multi-curreny invoice reconciliation
* test: Update test cases
* chore: Ignore SQL linting rule
* chore: Joural Entry for exchange gainand loss booking
* chore: Journal entry for exchange gain loss booking
* test: Update test case
* chore: Default exchange gain and loss account
(cherry picked from commit 9a3d947e89)
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
fix: Get payment entry button not visible in Bank Clearance doc (#33518)
(cherry picked from commit 1a83a67d41)
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
refactor: Exchange rate revaluation to handle accounts with zero account balance (#33165)
* refactor: new type for JE - Exchange Gain or Loss
* refactor: skip few validations for Exchanage Gain Or Loss type Jour
* refactor: ERR create 2 journals for handling zero and non-zero compa
1. Additional check box accounts table to identify accounts with zero balance
2. Accounts with zero balance only in either of the 2 currencies will be handled on separate Journal
* refactor: skips few validation for allowing 0 debit/credit
* fix: General Ledger presentaion currency
* test: fix test case in general ledger
* test: fix failing test case in AR report
(cherry picked from commit 914b23038c)
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
