Commit Graph

38230 Commits

Author SHA1 Message Date
GangaManoj
84952beed4 fix: Filter Depreciation Expense Account by root type 2021-12-06 16:06:27 +05:30
Deepesh Garg
334f22f453 Merge pull request #28744 from frappe/mergify/bp/version-13-hotfix/pr-28656
fix: Taxjar Nexus list visible only if child table is visible (backport #28656)
2021-12-06 15:57:14 +05:30
Saqib
416faf76df fix: Calculate depreciation_amount accurately (backport #27585) 2021-12-06 15:43:48 +05:30
Saqib Ansari
1a2e815e6a fix: asset not copied on creating invoice return 2021-12-06 15:16:25 +05:30
Ankush Menat
90131f5e6e fix: reload sellling settings before patch 2021-12-06 12:12:35 +05:30
Ankush Menat
9a1b4119e9 test: set customer group and territory defaults
(cherry picked from commit a8375239eb)
2021-12-06 12:12:35 +05:30
Ankush Menat
e9af26e7b6 fix: patch to remove default item group and territory
(cherry picked from commit bdf7b8d379)
2021-12-06 12:12:35 +05:30
Ankush Menat
93ee870bf9 fix: remove bad defaults from selling settings
"All cusotmer groups" and "All territories" are pointless defaults, not
sure why these are made default. They don't help you track anything.
"All" might as well be `Null`.

Even the filters for customer_group suggest it shouldn't be group then
having the root as default makes no sense.

(cherry picked from commit 105b6d498c)
2021-12-06 12:12:35 +05:30
Subin Tom
a36c13e2d5 fix: removing db call for variables
(cherry picked from commit ecc5de6159)
2021-12-06 06:14:46 +00:00
Subin Tom
7529382c5a fix: Taxjar Nexus list visible only if child table is visible
(cherry picked from commit 0963fceede)
2021-12-06 06:14:45 +00:00
Saqib Ansari
635fd5e8f8 fix: conflicts 2021-12-06 11:33:37 +05:30
mergify[bot]
797b75224e fix(patch): create only component type field instead of running the whole setup (#28734) (#28735)
(cherry picked from commit 0ef42d1000)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-12-05 13:03:08 +05:30
rohitwaghchaure
ad9e45bd54 Merge pull request #28728 from frappe/mergify/bp/version-13-hotfix/pr-28710
fix: incorrect outgoing rates when material_consumption enabled (backport #28710)
2021-12-04 12:55:13 +05:30
Noah Jacob
740682ec20 test: added tests for manufacture stock entry when material_consumption is enabled
(cherry picked from commit 35346de162)
2021-12-04 07:05:15 +00:00
Noah Jacob
b59f5c2574 fix: incorrect outgoing rates when material_consumption enabled
(cherry picked from commit 7f3e6d149a)
2021-12-04 07:05:15 +00:00
Ankush Menat
35a3fbd4ed fix: weird item sorting by idx
(cherry picked from commit ba5a7ffd60)
2021-12-03 19:12:13 +05:30
Ankush Menat
c57f639ed8 fix: remove autocommit from item rename
(cherry picked from commit 5caf411be3)
2021-12-03 18:57:33 +05:30
Ankush Menat
8e19608d0f fix!: dont allow renaming warehouse primary key
(cherry picked from commit 72dbc3d6b8)
2021-12-03 18:57:33 +05:30
Ankush Menat
61eb754862 refactor: simplify the way SLEs are submitted
(cherry picked from commit cef84c25a7)
2021-12-03 18:48:22 +05:30
Ankush Menat
a9bf4ad8fa refactor: replace misleading variable name
(cherry picked from commit 97060c45e9)
2021-12-03 18:48:22 +05:30
Saqib
2a6d202061 fix: test wdv method for indian region
(cherry picked from commit 7681600b5e)
2021-12-03 11:24:46 +00:00
GangaManoj
a424f55943 fix: Test for WDV
(cherry picked from commit f047c6ffc8)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:45 +00:00
Saqib
b937c55b85 fix: reset temporary flag after use
(cherry picked from commit a261d08dd8)
2021-12-03 11:24:43 +00:00
GangaManoj
445f1b2a09 fix: Linters
(cherry picked from commit 06c505ddc2)
2021-12-03 11:24:42 +00:00
GangaManoj
f0076ca3f9 fix: Add flag for reverse depreciation entries
(cherry picked from commit cde0dae987)
2021-12-03 11:24:42 +00:00
GangaManoj
5146985a66 fix: Replace post_depreciation_entries() with make_depreciation_entry()
(cherry picked from commit 82bf5e5539)
2021-12-03 11:24:41 +00:00
GangaManoj
92ebe52432 fix: Only add additional depreciation schedule row on sale if depreciation_amount > 0
(cherry picked from commit 9e7022830e)
2021-12-03 11:24:40 +00:00
GangaManoj
595d6c31b5 fix: Add missing digit
(cherry picked from commit 0b8cb5dd47)
2021-12-03 11:24:40 +00:00
GangaManoj
c104a2a2f4 fix: Sider issues
(cherry picked from commit fdeb273fa0)
2021-12-03 11:24:39 +00:00
GangaManoj
9595f7cc3f fix: Add missing digit
(cherry picked from commit 60aae4423d)
2021-12-03 11:24:38 +00:00
GangaManoj
6657a15898 fix: Compare date strings
(cherry picked from commit 371b621364)
2021-12-03 11:24:38 +00:00
GangaManoj
db06373fa6 fix: Format tests
(cherry picked from commit e9d310a13e)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:36 +00:00
GangaManoj
a5b8b4ac41 fix: Remove PR creation from all tests in TestDepreciationBasics
(cherry picked from commit 968be70bd1)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:34 +00:00
GangaManoj
38ec9c80fc fix: Remove PR creation from all tests for Depreciation Methods
(cherry picked from commit 09215a9781)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:32 +00:00
GangaManoj
627d9633b2 fix: Move Purchase Receipt creation to setUpClass
(cherry picked from commit 4bf01bb4b7)
2021-12-03 11:24:29 +00:00
GangaManoj
511c742fd9 fix: Move test for Finance Books to Depreciation test suite
(cherry picked from commit e8986df3ca)
2021-12-03 11:24:29 +00:00
GangaManoj
026d72aff8 fix: Add test to validate available_for_use_date
(cherry picked from commit 83ec9879ee)
2021-12-03 11:24:28 +00:00
GangaManoj
0442230d98 fix: Enable cwip accounting
(cherry picked from commit 749d1b6ee6)
2021-12-03 11:24:27 +00:00
GangaManoj
e1f4672023 fix: Only validate against JV if it's not a reverse depreciation entry
(cherry picked from commit 8ea1ad9232)
2021-12-03 11:24:26 +00:00
GangaManoj
86fcc94b7a fix: Add tests to validate item
(cherry picked from commit a7ec007dcf)
2021-12-03 11:24:26 +00:00
GangaManoj
d81f4e625a fix: Add tests to validate Asset values
(cherry picked from commit d8aaf3d389)
2021-12-03 11:24:25 +00:00
GangaManoj
3cc8dd2b47 fix: Add tearDownClass()
(cherry picked from commit 4918e9533b)
2021-12-03 11:24:24 +00:00
GangaManoj
e28a7f11b7 fix: Replace setUp() with setUpClass()
(cherry picked from commit ef3f2fcb3a)
2021-12-03 11:24:24 +00:00
GangaManoj
5972acf0ec fix: Add test for depreciation on return of sold Asset
(cherry picked from commit 273fccf0dd)
2021-12-03 11:24:23 +00:00
GangaManoj
53789ae4d6 fix: Adjust depreciation_amount in final row
(cherry picked from commit adebf2d71b)
2021-12-03 11:24:22 +00:00
GangaManoj
4735162bdc fix: Unlink Depreciation Entry made on sale if the Asset is returned
(cherry picked from commit f51bd44929)
2021-12-03 11:24:21 +00:00
GangaManoj
d189ea8d37 fix: Rename tests
(cherry picked from commit 62fea8a5aa)
2021-12-03 11:24:20 +00:00
GangaManoj
ae6bac9fcb fix: Categorize into test suites
(cherry picked from commit c84c983073)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:18 +00:00
GangaManoj
94c3e0503f fix: Add tests for depreciation
(cherry picked from commit 40ec2d622b)

# Conflicts:
#	erpnext/assets/doctype/asset/test_asset.py
2021-12-03 11:24:15 +00:00
GangaManoj
7c114c0bc5 fix: Replace asset.schedules with asset.get('schedules')
(cherry picked from commit fdd9e6cc3c)
2021-12-03 11:24:13 +00:00