Gursheen Anand
657ca7ff22
feat: add field for specifying pdf name
...
(cherry picked from commit 5c2a949593 )
# Conflicts:
# erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.py
2023-09-10 06:51:57 +00:00
Gursheen Anand
2077b2cde4
fix: show letterhead and terms for AR pdf
...
(cherry picked from commit 0a9187ea42 )
2023-09-10 06:51:57 +00:00
Deepesh Garg
7ea53cc316
Merge pull request #36964 from GursheenK/test_tds_payable_monthly
...
test: TDS payable monthly report
2023-09-10 11:42:19 +05:30
Deepesh Garg
7acf732a9c
Merge pull request #36976 from frappe/mergify/bp/version-14-hotfix/pr-36898
...
fix: `company` is ambiguous (#36898 )
2023-09-10 11:41:46 +05:30
Deepesh Garg
43d9a10093
Merge pull request #36985 from deepeshgarg007/employee_loan_repayment
...
fix: Update party type for payroll payable account
2023-09-07 10:17:19 +05:30
Anand Baburajan
2ae4463b76
fix: correct asset daily depr schedule calculation [v14] ( #36991 )
...
fix: correct asset daily depr schedule calculation
2023-09-06 22:20:29 +05:30
Deepesh Garg
62569b1b41
Merge pull request #36986 from frappe/mergify/bp/version-14-hotfix/pr-36983
...
chore: Update employee for tests (backport #36983 )
2023-09-06 18:01:17 +05:30
Deepesh Garg
24a4815250
chore: Update employee for tests
...
(cherry picked from commit ae01d70b33 )
2023-09-06 11:02:18 +00:00
Deepesh Garg
1894371b68
chore: Update function
2023-09-06 16:29:12 +05:30
mergify[bot]
e210b28f0d
chore: asset finance books validation (backport #36979 ) ( #36981 )
...
* chore: asset finance books validation (#36979 )
(cherry picked from commit 0077659e93 )
* chore: fix tests
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-09-06 15:39:46 +05:30
Deepesh Garg
f251d6cb69
fix: Update party type for payroll payable account
2023-09-06 15:18:21 +05:30
mergify[bot]
4fede56d98
fix: use primary key for link lookup (backport #36919 ) ( #36978 )
...
fix: use primary key for link lookup (#36919 )
(cherry picked from commit 8ce6b8179e )
Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com >
2023-09-06 06:45:58 +00:00
Dany Robert
fe69d5364d
fix: company is ambiguous
...
(cherry picked from commit 3e1065a561 )
2023-09-06 04:58:54 +00:00
mergify[bot]
58163d5aa8
fix: ask for asset related accounts only when needed (backport #36960 ) ( #36971 )
...
fix: ask for asset related accounts only when needed (#36960 )
* fix: only ask for asset_received_but_not_billed account when needed
* chore: remove unnecessary if condition
* fix: only ask for expenses_included_in_asset_valuation account when needed
(cherry picked from commit 174f95d699 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-09-05 18:14:44 +05:30
Gursheen Anand
dbeb132688
refactor: use accounts mixin
2023-09-05 17:33:30 +05:30
mergify[bot]
e3d64fc553
fix: index error on Receivable report based on payment terms ( #36963 )
...
fix: index error on Receivable report based on payment terms
cr note's don't have payment terms. So, skip for them.
(cherry picked from commit b9c556c4a9 )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-09-05 16:32:58 +05:30
mergify[bot]
c125dea0f1
fix: ignore mandatory fields while saving WO (backport #36954 ) ( #36970 )
...
fix: ignore mandatory fields while saving WO (#36954 )
(cherry picked from commit f809e12747 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-09-05 16:29:03 +05:30
mergify[bot]
119273639c
fix: added validation for unique serial numbers in pos invoice ( #36302 )
...
fix: added validation for unique serial numbers in pos invoice (#36302 )
* fix: added validation for unique serial numbers in pos invoice
* fix: updated title of validation
* fix: removed extra whitespace
* fix: added validation for duplicate batch numbers
---------
Co-authored-by: Ritvik Sardana <ritviksardana@Ritviks-MacBook-Air.local >
(cherry picked from commit a165b37fd7 )
Co-authored-by: RitvikSardana <65544983+RitvikSardana@users.noreply.github.com >
2023-09-05 16:21:33 +05:30
Gursheen Kaur Anand
fc79af5926
fix: prorate factor for subscription plan ( #36953 )
2023-09-05 16:14:16 +05:30
Gursheen Anand
035eaa5e40
test: tds payable monthly
2023-09-05 15:24:59 +05:30
Anand Baburajan
09e2f24329
fix: allow payment_account of loan repayment to be edited ( #36948 )
2023-09-05 12:44:14 +05:30
ruthra kumar
a0c65342a1
Merge pull request #36952 from frappe/mergify/bp/version-14-hotfix/pr-36950
...
refactor: gain/loss je should use same posting date as payment (backport #36950 )
2023-09-05 09:24:10 +05:30
ruthra kumar
01eae2b758
refactor: gain/loss should use same posting date as payment
...
(cherry picked from commit f7865da4d2 )
2023-09-05 03:00:02 +00:00
ruthra kumar
b43c6ff1ae
Merge pull request #36946 from GursheenK/tds_payable_monthly_si_withholding_category
...
fix: TDS payable monthly SI withholding category
2023-09-04 19:01:00 +05:30
Gursheen Anand
18f8f7f09c
fix: remove withholding category from common fields
2023-09-04 17:30:10 +05:30
ruthra kumar
2d2bcd37cb
Merge pull request #36942 from frappe/mergify/bp/version-14-hotfix/pr-36940
...
fix: invalid gain/loss JE created on base currency Expense Claim (backport #36940 )
2023-09-04 15:20:23 +05:30
ruthra kumar
068f1b5a6b
fix: invalid gain/loss JE created on base currency Expense Claim
...
(cherry picked from commit 75d95acb23 )
2023-09-04 08:27:37 +00:00
Ankush Menat
fca154fd60
Merge pull request #36939 from frappe/mergify/bp/version-14-hotfix/pr-36869
...
fix: ignore_user_permissions set to 1 for parent field of tree doctypes (backport #36869 )
2023-09-04 13:27:13 +05:30
RitvikSardana
451cc7bc12
fix: added ignore_user_permissions to parent field of tree doctypes
...
(cherry picked from commit de433d8626 )
2023-09-04 07:17:07 +00:00
mergify[bot]
11e67c7dc0
refactor: remove Recalculate Rate from SCR Item (backport #36929 ) ( #36931 )
...
* refactor: remove `Recalculate Rate` from SCR Item (#36929 )
(cherry picked from commit cd8ddae7c5 )
# Conflicts:
# erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.js
# erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
# erpnext/subcontracting/doctype/subcontracting_receipt_item/subcontracting_receipt_item.json
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-09-03 19:05:05 +05:30
mergify[bot]
5c8bee0a95
fix: when create doc from item dashboard default uom (buying or selling) is not correctly selected (backport #36892 ) ( #36928 )
...
fix: when create doc from item dashboard default uom (buying or selling) is not correctly selected (#36892 )
fix: when create doc from item dashboard defaut uom is not correctly selected
(cherry picked from commit 24e1144de5 )
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro >
2023-09-03 16:38:44 +05:30
ruthra kumar
553ff11de6
Merge pull request #36925 from frappe/mergify/bp/version-14-hotfix/pr-36911
...
fix: deduplicate gain/loss JE creation for journals as payment (backport #36911 )
2023-09-03 10:56:36 +05:30
ruthra kumar
5523bc5081
chore: resolve merge conflict
2023-09-03 10:28:58 +05:30
ruthra kumar
c8d81cc52d
test: cost center inheritance from payment
...
(cherry picked from commit 0366928db5 )
2023-09-03 04:44:17 +00:00
ruthra kumar
d24c8b1bbc
refactor: use payment's CC for gain/loss if company default is unset
...
(cherry picked from commit d6a3b9a5c7 )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
2023-09-03 04:44:16 +00:00
ruthra kumar
7fd96d0116
test: extend test to cancellation
...
(cherry picked from commit 79fa562004 )
2023-09-03 04:44:15 +00:00
ruthra kumar
475750302b
test: deduplicate gain/loss JE on reconciling journals against inv
...
(cherry picked from commit cb6da6ec59 )
2023-09-03 04:44:14 +00:00
ruthra kumar
9168b3b0e8
fix: deduplicate gain/loss JE creation for journals as payment
...
(cherry picked from commit 79c6f0165b )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2023-09-03 04:44:13 +00:00
Anand Baburajan
0ff1546b9b
chore: patch to correct asset values if je has workflow [v14] ( #36915 )
...
chore: patch to correct asset values if je has workflow
2023-09-02 18:32:16 +05:30
mergify[bot]
345c6084e5
feat(RFQ): optionally send document print ( #36363 )
...
feat(RFQ): optionally send document print (#36363 )
2023-09-02 17:53:08 +05:30
Deepesh Garg
3820953022
Merge pull request #36917 from frappe/mergify/bp/version-14-hotfix/pr-36900
...
fix: reduce threshold for background job in PCV (#36900 )
2023-09-02 17:46:44 +05:30
Deepesh Garg
78051e7f0f
Merge pull request #36918 from frappe/mergify/bp/version-14-hotfix/pr-36908
...
fix: only show "Unreconcile" if reconciled (#36908 )
2023-09-02 17:46:27 +05:30
barredterra
61752ac2b4
fix: only show "Unreconcile" if reconciled
...
(cherry picked from commit 91e574609f )
2023-09-02 11:43:12 +00:00
Gursheen Anand
5a226a8395
fix: reduce threshold for bg job fn
...
(cherry picked from commit b6e6f2ef8d )
2023-09-02 11:42:08 +00:00
ruthra kumar
543e4c87ea
Merge pull request #36912 from frappe/mergify/bp/version-14-hotfix/pr-36859
...
fix: account payable currency and value (backport #36859 )
2023-09-02 14:38:27 +05:30
Deepesh Garg
0a0b94e1cb
Merge pull request #36884 from Nihantra-Patel/fiscal_year_trends_reports
...
fix: Set the default filter in All Trends Report
2023-09-02 14:37:14 +05:30
RitvikSardana
98c26403c1
fix: account payable currency and value ( #36859 )
...
* fix: account payable currency and value
* fix: added party_type and party in accounts payable report
* chore: code cleanup
* fix: customer group test case failure
* fix: added test case of the issue
* fix: filter toggle for party_type
* fix: filter toggle for party_type
* chore: fix typo
---------
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
(cherry picked from commit e599f75a51 )
2023-09-02 07:39:33 +00:00
Deepesh Garg
d19716142e
Merge pull request #36904 from frappe/mergify/bp/version-14-hotfix/pr-36889
...
fix: fetch currency in discount accounting SI (#36889 )
2023-09-01 22:51:35 +05:30
ruthra kumar
83e3402fea
Merge pull request #36907 from frappe/mergify/bp/version-14-hotfix/pr-36899
...
fix: difference amount calculation logic in Payment Entry UI (backport #36899 )
2023-09-01 17:50:22 +05:30
ruthra kumar
9bc2b419e3
fix: difference amount in UI should not be calculated
...
(cherry picked from commit a7e0709ae8 )
2023-09-01 12:09:21 +00:00