* fix: account group totals calculation to consider include_in_gross
(cherry picked from commit 8dcb9302b4)
* refactor: remove unused parameters
(cherry picked from commit 50822f207e)
* refactor: merge separate loops for calculating group / leaf node totals
rename function
remove return statement as the list is mutated
(cherry picked from commit 1a3b9c5bdf)
* fix: add total col for gross and net profit
(cherry picked from commit cb9b4fbb91)
---------
Co-authored-by: Anoop Kurungadam <anoop@earthianslive.com>
Getting error while clicking create sales order button from quotation
Taceback (most recent call last):
File "apps/frappe/frappe/app.py", line 66, in application
response = frappe.api.handle()
File "apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "apps/frappe/frappe/handler.py", line 45, in handle
data = execute_cmd(cmd)
File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "apps/frappe/frappe/__init__.py", line 1607, in call
return fn(*args, **newargs)
File "apps/frappe/frappe/model/mapper.py", line 36, in make_mapped_doc
return method(source_name)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 263, in make_sales_order
return _make_sales_order(source_name, target_doc)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 333, in _make_sales_order
doclist = get_mapped_doc(
File "apps/frappe/frappe/model/mapper.py", line 144, in get_mapped_doc
postprocess(source_doc, target_doc)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 291, in set_missing_values
for d in customer.get("sales_team"):
TypeError: 'NoneType' object is not iterable
* fix: depreciation schedule for existing assets
* chore: correct logic for existing assets and fix test
* chore: properly check if depr amount is non zero
Two purchase invoices for the same supplier, using different tax
withholding categories have this issue.
| Category | single | cumulative |
|----------+--------+------------|
| cat1 | 100 | 500 |
| cat2 | 1000 | 5000 |
1. PINV1 of net total: 105/- uses cat1. TDS is calculated as it
breached single threshold
2. PINV2 of net total: 200/- uses cat2. TDS incorrectly calculated as
PINV1 already has TDS calculated and 'consider_party_ledger_amount' is enabled.
