Maharshi Patel
42b395916d
fix: f-string and where clause
...
Used f-string formatting and added conditions to WHERE clause
2022-08-09 18:22:05 +05:30
Maharshi Patel
6c574fbf33
fix: taxable_value and gst_account_heads
...
used taxable_value instead of base_net_amount and only appended required GST accounts
2022-08-09 14:39:13 +05:30
Maharshi Patel
08c69c7a76
fix: (india) HSN wise report
...
Problem:
The previous approach for calculating tax_rate was incorrect.
```
['tax_rate'] * ['number of unique rows']
```
Joining `tabSales Taxes and Charges` was adding unnecessary rows & complexity.
Solution:
Instead of trying to get tax_rate from the main query itself, I used the get_tax_accounts's data to calculate the correct tax_rate.
Todo:
Union Territory
2022-07-29 14:22:31 +05:30
Deepesh Garg
25da4d28ff
Merge pull request #31727 from frappe/mergify/bp/version-13-hotfix/pr-31656
...
fix: use current pos profile on sales return (backport #31656 )
2022-07-28 16:32:36 +05:30
Deepesh Garg
f57d2fadbc
Merge pull request #31728 from frappe/mergify/bp/version-13-hotfix/pr-31676
...
fix: enable tax withholding checkbox in PI with supplier_tds (backport #31676 )
2022-07-28 16:32:17 +05:30
Deepesh Garg
9e7edd677a
Merge pull request #31726 from frappe/mergify/bp/version-13-hotfix/pr-31576
...
fix: credite note for returned delivery note updates SO's billed percentage (backport #31576 )
2022-07-28 16:32:05 +05:30
ruthra kumar
bc7494278d
fix: enable tax withholding checkbox in PI with supplier_tds
...
(cherry picked from commit b461724416 )
2022-07-28 10:42:58 +00:00
ruthra kumar
c442b4aef1
fix: use current pos profile on sales return
...
(cherry picked from commit 5b85af5f1a )
2022-07-28 10:36:23 +00:00
ruthra kumar
ef9b25cf08
test: SO percentage billed when cr_note made against delivery return
...
(cherry picked from commit 243f66fcd3 )
2022-07-28 10:21:19 +00:00
ruthra kumar
2f2d3de306
fix: update SO's percentage billed on credit note
...
Credit Note created from Sales Return will update precentage billed in
Sales Order accordingly
(cherry picked from commit 04c1019242 )
2022-07-28 10:21:18 +00:00
Rucha Mahabal
13639682ce
Merge pull request #31724 from ruchamahabal/expense-claim-adv
2022-07-28 14:51:15 +05:30
Rucha Mahabal
c01adae8a5
test: advance amount allocation against expense claim with taxes
2022-07-28 14:27:09 +05:30
Deepesh Garg
8ae691d9dc
Merge branch 'version-13' into version-13-hotfix
2022-07-28 13:59:25 +05:30
Alaa Alsalehi
a95c011a93
fix: Reload loan Table in Salary Slip when change Employee ( #31525 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
Co-authored-by: bahaaabed <bahaa.9999.sh@gmail.com >
Co-authored-by: newhr1 <104132586+newhr1@users.noreply.github.com >
2022-07-28 13:22:07 +05:30
Rucha Mahabal
42f3592e95
fix: Allow allocating advance amount against Expense Claim taxes
2022-07-28 13:21:29 +05:30
Syed Mujeer Hashmi
0602848caa
fix: The Fee details are not fetched in Program Enrollment ( #31153 )
2022-07-28 12:30:39 +05:30
Rucha Mahabal
9985d28571
chore: Add HR & Payroll deprecation warning ( #31720 )
2022-07-28 11:43:49 +05:30
Marica
31824c2280
Merge pull request #31716 from frappe/mergify/bp/version-13-hotfix/pr-31687
...
fix: update fr translations (backport #31687 )
2022-07-27 18:01:30 +05:30
marination
6fbb06a878
chore: Merge Conflict
2022-07-27 17:30:46 +05:30
HENRY Florian
89348c1bb4
fix: update fr translations ( #31687 )
...
* fix: update fr translations
* fix: update fr translation
* fix: update fr translation
* chore: Replace apostrophe encoding by symbol
Co-authored-by: marination <maricadsouza221197@gmail.com >
(cherry picked from commit cc1f837685 )
# Conflicts:
# erpnext/translations/fr.csv
2022-07-27 11:52:03 +00:00
Marica
598dbc93ac
Merge pull request #31669 from frappe/mergify/bp/version-13-hotfix/pr-31579
...
fix: display customer name on picking list (backport #31579 )
2022-07-27 16:45:07 +05:30
Marica
51a4ef3069
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-31579
2022-07-27 16:23:22 +05:30
Marica
49fb177f86
chore: Merge Conflicts
2022-07-27 16:22:17 +05:30
Marica
b0aae8a297
Merge pull request #31713 from frappe/mergify/bp/version-13-hotfix/pr-31469
...
chore: Make `image` field obsolete in Website Item (redundant) (backport #31469 )
2022-07-27 16:12:32 +05:30
Marica
e310347ca4
chore: Merge Conflicts
2022-07-27 15:51:01 +05:30
marination
9b1544aa14
fix: Map Item image to Website Item website_image only if published via UI (v13)
...
- For v12 Items, `website_image` should be mapped from `Item` to `Website Item`
(cherry picked from commit af38baeb3b )
# Conflicts:
# erpnext/e_commerce/doctype/website_item/website_item.py
2022-07-27 10:14:20 +00:00
marination
a8da5f4566
chore: Remove image use in website item list
...
(cherry picked from commit 7a6ee8cf2d )
2022-07-27 10:14:18 +00:00
marination
0e469f6d95
chore: Remove image from ProductQuery fields
...
(cherry picked from commit eec07833f4 )
2022-07-27 10:14:18 +00:00
marination
b393c230bd
chore: Make image field obsolete in Website Item (redundant)
...
- Delete Image field and set `website_image` as form's image field for uploads
- Remove instances of `image` field access via Website Item
- Item -> Web Item via Desk: Map Item's `image` to Web Item's `website_image`
- Item -> Web Item via patch: `website_image` will be mapped with thumbnail
- Remove magic that auto-sets `website_image` from `image` in Website Item
(cherry picked from commit 9541354ec7 )
# Conflicts:
# erpnext/e_commerce/doctype/website_item/website_item.py
2022-07-27 10:14:16 +00:00
Rucha Mahabal
32c1bb61de
fix: manually generated salary slips overwritten by structure amount ( #31711 )
2022-07-27 12:44:26 +05:30
MohsinAli
4f023757de
fix: payment entry to student ( #31708 )
...
Payment entry to student via Payment References(From Journal Entry)
2022-07-27 11:50:15 +05:30
Deepesh Garg
d2d25e17bb
Merge pull request #31698 from maharshivpatel/fix-einvoice-margin-internal-transfer
...
fix: (india) (e-invoice) margin & internal company transfer
2022-07-26 21:59:44 +05:30
Maharshi Patel
a843e784e6
fix: discount and test added
...
only report net rate if discount is less than 0 and added test.
2022-07-26 17:40:59 +05:30
Rucha Mahabal
8a6432ec3f
fix: hero image not loading in portal homepage ( #31699 )
2022-07-26 13:43:36 +05:30
Maharshi Patel
b97d30aad0
fix: (india) (e-invoice) margin & internal company transfer
...
When the item price is more than the price list rate ( margin added ) discount value becomes negative. The previous attempt to solve this was to convert discount to absolute value. However, that gives incorrect unit price and discount value. To solve this, I have made changes to report net rates in cases where the margin is added or is an internal company transfer.
2022-07-26 12:57:47 +05:30
Rucha Mahabal
bc7cfe6919
fix: do not update component amount for timesheet components ( #31696 )
...
* fix: do not update component amount for timesheet components
* fix: warn the user about overwriting timesheet component amount
2022-07-26 12:35:50 +05:30
Deepesh Garg
85802b0f97
Merge pull request #31602 from rtdany10/patch-19
...
fix(india): e-way bill json for unregistered gst category
2022-07-22 13:11:19 +05:30
Deepesh Garg
dc67d39ce6
Merge pull request #31665 from maharshivpatel/fix-add-overseas-hsn-report
...
fix: (india) add entries from overseas invoices in HSN wise report
2022-07-22 13:06:30 +05:30
mergify[bot]
529a47bc88
fix: rounding errors while closing pos (backport #31654 ) ( #31658 )
2022-07-22 11:17:59 +05:30
Devin Slauenwhite
2381b81aac
fix: make customer_name field read only.
...
(cherry picked from commit 7083b3148b )
# Conflicts:
# erpnext/stock/doctype/pick_list/pick_list.json
2022-07-21 13:08:41 +00:00
Devin Slauenwhite
dbf245c687
fix: display customer name on picking list
...
(cherry picked from commit 0a633a212d )
# Conflicts:
# erpnext/stock/doctype/pick_list/pick_list.json
2022-07-21 13:08:40 +00:00
Nihantra C. Patel
5cdc267aee
fix: Route condition set with proper filter ( #31556 )
...
* fix: Redirect to report with proper filter
* Update member.js
* fix: Route condition set with proper filter
* fix: Route condition set with proper filter
* fix: Route condition set with proper filter
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2022-07-21 18:29:06 +05:30
mergify[bot]
95e1021caf
fix: update fr translations (backport #31526 ) ( #31666 )
...
fix: update fr translations (#31526 )
* fix: update fr translations
* fix: update fr translations
* fix: update fr translations
* fix: update fr translations
* chore: Update french translation
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit 3ba0d6cc5c )
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro >
2022-07-21 18:11:32 +05:30
mergify[bot]
7d50f8798a
Update de.csv (backport #31596 ) ( #31667 )
...
Update de.csv (#31596 )
IN,IM to IN,EIN
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit 8629d01dd5 )
Co-authored-by: billy995 <48571007+billy995@users.noreply.github.com >
2022-07-21 18:10:46 +05:30
Marica
dd751c6e92
Merge pull request #31664 from frappe/mergify/bp/version-13-hotfix/pr-31544
...
FIX: quality inspection quick creation from purchase receipt: pre-fill sample size if available (backport #31544 )
2022-07-21 14:13:48 +05:30
Frappe PR Bot
69087b8790
chore(release): Bumped to Version 13.36.1
...
## [13.36.1](https://github.com/frappe/erpnext/compare/v13.36.0...v13.36.1 ) (2022-07-21)
### Bug Fixes
* ensure defaults removed in bad frappe patch get set again (backport [#31659 ](https://github.com/frappe/erpnext/issues/31659 )) ([2ae3bd9 ](2ae3bd9fed ))
v13.36.1
2022-07-21 08:26:20 +00:00
mergify[bot]
763787b0a5
fix: ensure defaults removed in bad frappe patch get set again (backport #31659 ) ( #31661 )
...
fix: ensure defaults removed in bad frappe patch get set again (#31659 )
(cherry picked from commit bf2833b8ee )
Co-authored-by: Sagar Vora <sagar@resilient.tech >
2022-07-21 13:54:55 +05:30
mergify[bot]
2ae3bd9fed
fix: ensure defaults removed in bad frappe patch get set again (backport #31659 )
...
fix: ensure defaults removed in bad frappe patch get set again (#31659 )
(cherry picked from commit bf2833b8ee )
(cherry picked from commit 9071018e4e )
Co-authored-by: Sagar Vora <sagar@resilient.tech >
2022-07-21 13:54:40 +05:30
Marc de Lima Lucio
1998223ee3
FIX: quality inspection quick creation from purchase receipt: pre-fill sample size if available ( #31544 )
...
FIX: quality inspection quick creation from transaction documents: pre-fill sample size if available
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit 048c037842 )
2022-07-21 08:17:48 +00:00
mergify[bot]
794fd0819f
fix: correct Brazilian portuguese translations (backport #31498 ) ( #31660 )
...
fix: correct Brazilian portuguese translations (#31498 )
* fix brazilian portuguese translations
* minor adjustments
* fix minor adjustments
* fix: remove legacy pt_br.csv
* chore: Fix translation quotation marks
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit d30f8387d9 )
Co-authored-by: Marco Fonseca <62901164+treasuryesc@users.noreply.github.com >
2022-07-21 13:47:18 +05:30