Commit Graph

31719 Commits

Author SHA1 Message Date
rohitwaghchaure
2eb452f3bb Merge pull request #22458 from scmmishra/fix-email-digest-so-company
fix: add company filter in email digest
2020-06-25 23:18:38 +05:30
rohitwaghchaure
6cf568d094 Merge pull request #22462 from marination/production-plan-ux
fix: Handling Empty tables in Production Plan
2020-06-25 23:15:28 +05:30
rohitwaghchaure
5414e2c306 Merge pull request #22463 from frappe/michellealva-fiscal_year
fix: grammatical fix on error message
2020-06-25 23:11:36 +05:30
Michelle Alva
978722621f fix: grammatical fix on error message
Before:

Fiscal Year: 2020 does not exists

After:

Fiscal Year 2020 Does Not Exist
2020-06-25 22:35:33 +05:30
marination
c8f590bc8f fix: Handling Empty tables in Production Plan 2020-06-25 21:30:45 +05:30
Shivam Mishra
5374e7ae1f fix: add company filter in email digest 2020-06-25 19:41:42 +05:30
Saqib
40847aeac3 fix: cannot cancel assets with repair pending (#22440)
* fix: cannot cancel assets with repair pending

* fix: message

* Update asset.py

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2020-06-25 15:43:31 +05:30
Deepesh Garg
8a55ec1580 fix: Add view ledger button for cancelled docs (#22432)
* fix: Add view ledger button for cancelled docs

* fix: Add moddified to date in Stock Ledger
2020-06-25 15:34:01 +05:30
Sun Howwrongbum
ecff8f9582 fix: UnboundLocalError when setting product_info (#22436)
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2020-06-25 14:25:53 +05:30
Rucha Mahabal
7b3700b3ec fix: handle custom statuses for the pause SLA configuration (#22349)
* fix: handle hold time for custom statuses

* fix: set total hold time only if hold configurations are enabled

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
2020-06-25 13:29:14 +05:30
Shivam Mishra
53346217d2 Revert "feat: added search to support page (#22376)" (#22431)
This reverts commit 3ab8d865dd.
2020-06-25 11:12:09 +05:30
Deepesh Garg
fdc276bb0e Merge pull request #22434 from frappe/michellealva-patch-4-1
fix: change error messages in RFQ
2020-06-25 09:17:36 +05:30
Michelle Alva
da0385cd39 fix: change error messages in RFQ
Before:
1. Row {0}: For supplier {0} Email Address is required to send email
2. Email sent to supplier
3. Request for Quotation is disabled to access from portal, for more check portal settings.
4. Supplier Quotation created.


After:
1. Row {0}: For Supplier {0} Email Address is Required to Send Email
2. Email sent to Supplier
3. The Access to Request for Quotation From Portal is Disabled. To Allow Access, Enable it in Portal Settings.
4. Supplier Quotation Created.
2020-06-25 08:24:01 +05:30
Marica
ba334cbfa5 Merge pull request #22430 from frappe/clarkejj-patch-1
fix: stock_ageing.py report SyntaxError: can’t assign to function call
2020-06-24 21:24:44 +05:30
John Clarke
6fd1068af3 Update stock_ageing.py 2020-06-24 07:31:21 -06:00
Deepesh Garg
06a37660ae Merge pull request #22421 from deepeshgarg007/update_jv_account_timestamp
fix: Update journal entry accounts times stamp
2020-06-24 17:56:51 +05:30
Deepesh Garg
2abd66da9d fix: Update journal entry account timesstamp 2020-06-24 17:49:50 +05:30
Anupam Kumar
10c7faf090 updating education report modified time (#22418)
Co-authored-by: Anurag Mishra <32095923+Anurag810@users.noreply.github.com>
2020-06-24 17:34:52 +05:30
Shivam Mishra
3ab8d865dd feat: added search to support page (#22376)
* feat: added search to support page

* style: add styles in style block
2020-06-24 15:50:06 +05:30
rohitwaghchaure
a50c95c959 Merge pull request #22223 from deepeshgarg007/grn_posting
feat: Accounting entries for service item in Purchase receipt
2020-06-24 11:00:19 +05:30
rohitwaghchaure
c4382abc03 Merge pull request #22410 from kennethsequeira/item_report_date
fix: add error prompt for wrong date range
2020-06-24 10:49:21 +05:30
rohitwaghchaure
d63c59ced4 Merge branch 'develop' into grn_posting 2020-06-24 10:23:23 +05:30
Marica
7af7bb8311 fix: Insert Supplier Group via List View (#22403) 2020-06-23 17:51:02 +05:30
Rohan
9c25101d9b feat: add ability for a contract to be authorised internally (#22095)
* Added ability for a contract to be signed by a company user before being sent out

* feat: contract signed by stays even after reload (#402)

* format: use new JSON format

Co-authored-by: Neil Lasrado <neil@digithinkit.com>
Co-authored-by: nehasacher143 <45919049+nehasacher143@users.noreply.github.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2020-06-23 17:39:37 +05:30
Kenneth Sequeira
f5b7bd9dcb fix: add error prompt for wrong date range 2020-06-23 16:55:35 +05:30
Anurag Mishra
ecbfda7d6a fix: typo in template(#22401) 2020-06-23 14:33:49 +05:30
Anoop
5e16ca0326 fix: Login page doesn't load for new sites (#22388)
* fix: Login page doesn't load for new sites

Login page broken as active domains are not set for new sites

* Update footer_powered.html

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2020-06-23 11:11:13 +05:30
Anurag Mishra
101d15f2f8 fix: not working without from_amount and percentage_deduction (#22380) 2020-06-23 10:45:54 +05:30
Anurag Mishra
36560c8406 fix: staffing Plan validation (#22379) 2020-06-23 10:44:33 +05:30
mergify[bot]
ca8894b0fc fix: alternative item not working for subcontract (#22386)
(cherry picked from commit 171699537c)

Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
2020-06-23 10:42:32 +05:30
Marica
3dee5273d6 fix: Update Packed Items via Update Items in SO (#22392) 2020-06-23 10:33:47 +05:30
Marica
bd5c8573de fix: Unable to create batched Item (#22393) 2020-06-23 10:32:51 +05:30
Deepesh Garg
7cc1cf36ca feat: More controlled deferred revenue booking (#21671)
* feat: More controller deferred revenue booking

* fix: Query for last gl entry

* fix: Accounting Dimension for Deferred entries

* fix: Deferred revenue booking against paid invoices

* fix: Don not update outstanding on Deferred Entry submission

* fix: Naming fixes

* feat: Deferred revenue/expense booking based on months

* fix: Test case for fix monthly deferred revenue booking

* fix: Typo

* fix: Patch to update settings

* fix: Test case to book deferred expense via journal entry

* fix: Update field for better UX

* fix: Codacy

* fix: Change select field to checkbox
2020-06-23 09:57:56 +05:30
Deepesh Garg
3c25308b27 Merge pull request #21997 from totolouis/patch-1
fix: translation from HTML code to apostrophe
2020-06-22 21:43:38 +05:30
Suraj Shetty
c753502412 Merge branch 'develop' into patch-1 2020-06-22 21:41:31 +05:30
rohitwaghchaure
b658a010f1 Merge pull request #22383 from frappe/mergify/bp/develop/pr-22330
fix(pricing_rule): apply_on logic dont get cleanup (bp #22330)
2020-06-22 21:08:55 +05:30
Deepesh Garg
49f51f4132 Merge pull request #22346 from AfshanKhan/ISS_20_21_02455
fix: set row_id by default as previous row for On Previous Row Amount and On Previous Row Total
2020-06-22 20:53:23 +05:30
Rohit Waghchaure
aaed3b988f added validation and clear fields for Apply Rule On Other
(cherry picked from commit ebbbc85fc0)
2020-06-22 14:52:30 +00:00
Poranut Chollavorn
e3973a4730 fix(pricing_rule): apply_on logic dont get cleanup
(cherry picked from commit acf399c4e0)
2020-06-22 14:52:29 +00:00
Deepesh Garg
5dc175f068 fix(Immutable Ledger): Item wise backdated stock entry posting (#22366)
* fix(Immutable Ledger): Item wise backdated stock entry posting

* fix: Remove fiscal year query

* fix: Update message string
2020-06-22 19:05:39 +05:30
Deepesh Garg
c914d1b8e8 Merge branch 'develop' into ISS_20_21_02455 2020-06-22 18:46:58 +05:30
Anupam Kumar
71da90034d fix: resetting lost reason in opportunity and quotation (#22378) 2020-06-22 18:27:14 +05:30
Deepesh Garg
be4fc1a78e fix(UX): Notify user of expense account change in Purchase Invoice (#22193) 2020-06-22 18:03:11 +05:30
Anurag Mishra
7672166ce3 fix: Wrong filter (#22375) 2020-06-22 17:22:05 +05:30
Anurag Mishra
0093b3b27c fix: label (#22377) 2020-06-22 17:21:01 +05:30
Deepesh Garg
0252cb6789 Merge pull request #22374 from deepeshgarg007/employee_advance_cancel
fix: Unable to cancel employee advance
2020-06-22 14:55:21 +05:30
Deepesh Garg
62897d3878 fix: Unable to cancel employee advance 2020-06-22 14:54:01 +05:30
Anurag Mishra
8ffb9f852f fix: patch check_is_income_tax_component (#22371) 2020-06-22 12:17:29 +05:30
rohitwaghchaure
39a7516252 Merge pull request #22241 from deepeshgarg007/cost_center_fix
fix: Minor fixes in cost center
2020-06-22 11:21:14 +05:30
Alvaro
43be163b32 feat: Enabled translation on html files in LMS [Proposal] (#21582)
* :fix:  translation fix for html files in LMS

* fix: typo in translation

* Update content.html

* Update content.html

* Update profile.html

Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2020-06-22 11:06:12 +05:30