Suraj Shetty
23a441252b
fix: Replace walrus operator
2022-08-22 09:49:15 +05:30
Suraj Shetty
89f889068e
style: Fix formatting
2022-08-20 14:19:15 +05:30
Suraj Shetty
9263d5ff4d
fix: Update received_by if "to" is changed
2022-08-20 14:15:54 +05:30
Suraj Shetty
4df197a282
test: Do not overwrite frappe.form_dict to retain proxy reference
...
Set frappe.local.form_dict instead
2022-08-20 14:14:16 +05:30
Suraj Shetty
b495969eb8
test: Clean up form_dict
...
To avoid failures like
https://github.com/frappe/erpnext/runs/5887687369?check_suite_focus=true#step:12:783
2022-08-20 14:14:10 +05:30
Suraj Shetty
5f4760985c
test: Fix used frappe._dict to avoid AttributeError down the line
...
ref: https://github.com/frappe/erpnext/runs/5816574721?check_suite_focus=true#step:12:880
2022-08-20 14:14:03 +05:30
Suraj Shetty
4a61840e39
test: Use FrappeAPITestCase to track coverage
2022-08-20 14:13:56 +05:30
Suraj Shetty
ca48b9de54
test: Fix erroneous code
2022-08-20 14:13:50 +05:30
Suraj Shetty
baab96d02c
fix: Handle exception where no employee is returned
2022-08-20 14:13:40 +05:30
Suraj Shetty
f5b967a947
chore: Remove unused code
...
- and simplify get_call_log
2022-08-20 14:13:24 +05:30
Suraj Shetty
06b1bcbf59
test: Refactor exotel test setup
...
- Remove unnecessary code
- Move test data to separate file
- Make proper test assertions
2022-08-20 14:12:17 +05:30
Subin Tom
aa8a063103
fix: added tests
2022-08-20 14:11:48 +05:30
Subin Tom
3f46b2a0ce
fix: used get_employees_with_number, strip_number methods
2022-08-20 14:10:18 +05:30
Subin Tom
b52962751c
fix: linter, sider fixes
2022-08-20 14:07:17 +05:30
Subin Tom
b94154f00a
fix: call type doctype, fixes
2022-08-20 14:06:52 +05:30
Subin Tom
90ed14a055
fix: sider fixes
2022-08-20 14:05:49 +05:30
Subin Tom
b65bce8f98
fix: added type of call select field, additional status for agent rejecting call
2022-08-20 14:05:27 +05:30
Subin Tom
66578a58cf
fix: added field to show called group, user_id
2022-08-20 14:04:01 +05:30
Subin Tom
476ded2972
fix: added employee name to call log
2022-08-20 14:03:40 +05:30
Subin Tom
ffb1196516
fix: call status fix
2022-08-20 14:03:14 +05:30
Rucha Mahabal
2471ca58ee
Merge pull request #31884 from ruchamahabal/fix-promotion
2022-08-18 12:29:31 +05:30
Rucha Mahabal
a4828407d0
fix: interview rescheduling not working
2022-08-18 12:02:32 +05:30
Rucha Mahabal
36130c6292
fix(minor): save the employee doc on promotion/transfer update
2022-08-18 11:42:29 +05:30
mergify[bot]
4775c42593
fix: Make expense account editable in Purchase Receipt Item (backport #31730 ) ( #31879 )
...
* fix: Make expense account editable in Purchase Receipt Item (#31730 )
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
(cherry picked from commit 1a6508972e )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
* chore: conflicts
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-18 11:15:26 +05:30
mergify[bot]
b0917aaf8a
fix: Transit filter for Default Target Warehouse in SE (backport #31839 ) ( #31874 )
...
fix: Transit filter for Default Target Warehouse in SE (#31839 )
(cherry picked from commit f1a612245c )
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 17:25:31 +05:30
rohitwaghchaure
d349a337e1
Merge pull request #31866 from frappe/mergify/bp/version-13-hotfix/pr-31863
...
fix: not able to issue expired batches (backport #31863 )
2022-08-17 15:43:22 +05:30
rohitwaghchaure
41b8563b7a
fix: conflicts
2022-08-17 14:47:47 +05:30
Rohit Waghchaure
7ee75ff762
fix: not able to issue expired batches
...
(cherry picked from commit 795c94384a )
# Conflicts:
# erpnext/stock/doctype/stock_entry/test_stock_entry.py
2022-08-17 09:16:37 +00:00
mergify[bot]
3274e7681d
fix: incorrect rate in BOM exploded items (backport #31513 ) ( #31865 )
...
* fix: incorrect rate in BOM exploded items (#31513 )
(cherry picked from commit 313625c349 )
# Conflicts:
# erpnext/manufacturing/doctype/bom_item/bom_item.json
* chore: conflicts
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 14:39:15 +05:30
mergify[bot]
7ddb332f47
fix: incorrect produced-qty in production-plan-item (backport #31706 ) ( #31862 )
...
fix: incorrect produced-qty in production-plan-item (#31706 )
(cherry picked from commit 538cd6fdcf )
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 13:49:51 +05:30
mergify[bot]
2a615af00a
fix: contact search in request for quotation (backport #31828 ) ( #31841 )
...
* fix: contact search in request for quotation (#31828 )
(cherry picked from commit e5e88bb9f1 )
# Conflicts:
# erpnext/buying/doctype/request_for_quotation/request_for_quotation.py
* chore: conflicts
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 11:23:24 +05:30
mergify[bot]
ba8dc8925f
fix: check item_code in all rows of po_items (backport #31741 ) ( #31843 )
...
fix: check item_code in all rows of po_items (#31741 )
fix: check item-code in each row of po-items
(cherry picked from commit 0047e18a9b )
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 11:21:47 +05:30
Sagar Vora
14891ccf18
Merge pull request #31792 from frappe/mergify/bp/version-13-hotfix/pr-31733
...
fix: set `billing_address` for purchases in `get_party_details` (backport #31733 )
2022-08-16 05:48:48 +00:00
Sagar Vora
15654aae8b
fix: use old style for _dict.update
2022-08-13 08:00:27 +00:00
Sagar Vora
d1de4b027c
fix: set company_address for purchases in party.js
...
(cherry picked from commit d05082987f )
2022-08-13 08:00:27 +00:00
Sagar Vora
a7d66fa352
fix: set billing_address for purchases in get_party_details
...
(cherry picked from commit a3625b3817 )
2022-08-13 08:00:27 +00:00
Deepesh Garg
0569f8a857
Merge pull request #31736 from maharshivpatel/fix-india-hsn-report
...
fix: (india) HSN wise report
2022-08-09 18:58:25 +05:30
Rucha Mahabal
63715bf229
Merge pull request #31813 from ruchamahabal/fix-claim
2022-08-09 18:52:22 +05:30
Rucha Mahabal
63cd4349a6
fix: consider precision while validating advance amount against sanctioned amount
2022-08-09 18:28:19 +05:30
Maharshi Patel
42b395916d
fix: f-string and where clause
...
Used f-string formatting and added conditions to WHERE clause
2022-08-09 18:22:05 +05:30
Rucha Mahabal
0057c10a7d
fix: update To Date in Employee Work History ( #31811 )
2022-08-09 18:19:09 +05:30
Deepesh Garg
3c8c5d01fb
Merge pull request #31797 from frappe/mergify/bp/version-13-hotfix/pr-31779
...
Bug add accouting dimension in asset repair (backport #31779 )
2022-08-09 18:18:42 +05:30
Rucha Mahabal
d820757359
fix: Payment Entry button is visible even when claim is fully paid
2022-08-09 18:15:41 +05:30
mergify[bot]
14e59c86aa
Tds report (backport #31801 ) ( #31808 )
...
* fix: TDS Computation Summary Report not loading, too many values to unpack
2022-08-09 18:11:13 +05:30
Deepesh Garg
9e16f4e412
chore: resolve conflicts
2022-08-09 17:55:02 +05:30
rohitwaghchaure
6d269a4d89
Merge pull request #31805 from frappe/mergify/bp/version-13-hotfix/pr-31804
...
fix: incorrect incoming rate set for inter transfer purchase receipt (backport #31804 )
2022-08-09 16:26:34 +05:30
Rohit Waghchaure
4e8b39ab3f
fix: incorrect incoming rate set for inter transfer purchase receipt
...
(cherry picked from commit ddd24ea8c8 )
2022-08-09 10:31:14 +00:00
Rucha Mahabal
9925eb9982
Merge pull request #31802 from ruchamahabal/fix-salary-slip-tds-v13
2022-08-09 15:33:54 +05:30
Rucha Mahabal
301d199ece
test: default amount in slip
2022-08-09 14:57:10 +05:30
Maharshi Patel
6c574fbf33
fix: taxable_value and gst_account_heads
...
used taxable_value instead of base_net_amount and only appended required GST accounts
2022-08-09 14:39:13 +05:30