Nabin Hait
0bcafa1fde
fix: use full refresh instead of refresh_fields for multi currency
...
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-06-19 23:16:27 +05:30
Nabin Hait
f24ea74ef8
refactor: simplify Journal Entry client script
...
- Replace the JournalEntry controller class and cur_frm.cscript free
functions with frappe.ui.form.on event blocks plus a namespaced
erpnext.journal_entry helper object
- Drop deprecated APIs: cur_frm/script_manager, add_fetch, $.each and var
- Move the bank_account -> account fetch to fetch_from on the
Journal Entry Account "account" field
- Keep totals/difference and company-currency conversion on the client
(cheap, race-free); call the server only to fetch exchange rates
- get_balance now computes its own difference instead of trusting the
client-sent value, with a regression test
2026-06-19 16:34:31 +05:30
Khushi Rawat
bda7a8ced2
Merge pull request #54570 from khushi8112/item-opening-stock-dialog
...
feat: add opening stock dialog for stock items
2026-06-18 11:28:08 +05:30
khushi8112
e57593fcf8
fix(item): add server-side guard for serial/batch items in make_opening_stock_entry
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-06-18 02:25:13 +05:30
khushi8112
c5b4a742b3
fix: so many conflicts
2026-06-18 02:05:24 +05:30
Mihir Kandoi
65d9f78409
Merge pull request #56057 from mihir-kandoi/pg-accounts-payments
2026-06-17 18:59:43 +05:30
Mihir Kandoi
acda04a4bd
refactor(postgres): port Payment Request doctype queries to the query builder
...
3-way merged onto develop (preserving the get_party_bank_account import move).
get_subscription_details passes order_by="" so get_all does not inject the
doctype default sort the raw query never had.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:38:02 +05:30
Mihir Kandoi
d1e167815f
refactor(postgres): port Payment Entry doctype queries to the query builder
...
3-way merged onto develop, preserving develop's set_exchange_rate(ref_doc=doc) change.
One portable raw query is intentionally kept (as on the source branch).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:38:01 +05:30
Mihir Kandoi
588dfac4cd
refactor(postgres): port Mode of Payment doctype queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:38:00 +05:30
Mihir Kandoi
ac26c01e52
refactor(postgres): port Cashier Closing doctype queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:38:00 +05:30
Mihir Kandoi
c0d2bd7bce
refactor(postgres): port Invoice Discounting doctype queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:37:59 +05:30
Mihir Kandoi
4d03e915f7
refactor(postgres): port Bank Transaction doctype queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:37:58 +05:30
Mihir Kandoi
09beed9cc3
refactor(postgres): port Payment Order doctype queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 18:37:57 +05:30
Mihir Kandoi
0737a4cfbb
Merge pull request #56051 from mihir-kandoi/pg-accounts-statements
...
refactor(postgres): port Accounts statement & ledger report queries to the query builder
2026-06-17 17:55:47 +05:30
Mihir Kandoi
1332ad7583
refactor(postgres): port Share Ledger report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:36:01 +05:30
Mihir Kandoi
058be399c3
refactor(postgres): port Asset Depreciation Ledger report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:36:01 +05:30
Mihir Kandoi
e482c846c8
refactor(postgres): port General Ledger report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:36:00 +05:30
Mihir Kandoi
6a60f072a8
refactor(postgres): port Dimension-wise Account Balance report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:59 +05:30
Mihir Kandoi
18c1f0f04d
refactor(postgres): port Trial Balance report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:58 +05:30
Mihir Kandoi
217c107549
refactor(postgres): port Consolidated Trial Balance report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:57 +05:30
Mihir Kandoi
44ca5878b8
refactor(postgres): port Consolidated Financial Statement report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:56 +05:30
Mihir Kandoi
66e82c56b1
refactor(postgres): port Gross Profit report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:55 +05:30
Mihir Kandoi
65c0d35f2e
refactor(postgres): port Budget Variance report query to the query builder
...
The raw get_fiscal_years query had no ORDER BY (de-facto oldest-first); the
get_all port adds explicit order_by="name asc" so the Fiscal Year doctype
default (name DESC) does not reverse the report column order / cumulative values.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:55 +05:30
Mihir Kandoi
e9eca10927
refactor(postgres): port Cash Flow report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:54 +05:30
Mihir Kandoi
6849d292f8
refactor(postgres): port financial statements helper queries to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 17:35:52 +05:30
Mihir Kandoi
261b7fe7aa
Merge pull request #56047 from mihir-kandoi/pg-accounts-registers
...
refactor(postgres): port Accounts register report queries to the query builder
2026-06-17 17:09:03 +05:30
khushi8112
03be975f26
fix(stock): create opening stock via Stock Reconciliation with serial/batch bundle support
2026-06-17 17:02:34 +05:30
khushi8112
70086f92f5
fix: test case
2026-06-17 16:54:32 +05:30
khushi8112
e602cad39a
fix: use Stock Reconciliation for opening stock entry
2026-06-17 16:54:26 +05:30
khushi8112
60f528b531
fix: minor UI and UX fixes
2026-06-17 16:52:19 +05:30
Mihir Kandoi
30568d36d0
refactor(postgres): port Accounts Receivable report query to the query builder
...
Most queries are straight raw-SQL -> query-builder ports. One rider:
get_future_payments_from_journal_entry sums future amounts with no GROUP BY,
so its non-aggregated identity columns (invoice_no/party/future_date/future_ref)
are wrapped in Max() to satisfy postgres strict GROUP BY. The summed amount is
unchanged; the attributed invoice/party label stays within MariaDB's existing
arbitrary-row indeterminacy for that already-aggregated single-row query.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:49:48 +05:30
Mihir Kandoi
8527e78820
refactor(postgres): port POS Register report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:46:32 +05:30
Mihir Kandoi
ae4a5e82b0
refactor(postgres): port Item-wise Purchase Register report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:46:31 +05:30
Mihir Kandoi
196fce9792
refactor(postgres): port Purchase Register report query to the query builder
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:46:30 +05:30
Mihir Kandoi
449004d29a
refactor(postgres): port Sales Register report query to the query builder
...
Also sort the distinct income / unrealized P&L account lists in python:
frame drops ORDER BY for distinct queries on postgres, so the generated
account-column order must be pinned in python to stay deterministic on
both backends.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:46:29 +05:30
khushi8112
e00cfc7c2a
feat: add opening stock dialog box in Item form
2026-06-17 16:44:22 +05:30
Mihir Kandoi
bae3668bd0
Merge pull request #56045 from mihir-kandoi/pg-final-fixes
...
fix(postgres): final fix-class changes (asset GROUP BY + accounts-controller boolean)
2026-06-17 16:32:13 +05:30
Mihir Kandoi
8ce0e5386a
Merge pull request #56042 from mihir-kandoi/codex/fix-stock-ageing-reco-ageing
...
fix: preserve stock ageing on non-serial reconciliation
2026-06-17 16:15:26 +05:30
Mihir Kandoi
4ba042c7c7
fix(postgres): compare Check fields with == 1 in accounts controller CASE/condition
...
disable_rounded_total and is_pos are smallint Check fields; postgres rejects
using them as bare boolean conditions in CASE WHEN / bitwise-AND, so compare
explicitly against 1. No-op on MariaDB.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:09:00 +05:30
Mihir Kandoi
59ad76c21e
fix(postgres): satisfy strict GROUP BY in asset depreciation query
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 16:08:24 +05:30
Mihir Kandoi
1efe0be379
Merge pull request #56041 from mihir-kandoi/pg-engine-semantics
...
fix(postgres): assorted engine-semantics fixes (casing, null, boolean)
2026-06-17 16:07:07 +05:30
Mihir Kandoi
6bb7fa6d68
fix: preserve stock ageing on non-serial reconciliation
2026-06-17 15:55:22 +05:30
Mihir Kandoi
ef5feb613a
fix(postgres): default empty balance_serial_no to "" in Available Serial No report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:42:04 +05:30
Mihir Kandoi
2fa9d7cee6
fix(postgres): match stored "Exchange Gain Or Loss" voucher_type casing
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:42:02 +05:30
Mihir Kandoi
431dc208b3
Merge pull request #56040 from mihir-kandoi/pg-fn-swap
...
fix(postgres): replace MySQL-only SQL functions with portable equivalents
2026-06-17 15:40:43 +05:30
Mihir Kandoi
0b795a628f
fix(postgres): use portable GroupConcat in Lost Opportunity report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:19:16 +05:30
Mihir Kandoi
595a4c8517
fix(postgres): replace MySQL IF() with Case in Cheques and Deposits report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:18:50 +05:30
Mihir Kandoi
9ec224c3fd
fix(postgres): use CombineDatetime for work order stock-entry timestamps
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:18:49 +05:30
Mihir Kandoi
68415c341b
fix(postgres): use portable DateDiff in supplier scorecard variables
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:18:48 +05:30
Mihir Kandoi
a43df3278f
fix(postgres): use portable DateDiff/CurDate in Inactive Sales Items report
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-17 15:18:47 +05:30