Saqib Ansari
0700ee8a06
fix: fetch from fields not working in eway bill dialog
...
(cherry picked from commit c8779aa446 )
2022-04-05 10:22:59 +00:00
Rucha Mahabal
6b1a27a641
Merge pull request #30576 from frappe/mergify/bp/version-13-hotfix/pr-30569
2022-04-04 20:40:49 +05:30
Rucha Mahabal
cb2a8aab31
fix(test): set company for employee in leave allocation test setup
...
(cherry picked from commit 793164ac2e )
2022-04-04 14:49:20 +00:00
Rucha Mahabal
e41f35aa82
test: leave allocation validations and total value for updates done before and after submission
...
(cherry picked from commit 5499cecffd )
2022-04-04 14:49:20 +00:00
Rucha Mahabal
1093307dcc
fix: total leaves allocated not validated and recalculated on updates post submission
...
(cherry picked from commit 3538656a7d )
2022-04-04 14:49:19 +00:00
rohitwaghchaure
3f13ce5620
Merge pull request #30570 from frappe/mergify/bp/version-13-hotfix/pr-30564
...
fix: if accepted warehouse not selected during rejection then stock ledger not created (backport #30564 )
2022-04-04 20:15:15 +05:30
Marica
761f8e0b1c
Merge pull request #30539 from marination/redisearch-app-install-v13
...
feat: Redisearch with consent (bp)
2022-04-04 19:25:29 +05:30
Sherin KR
0a2c72c594
fix: Validation for single threshold in Tax With Holding Category ( #30382 )
2022-04-04 19:07:51 +05:30
Rohit Waghchaure
3038a5cd5a
test: test case to validate rejected qty without accepted warehouse
...
(cherry picked from commit ac5df1abbe )
2022-04-04 12:57:04 +00:00
Rohit Waghchaure
157461ed02
fix: if accepted warehouse not selected during rejection then stock ledger not created
...
(cherry picked from commit 0a71cabab1 )
2022-04-04 12:57:04 +00:00
Marica
3e84607cd4
Merge branch 'version-13-hotfix' into redisearch-app-install-v13
2022-04-04 18:01:36 +05:30
mergify[bot]
012cab80bf
fix(ux): refresh update to zero val checkbox ( #30567 ) ( #30568 )
...
(cherry picked from commit de83511091 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-04-04 17:31:26 +05:30
mergify[bot]
b524e657e2
fix(pos): do not reset search input on item selection (backport #30537 )
2022-04-04 16:35:46 +05:30
Ankush Menat
4cc23830f1
fix: maintain FIFO queue even if outgoing_rate is not found ( #30563 )
...
port of #30560
2022-04-04 15:46:49 +05:30
Marica
e5c303e9f4
Merge branch 'version-13-hotfix' into redisearch-app-install-v13
2022-04-04 13:28:09 +05:30
marination
4dc7047a59
chore: Add TODOs(perf) for Redisearch Query
2022-04-04 13:26:08 +05:30
marination
42ec9db5f4
fix: Payload incorrect data (pass item_group.name)
2022-04-04 12:35:14 +05:30
marination
0f9277a8c8
fix: Add default score of 1 to Item Group Autocompleter
...
- If score 0 is inserted into suggestions, RS does not consider that suggestion
2022-04-04 12:06:27 +05:30
marination
5c36d12369
fix: Convert payload to string before adding to autocompleter
2022-04-04 11:34:39 +05:30
marination
b4d427b429
fix: Better Exception Handling and vaeiabl naming
...
- Function to handle RS exceptions (create log and raise error)
- Handle `ResponseError` where it is anticipated
- Misc: Better variables
2022-04-04 11:15:45 +05:30
rohitwaghchaure
d032a0cd77
Merge pull request #30450 from anupamvs/crm-contract-naming-v13
...
feat: configurable Contract naming
2022-04-02 23:43:02 +05:30
Deepesh Garg
00f6565596
Merge pull request #30550 from frappe/mergify/bp/version-13-hotfix/pr-30191
...
fix: incorrect payable amount for loan closure (backport #30191 )
2022-04-02 23:32:56 +05:30
Deepesh Garg
7bf6de1883
fix: Resolve conflicts
2022-04-02 20:33:46 +05:30
Deepesh Garg
3fc43cb259
fix: Code cleanup
...
(cherry picked from commit 1b2c6a5b78 )
# Conflicts:
# erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
2022-04-02 14:23:50 +00:00
Abhinav Raut
1d9a6efb1b
fix: incorrect payable amount for loan closure
...
(cherry picked from commit 8c76a76154 )
# Conflicts:
# erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
2022-04-02 14:23:50 +00:00
Abhinav Raut
c44a4e559b
fix: incorrect payable amount for loan closure
...
- Add penalty amount to payable amount for loan closure
(cherry picked from commit 4e92926a52 )
# Conflicts:
# erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
2022-04-02 14:23:49 +00:00
marination
17f95b1f83
fix: Use Payload in AutoCompleter (categories in search) and misc
...
- Separate Item group and Item autocomplete dict definition
- Add payload along with Item group, containing namke and route
- Pass weightage while defining item group autocomplete dict (auto sort)
- Use payload while getting results for categories in search
- Remove check to show categories, always show
- Search fields mandatory if reidsearch enabled
- Code separation (rough)
2022-04-01 18:51:22 +05:30
mergify[bot]
c5fd77ebf7
perf: index barcode for faster scans ( #30543 ) ( #30544 )
...
(cherry picked from commit 6c5b01c60d )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-04-01 15:50:04 +05:30
Alberto826
63dacaa03d
fix: Remove trailing slashes "/" from route ( #30531 )
...
Trailing slashes "/" in the routes causes redirect to port 8080 in docker implementation with reverse proxy.
The "student_admission_row.html" template has an href attribute with a trailing slash.
2022-04-01 14:48:15 +05:30
mergify[bot]
a35cc7004d
fix: convert dates to datetime before comparing in leave days calculation and fix half day edge case (backport #30538 ) ( #30541 )
2022-04-01 14:17:25 +05:30
marination
fd29722d36
fix: Call Redisearch index creation functions on enabling redisearch in settings
2022-04-01 13:05:17 +05:30
Saqib Ansari
9a5acc313c
Merge pull request #30515 from frappe/mergify/copy/version-13-hotfix/pr-30324
...
fix: multiple pos issues (copy #30324 )
2022-04-01 12:11:06 +05:30
Saqib Ansari
9335578a0b
fix: linting errors
2022-04-01 11:02:18 +05:30
Deepesh Garg
af6dcd66dc
Merge pull request #30534 from frappe/mergify/bp/version-13-hotfix/pr-30510
...
fix: Taxes getting overriden from mapped to target doc (backport #30510 )
2022-04-01 10:31:32 +05:30
Deepesh Garg
6c53ca6328
Merge pull request #30512 from frappe/mergify/bp/version-13-hotfix/pr-30486
...
fix: Account currency validation (backport #30486 )
2022-04-01 09:45:45 +05:30
Deepesh Garg
20df023b9a
Merge pull request #30525 from frappe/mergify/bp/version-13-hotfix/pr-30500
...
fix(India): Tax fetching based on tax category (backport #30500 )
2022-04-01 09:45:28 +05:30
Deepesh Garg
328b9431b2
fix: Taxes getting overriden from mapped to target doc
...
(cherry picked from commit 4720969ce6 )
2022-04-01 04:14:07 +00:00
Saqib Ansari
a9f24859ad
Merge pull request #30514 from frappe/mergify/bp/version-13-hotfix/pr-30461
...
fix(asset): do not validate warehouse on asset purchase (backport #30461 )
2022-03-31 21:08:51 +05:30
rohitwaghchaure
dbb872aeb4
Merge pull request #30530 from frappe/mergify/bp/version-13-hotfix/pr-30527
...
feat: minor, pick list item reference on delivery note item table (backport #30527 )
2022-03-31 21:04:02 +05:30
Rohit Waghchaure
a74198f974
test: test case to check pick list name has mapped or not
...
(cherry picked from commit 2f51011f91 )
2022-03-31 14:53:52 +00:00
Rohit Waghchaure
c92df4eed3
feat: minor, pick list item reference on delivery note item table
...
(cherry picked from commit 2f63ae2ee9 )
2022-03-31 14:53:51 +00:00
Deepesh Garg
f213dc9999
fix(India): Tax fetching based on tax category
...
(cherry picked from commit 532961fad2 )
2022-03-31 12:32:41 +00:00
Saqib Ansari
8416dc713c
fix: unexpected keyword argument 'pluck'
2022-03-31 16:32:01 +05:30
Saqib Ansari
8d315a6573
fix: 'int' object has no attribute 'is_draft'
2022-03-31 16:17:51 +05:30
Marica
70485a6afc
Merge pull request #30517 from frappe/mergify/bp/version-13-hotfix/pr-30509
...
fix: Add non-existent Item check and cleanup in `validate_for_items` (backport #30509 )
2022-03-31 15:55:46 +05:30
marination
40a154e64d
fix: (test) change expected exception due to https://github.com/frappe/frappe/pull/16454
...
(cherry picked from commit 93f6346cea )
2022-03-31 09:23:47 +00:00
marination
84247e91f3
fix: Add non-existent Item check and cleanup in validate_for_items
...
- Added a validation if invalid item code ia passed via data import/API, etc.
- Used DB APIs instead of raw sql
- Separated checks into separate functions
- Added return types to functions
- Better variable naming and removed redundant utils import in function
(cherry picked from commit 982a246eec )
2022-03-31 09:23:46 +00:00
Saqib Ansari
ab7417c26a
fix: invalid keyword argument 'pluck'
2022-03-31 14:38:40 +05:30
Saqib Ansari
0bafec2384
fix: merge conflicts
2022-03-31 14:24:42 +05:30
Saqib Ansari
a51b32b7e0
fix: merge conflicts
2022-03-31 14:19:53 +05:30