nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-28 17:34:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sales_order): Replace SQL with ORM in update_enquiry_status (#55203)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-23 08:03:54 +02:00
committed by GitHub
parent 9a46b3374f
commit f1c2d2e21d
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/selling/doctype/sales_order/sales_order.py
View File

@@ -474,12 +474,9 @@ class SalesOrder(SellingController):
self.validate_rate_with_reference_doc([["Quotation", "prevdoc_docname", "quotation_item"]]) self.validate_rate_with_reference_doc([["Quotation", "prevdoc_docname", "quotation_item"]])
def update_enquiry_status(self, prevdoc, flag): def update_enquiry_status(self, prevdoc, flag):
enq = frappe.db.sql( opportunity_name = frappe.db.get_value("Quotation Item", {"parent": prevdoc}, "prevdoc_docname")
"select t2.prevdoc_docname from `tabQuotation` t1, `tabQuotation Item` t2 where t2.parent = t1.name and t1.name=%s", if opportunity_name:
prevdoc, frappe.db.set_value("Opportunity", opportunity_name, "status", flag)
)
if enq:
frappe.db.sql("update `tabOpportunity` set status = %s where name=%s", (flag, enq[0][0]))
def update_prevdoc_status(self, flag=None): def update_prevdoc_status(self, flag=None):
for quotation in set(d.prevdoc_docname for d in self.get("items")): for quotation in set(d.prevdoc_docname for d in self.get("items")):