From f1c2d2e21dca1a5fc7ea42c8bc163941fe0c1075 Mon Sep 17 00:00:00 2001 From: Loic Oberle Date: Sat, 23 May 2026 08:03:54 +0200 Subject: [PATCH] refactor(sales_order): Replace SQL with ORM in update_enquiry_status (#55203) --- erpnext/selling/doctype/sales_order/sales_order.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index b0cb1e5b8ac..b170305ebfb 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -474,12 +474,9 @@ class SalesOrder(SellingController): self.validate_rate_with_reference_doc([["Quotation", "prevdoc_docname", "quotation_item"]]) def update_enquiry_status(self, prevdoc, flag): - enq = frappe.db.sql( - "select t2.prevdoc_docname from `tabQuotation` t1, `tabQuotation Item` t2 where t2.parent = t1.name and t1.name=%s", - prevdoc, - ) - if enq: - frappe.db.sql("update `tabOpportunity` set status = %s where name=%s", (flag, enq[0][0])) + opportunity_name = frappe.db.get_value("Quotation Item", {"parent": prevdoc}, "prevdoc_docname") + if opportunity_name: + frappe.db.set_value("Opportunity", opportunity_name, "status", flag) def update_prevdoc_status(self, flag=None): for quotation in set(d.prevdoc_docname for d in self.get("items")):